superreview granted: [Bug 418133] [FIX]"Assertion failure: !JS_IsExceptionPending(cx)" with <xul:preferences> : [Attachment 306201] Possible patch

Brendan Eich <brendan@mozilla.org> has granted Boris Zbarsky (reviews very slow
until May) <bzbarsky@mit.edu>'s request for superreview:
Bug 418133: [FIX]"Assertion failure: !JS_IsExceptionPending(cx)" with
<xul:preferences>
https://bugzilla.mozilla.org/show_bug.cgi?id=418133

Attachment 306201: Possible patch
https://bugzilla.mozilla.org/attachment.cgi?id=306201&action=edit

------- Additional Comments from Brendan Eich <brendan@mozilla.org>
>+  // If EvaluateStringWithValue() threw an exception, just report it now.
>+  // Failure to evaluate a field should neither stop the get of the field
value
>+  // nor an enumeration attempt.

s/neither stop/stop neither/, I think.

Also, this JS_IsExceptionPending test is unnecessary:

>+  if (::JS_IsExceptionPending(cx)) {
>+    ::JS_ReportPendingException(cx);
>+  }

Since JS_ReportPendingException (under js_ReportUncaughtException) tests that
predicate too -- but it's better this way I think. Just FYI, no change
requested.

sr=me in advance of jst. Thanks!

/be
0
bugzilla
3/5/2008 2:36:06 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
271 Views

Similar Articles

[PageSpeed] 23

Reply:

Similar Artilces:

superreview requested: [Bug 418133] "Assertion failure: !JS_IsExceptionPending(cx)" with <xul:preferences> : [Attachment 306201] Possible patch
Boris Zbarsky (reviews very slow until May) <bzbarsky@mit.edu> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 418133: "Assertion failure: !JS_IsExceptionPending(cx)" with <xul:preferences> https://bugzilla.mozilla.org/show_bug.cgi?id=418133 Attachment 306201: Possible patch https://bugzilla.mozilla.org/attachment.cgi?id=306201&action=edit ------- Additional Comments from Boris Zbarsky (reviews very slow until May) <bzbarsky@mit.edu> If this patch fails mochitest, I'll be very very surprised! If this fixes the bug, let...

superreview granted: [Bug 344215] <xul:observes/> with no attributes triggers "ASSERTION: getElementById(""), fix caller?" : [Attachment 229189] Patch rev. 1
Jonas Sicking <bugmail@sicking.cc> has granted superreview: Bug 344215: <xul:observes/> with no attributes triggers "ASSERTION: getElementById(""), fix caller?" https://bugzilla.mozilla.org/show_bug.cgi?id=344215 Attachment 229189: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=229189&action=edit ...

superreview granted: [Bug 226958] Bug 197315, "other" files: Convert <window class="dialog"> to <dialog> : [Attachment 136628] <xpistatus.*> patch v3
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 226958: Bug 197315, "other" files: Convert <window class="dialog"> to <dialog> http://bugzilla.mozilla.org/show_bug.cgi?id=226958 Attachment 136628: <xpistatus.*> patch v3 http://bugzilla.mozilla.org/attachment.cgi?id=136628&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> I checked in the patch with ben's changes. ...

superreview granted: [Bug 225840] '4 .xul files': Convert <window class="dialog"> to <dialog> ... additional cleanup : [Attachment 135958] <WalletPreview.xul> patch v4b
Asa Dotzler <asa@mozilla.org> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 225840: '4 .xul files': Convert <window class="dialog"> to <dialog> ... additional cleanup http://bugzilla.mozilla.org/show_bug.cgi?id=225840 Attachment 135958: <WalletPreview.xul> patch v4b http://bugzilla.mozilla.org/attachment.cgi?id=135958&action=edit ------- Additional Comments from Asa Dotzler <asa@mozilla.org> r=ben a=asa (on behalf of drivers) for checkin to 1.6beta. ...

superreview granted: [Bug 225840] '4 .xul files': Convert <window class="dialog"> to <dialog> ... additional cleanup : [Attachment 136423] <p3pDialog.xul> patch v1
Asa Dotzler <asa@mozilla.org> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 225840: '4 .xul files': Convert <window class="dialog"> to <dialog> ... additional cleanup http://bugzilla.mozilla.org/show_bug.cgi?id=225840 Attachment 136423: <p3pDialog.xul> patch v1 http://bugzilla.mozilla.org/attachment.cgi?id=136423&action=edit ------- Additional Comments from Asa Dotzler <asa@mozilla.org> r=ben a=asa (on behalf of drivers) for checkin to 1.6beta. ...

superreview granted: [Bug 225840] '4 .xul files': Convert <window class="dialog"> to <dialog> ... additional cleanup : [Attachment 136121] <p3p.xul> patch v2
Asa Dotzler <asa@mozilla.org> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 225840: '4 .xul files': Convert <window class="dialog"> to <dialog> ... additional cleanup http://bugzilla.mozilla.org/show_bug.cgi?id=225840 Attachment 136121: <p3p.xul> patch v2 http://bugzilla.mozilla.org/attachment.cgi?id=136121&action=edit ------- Additional Comments from Asa Dotzler <asa@mozilla.org> r=ben a=asa (on behalf of drivers) for checkin to 1.6beta. ...

superreview requested: [Bug 344215] <xul:observes/> with no attributes triggers "ASSERTION: getElementById(""), fix caller?" : [Attachment 229189] Patch rev. 1
Mats Palmgren <mats.palmgren@bredband.net> has asked Jonas Sicking <bugmail@sicking.cc> for superreview: Bug 344215: <xul:observes/> with no attributes triggers "ASSERTION: getElementById(""), fix caller?" https://bugzilla.mozilla.org/show_bug.cgi?id=344215 Attachment 229189: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=229189&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> Return NS_FINDBROADCASTER_NOT_FOUND when there is no/empty "element" attribute. (as we do in th...

superreview requested: [Bug 366021] "ASSERTION: cannot call on a dirty frame not currently being reflowed" with abs pos, < tr>, <xul:window> : [Attachment 295329] patch to fix
Jonas Sicking (:sicking) Vacation Dec 19th to Jan 2nd <jonas@sicking.cc> has asked Robert O'Callahan (:roc) <roc@ocallahan.org> for superreview: Bug 366021: "ASSERTION: cannot call on a dirty frame not currently being reflowed" with abs pos, <tr>, <xul:window> https://bugzilla.mozilla.org/show_bug.cgi?id=366021 Attachment 295329: patch to fix https://bugzilla.mozilla.org/attachment.cgi?id=295329&action=edit ------- Additional Comments from Jonas Sicking (:sicking) Vacation Dec 19th to Jan 2nd <jonas@sicking.cc> This should fix this o...

superreview canceled: [Bug 366021] "ASSERTION: cannot call on a dirty frame not currently being reflowed" with abs pos, < tr>, <xul:window> : [Attachment 295329] patch to fix
Jonas Sicking (:sicking) Vacation Dec 19th to Jan 2nd <jonas@sicking.cc> has canceled Jonas Sicking (:sicking) Vacation Dec 19th to Jan 2nd <jonas@sicking.cc>'s request for superreview: Bug 366021: "ASSERTION: cannot call on a dirty frame not currently being reflowed" with abs pos, <tr>, <xul:window> https://bugzilla.mozilla.org/show_bug.cgi?id=366021 Attachment 295329: patch to fix https://bugzilla.mozilla.org/attachment.cgi?id=295329&action=edit ------- Additional Comments from Jonas Sicking (:sicking) Vacation Dec 19th to Jan 2nd <jo...

superreview granted: [Bug 223470] [FIX]Crash with <ATTLIST foo size CDATA #FIXED "3">...<foo/> : [Attachment 134067] Proposed patch
Peter Van der Beken <peterv@propagandism.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 223470: [FIX]Crash with <ATTLIST foo size CDATA #FIXED "3">...<foo/> http://bugzilla.mozilla.org/show_bug.cgi?id=223470 Attachment 134067: Proposed patch http://bugzilla.mozilla.org/attachment.cgi?id=134067&action=edit ------- Additional Comments from Peter Van der Beken <peterv@propagandism.org> >Index: htmlparser/public/nsIExpatSink.idl >=================================================================== ...

superreview granted: [Bug 422009] [FIX]"Assertion failure: !cx->throwing" with XBL constructor that throws and syntax error in event handler : [Attachment 310421] Fix
Johnny Stenback (:jst) <jst@mozilla.org> has granted Boris Zbarsky (reviews very slow until May) <bzbarsky@mit.edu>'s request for superreview: Bug 422009: [FIX]"Assertion failure: !cx->throwing" with XBL constructor that throws and syntax error in event handler https://bugzilla.mozilla.org/show_bug.cgi?id=422009 Attachment 310421: Fix https://bugzilla.mozilla.org/attachment.cgi?id=310421&action=edit ...

superreview granted: [Bug 226958] Bug 197315, "other" files: Convert <window class="dialog"> to <dialog> : [Attachment 137732] (Cv2c) <Wallet*.*>
Alec Flett <alecf@flett.org> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 226958: Bug 197315, "other" files: Convert <window class="dialog"> to <dialog> http://bugzilla.mozilla.org/show_bug.cgi?id=226958 Attachment 137732: (Cv2c) <Wallet*.*> http://bugzilla.mozilla.org/attachment.cgi?id=137732&action=edit ------- Additional Comments from Alec Flett <alecf@flett.org> damn, nice cleanup sr=alecf assuming it all works well. ...

superreview requested: [Bug 226958] Bug 197315, "other" files: Convert <window class="dialog"> to <dialog> : [Attachment 136628] <xpistatus.*> patch v3
Serge GAUTHERIE <gautheri@noos.fr> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 226958: Bug 197315, "other" files: Convert <window class="dialog"> to <dialog> http://bugzilla.mozilla.org/show_bug.cgi?id=226958 Attachment 136628: <xpistatus.*> patch v3 http://bugzilla.mozilla.org/attachment.cgi?id=136628&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> 'approval1.6b=?': Trivial U.I. code cleanup. ...

superreview granted: [Bug 226956] Bug 197315, </mailnews/*> files: Convert <window class="dialog"> to <dialog> : [Attachment 151099] Patch V1.2
Scott MacGregor <mscott@mozilla.org> has granted Stefan Borggraefe <Stefan.Borggraefe@gmx.de>'s request for superreview: Bug 226956: Bug 197315, </mailnews/*> files: Convert <window class="dialog"> to <dialog> http://bugzilla.mozilla.org/show_bug.cgi?id=226956 Attachment 151099: Patch V1.2 http://bugzilla.mozilla.org/attachment.cgi?id=151099&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> sorry for the delay ...

Web resources about - superreview granted: [Bug 418133] [FIX]"Assertion failure: !JS_IsExceptionPending(cx)" with <xul:preferences> : [Attachment 306201] Possible patch - mozilla.dev.super-review

Resources last updated: 11/29/2015 11:01:06 AM