superreview granted: [Bug 410946] Crash in JS engine aborting applet making Java/JS calls : [Attachment 306220] Updated diff, ready to land.

Johnny Stenback (:jst) <jst@mozilla.org> has granted  superreview:
Bug 410946: Crash in JS engine aborting applet making Java/JS calls
https://bugzilla.mozilla.org/show_bug.cgi?id=410946

Attachment 306220: Updated diff, ready to land.
https://bugzilla.mozilla.org/attachment.cgi?id=306220&action=edit

------- Additional Comments from Johnny Stenback (:jst) <jst@mozilla.org>
Updated fix, fixes all of the above. Boris, the only real difference here is
how nsPluginDestroyRunnable works, it's now a PRCList with a static list head
so that when we run one of these we can walk the list of other scheduled
runnables and see if there's another one that will destroy this plugin for us,
and also if there's another guard on the stack for the instance in question the
runnable doesn't tear down the plugin but makes the guard on the stack do that.


I also realized that I lost all of the guards I put in ns4xPluginInternal.cpp
at some point, but they were not critical for the java issue in this bug.
Either way, they're now back in the change...

Drivers, this neads a beta for sure, so it'd be awesome to get this in for
beta4. It's essentially not a change in behavior unless we end up in a case
where we tear down a plugin where it's not safe to do so w/o this patch. IOW,
this should only change behavior when the current code crashes us.
0
bugzilla
2/28/2008 8:55:23 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
488 Views

Similar Articles

[PageSpeed] 16

Reply:

Similar Artilces:

superreview granted: [Bug 410946] Crash in JS engine aborting applet making Java/JS calls : [Attachment 305554] Fix.
Boris Zbarsky (reviews very slow until May) <bzbarsky@mit.edu> has granted Johnny Stenback (:jst) <jst@mozilla.org>'s request for superreview: Bug 410946: Crash in JS engine aborting applet making Java/JS calls https://bugzilla.mozilla.org/show_bug.cgi?id=3D410946 Attachment 305554: Fix. https://bugzilla.mozilla.org/attachment.cgi?id=3D305554&action=3Dedit ------- Additional Comments from Boris Zbarsky (reviews very slow until May) <bzbarsky@mit.edu> Could you add documentation to nsIObjectFrame which says which of the metho= ds might destroy the frame? ...

superreview requested: [Bug 410946] Crash in JS engine aborting applet making Java/JS calls : [Attachment 305554] Fix.
Johnny Stenback (:jst) <jst@mozilla.org> has asked Boris Zbarsky (reviews very slow until May) <bzbarsky@mit.edu> for superreview: Bug 410946: Crash in JS engine aborting applet making Java/JS calls https://bugzilla.mozilla.org/show_bug.cgi?id=410946 Attachment 305554: Fix. https://bugzilla.mozilla.org/attachment.cgi?id=305554&action=edit ------- Additional Comments from Johnny Stenback (:jst) <jst@mozilla.org> See previous comment for description of what this does. ...

superreview granted: [Bug 141056] crash running some xpi [@JS_FrameIterator] : [Attachment 142780] Make XPInstall push a JS context on the cx stack before calling JS.
Boris Zbarsky <bzbarsky@mit.edu> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 141056: crash running some xpi [@JS_FrameIterator] http://bugzilla.mozilla.org/show_bug.cgi?id=141056 Attachment 142780: Make XPInstall push a JS context on the cx stack before calling JS. http://bugzilla.mozilla.org/attachment.cgi?id=142780&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> r+sr=bzbarsky ...

superreview requested: [Bug 141056] crash running some xpi [@JS_FrameIterator] : [Attachment 142780] Make XPInstall push a JS context on the cx stack before calling JS.
Johnny Stenback <jst@mozilla.jstenback.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 141056: crash running some xpi [@JS_FrameIterator] http://bugzilla.mozilla.org/show_bug.cgi?id=141056 Attachment 142780: Make XPInstall push a JS context on the cx stack before calling JS. http://bugzilla.mozilla.org/attachment.cgi?id=142780&action=edit ...

superreview granted: [Bug 275107] Some JS Strict warnings (In am-server.js, am-server-advanced.js, am-serverwithnoidentities.js) : [Attachment 169134] (Bv1) <am-serverwithnoidentities.js>
Dan Mosedale <dmose@mozilla.org> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 275107: Some JS Strict warnings (In am-server.js, am-server-advanced.js, am-serverwithnoidentities.js) https://bugzilla.mozilla.org/show_bug.cgi?id=275107 Attachment 169134: (Bv1) <am-serverwithnoidentities.js> https://bugzilla.mozilla.org/attachment.cgi?id=169134&action=edit ------- Additional Comments from Dan Mosedale <dmose@mozilla.org> sr=dmose ...

superreview granted: [Bug 275107] Some JS Strict warnings (In am-server.js, am-server-advanced.js, am-serverwithnoidentities.js) : [Attachment 168993] (Av1) <am-server*.js>
Dan Mosedale <dmose@mozilla.org> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 275107: Some JS Strict warnings (In am-server.js, am-server-advanced.js, am-serverwithnoidentities.js) https://bugzilla.mozilla.org/show_bug.cgi?id=275107 Attachment 168993: (Av1) <am-server*.js> https://bugzilla.mozilla.org/attachment.cgi?id=168993&action=edit ------- Additional Comments from Dan Mosedale <dmose@mozilla.org> sr=dmose ...

superreview granted: [Bug 442256] Make getURIs/IndicesForSelection easier to call from JS : [Attachment 327122] Proposed patch
David Bienvenu <bienvenu@nventure.com> has granted neil@parkwaycc.co.uk <neil@httl.net>'s request for superreview: Bug 442256: Make getURIs/IndicesForSelection easier to call from JS https://bugzilla.mozilla.org/show_bug.cgi?id=442256 Attachment 327122: Proposed patch https://bugzilla.mozilla.org/attachment.cgi?id=327122&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> Ironically, these methods are never called from c++, which means we could simply drop the length out parameter, since the js callers never need it. GetInd...

superreview granted: [Bug 304669] nsTimerImpl crashes even if called by JS, should me more defensive about pointers : [Attachment 192947] Argument validation only
David Baron <dbaron@mozillafoundation.org> has granted Giorgio Maone <g.maone@informaction.com>'s request for superreview: Bug 304669: nsTimerImpl crashes even if called by JS, should me more defensive about pointers https://bugzilla.mozilla.org/show_bug.cgi?id=304669 Attachment 192947: Argument validation only https://bugzilla.mozilla.org/attachment.cgi?id=192947&action=edit ...

superreview granted: [Bug 361248] Synchronize mail/ <-> mailnews/ <msgMail3PaneWindow.js> : [Attachment 245999] (Av1_Bw-SM) <msgMail3PaneWindow.js> (for review only)
neil@parkwaycc.co.uk <neil@httl.net> has granted Serge Gautherie <sgautherie.bz@free.fr>'s request for superreview: Bug 361248: Synchronize mail/ <-> mailnews/ <msgMail3PaneWindow.js> https://bugzilla.mozilla.org/show_bug.cgi?id=361248 Attachment 245999: (Av1_Bw-SM) <msgMail3PaneWindow.js> (for review only) https://bugzilla.mozilla.org/attachment.cgi?id=245999&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> >- if (event.originalTarget.localName == "treecol") >+ if (event.originalTarget.loc...

superreview granted: [Bug 312932] Java applet + screen reader no longer crashes; allow that combo : [Attachment 200016] Back out changes from bug 288356 -- allow applets to run when screen reader is
Boris Zbarsky <bzbarsky@mit.edu> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 312932: Java applet + screen reader no longer crashes; allow that combo https://bugzilla.mozilla.org/show_bug.cgi?id=312932 Attachment 200016: Back out changes from bug 288356 -- allow applets to run when screen reader is present https://bugzilla.mozilla.org/attachment.cgi?id=200016&action=edit ...

superreview granted: [Bug 442066] Calling a JS callback from a worker thread can cause a crash : [Attachment 328787] Add requested comments
Johnny Stenback (:jst, jst@mozilla.com) <jst@mozilla.org> has granted superreview: Bug 442066: Calling a JS callback from a worker thread can cause a crash https://bugzilla.mozilla.org/show_bug.cgi?id=442066 Attachment 328787: Add requested comments https://bugzilla.mozilla.org/attachment.cgi?id=328787&action=edit ------- Additional Comments from Johnny Stenback (:jst, jst@mozilla.com) <jst@mozilla.org> Awesome. r+sr=jst, thanks for fixing! ...

superreview granted: [Bug 287086] Move browser.link.* prefs out of all.js and ensure they are not required by all apps : [Attachment 178175] with all.js removal+fancier comments for SM+jst's review c
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Mike Connor <mconnor@steelgryphon.com>'s request for superreview: Bug 287086: Move browser.link.* prefs out of all.js and ensure they are not required by all apps https://bugzilla.mozilla.org/show_bug.cgi?id=287086 Attachment 178175: with all.js removal+fancier comments for SM+jst's review comment https://bugzilla.mozilla.org/attachment.cgi?id=178175&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> sr=me if you remove the "...

superreview granted: [Bug 212231] Errors from document.open() cause silent failures in JS : [Attachment 127391] Don't return JS_FALSE in common cases to the JS engine w/o throwing an exception
Boris Zbarsky <bzbarsky@mit.edu> has granted Johnny Stenback <jst@netscape.com>'s request for superreview: Bug 212231: Errors from document.open() cause silent failures in JS http://bugzilla.mozilla.org/show_bug.cgi?id=212231 Attachment 127391: Don't return JS_FALSE in common cases to the JS engine w/o throwing an exception http://bugzilla.mozilla.org/attachment.cgi?id=127391&action=edit ...

superreview granted: [Bug 439276] Silent script termination when calling atob() with illegal input in JS component : [Attachment 325347] JS_ReportError makes this a catchable exn
Mike Shaver <shaver@mozilla.org> has granted Brian Crowder <crowder@fiverocks.com>'s request for superreview: Bug 439276: Silent script termination when calling atob() with illegal input in JS component https://bugzilla.mozilla.org/show_bug.cgi?id=439276 Attachment 325347: JS_ReportError makes this a catchable exn https://bugzilla.mozilla.org/attachment.cgi?id=325347&action=edit ------- Additional Comments from Mike Shaver <shaver@mozilla.org> r+sr=shaver ...

Web resources about - superreview granted: [Bug 410946] Crash in JS engine aborting applet making Java/JS calls : [Attachment 306220] Updated diff, ready to land. - mozilla.dev.super-review

Resources last updated: 12/3/2015 6:05:16 PM