superreview granted: [Bug 409331] convert sites that QueryInterface to kBlockCID to use nsLayoutUtils:: GetAsBlock : [Attachment 295022] convert sites that QueryInterface to kBlockCID to use nsLayoutU

Robert O'Callahan (:roc) <roc@ocallahan.org> has granted  superreview:
Bug 409331: convert sites that QueryInterface to kBlockCID to use
nsLayoutUtils::GetAsBlock
https://bugzilla.mozilla.org/show_bug.cgi?id=409331

Attachment 295022: convert sites that QueryInterface to kBlockCID to use
nsLayoutUtils::GetAsBlock
https://bugzilla.mozilla.org/attachment.cgi?id=295022&action=edit

------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.org>
cool.

We probably don't need to take this for FF3 though. Let's land it post-FF3.
0
bugzilla
1/3/2008 1:42:19 AM
mozilla.dev.super-review 29307 articles. 2 followers. Post Follow

0 Replies
391 Views

Similar Articles

[PageSpeed] 9

Reply:

Similar Artilces:

superreview granted: [Bug 339135] Convert Thunderbird to use the NSIS Installer : [Attachment 229176] patch for review
Scott MacGregor <mscott@mozilla.org> has granted superreview: Bug 339135: Convert Thunderbird to use the NSIS Installer https://bugzilla.mozilla.org/show_bug.cgi?id=339135 Attachment 229176: patch for review https://bugzilla.mozilla.org/attachment.cgi?id=229176&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> Thanks Rob! ...

superreview granted: [Bug 224621] convert imgContainerGIF to use nsCOMArray : [Attachment 134720] patch
<tor@acm.org> has granted Brian Ryner <bryner@brianryner.com>'s request for superreview: Bug 224621: convert imgContainerGIF to use nsCOMArray http://bugzilla.mozilla.org/show_bug.cgi?id=224621 Attachment 134720: patch http://bugzilla.mozilla.org/attachment.cgi?id=134720&action=edit ------- Additional Comments from <tor@acm.org> Looks cleaner, too. sr=tor ...

superreview granted: [Bug 255337] [FIX]Make more use of GetOwnerDoc() : [Attachment 155905] Convert some code
Peter Van der Beken <peterv@propagandism.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 255337: [FIX]Make more use of GetOwnerDoc() http://bugzilla.mozilla.org/show_bug.cgi?id=255337 Attachment 155905: Convert some code http://bugzilla.mozilla.org/attachment.cgi?id=155905&action=edit ------- Additional Comments from Peter Van der Beken <peterv@propagandism.org> >Index: content/events/src/nsEventListenerManager.cpp >=================================================================== >@@ -1859,25 +1859,17 @@ NS_I...

superreview granted: [Bug 312491] convert CSSStyleSheet and CSSGroupRule to use nsCOMArray : [Attachment 199581] patch
Boris Zbarsky <bzbarsky@mit.edu> has granted Brian Ryner <bryner@brianryner.com>'s request for superreview: Bug 312491: convert CSSStyleSheet and CSSGroupRule to use nsCOMArray https://bugzilla.mozilla.org/show_bug.cgi?id=312491 Attachment 199581: patch https://bugzilla.mozilla.org/attachment.cgi?id=199581&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> >Index: nsCSSRules.cpp > nsCSSGroupRule::GetStyleRuleAt(PRInt32 aIndex, nsICSSRule*& aRule) const >+ if (aIndex >= mRules.Count()) { >+ aRule = nsnull;...

superreview granted: [Bug 376662] Convert nsIFrame::GetOffsetTo to not explicitly use views : [Attachment 334982] fix
Boris Zbarsky (todo: 200+ items) [gone 8/9--8/17] <bzbarsky@mit.edu> has granted Robert O'Callahan (:roc) (Mozilla Corporation) <roc@ocallahan.org>'s request for superreview: Bug 376662: Convert nsIFrame::GetOffsetTo to not explicitly use views https://bugzilla.mozilla.org/show_bug.cgi?id=3D376662 Attachment 334982: fix https://bugzilla.mozilla.org/attachment.cgi?id=3D334982&action=3Dedit ------- Additional Comments from Boris Zbarsky (todo: 200+ items) [gone 8/9--8/17] <bzbarsky@mit.edu> >+++ b/layout/generic/nsFrame.cpp=0D >+ aOther =3D aOthe...

superreview granted: [Bug 224625] [spellcheck] Convert mozPersonalDictionary to use nsTHashTable : [Attachment 137425] patch v1.6b
Alec Flett <alecf@flett.org> has granted Michiel van Leeuwen <mvl@exedo.nl>'s request for superreview: Bug 224625: [spellcheck] Convert mozPersonalDictionary to use nsTHashTable http://bugzilla.mozilla.org/show_bug.cgi?id=224625 Attachment 137425: patch v1.6b http://bugzilla.mozilla.org/attachment.cgi?id=137425&action=edit ------- Additional Comments from Alec Flett <alecf@flett.org> + PRUint32 bytesWritten; + for (PRInt32 i = 0; i < array.Count(); ++i ) { + const nsString *key = array[i]; + NS_ConvertUTF16toUTF8 utf8Key(*key); would be n...

superreview granted: [Bug 181602] Convert accessible/ to use the newer pref APIs : [Attachment 139179] with caillons comments
Peter Van der Beken <peterv@propagandism.org> has granted Simon 'sipaq' Paquet <bugzilla@babylonsounds.com>'s request for superreview: Bug 181602: Convert accessible/ to use the newer pref APIs http://bugzilla.mozilla.org/show_bug.cgi?id=181602 Attachment 139179: with caillons comments http://bugzilla.mozilla.org/attachment.cgi?id=139179&action=edit ...

superreview granted: [Bug 320746] [mac] Use GetCurrentEventKeyModifiers() instead of GetCurrentKeyModifiers() : [Attachment 306547] convert all, v1.0
Robert O'Callahan (:roc) <roc@ocallahan.org> has granted Josh Aas <joshmoz@gmail.com>'s request for superreview: Bug 320746: [mac] Use GetCurrentEventKeyModifiers() instead of GetCurrentKeyModifiers() https://bugzilla.mozilla.org/show_bug.cgi?id=320746 Attachment 306547: convert all, v1.0 https://bugzilla.mozilla.org/attachment.cgi?id=306547&action=edit ...

superreview granted: [Bug 376662] Convert nsIFrame::GetOffsetTo to not explicitly use views : [Attachment 335971] fix v4
Boris Zbarsky (todo: 200+ items) [gone 8/9--8/17] <bzbarsky@mit.edu> has granted Robert O'Callahan (:roc) (Mozilla Corporation) <roc@ocallahan.org>'s request for superreview: Bug 376662: Convert nsIFrame::GetOffsetTo to not explicitly use views https://bugzilla.mozilla.org/show_bug.cgi?id=376662 Attachment 335971: fix v4 https://bugzilla.mozilla.org/attachment.cgi?id=335971&action=edit ...

superreview granted: [Bug 376662] Convert nsIFrame::GetOffsetTo to not explicitly use views : [Attachment 335453] fix v2
Boris Zbarsky (todo: 200+ items) [gone 8/9--8/17] <bzbarsky@mit.edu> has granted Robert O'Callahan (:roc) (Mozilla Corporation) <roc@ocallahan.org>'s request for superreview: Bug 376662: Convert nsIFrame::GetOffsetTo to not explicitly use views https://bugzilla.mozilla.org/show_bug.cgi?id=376662 Attachment 335453: fix v2 https://bugzilla.mozilla.org/attachment.cgi?id=335453&action=edit ...

superreview granted: [Bug 331557] Remove nsIAbDirectoryProperties : [Attachment 221470] Convert pref functions to use ACString for values v3
neil@parkwaycc.co.uk <neil@httl.net> has granted Mark Banner <bugzilla@standard8.demon.co.uk>'s request for superreview: Bug 331557: Remove nsIAbDirectoryProperties https://bugzilla.mozilla.org/show_bug.cgi?id=331557 Attachment 221470: Convert pref functions to use ACString for values v3 https://bugzilla.mozilla.org/attachment.cgi?id=221470&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> >+ ACString getLocalizedStringValue(in string aName, in ACString aDefaultValue); Since you convert UTF16 to UTF8 below I guess these...

superreview granted: [Bug 78274] Convert profile manager to use <dialog> : [Attachment 151485] v1.1
Seth Spitzer <sspitzer@mozilla.org> has granted neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview: Bug 78274: Convert profile manager to use <dialog> http://bugzilla.mozilla.org/show_bug.cgi?id=78274 Attachment 151485: v1.1 http://bugzilla.mozilla.org/attachment.cgi?id=151485&action=edit ------- Additional Comments from Seth Spitzer <sspitzer@mozilla.org> sr=sspitzer ...

superreview granted: [Bug 349170] nsCSSValue should use nsMemory allocators : [Attachment 235018] Convert mString and mURL.mString to nsMemory
Boris Zbarsky <bzbarsky@mit.edu> has granted Robert Sayre <sayrer@gmail.com>'s request for superreview: Bug 349170: nsCSSValue should use nsMemory allocators https://bugzilla.mozilla.org/show_bug.cgi?id=349170 Attachment 235018: Convert mString and mURL.mString to nsMemory https://bugzilla.mozilla.org/attachment.cgi?id=235018&action=edit ...

superreview granted: [Bug 275131] want cookies for RSS sites : [Attachment 171060] adjusted patch to use a shared helper method
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 275131: want cookies for RSS sites https://bugzilla.mozilla.org/show_bug.cgi?id=275131 Attachment 171060: adjusted patch to use a shared helper method https://bugzilla.mozilla.org/attachment.cgi?id=171060&action=edit ...

Web resources about - superreview granted: [Bug 409331] convert sites that QueryInterface to kBlockCID to use nsLayoutUtils:: GetAsBlock : [Attachment 295022] convert sites that QueryInterface to kBlockCID to use nsLayoutU - mozilla.dev.super-review