superreview granted: [Bug 408782] [FIX]Inconsistent display of <input type= "image"> when "alt" attribute is removed : [Attachment 293629] Simple fix

David Baron [:dbaron] <dbaron@mozilla.com> has granted Boris Zbarsky (reviews
very slow until spring) <bzbarsky@mit.edu>'s request for superreview:
Bug 408782: [FIX]Inconsistent display of <input type="image"> when "alt"
attribute is removed
https://bugzilla.mozilla.org/show_bug.cgi?id=408782

Attachment 293629: Simple fix
https://bugzilla.mozilla.org/attachment.cgi?id=293629&action=edit

------- Additional Comments from David Baron [:dbaron] <dbaron@mozilla.com>
r+sr=dbaron
0
bugzilla
12/18/2007 6:04:41 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
587 Views

Similar Articles

[PageSpeed] 43

Reply:

Similar Artilces:

superreview requested: [Bug 408782] Inconsistent display of <input type=" image"> when "alt" attribute is removed : [Attachment 293629] Simple fix
Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> has asked David Baron [:dbaron] <dbaron@mozilla.com> for superreview: Bug 408782: Inconsistent display of <input type="image"> when "alt" attribute is removed https://bugzilla.mozilla.org/show_bug.cgi?id=408782 Attachment 293629: Simple fix https://bugzilla.mozilla.org/attachment.cgi?id=293629&action=edit ...

superreview granted: [Bug 288331] [FIX]Removing type attribute on an <input type="checkbox"> does not work : [Attachment 179095] Fix
Johnny Stenback <jst@mozilla.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 288331: [FIX]Removing type attribute on an <input type="checkbox"> does not work https://bugzilla.mozilla.org/show_bug.cgi?id=288331 Attachment 179095: Fix https://bugzilla.mozilla.org/attachment.cgi?id=179095&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> r+sr=jst ...

superreview requested: [Bug 288331] [FIX]Removing type attribute on an <input type="checkbox"> does not work : [Attachment 179095] Fix
Boris Zbarsky <bzbarsky@mit.edu> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 288331: [FIX]Removing type attribute on an <input type="checkbox"> does not work https://bugzilla.mozilla.org/show_bug.cgi?id=288331 Attachment 179095: Fix https://bugzilla.mozilla.org/attachment.cgi?id=179095&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> This is basically a one-liner; should be a very quick review. ...

superreview requested: [Bug 288331] Removing type attribute on an <input type="checkbox"> does not work : [Attachment 179095] Fix
Boris Zbarsky <bzbarsky@mit.edu> has asked Peter Van der Beken (away from March 29th to April 11th 2005) <peterv@propagandism.org> for superreview: Bug 288331: Removing type attribute on an <input type="checkbox"> does not work https://bugzilla.mozilla.org/show_bug.cgi?id=288331 Attachment 179095: Fix https://bugzilla.mozilla.org/attachment.cgi?id=179095&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> I think the comment in the diff pretty much explains what's going on here... ...

superreview granted: [Bug 307616] <input type="image"> with missing image gives "ASSERTION: Form control has a frame, but it's not a form frame" : [Attachment 207080] patch
Boris Zbarsky (out of town Dec 12 -- Jan 2) <bzbarsky@mit.edu> has granted Boris Zbarsky (out of town Dec 12 -- Jan 2) <bzbarsky@mit.edu>'s request for superreview: Bug 307616: <input type="image"> with missing image gives "ASSERTION: Form control has a frame, but it's not a form frame" https://bugzilla.mozilla.org/show_bug.cgi?id=307616 Attachment 207080: patch https://bugzilla.mozilla.org/attachment.cgi?id=207080&action=edit ------- Additional Comments from Boris Zbarsky (out of town Dec 12 -- Jan 2) <bzbarsky@mit.edu> Yep...

superreview granted: [Bug 242873] [FIX]Remove <input type="browse"> : [Attachment 147838] Like so
Peter Van der Beken <peterv@propagandism.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 242873: [FIX]Remove <input type="browse"> http://bugzilla.mozilla.org/show_bug.cgi?id=242873 Attachment 147838: Like so http://bugzilla.mozilla.org/attachment.cgi?id=147838&action=edit ...

superreview granted: [Bug 344215] <xul:observes/> with no attributes triggers "ASSERTION: getElementById(""), fix caller?" : [Attachment 229189] Patch rev. 1
Jonas Sicking <bugmail@sicking.cc> has granted superreview: Bug 344215: <xul:observes/> with no attributes triggers "ASSERTION: getElementById(""), fix caller?" https://bugzilla.mozilla.org/show_bug.cgi?id=344215 Attachment 229189: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=229189&action=edit ...

superreview granted: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only)
Brendan Eich <brendan@mozilla.org> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> rs=me, I'm trusting you guys, patch looks ok from the context di...

superreview granted: [Bug 403249] [FIX]"ASSERTION: How did that happen??" with <col>, changing "span" attribute
Robert O'Callahan (:roc) <roc@ocallahan.org> has granted Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu>'s request for superreview: Bug 403249: [FIX]"ASSERTION: How did that happen??" with <col>, changing "span" attribute https://bugzilla.mozilla.org/show_bug.cgi?id=403249 Attachment 288234: Proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=288234&action=edit ...

superreview requested: [Bug 242873] [FIX]Remove <input type="browse"> : [Attachment 147838] Like so
Boris Zbarsky <bzbarsky@mit.edu> has asked Peter Van der Beken <peterv@propagandism.org> for superreview: Bug 242873: [FIX]Remove <input type="browse"> http://bugzilla.mozilla.org/show_bug.cgi?id=242873 Attachment 147838: Like so http://bugzilla.mozilla.org/attachment.cgi?id=147838&action=edit ...

superreview granted: [Bug 245819] Can't get accessibility info from 2 pages in a row, when they have <input type="text"> : [Attachment 150220] Fix flaws in checkin to bug 244624, which caused this re
Henry Jia <Henry.Jia@sun.com> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 245819: Can't get accessibility info from 2 pages in a row, when they have <input type="text"> http://bugzilla.mozilla.org/show_bug.cgi?id=245819 Attachment 150220: Fix flaws in checkin to bug 244624, which caused this regression http://bugzilla.mozilla.org/attachment.cgi?id=150220&action=edit ...

superreview granted: [Bug 217089] Fix compiler warnings: "unused variable" and "defined but not used" : [Attachment 146892] <nsFrame.cpp>
David Baron <dbaron@dbaron.org> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 217089: Fix compiler warnings: "unused variable" and "defined but not used" http://bugzilla.mozilla.org/show_bug.cgi?id=217089 Attachment 146892: <nsFrame.cpp> http://bugzilla.mozilla.org/attachment.cgi?id=146892&action=edit ...

superreview granted: [Bug 217089] Fix compiler warnings: "unused variable" and "defined but not used" : [Attachment 137772] <nsScreenManagerWin.*> (v6)
<rbs@maths.uq.edu.au> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 217089: Fix compiler warnings: "unused variable" and "defined but not used" http://bugzilla.mozilla.org/show_bug.cgi?id=217089 Attachment 137772: <nsScreenManagerWin.*> (v6) http://bugzilla.mozilla.org/attachment.cgi?id=137772&action=edit ------- Additional Comments from <rbs@maths.uq.edu.au> sr=rbs ...

superreview granted: [Bug 353609] Rename "Show Images" button to "Load Images" : [Attachment 239475] the fix
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 353609: Rename "Show Images" button to "Load Images" https://bugzilla.mozilla.org/show_bug.cgi?id=353609 Attachment 239475: the fix https://bugzilla.mozilla.org/attachment.cgi?id=239475&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> I kinda disagree - yes, technically this is more correct, we'll load the images *and* show them, but what the user is interested in is showing them. ...

Web resources about - superreview granted: [Bug 408782] [FIX]Inconsistent display of <input type= "image"> when "alt" attribute is removed : [Attachment 293629] Simple fix - mozilla.dev.super-review

Resources last updated: 1/8/2016 6:43:11 AM