superreview granted: [Bug 303521] !!! Object's nsIClassInfo lies about it's interfaces!!! s.b. "its" : [Attachment 191706] fix spelling
Johnny Stenback <jst@mozilla.org> has granted timeless@myrealbox.com (working) <timeless@bemail.org>'s request for superreview: Bug 303521: !!! Object's nsIClassInfo lies about it's interfaces!!! s.b. "its" https://bugzilla.mozilla.org/show_bug.cgi?id=303521 Attachment 191706: fix spelling https://bugzilla.mozilla.org/attachment.cgi?id=191706&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> r+sr=jst either way... ...

superreview granted: [Bug 157566] Enhance MailNews to work with WinZip's "Zip and e-mail" shell extension : [Attachment 147290] trunk version of the fix with david's review comment
Scott MacGregor <mscott@mozilla.org> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 157566: Enhance MailNews to work with WinZip's "Zip and e-mail" shell extension http://bugzilla.mozilla.org/show_bug.cgi?id=157566 Attachment 147290: trunk version of the fix with david's review comment http://bugzilla.mozilla.org/attachment.cgi?id=147290&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> carrying over david's sr ...

superreview requested: [Bug 303521] !!! Object's nsIClassInfo lies about it's interfaces!!! s.b. "its" : [Attachment 191706] fix spelling
timeless@myrealbox.com (working) <timeless@bemail.org> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 303521: !!! Object's nsIClassInfo lies about it's interfaces!!! s.b. "its" https://bugzilla.mozilla.org/show_bug.cgi?id=303521 Attachment 191706: fix spelling https://bugzilla.mozilla.org/attachment.cgi?id=191706&action=edit ...

superreview granted: [Bug 382199] "ASSERTION: Disagreement about whether it 's a block or not" with table-as-root, float, absolute
David Baron [:dbaron] <dbaron@mozilla.com> has granted superreview: Bug 382199: "ASSERTION: Disagreement about whether it's a block or not" with table-as-root, float, absolute https://bugzilla.mozilla.org/show_bug.cgi?id=3D382199 Attachment 270366: Just the assert https://bugzilla.mozilla.org/attachment.cgi?id=3D270366&action=3Dedit ------- Additional Comments from David Baron [:dbaron] <dbaron@mozilla.com> r+sr=3Ddbaron. Sorry for the delay.= ...

superreview denied: [Bug 304239] Fix issues in NSPR's real_install makefile target : [Attachment 192310] Report NSPR 4.6's version as "4.6" instead of "4.6.0"
Chris Seawood <cls@seawood.org> has denied Wan-Teh Chang <wtchang@redhat.com>'s request for superreview: Bug 304239: Fix issues in NSPR's real_install makefile target https://bugzilla.mozilla.org/show_bug.cgi?id=304239 Attachment 192310: Report NSPR 4.6's version as "4.6" instead of "4.6.0" https://bugzilla.mozilla.org/attachment.cgi?id=192310&action=edit ------- Additional Comments from Chris Seawood <cls@seawood.org> I don't like this kind of special casing. And the checks in nspr.m4 & values in mozilla-nspr.pc would ...

superreview requested: [Bug 304239] Fix issues in NSPR's real_install makefile target : [Attachment 192310] Report NSPR 4.6's version as "4.6" instead of "4.6.0"
Wan-Teh Chang <wtchang@redhat.com> has asked Chris Seawood <cls@seawood.org> for superreview: Bug 304239: Fix issues in NSPR's real_install makefile target https://bugzilla.mozilla.org/show_bug.cgi?id=304239 Attachment 192310: Report NSPR 4.6's version as "4.6" instead of "4.6.0" https://bugzilla.mozilla.org/attachment.cgi?id=192310&action=edit ------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com> Will dropping the 0 patch level break any script (e.g., mozilla's --with-system-nspr configure option)? ...

superreview granted: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 227564] fixes in response to Darin's re
Darin Fisher (Google) <darin@meer.net> has granted Marria Nazif <marria@gmail.com>'s request for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 227564: fixes in response to Darin's review https://bugzilla.mozilla.org/attachment.cgi?id=227564&action=edit ------- Additional Comments from Darin Fisher (Google) <darin@meer.net> >Index: docshell/base/nsDocShell.cpp > if (!r...

superreview requested: [Bug 344505] role="anything" on <table> should remove roleless <td>'s, <th's> from hierarchy : [Attachment 229522] Any role on a table means the table structure descendants are
Aaron Leventhal <aaronleventhal@moonset.net> has asked for superreview: Bug 344505: role="anything" on <table> should remove roleless <td>'s, <th's> from hierarchy https://bugzilla.mozilla.org/show_bug.cgi?id=344505 Attachment 229522: Any role on a table means the table structure descendants are no longer structurally relevant, unless they have their own role. They're being used to layout the container. https://bugzilla.mozilla.org/attachment.cgi?id=229522&action=edit ...

superreview cancelled: [Bug 344505] role="anything" on <table> should remove roleless <td>'s, <th's> from hierarchy : [Attachment 229522] Any role on a table means the table structure descendants are
Aaron Leventhal <aaronleventhal@moonset.net> has cancelled Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 344505: role="anything" on <table> should remove roleless <td>'s, <th's> from hierarchy https://bugzilla.mozilla.org/show_bug.cgi?id=344505 Attachment 229522: Any role on a table means the table structure descendants are no longer structurally relevant, unless they have their own role. They're being used to layout the container. https://bugzilla.mozilla.org/attachment.cgi?id=229522&action=edi...

superreview requested: [Bug 382199] "ASSERTION: Disagreement about whether it's a block or not" with table-as-root, float, absolute
Boris Zbarsky (reviews very slow until at least mid-July) <bzbarsky@mit.edu> has asked David Baron [:dbaron] <dbaron@mozilla.com> for superreview: Bug 382199: "ASSERTION: Disagreement about whether it's a block or not" with table-as-root, float, absolute https://bugzilla.mozilla.org/show_bug.cgi?id=382199 Attachment 267931: Sounds good https://bugzilla.mozilla.org/attachment.cgi?id=267931&action=edit ...

superreview canceled: [Bug 382199] "ASSERTION: Disagreement about whether it's a block or not" with table-as-root, float, absolute
Boris Zbarsky (not available till July 4) <bzbarsky@mit.edu> has canceled Boris Zbarsky (not available till July 4) <bzbarsky@mit.edu>'s request for superreview: Bug 382199: "ASSERTION: Disagreement about whether it's a block or not" with table-as-root, float, absolute https://bugzilla.mozilla.org/show_bug.cgi?id=382199 Attachment 267931: Sounds good https://bugzilla.mozilla.org/attachment.cgi?id=267931&action=edit ...

superreview granted: [Bug 157566] Enhance MailNews to work with WinZip's "Zip and e-mail" shell extension : [Attachment 148878] here's the new routine in its entirety instead of as a diff
David Bienvenu <bienvenu@nventure.com> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 157566: Enhance MailNews to work with WinZip's "Zip and e-mail" shell extension http://bugzilla.mozilla.org/show_bug.cgi?id=157566 Attachment 148878: here's the new routine in its entirety instead of as a diff http://bugzilla.mozilla.org/attachment.cgi?id=148878&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> looks good - one spelling nit: // copy the file to it's new loca...

superreview granted: [Bug 309044] Flashplayer 8 "Bad NPObject as private data!" : [Attachment 201809] Take a plugin's scriptable object out of the plugin element's prototype chain on plugin destructi
Brendan Eich <brendan@mozilla.org> has granted Johnny Stenback <jst@mozilla.org>'s request for superreview: Bug 309044: Flashplayer 8 "Bad NPObject as private data!" https://bugzilla.mozilla.org/show_bug.cgi?id=309044 Attachment 201809: Take a plugin's scriptable object out of the plugin element's prototype chain on plugin destruction https://bugzilla.mozilla.org/attachment.cgi?id=201809&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> sr=me. /be ...

superreview granted: [Bug 378544] General's Default Feed Viewer's " =?UTF-8?Q?Select=E2=80=A6?=" doesn't use real elipsis
Mike Pinkerton <mikepinkerton@mac.com> has granted Stuart Morgan <stuart.morgan@alumni.case.edu>'s request for superreview: Bug 378544: General's Default Feed Viewer's "Select=E2=80=A6" doesn't use r= eal elipsis https://bugzilla.mozilla.org/show_bug.cgi?id=3D378544 Attachment 264750: changed https://bugzilla.mozilla.org/attachment.cgi?id=3D264750&action=3Dedit ------- Additional Comments from Mike Pinkerton <mikepinkerton@mac.com> rs=3Dpink= ...

superreview granted: [Bug 388374] [FIX]"ASSERTION: How did our kid' s height change if nothing was dirty?" with tables, padding, <select>
David Baron [:dbaron] <dbaron@mozilla.com> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 388374: [FIX]"ASSERTION: How did our kid's height change if nothing was dirty?" with tables, padding, <select> https://bugzilla.mozilla.org/show_bug.cgi?id=388374 Attachment 273034: Proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=273034&action=edit ------- Additional Comments from David Baron [:dbaron] <dbaron@mozilla.com> r+sr=dbaron. (Seems like checking ShouldReflowAllKids() rather than just mHResize mi...