superreview granted: [Bug 408023] The indicator doesn' t look disabled in a disabled check menu item : [Attachment 292721] Patch

Robert O'Callahan (:roc) <roc@ocallahan.org> has granted Michael Ventnor
<ventnor.bugzilla@yahoo.com.au>'s request for superreview:
Bug 408023: The indicator doesn't look disabled in a disabled check menu item
https://bugzilla.mozilla.org/show_bug.cgi?id=408023

Attachment 292721: Patch
https://bugzilla.mozilla.org/attachment.cgi?id=292721&action=edit
0
bugzilla
12/12/2007 8:13:38 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
317 Views

Similar Articles

[PageSpeed] 50

Reply:

Similar Artilces:

superreview requested: [Bug 408023] The indicator doesn' t look disabled in a disabled check menu item : [Attachment 292721] Patch
Michael Ventnor <ventnor.bugzilla@yahoo.com.au> has asked Robert O'Callahan (:roc) <roc@ocallahan.org> for superreview: Bug 408023: The indicator doesn't look disabled in a disabled check menu item https://bugzilla.mozilla.org/show_bug.cgi?id=408023 Attachment 292721: Patch https://bugzilla.mozilla.org/attachment.cgi?id=292721&action=edit ------- Additional Comments from Michael Ventnor <ventnor.bugzilla@yahoo.com.au> In the Library, you cannot remove the Name column which is represented by a disabled check menu item on the column menu to the top-righ...

superreview requested: [Bug 342354] Menu item acceltext doesn't reflect <xul:key disabled="true"/> : [Attachment 226822] patch, v1
Alex Vincent <ajvincent@gmail.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 342354: Menu item acceltext doesn't reflect <xul:key disabled="true"/> https://bugzilla.mozilla.org/show_bug.cgi?id=342354 Attachment 226822: patch, v1 https://bugzilla.mozilla.org/attachment.cgi?id=226822&action=edit ------- Additional Comments from Alex Vincent <ajvincent@gmail.com> With this patch, the acceltext is still visible, but disabled when the corresponding key element is disabled. Patch applies to toolkit and xpfe. ...

superreview granted: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 313971] Label disabling patch v1.1a
neil@parkwaycc.co.uk <neil@httl.net> has granted Ian Neal <iann_bugzilla@blueyonder.co.uk>'s request for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=79603 Attachment 313971: Label disabling patch v1.1a https://bugzilla.mozilla.org/attachment.cgi?id=313971&action=edit ...

superreview denied: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 312934] Disable and lock checking patch v1.0a
neil@parkwaycc.co.uk <neil@httl.net> has denied Ian Neal <iann_bugzilla@blueyonder.co.uk>'s request for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=3D79603 Attachment 312934: Disable and lock checking patch v1.0a https://bugzilla.mozilla.org/attachment.cgi?id=3D312934&action=3Dedit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> Unfortunately disabling colourpickers doesn't work correctly - the binding simply makes a bold claim that it's...

superreview canceled: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 312933] Disable and lock checking patch v1.0
Ian Neal <iann_bugzilla@blueyonder.co.uk> has canceled Ian Neal <iann_bugzilla@blueyonder.co.uk>'s request for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=79603 Attachment 312933: Disable and lock checking patch v1.0 https://bugzilla.mozilla.org/attachment.cgi?id=312933&action=edit ...

superreview requested: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 312933] Disable and lock checking patch v1.0
Ian Neal <iann_bugzilla@blueyonder.co.uk> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=79603 Attachment 312933: Disable and lock checking patch v1.0 https://bugzilla.mozilla.org/attachment.cgi?id=312933&action=edit ------- Additional Comments from Ian Neal <iann_bugzilla@blueyonder.co.uk> This patch: * Disables the color pickers when system colors box is checked as long as picker pref is not locked. * Re-enables the col...

superreview requested: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 312934] Disable and lock checking patch v1.0a
Ian Neal <iann_bugzilla@blueyonder.co.uk> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=79603 Attachment 312934: Disable and lock checking patch v1.0a https://bugzilla.mozilla.org/attachment.cgi?id=312934&action=edit ------- Additional Comments from Ian Neal <iann_bugzilla@blueyonder.co.uk> Correct patch that doesn't try adding a second pref-appearance.js entry to jar.mn ...

superreview granted: [Bug 274036] [Mac] Scrollbars should look disabled when there's nowhere to scroll : [Attachment 186896] Revised patch, fixes carbon scrollbar disabling
Brian Ryner <bryner@brianryner.com> has granted Simon Fraser <sfraser_bugs@smfr.org>'s request for superreview: Bug 274036: [Mac] Scrollbars should look disabled when there's nowhere to scroll https://bugzilla.mozilla.org/show_bug.cgi?id=274036 Attachment 186896: Revised patch, fixes carbon scrollbar disabling https://bugzilla.mozilla.org/attachment.cgi?id=186896&action=edit ...

superreview granted: [Bug 257638] [ATK] Menu Item doesn't work properly : [Attachment 171735] patch v2
Henry Jia <Henry.Jia@sun.com> has granted Louie Zhao <Louie.Zhao@sun.com>'s request for superreview: Bug 257638: [ATK] Menu Item doesn't work properly https://bugzilla.mozilla.org/show_bug.cgi?id=257638 Attachment 171735: patch v2 https://bugzilla.mozilla.org/attachment.cgi?id=171735&action=edit ...

superreview granted: [Bug 363680] Bookmark Info should be disabled for menu spacers : [Attachment 248855] Doesn't break when selection is only separators
Mike Pinkerton <mikepinkerton@mac.com> has granted Chris Lawson (gone until 05 Jan) <bugzilla@chrislawson.net>'s request for superreview: Bug 363680: Bookmark Info should be disabled for menu spacers https://bugzilla.mozilla.org/show_bug.cgi?id=363680 Attachment 248855: Doesn't break when selection is only separators https://bugzilla.mozilla.org/attachment.cgi?id=248855&action=edit ------- Additional Comments from Mike Pinkerton <mikepinkerton@mac.com> sr=pink ...

superreview granted: [Bug 279535] [FIX] disabling and then enabling image view doesn't show images again : [Attachment 173396] patch v1
Darin Fisher <darin@meer.net> has granted Michiel van Leeuwen (email: mvl+moz@) <mvl@exedo.nl>'s request for superreview: Bug 279535: [FIX] disabling and then enabling image view doesn't show images again https://bugzilla.mozilla.org/show_bug.cgi?id=279535 Attachment 173396: patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=173396&action=edit ------- Additional Comments from Darin Fisher <darin@meer.net> ack! sr=darin ...

superreview granted: [Bug 301688] Disabled buttons shoudn't have a "default button" look&feel : [Attachment 190112] patch
Simon Fraser <sfraser_bugs@smfr.org> has granted Asaf Romano (use mozilla.mano@ for email) <bugs.mano@sent.com>'s request for superreview: Bug 301688: Disabled buttons shoudn't have a "default button" look&feel https://bugzilla.mozilla.org/show_bug.cgi?id=301688 Attachment 190112: patch https://bugzilla.mozilla.org/attachment.cgi?id=190112&action=edit ...

superreview granted: [Bug 122238] input type="image" doesn't send x/y (image doesn't exist; width and height not set) : [Attachment 139545] Same as jkeiser's patch, really...
Johnny Stenback <jst@mozilla.jstenback.com> has granted Boris Zbarsky <bz-vacation@mit.edu>'s request for superreview: Bug 122238: input type="image" doesn't send x/y (image doesn't exist; width and height not set) http://bugzilla.mozilla.org/show_bug.cgi?id=122238 Attachment 139545: Same as jkeiser's patch, really... http://bugzilla.mozilla.org/attachment.cgi?id=139545&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> + if (!name.IsEmpty()) { + aFormSubmission->AddNameValuePair(thi...

superreview requested: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 313971] Label disabling patch v1.1a
Ian Neal <iann_bugzilla@blueyonder.co.uk> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=79603 Attachment 313971: Label disabling patch v1.1a https://bugzilla.mozilla.org/attachment.cgi?id=313971&action=edit ------- Additional Comments from Ian Neal <iann_bugzilla@blueyonder.co.uk> Changes since v1.1: * Labels now have the same disabled status as their associated colorpicker. ...

Web resources about - superreview granted: [Bug 408023] The indicator doesn' t look disabled in a disabled check menu item : [Attachment 292721] Patch - mozilla.dev.super-review

Resources last updated: 1/11/2016 9:37:01 AM