superreview granted: [Bug 407538] newURI("http://foo.com:80").port is 80, should be -1 (can set a URI's port to its default value by setting .spec) : [Attachment 292260] patch

Christian :Biesinger <cbiesinger@gmx.at> has granted Gavin Sharp
<gavin.sharp@gmail.com>'s request for superreview:
Bug 407538: newURI("http://foo.com:80").port is 80, should be -1 (can set a
URI's port to its default value by setting .spec)
https://bugzilla.mozilla.org/show_bug.cgi?id=407538

Attachment 292260: patch
https://bugzilla.mozilla.org/attachment.cgi?id=292260&action=edit

------- Additional Comments from Christian :Biesinger <cbiesinger@gmx.at>
would be good to also test that .spec doesn't include the :80 either

+  //XXX URL parsers shouldn't set ports to default value, even when changing
scheme?

the URI doesn't know the default port of the other scheme... and in fact the
other scheme may use a different URI implementation
0
bugzilla
12/10/2007 10:04:56 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
597 Views

Similar Articles

[PageSpeed] 51

Reply:

Similar Artilces:

superreview granted: [Bug 237228] pref "layout.word_select.eat_space_to_next_word" can't be set by user in the profile's prefs.js : [Attachment 158389] patch, add UnregisterPrefCallback
Robert O'Callahan <roc@ocallahan.org> has granted Ginn Chen <ginn.chen@sun.com>'s request for superreview: Bug 237228: pref "layout.word_select.eat_space_to_next_word" can't be set by user in the profile's prefs.js http://bugzilla.mozilla.org/show_bug.cgi?id=237228 Attachment 158389: patch, add UnregisterPrefCallback http://bugzilla.mozilla.org/attachment.cgi?id=158389&action=edit ...

superreview granted: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 218487] updated patch ready for review
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 218487: updated patch ready for review https://bugzilla.mozilla.org/attachment.cgi?id=218487&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> my one concern is about migration from the per-server prefs to the global prefs. What happens in that scenar...

superreview granted: [Bug 216533] Move the "Composition" settings *above* the "Addressing" settings in the Account Settings : [Attachment 130078] Patch v0.1a
David Bienvenu <bienvenu@nventure.com> has granted Ian Neal <bugzilla@arlen.demon.co.uk>'s request for superreview: Bug 216533: Move the "Composition" settings *above* the "Addressing" settings in the Account Settings http://bugzilla.mozilla.org/show_bug.cgi?id=216533 Attachment 130078: Patch v0.1a http://bugzilla.mozilla.org/attachment.cgi?id=130078&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> sr=bienvenu ...

superreview granted: [Bug 122238] input type="image" doesn't send x/y (image doesn't exist; width and height not set) : [Attachment 139545] Same as jkeiser's patch, really...
Johnny Stenback <jst@mozilla.jstenback.com> has granted Boris Zbarsky <bz-vacation@mit.edu>'s request for superreview: Bug 122238: input type="image" doesn't send x/y (image doesn't exist; width and height not set) http://bugzilla.mozilla.org/show_bug.cgi?id=122238 Attachment 139545: Same as jkeiser's patch, really... http://bugzilla.mozilla.org/attachment.cgi?id=139545&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> + if (!name.IsEmpty()) { + aFormSubmission->AddNameValuePair(thi...

superreview granted: [Bug 246750] Can't read menu/menuitem's "keyboard shortcut" and "accesskey" : [Attachment 150781] patch v1
Henry Jia <Henry.Jia@sun.com> has granted Louie Zhao <Louie.Zhao@sun.com>'s request for superreview: Bug 246750: Can't read menu/menuitem's "keyboard shortcut" and "accesskey" http://bugzilla.mozilla.org/show_bug.cgi?id=246750 Attachment 150781: patch v1 http://bugzilla.mozilla.org/attachment.cgi?id=150781&action=edit ------- Additional Comments from Henry Jia <Henry.Jia@sun.com> sr=Henry ...

superreview requested: [Bug 237228] pref "layout.word_select.eat_space_to_next_word" can't be set by user in the profile's prefs.js : [Attachment 158389] patch, add UnregisterPrefCallback
Ginn Chen <ginn.chen@sun.com> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 237228: pref "layout.word_select.eat_space_to_next_word" can't be set by user in the profile's prefs.js http://bugzilla.mozilla.org/show_bug.cgi?id=237228 Attachment 158389: patch, add UnregisterPrefCallback http://bugzilla.mozilla.org/attachment.cgi?id=158389&action=edit ...

superreview granted: [Bug 378544] General's Default Feed Viewer's " =?UTF-8?Q?Select=E2=80=A6?=" doesn't use real elipsis
Mike Pinkerton <mikepinkerton@mac.com> has granted Stuart Morgan <stuart.morgan@alumni.case.edu>'s request for superreview: Bug 378544: General's Default Feed Viewer's "Select=E2=80=A6" doesn't use r= eal elipsis https://bugzilla.mozilla.org/show_bug.cgi?id=3D378544 Attachment 264750: changed https://bugzilla.mozilla.org/attachment.cgi?id=3D264750&action=3Dedit ------- Additional Comments from Mike Pinkerton <mikepinkerton@mac.com> rs=3Dpink= ...

superreview requested: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 218487] updated patch ready for review
Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 218487: updated patch ready for review https://bugzilla.mozilla.org/attachment.cgi?id=218487&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> Here's what I did: 1) nsMsgAccountManagerDS.cpp.h Add code to display a junk mail panel for all accounts but news who h...

superreview granted: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 220151] updated fix with review comments
Scott MacGregor <mscott@mozilla.org> has granted superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 220151: updated fix with review comments https://bugzilla.mozilla.org/attachment.cgi?id=220151&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> carrying forward david's sr and neil's r. ...

superreview granted: [Bug 284911] "Default" text label is higher than "Port" in the SMTP edit window : [Attachment 176409] Patch
David Bienvenu <bienvenu@nventure.com> has granted Frank Wein <bugzilla@mcsmurf.de>'s request for superreview: Bug 284911: "Default" text label is higher than "Port" in the SMTP edit window https://bugzilla.mozilla.org/show_bug.cgi?id=284911 Attachment 176409: Patch https://bugzilla.mozilla.org/attachment.cgi?id=176409&action=edit ...

superreview granted: [Bug 216789] "Server Settings" tab in "Account Settings" is too big for preferences window : [Attachment 130981] Revised Patch v0.2a
David Bienvenu <bienvenu@nventure.com> has granted Ian Neal <bugzilla@arlen.demon.co.uk>'s request for superreview: Bug 216789: "Server Settings" tab in "Account Settings" is too big for preferences window http://bugzilla.mozilla.org/show_bug.cgi?id=216789 Attachment 130981: Revised Patch v0.2a http://bugzilla.mozilla.org/attachment.cgi?id=130981&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> sr=bienvenu ...

superreview granted: [Bug 338103] regression: document.dir is "" unless it's set manually : [Attachment 222194] patch
Boris Zbarsky (gone May 17 -- May 29) <bzbarsky@mit.edu> has granted Simon Montagu <smontagu@smontagu.org>'s request for superreview: Bug 338103: regression: document.dir is "" unless it's set manually https://bugzilla.mozilla.org/show_bug.cgi?id=338103 Attachment 222194: patch https://bugzilla.mozilla.org/attachment.cgi?id=222194&action=edit ------- Additional Comments from Boris Zbarsky (gone May 17 -- May 29) <bzbarsky@mit.edu> So who's the caller of SetBidi in this case? ...

superreview granted: [Bug 382331] [l10n] Default browser dialogue's "set" button does not resize well : [Attachment 303045] fix
Mike Pinkerton (not reading bugmail) <mikepinkerton@mac.com> has granted Stuart Morgan <stuart.morgan@alumni.case.edu>'s request for superreview: Bug 382331: [l10n] Default browser dialogue's "set" button does not resize well https://bugzilla.mozilla.org/show_bug.cgi?id=382331 Attachment 303045: fix https://bugzilla.mozilla.org/attachment.cgi?id=303045&action=edit ...

superreview cancelled: [Bug 274010] "Restore Default Set" of a customize tool bar works only a part. : [Attachment 244795] quick port patch
Hiro <sugar.waffle@gmail.com> has cancelled Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 274010: "Restore Default Set" of a customize tool bar works only a part. https://bugzilla.mozilla.org/show_bug.cgi?id=274010 Attachment 244795: quick port patch https://bugzilla.mozilla.org/attachment.cgi?id=244795&action=edit ...

superreview requested: [Bug 274010] "Restore Default Set" of a customize tool bar works only a part. : [Attachment 244795] quick port patch
Scott MacGregor <mscott@mozilla.org> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 274010: "Restore Default Set" of a customize tool bar works only a part. https://bugzilla.mozilla.org/show_bug.cgi?id=274010 Attachment 244795: quick port patch https://bugzilla.mozilla.org/attachment.cgi?id=244795&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> adding Phil as a reviewer since he's been looking at the toolbar code. ...

Web resources about - superreview granted: [Bug 407538] newURI("http://foo.com:80").port is 80, should be -1 (can set a URI's port to its default value by setting .spec) : [Attachment 292260] patch - mozilla.dev.super-review

Resources last updated: 12/27/2015 9:03:50 PM