superreview granted: [Bug 407415] NaNs in gfx*Font with font-size: 0 and font-size-adjust : [Attachment 293072] check for zero xHeight

Robert O'Callahan (:roc) <roc@ocallahan.org> has granted  superreview:
Bug 407415: NaNs in gfx*Font with font-size:0 and font-size-adjust
https://bugzilla.mozilla.org/show_bug.cgi?id=407415

Attachment 293072: check for zero xHeight
https://bugzilla.mozilla.org/attachment.cgi?id=293072&action=edit

------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.org>
Should you also check that emHeight is nonzero in gfxWindowsFonts to ensure we
don't divide by zero on it? I guess it should be equal to the requested font
size which should be nonzero, but I'm not sure if we can guarantee that.

If you want to do that, you can add it to this patch or make a new patch.
0
bugzilla
12/18/2007 9:13:20 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
674 Views

Similar Articles

[PageSpeed] 15

Reply:

Similar Artilces:

superreview granted: [Bug 181712] Menu item for "default font size" (also indicate current text/font zoom value/size?) : [Attachment 237374] r=smorgan patch
Mike Pinkerton <mikepinkerton@mac.com> has granted froodian <stridey@gmail.com>'s request for superreview: Bug 181712: Menu item for "default font size" (also indicate current text/font zoom value/size?) https://bugzilla.mozilla.org/show_bug.cgi?id=181712 Attachment 237374: r=smorgan patch https://bugzilla.mozilla.org/attachment.cgi?id=237374&action=edit ------- Additional Comments from Mike Pinkerton <mikepinkerton@mac.com> sr=pink. are we sure those getter_addrefs -> dont_addrefs are correct? ...

superreview granted: [Bug 428458] text input size="n" is too wide with monospace font : [Attachment 316186] patch, v.0.2, explicitly set Courier to be fixed-pitch font on mac
Robert O'Callahan (:roc) <roc@ocallahan.org> has granted John Daggett (:jtd) <jdaggett@mozilla.com>'s request for superreview: Bug 428458: text input size="n" is too wide with monospace font https://bugzilla.mozilla.org/show_bug.cgi?id=428458 Attachment 316186: patch, v.0.2, explicitly set Courier to be fixed-pitch font on mac https://bugzilla.mozilla.org/attachment.cgi?id=316186&action=edit ...

superreview granted: [Bug 404112] Crash with zero-sized fonts in some versions of libpango [@ libpango-1.0. so.0.1001.1
Stuart Parmenter <pavlov@pavlov.net> has granted Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 404112: Crash with zero-sized fonts in some versions of libpango [@ libpango-1.0.so.0.1001.1 - gfxPangoFont::GetMetrics] https://bugzilla.mozilla.org/show_bug.cgi?id=404112 Attachment 292062: Patch rev. 2 https://bugzilla.mozilla.org/attachment.cgi?id=292062&action=edit ...

superreview requested: [Bug 366138] The line-height should refer to adjusted font size, not 'font-size'
Masayuki Nakano (Mozilla Japan)(busy) <masayuki@d-toybox.com> has asked David Baron [:dbaron] <dbaron@mozilla.com> for superreview: Bug 366138: The line-height should refer to adjusted font size, not 'font-size' https://bugzilla.mozilla.org/show_bug.cgi?id=366138 Attachment 259881: Patch rv1.0 https://bugzilla.mozilla.org/attachment.cgi?id=259881&action=edit ------- Additional Comments from Masayuki Nakano (Mozilla Japan)(busy) <masayuki@d-toybox.com> fix. We should use actual font size for any relative sizes. ...

superreview cancelled: [Bug 366138] The line-height should refer to adjusted font size, not 'font-size'
Masayuki Nakano (Mozilla Japan)(busy) <masayuki@d-toybox.com> has cancelled Masayuki Nakano (Mozilla Japan)(busy) <masayuki@d-toybox.com>'s request for superreview: Bug 366138: The line-height should refer to adjusted font size, not 'font-size' https://bugzilla.mozilla.org/show_bug.cgi?id=366138 Attachment 259881: Patch rv1.0 https://bugzilla.mozilla.org/attachment.cgi?id=259881&action=edit ------- Additional Comments from Masayuki Nakano (Mozilla Japan)(busy) <masayuki@d-toybox.com> Sorry, we should use nsIRenderingContext::GetEmHeight instead of...

superreview denied: [Bug 366138] The line-height should refer to adjusted font size, not 'font-size'
David Baron [:dbaron] <dbaron@mozilla.com> has denied Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview: Bug 366138: The line-height should refer to adjusted font size, not 'font-size' https://bugzilla.mozilla.org/show_bug.cgi?id=366138 Attachment 260565: Patch rv1.1 https://bugzilla.mozilla.org/attachment.cgi?id=260565&action=edit ------- Additional Comments from David Baron [:dbaron] <dbaron@mozilla.com> In any case, I'm not sure what we do want to do here, but I don't think this patch is what we want. ...

superreview granted: [Bug 120401] Font selection in pref. does not work (Hebrew, Arabic, CE, Baltic, Cyrillic, CJK, etc) : [Attachment 155201] Add change to default font size (as in bug 143557)
Simon Fraser <sfraser@aol.net> has granted Asaf Romano <bugs.mano@mail-central.com>'s request for superreview: Bug 120401: Font selection in pref. does not work (Hebrew, Arabic, CE, Baltic, Cyrillic, CJK, etc) http://bugzilla.mozilla.org/show_bug.cgi?id=120401 Attachment 155201: Add change to default font size (as in bug 143557) http://bugzilla.mozilla.org/attachment.cgi?id=155201&action=edit ...

superreview requested: [Bug 366138] The line-height should refer to adjusted font size, not 'font-size' #2
Masayuki Nakano (Mozilla Japan)(busy) <masayuki@d-toybox.com> has asked David Baron [:dbaron] <dbaron@mozilla.com> for superreview: Bug 366138: The line-height should refer to adjusted font size, not 'font-size' https://bugzilla.mozilla.org/show_bug.cgi?id=366138 Attachment 260557: Patch rv1.1 https://bugzilla.mozilla.org/attachment.cgi?id=260557&action=edit ...

superreview cancelled: [Bug 366138] The line-height should refer to adjusted font size, not 'font-size' #2
Masayuki Nakano (Mozilla Japan)(busy) <masayuki@d-toybox.com> has cancelled Masayuki Nakano (Mozilla Japan)(busy) <masayuki@d-toybox.com>'s request for superreview: Bug 366138: The line-height should refer to adjusted font size, not 'font-size' https://bugzilla.mozilla.org/show_bug.cgi?id=366138 Attachment 260557: Patch rv1.1 https://bugzilla.mozilla.org/attachment.cgi?id=260557&action=edit ------- Additional Comments from Masayuki Nakano (Mozilla Japan)(busy) <masayuki@d-toybox.com> Sorry. The patch has a gfx code. We need some easy work in gfx a...

superreview requested: [Bug 366138] The line-height should refer to adjusted font size, not 'font-size' #3
Masayuki Nakano (Mozilla Japan)(busy) <masayuki@d-toybox.com> has asked David Baron [:dbaron] <dbaron@mozilla.com> for superreview: Bug 366138: The line-height should refer to adjusted font size, not 'font-size' https://bugzilla.mozilla.org/show_bug.cgi?id=366138 Attachment 260565: Patch rv1.1 https://bugzilla.mozilla.org/attachment.cgi?id=260565&action=edit ------- Additional Comments from Masayuki Nakano (Mozilla Japan)(busy) <masayuki@d-toybox.com> Sorry. The patch has a gfx code. We need some easy work in gfx after this. ...

superreview requested: [Bug 181712] Menu item for "default font size" (also indicate current text/font zoom value/size?) : [Attachment 237374] r=smorgan patch
froodian <stridey@gmail.com> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 181712: Menu item for "default font size" (also indicate current text/font zoom value/size?) https://bugzilla.mozilla.org/show_bug.cgi?id=181712 Attachment 237374: r=smorgan patch https://bugzilla.mozilla.org/attachment.cgi?id=237374&action=edit ------- Additional Comments from froodian <stridey@gmail.com> Pink, this blocks all the menu cleanup work for 1.1, so a speedy sr would be most helpful for me. :) ...

superreview granted: [Bug 290081] font size can override <hN> tags if more than one <font> is opened incorrectly : [Attachment 180559] patch v1
rbs@maths.uq.edu.au has granted Blake Kaplan <mrbkap@gmail.com>'s request for superreview: Bug 290081: font size can override <hN> tags if more than one <font> is opened incorrectly https://bugzilla.mozilla.org/show_bug.cgi?id=290081 Attachment 180559: patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=180559&action=edit ------- Additional Comments from rbs@maths.uq.edu.au sr=rbs + while (count-- > 0) { To speedup understanding, I would have preferred (in this context) + while (--count >= 0) { but... ...

superreview requested: [Bug 428458] text input size="n" is too wide with monospace font : [Attachment 316186] patch, v.0.2, explicitly set Courier to be fixed-pitch font on mac
John Daggett (:jtd) <jdaggett@mozilla.com> has asked Vladimir Vukicevic (:vlad) <vladimir@pobox.com> for superreview: Bug 428458: text input size="n" is too wide with monospace font https://bugzilla.mozilla.org/show_bug.cgi?id=428458 Attachment 316186: patch, v.0.2, explicitly set Courier to be fixed-pitch font on mac https://bugzilla.mozilla.org/attachment.cgi?id=316186&action=edit ------- Additional Comments from John Daggett (:jtd) <jdaggett@mozilla.com> Based on Smokey's screenshots, setting Courier New as the default monospace font doesn...

superreview requested: [Bug 404112] Crash with zero-sized fonts in some versions of libpango [@ libpango-1.0. so.0.1001.1
Mats Palmgren <mats.palmgren@bredband.net> has asked Robert O'Callahan (:ro= c) <roc@ocallahan.org> for superreview: Bug 404112: Crash with zero-sized fonts in some versions of libpango [@ libpango-1.0.so.0.1001.1 - gfxPangoFont::GetMetrics] https://bugzilla.mozilla.org/show_bug.cgi?id=3D404112 Attachment 292062: Patch rev. 2 https://bugzilla.mozilla.org/attachment.cgi?id=3D292062&action=3Dedit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> (In reply to comment #27)=0D > libpango _to_ crash=0D =0D fixed=0D =0D > Ple...

Web resources about - superreview granted: [Bug 407415] NaNs in gfx*Font with font-size: 0 and font-size-adjust : [Attachment 293072] check for zero xHeight - mozilla.dev.super-review

This awesome experiment in responsive typography uses face detection to adjust font size
... typography to a new level: using face detection, Dugonjić calculates the proximity a user is from his or her screen, and then adjusts font size ...

Resources last updated: 1/16/2016 11:40:40 AM