superreview granted: [Bug 407019] "Assertion failure: !JS_IsExceptionPending(cx)" with |new Option|, take 2 : [Attachment 293779 ] Fix

Jonas Sicking (:sicking) Vacation Dec 19th to Jan 2nd <jonas@sicking.cc> has
granted Blake Kaplan <mrbkap@gmail.com>'s request for superreview:
Bug 407019: "Assertion failure: !JS_IsExceptionPending(cx)" with |new Option|,
take 2
https://bugzilla.mozilla.org/show_bug.cgi?id=407019

Attachment 293779: Fix
https://bugzilla.mozilla.org/attachment.cgi?id=293779&action=edit
0
bugzilla
12/26/2007 2:22:53 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
254 Views

Similar Articles

[PageSpeed] 7

Reply:

Similar Artilces:

superreview requested: [Bug 407019] "Assertion failure: !JS_IsExceptionPending(cx)" with |new Option|, take 2 : [Attachment 293779 ] Fix
Blake Kaplan <mrbkap@gmail.com> has asked Jonas Sicking (:sicking) <jonas@sicking.cc> for superreview: Bug 407019: "Assertion failure: !JS_IsExceptionPending(cx)" with |new Option|, take 2 https://bugzilla.mozilla.org/show_bug.cgi?id=407019 Attachment 293779: Fix https://bugzilla.mozilla.org/attachment.cgi?id=293779&action=edit ------- Additional Comments from Blake Kaplan <mrbkap@gmail.com> Sorry, I had tunnel vision when I fixed the first bug. This applies the same fix to the rest of the function. I'll attach a diff -w for easier reviewing ...

superreview granted: [Bug 399960] "Assertion failure: !JS_IsExceptionPending(cx)" with |new Option|
Johnny Stenback <jst@mozilla.org> has granted Blake Kaplan <mrbkap@gmail.com>'s request for superreview: Bug 399960: "Assertion failure: !JS_IsExceptionPending(cx)" with |new Option| https://bugzilla.mozilla.org/show_bug.cgi?id=399960 Attachment 285548: diff -w of the fix https://bugzilla.mozilla.org/attachment.cgi?id=285548&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> r+sr=jst ...

superreview granted: [Bug 418133] [FIX]"Assertion failure: !JS_IsExceptionPending(cx)" with <xul:preferences> : [Attachment 306201] Possible patch
Brendan Eich <brendan@mozilla.org> has granted Boris Zbarsky (reviews very slow until May) <bzbarsky@mit.edu>'s request for superreview: Bug 418133: [FIX]"Assertion failure: !JS_IsExceptionPending(cx)" with <xul:preferences> https://bugzilla.mozilla.org/show_bug.cgi?id=418133 Attachment 306201: Possible patch https://bugzilla.mozilla.org/attachment.cgi?id=306201&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> >+ // If EvaluateStringWithValue() threw an exception, just report it now. >+ // Failure to ...

superreview granted: [Bug 340019] [FIX]js assertion "!JS_IsExceptionPending(cx)" when checking feeds : [Attachment 224130] fix newsblog js
Seth Spitzer <sspitzer@mozilla.com> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 340019: [FIX]js assertion "!JS_IsExceptionPending(cx)" when checking feeds https://bugzilla.mozilla.org/show_bug.cgi?id=340019 Attachment 224130: fix newsblog js https://bugzilla.mozilla.org/attachment.cgi?id=224130&action=edit ------- Additional Comments from Seth Spitzer <sspitzer@mozilla.com> sr=sspitzer, acting as sr while mscott is away. ...

superreview granted: [Bug 422009] [FIX]"Assertion failure: !cx->throwing" with XBL constructor that throws and syntax error in event handler : [Attachment 310421] Fix
Johnny Stenback (:jst) <jst@mozilla.org> has granted Boris Zbarsky (reviews very slow until May) <bzbarsky@mit.edu>'s request for superreview: Bug 422009: [FIX]"Assertion failure: !cx->throwing" with XBL constructor that throws and syntax error in event handler https://bugzilla.mozilla.org/show_bug.cgi?id=422009 Attachment 310421: Fix https://bugzilla.mozilla.org/attachment.cgi?id=310421&action=edit ...

superreview requested: [Bug 399960] "Assertion failure: !JS_IsExceptionPending(cx)" with |new Option|
Blake Kaplan <mrbkap@gmail.com> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 399960: "Assertion failure: !JS_IsExceptionPending(cx)" with |new Option| https://bugzilla.mozilla.org/show_bug.cgi?id=399960 Attachment 285548: diff -w of the fix https://bugzilla.mozilla.org/attachment.cgi?id=285548&action=edit ------- Additional Comments from Blake Kaplan <mrbkap@gmail.com> We need to ensure that we return an error if converting the object to a string fails. ...

superreview granted: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only)
Brendan Eich <brendan@mozilla.org> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> rs=me, I'm trusting you guys, patch looks ok from the context di...

superreview granted: [Bug 340019] js assertion "!JS_IsExceptionPending(cx)" when checking feeds : [Attachment 224138] Does this fix things?
Brendan Eich <brendan@mozilla.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 340019: js assertion "!JS_IsExceptionPending(cx)" when checking feeds https://bugzilla.mozilla.org/show_bug.cgi?id=340019 Attachment 224138: Does this fix things? https://bugzilla.mozilla.org/attachment.cgi?id=224138&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> Mangle that Reporter name (suggest mozJSLoaderErrorReporter, unless someone has a better idea) now that it's potentially a link-time global....

superreview granted: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 220151] updated fix with review comments
Scott MacGregor <mscott@mozilla.org> has granted superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 220151: updated fix with review comments https://bugzilla.mozilla.org/attachment.cgi?id=220151&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> carrying forward david's sr and neil's r. ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only) #2
Serge GAUTHERIE <gautheri@noos.fr> has asked Seth Spitzer <sspitzer@mozilla.org> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ...

superreview requested: [Bug 422009] [FIX]"Assertion failure: !cx->throwing" with XBL constructor that throws and syntax error in event handler : [Attachment 310421] Fix
Boris Zbarsky (reviews very slow until May) <bzbarsky@mit.edu> has asked Johnny Stenback (:jst) <jst@mozilla.org> for superreview: Bug 422009: [FIX]"Assertion failure: !cx->throwing" with XBL constructor that throws and syntax error in event handler https://bugzilla.mozilla.org/show_bug.cgi?id=422009 Attachment 310421: Fix https://bugzilla.mozilla.org/attachment.cgi?id=310421&action=edit ...

superreview granted: [Bug 349419] "Unexpected load type value" assertion after entering a URL needing fixup : [Attachment 234708] fixes the assertion by introducing a new nsIDocShellLoadInfo type
Boris Zbarsky <bzbarsky@mit.edu> has granted Christian Biesinger (:bi) (CA) (Google) <cbiesinger@gmx.at>'s request for superreview: Bug 349419: "Unexpected load type value" assertion after entering a URL needing fixup https://bugzilla.mozilla.org/show_bug.cgi?id=349419 Attachment 234708: fixes the assertion by introducing a new nsIDocShellLoadInfo type https://bugzilla.mozilla.org/attachment.cgi?id=234708&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Man. We so need to fix this mess. Can we find someone to do it...

superreview granted: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 156855] (Cv2) <nsMsgBodyHandler.cpp>
Dan Mosedale <dmose@mozilla.org> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 156855: (Cv2) <nsMsgBodyHandler.cpp> http://bugzilla.mozilla.org/attachment.cgi?id=156855&action=edit ------- Additional Comments from Dan Mosedale <dmose@mozilla.org> sr=dmose ...

superreview granted: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 137748] (Av1b) <nsMacMain.cpp>
Brian Ryner <bryner@brianryner.com> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 137748: (Av1b) <nsMacMain.cpp> http://bugzilla.mozilla.org/attachment.cgi?id=137748&action=edit ------- Additional Comments from Brian Ryner <bryner@brianryner.com> The explicit |(void)| cast should not be needed. sr=bryner if you remove that. ...

Web resources about - superreview granted: [Bug 407019] "Assertion failure: !JS_IsExceptionPending(cx)" with |new Option|, take 2 : [Attachment 293779 ] Fix - mozilla.dev.super-review

Resources last updated: 12/27/2015 1:48:15 PM