superreview granted: [Bug 396286] [FIX]Crash [@ nsIFrame:: GetPositionIgnoringScrolling] with :: first-line and bindings setting position: fixed

Robert O'Callahan <roc@ocallahan.org> has granted Boris Zbarsky (gone 9/4-9/11
and 9/14-9/17) <bzbarsky@mit.edu>'s request for superreview:
Bug 396286: [FIX]Crash [@ nsIFrame::GetPositionIgnoringScrolling] with
::first-line and bindings setting position: fixed
https://bugzilla.mozilla.org/show_bug.cgi?id=396286

Attachment 281151: Proposed fix
https://bugzilla.mozilla.org/attachment.cgi?id=281151&action=edit

------- Additional Comments from Robert O'Callahan <roc@ocallahan.org>
yeah OK. But add a comment mentioning that some XBL constructors may still be
pending and that we're just ignoring them because that's safer and it's not
worth processing them.
0
bugzilla
9/18/2007 12:15:25 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
436 Views

Similar Articles

[PageSpeed] 42

Reply:

Similar Artilces:

superreview requested: [Bug 396286] Crash [@ nsIFrame:: GetPositionIgnoringScrolling] with :: first-line and bindings setting position: fixed
Boris Zbarsky (gone 9/4-9/11 and 9/14-9/17) <bzbarsky@mit.edu> has asked Ro= bert O'Callahan <roc@ocallahan.org> for superreview: Bug 396286: Crash [@ nsIFrame::GetPositionIgnoringScrolling] with ::first-l= ine and bindings setting position: fixed https://bugzilla.mozilla.org/show_bug.cgi?id=3D396286 Attachment 281151: Proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=3D281151&action=3Dedit ------- Additional Comments from Boris Zbarsky (gone 9/4-9/11 and 9/14-9/17) <bzbarsky@mit.edu> The comments explain what's going on.=0D =0D Martijn,...

superreview granted: [Bug 355993] [FIX]Crash [@ nsIFrame::GetPositionIgnoringScrolling] with MathML table, position: fixed : [Attachment 241733] So this also fixes the problem, as expected
rbs@maths.uq.edu.au has granted superreview: Bug 355993: [FIX]Crash [@ nsIFrame::GetPositionIgnoringScrolling] with MathML table, position: fixed https://bugzilla.mozilla.org/show_bug.cgi?id=355993 Attachment 241733: So this also fixes the problem, as expected https://bugzilla.mozilla.org/attachment.cgi?id=241733&action=edit ------- Additional Comments from rbs@maths.uq.edu.au Let's go for this, as there is no latent apprehension that the positioning might awake and bite us. (Since it is not conceivable to have math without matrices, commutative diagrams and the likes,...

superreview cancelled: [Bug 355993] [FIX]Crash [@ nsIFrame::GetPositionIgnoringScrolling] with MathML table, position: fixed : [Attachment 241723] Fixes the crash for me
Boris Zbarsky <bzbarsky@mit.edu> has cancelled Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 355993: [FIX]Crash [@ nsIFrame::GetPositionIgnoringScrolling] with MathML table, position: fixed https://bugzilla.mozilla.org/show_bug.cgi?id=355993 Attachment 241723: Fixes the crash for me https://bugzilla.mozilla.org/attachment.cgi?id=241723&action=edit ...

superreview granted: [Bug 355993] [FIX]Crash [@ nsIFrame::GetPositionIgnoringScrolling] with MathML table, position: fixed : [Attachment 241787] Lightly tweaked
rbs@maths.uq.edu.au has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 355993: [FIX]Crash [@ nsIFrame::GetPositionIgnoringScrolling] with MathML table, position: fixed https://bugzilla.mozilla.org/show_bug.cgi?id=355993 Attachment 241787: Lightly tweaked https://bugzilla.mozilla.org/attachment.cgi?id=241787&action=edit ------- Additional Comments from rbs@maths.uq.edu.au sr=rbs ...

superreview requested: [Bug 355993] Crash [@ nsIFrame::GetPositionIgnoringScrolling] with MathML table, position: fixed : [Attachment 241723] Fixes the crash for me
Boris Zbarsky <bzbarsky@mit.edu> has asked rbs@maths.uq.edu.au for superreview: Bug 355993: Crash [@ nsIFrame::GetPositionIgnoringScrolling] with MathML table, position: fixed https://bugzilla.mozilla.org/show_bug.cgi?id=355993 Attachment 241723: Fixes the crash for me https://bugzilla.mozilla.org/attachment.cgi?id=241723&action=edit ...

superreview requested: [Bug 355993] [FIX]Crash [@ nsIFrame::GetPositionIgnoringScrolling] with MathML table, position: fixed : [Attachment 241787] Lightly tweaked
Boris Zbarsky <bzbarsky@mit.edu> has asked rbs@maths.uq.edu.au for superreview: Bug 355993: [FIX]Crash [@ nsIFrame::GetPositionIgnoringScrolling] with MathML table, position: fixed https://bugzilla.mozilla.org/show_bug.cgi?id=355993 Attachment 241787: Lightly tweaked https://bugzilla.mozilla.org/attachment.cgi?id=241787&action=edit ...

superreview granted: [Bug 363729] Crash [@ nsIFrame:: GetPositionIgnoringScrolling] on print preview that uses position: fixed
David Baron [:dbaron] <dbaron@mozilla.com> has granted Robert O'Callahan (:roc) <roc@ocallahan.org>'s request for superreview: Bug 363729: Crash [@ nsIFrame::GetPositionIgnoringScrolling] on print preview that uses position: fixed https://bugzilla.mozilla.org/show_bug.cgi?id=363729 Attachment 286941: fix https://bugzilla.mozilla.org/attachment.cgi?id=286941&action=edit ------- Additional Comments from David Baron [:dbaron] <dbaron@mozilla.com> Seems like you shuold just pass null for the absolute containing block two lines above rather than pushing it...

superreview granted: [Bug 431520] [FIX]legend positioning is incorrect when a :first-line rule matches containing fieldset : [Attachment 331364] Fix
David Baron [:dbaron] <dbaron@mozilla.com> has granted Boris Zbarsky (todo: 250+ items) <bzbarsky@mit.edu>'s request for superreview: Bug 431520: [FIX]legend positioning is incorrect when a :first-line rule matches containing fieldset https://bugzilla.mozilla.org/show_bug.cgi?id=431520 Attachment 331364: Fix https://bugzilla.mozilla.org/attachment.cgi?id=331364&action=edit ------- Additional Comments from David Baron [:dbaron] <dbaron@mozilla.com> It seems odd to me that the patch would look like this. We're only supposed to support :first-line and :...

superreview requested: [Bug 322348] Crash [@ nsFrameList::DestroyFrames] with evil testcase using position:fixed/absolute; and ::first-line : [Attachment 207659] Yep, this fixes all the asserts and t
Boris Zbarsky <bzbarsky@mit.edu> has asked David Baron <dbaron@mozilla.com> for superreview: Bug 322348: Crash [@ nsFrameList::DestroyFrames] with evil testcase using position:fixed/absolute; and ::first-line https://bugzilla.mozilla.org/show_bug.cgi?id=322348 Attachment 207659: Yep, this fixes all the asserts and the crash https://bugzilla.mozilla.org/attachment.cgi?id=207659&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> I think it's worth taking this on branches and working on something better on trunk.... ...

superreview granted: [Bug 353897] [FIX]Crash [@ nsMathMLContainerFrame::FixInterFrameSpacing] using position:fixed when position: static rule in mathml.css is removed : [Attachment 239922] Disable flo
rbs@maths.uq.edu.au has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 353897: [FIX]Crash [@ nsMathMLContainerFrame::FixInterFrameSpacing] using position:fixed when position: static rule in mathml.css is removed https://bugzilla.mozilla.org/show_bug.cgi?id=353897 Attachment 239922: Disable floating and positioning of MathML frames. https://bugzilla.mozilla.org/attachment.cgi?id=239922&action=edit ------- Additional Comments from rbs@maths.uq.edu.au I wouldn't care if <math> didn't float too, but it doesn't cost us much to hav...

superreview granted: [Bug 353894] [FIX]Crash [@ nsBlockBandData::Init] with position:fixed on mathml when position:static !important rule is removed in mathml.css : [Attachment 239919] Not sure why th
rbs@maths.uq.edu.au has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 353894: [FIX]Crash [@ nsBlockBandData::Init] with position:fixed on mathml when position:static !important rule is removed in mathml.css https://bugzilla.mozilla.org/show_bug.cgi?id=353894 Attachment 239919: Not sure why this wasn't done to start with https://bugzilla.mozilla.org/attachment.cgi?id=239919&action=edit ------- Additional Comments from rbs@maths.uq.edu.au r+sr=rbs > We'll create an nsMathMLTokenFrame for it I remembered that after posting my co...

superreview granted: [Bug 268111] [FIX]position: fixed elements are positioned relative to the page rather than the viewport : [Attachment 170755] Fix
David Baron <dbaron@mozilla.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 268111: [FIX]position: fixed elements are positioned relative to the page rather than the viewport https://bugzilla.mozilla.org/show_bug.cgi?id=268111 Attachment 170755: Fix https://bugzilla.mozilla.org/attachment.cgi?id=170755&action=edit ------- Additional Comments from David Baron <dbaron@mozilla.org> r+sr=dbaron (assuming you're restoring old code, didn't really look) ...

superreview granted: [Bug 265371] Crash when ISINDEX is used with position: fixed [@ nsBlockBandData::Init] : [Attachment 163024] Fix
Robert O'Callahan <roc@ocallahan.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 265371: Crash when ISINDEX is used with position: fixed [@ nsBlockBandData::Init] https://bugzilla.mozilla.org/show_bug.cgi?id=265371 Attachment 163024: Fix https://bugzilla.mozilla.org/attachment.cgi?id=163024&action=edit ...

superreview granted: [Bug 285996] Crash [@ nsViewManager::UpdateWidgetArea] when leaving page which uses position:fixed on applet : [Attachment 179145] fix
David Baron <dbaron@mozilla.org> has granted Robert O'Callahan (Novell) <roc@ocallahan.org>'s request for superreview: Bug 285996: Crash [@ nsViewManager::UpdateWidgetArea] when leaving page which uses position:fixed on applet https://bugzilla.mozilla.org/show_bug.cgi?id=285996 Attachment 179145: fix https://bugzilla.mozilla.org/attachment.cgi?id=179145&action=edit ...

Web resources about - superreview granted: [Bug 396286] [FIX]Crash [@ nsIFrame:: GetPositionIgnoringScrolling] with :: first-line and bindings setting position: fixed - mozilla.dev.super-review

Resources last updated: 1/8/2016 8:12:40 PM