superreview granted: [Bug 392746] Multiple selection can go wrong when selecting something before an existing selection : [Attachment 311145] patch

Robert O'Callahan (:roc) (reduced activity March 18 to April 9)
<roc@ocallahan.org> has granted  superreview:
Bug 392746: Multiple selection can go wrong when selecting something before an
existing selection
https://bugzilla.mozilla.org/show_bug.cgi?id=392746

Attachment 311145: patch
https://bugzilla.mozilla.org/attachment.cgi?id=311145&action=edit

------- Additional Comments from Robert O'Callahan (:roc) (reduced activity
March 18 to April 9) <roc@ocallahan.org>
looks good
0
bugzilla
3/24/2008 7:26:14 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
512 Views

Similar Articles

[PageSpeed] 31

Reply:

Similar Artilces:

superreview granted: [Bug 297172] [FIX]Select box bug when dynamicly enabling and disabling multiple selects. : [Attachment 197270] Proposed patch
Peter Van der Beken <peterv@propagandism.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 297172: [FIX]Select box bug when dynamicly enabling and disabling multiple selects. https://bugzilla.mozilla.org/show_bug.cgi?id=297172 Attachment 197270: Proposed patch https://bugzilla.mozilla.org/attachment.cgi?id=197270&action=edit ------- Additional Comments from Peter Van der Beken <peterv@propagandism.org> >Index: content/html/content/src/nsHTMLSelectElement.cpp >============================================================...

superreview granted: [Bug 301737] Support multiple selection for xul:listbox : [Attachment 190379] The last patch didn't reduce the selection when you went shift+down then shift+up, or vice-versa. Th
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 301737: Support multiple selection for xul:listbox https://bugzilla.mozilla.org/show_bug.cgi?id=301737 Attachment 190379: The last patch didn't reduce the selection when you went shift+down then shift+up, or vice-versa. This patch also fixes the firing of accessible selection_* events https://bugzilla.mozilla.org/attachment.cgi?id=190379&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.pa...

superreview granted: [Bug 395808] Importing from Eudora: When Eudora AB can't be found, manual selection method fails : [Attachment 305101] Trunk patch that allows directory to be selected during impo
Scott MacGregor <mscott@mozilla.org> has granted Geoffrey C. Wenger <gwenger@qualcomm.com>'s request for superreview: Bug 395808: Importing from Eudora: When Eudora AB can't be found, manual selection method fails https://bugzilla.mozilla.org/show_bug.cgi?id=395808 Attachment 305101: Trunk patch that allows directory to be selected during import as address book location without subsequent code rejecting it. https://bugzilla.mozilla.org/attachment.cgi?id=305101&action=edit ...

superreview granted: [Bug 185098] Font style ignored if <option selected="selected"> in a <select> that contains an optgroup : [Attachment 154999] Patch rev. 1
Boris Zbarsky <bzbarsky@mit.edu> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 185098: Font style ignored if <option selected="selected"> in a <select> that contains an optgroup http://bugzilla.mozilla.org/show_bug.cgi?id=185098 Attachment 154999: Patch rev. 1 http://bugzilla.mozilla.org/attachment.cgi?id=154999&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Yeah, this is reasonable. r+sr=bzbarsky. For future reference, using more context and the -p option makes the diff...

superreview granted: [Bug 112281] ctrl+shift+click whle making range selections in form <select> shouldn't wipe out other selected items : [Attachment 135533] Proposed patch
Robert O'Callahan <roc@ocallahan.org> has granted Boris Zbarsky (real world intrudes) <bz-vacation@mit.edu>'s request for superreview: Bug 112281: ctrl+shift+click whle making range selections in form <select> shouldn't wipe out other selected items http://bugzilla.mozilla.org/show_bug.cgi?id=112281 Attachment 135533: Proposed patch http://bugzilla.mozilla.org/attachment.cgi?id=135533&action=edit ------- Additional Comments from Robert O'Callahan <roc@ocallahan.org> looks quite straighforward :-) ...

superreview requested: [Bug 297172] Select box bug when dynamicly enabling and disabling multiple selects. : [Attachment 197270] Proposed patch
Boris Zbarsky <bzbarsky@mit.edu> has asked Peter Van der Beken <peterv@propagandism.org> for superreview: Bug 297172: Select box bug when dynamicly enabling and disabling multiple selects. https://bugzilla.mozilla.org/show_bug.cgi?id=297172 Attachment 197270: Proposed patch https://bugzilla.mozilla.org/attachment.cgi?id=197270&action=edit ...

superreview granted: [Bug 451252] "Highlight All" find selection not visible in elements that have -moz-user-select: none set : [Attachment 335566] Patch v2
Graeme McCutcheon <graememcc_firefox@graeme-online.co.uk> has granted superreview: Bug 451252: "Highlight All" find selection not visible in elements that have -moz-user-select: none set https://bugzilla.mozilla.org/show_bug.cgi?id=451252 Attachment 335566: Patch v2 - now with less cross-bug pollution https://bugzilla.mozilla.org/attachment.cgi?id=335566&action=edit ------- Additional Comments from Graeme McCutcheon <graememcc_firefox@graeme-online.co.uk> > The toolkit changes don't seem to be part of this patch And that's why you shouldn'...

superreview granted: [Bug 345707] "Print Selection" cuts off top of selection : [Attachment 245189] Patch
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted superreview: Bug 345707: "Print Selection" cuts off top of selection https://bugzilla.mozilla.org/show_bug.cgi?id=345707 Attachment 245189: Patch https://bugzilla.mozilla.org/attachment.cgi?id=245189&action=edit ...

superreview granted: [Bug 88593] Ctrl+select on thread button only selects top message : [Attachment 148423] Proposed patch
David Bienvenu <bienvenu@nventure.com> has granted neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview: Bug 88593: Ctrl+select on thread button only selects top message http://bugzilla.mozilla.org/show_bug.cgi?id=88593 Attachment 148423: Proposed patch http://bugzilla.mozilla.org/attachment.cgi?id=148423&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> cool, I've always wanted this. ...

superreview granted: [Bug 278207] select only writes one of multiple selected values to instance data : [Attachment 173032] fix with suggestions
Brian Ryner (IBM) <bryner@brianryner.com> has granted aaronr@us.ibm.com's request for superreview: Bug 278207: select only writes one of multiple selected values to instance data https://bugzilla.mozilla.org/show_bug.cgi?id=278207 Attachment 173032: fix with suggestions https://bugzilla.mozilla.org/attachment.cgi?id=173032&action=edit ...

superreview granted: [Bug 430748] Print-selection places text too low, with initial whitespace and select-all : [Attachment 318278] patch v3
Robert O'Callahan (:roc) <roc@ocallahan.org> has granted Daniel Holbert [:dholbert] <dholbert@mozilla.com>'s request for superreview: Bug 430748: Print-selection places text too low, with initial whitespace and select-all https://bugzilla.mozilla.org/show_bug.cgi?id=3D430748 Attachment 318278: patch v3 https://bugzilla.mozilla.org/attachment.cgi?id=3D318278&action=3Dedit ------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.or= g> + startRect.height =3D PR_MAX(0, startRect.height + startRect.y);=0D =0D Use startRect.YMost...

superreview granted: [Bug 267627] select event isn't fired when selection of listbox is changed : [Attachment 166293] patch
Brian Ryner (IBM) <bryner@brianryner.com> has granted Robert O'Callahan <roc@ocallahan.org>'s request for superreview: Bug 267627: select event isn't fired when selection of listbox is changed https://bugzilla.mozilla.org/show_bug.cgi?id=267627 Attachment 166293: patch https://bugzilla.mozilla.org/attachment.cgi?id=166293&action=edit ...

superreview granted: [Bug 210197] Mouse selection get stuck after selecting table elements (CTRL+click) : [Attachment 329224] patch v1
Mats Palmgren <mats.palmgren@bredband.net> has granted Uri Bernstein (Google) <uriber@gmail.com>'s request for superreview: Bug 210197: Mouse selection get stuck after selecting table elements (CTRL+click) https://bugzilla.mozilla.org/show_bug.cgi?id=210197 Attachment 329224: patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=329224&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> Looks good. r+sr=mats ...

superreview granted: [Bug 425225] Selecting an item from a <select> while page is loading can cause crash : [Attachment 311839] fix
Mike Pinkerton (not reading bugmail) <mikepinkerton@mac.com> has granted Stuart Morgan <stuart.morgan@alumni.case.edu>'s request for superreview: Bug 425225: Selecting an item from a <select> while page is loading can cause crash https://bugzilla.mozilla.org/show_bug.cgi?id=425225 Attachment 311839: fix https://bugzilla.mozilla.org/attachment.cgi?id=311839&action=edit ------- Additional Comments from Mike Pinkerton (not reading bugmail) <mikepinkerton@mac.com> sr=pink ...

Web resources about - superreview granted: [Bug 392746] Multiple selection can go wrong when selecting something before an existing selection : [Attachment 311145] patch - mozilla.dev.super-review

Resources last updated: 12/16/2015 12:37:35 PM