superreview requested: [Bug 383259] Thunderbird' s current trunk version is less than DOMi's minVersion for it
Phil Ringnalda <philringnalda@gmail.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 383259: Thunderbird's current trunk version is less than DOMi's minVersion for it https://bugzilla.mozilla.org/show_bug.cgi?id=383259 Attachment 267244: Fix v.1 https://bugzilla.mozilla.org/attachment.cgi?id=267244&action=edit ...

superreview granted: [Bug 157566] Enhance MailNews to work with WinZip's "Zip and e-mail" shell extension : [Attachment 147290] trunk version of the fix with david's review comment
Scott MacGregor <mscott@mozilla.org> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 157566: Enhance MailNews to work with WinZip's "Zip and e-mail" shell extension http://bugzilla.mozilla.org/show_bug.cgi?id=157566 Attachment 147290: trunk version of the fix with david's review comment http://bugzilla.mozilla.org/attachment.cgi?id=147290&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> carrying over david's sr ...

superreview granted: [Bug 280713] ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly : [Attachment 173997] updated to review comments
Boris Zbarsky <bzbarsky@mit.edu> has granted Blake Kaplan <mrbkap@gmail.com>'s request for superreview: Bug 280713: ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly https://bugzilla.mozilla.org/show_bug.cgi?id=280713 Attachment 173997: updated to review comments https://bugzilla.mozilla.org/attachment.cgi?id=173997&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> sr=bzbarsky. Land this either _really_ early in 1.8b2 or in 1.9a.... ...

superreview granted: [Bug 280713] ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly : [Attachment 173127] patch v1
Boris Zbarsky <bzbarsky@mit.edu> has granted Blake Kaplan <mrbkap@gmail.com>'s request for superreview: Bug 280713: ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly https://bugzilla.mozilla.org/show_bug.cgi?id=280713 Attachment 173127: patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=173127&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> sr=bzbarsky, but it sounds like some cleanup of incremental vs final chunk is in order.... ...

superreview requested: [Bug 280713] ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly : [Attachment 173997] updated to review comments
Blake Kaplan <mrbkap@gmail.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 280713: ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly https://bugzilla.mozilla.org/show_bug.cgi?id=280713 Attachment 173997: updated to review comments https://bugzilla.mozilla.org/attachment.cgi?id=173997&action=edit ...

superreview granted: [Bug 189307] typeahead initializes sound when it's uninitialized instead of if it's unitialized and there's a sound to play : [Attachment 135251] right
Robert O'Callahan <roc@ocallahan.org> has granted timeless@myrealbox.com <timeless@bemail.org>'s request for superreview: Bug 189307: typeahead initializes sound when it's uninitialized instead of if it's unitialized and there's a sound to play http://bugzilla.mozilla.org/show_bug.cgi?id=189307 Attachment 135251: right http://bugzilla.mozilla.org/attachment.cgi?id=135251&action=edit ...

superreview granted: [Bug 408749] "ASSERTION: A block's child' s next in flow's parent must be a block" with -moz-column, table stuff : [ Attachment 293607] fix assert
Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> has granted Robert O'Callahan (:roc) <roc@ocallahan.org>'s request for superreview: Bug 408749: "ASSERTION: A block's child's next in flow's parent must be a block" with -moz-column, table stuff https://bugzilla.mozilla.org/show_bug.cgi?id=408749 Attachment 293607: fix assert https://bugzilla.mozilla.org/attachment.cgi?id=293607&action=edit ------- Additional Comments from Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> Looks good. That said, s...

superreview granted: [Bug 408749] "ASSERTION: A block's child' s next in flow's parent must be a block" with -moz-column, table stuff : [ Attachment 293637] reflow captions with unconstrained height
Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> has granted Robert O'Callahan (:roc) <roc@ocallahan.org>'s request for superreview: Bug 408749: "ASSERTION: A block's child's next in flow's parent must be a block" with -moz-column, table stuff https://bugzilla.mozilla.org/show_bug.cgi?id=408749 Attachment 293637: reflow captions with unconstrained height https://bugzilla.mozilla.org/attachment.cgi?id=293637&action=edit ...

superreview granted: [Bug 220215] use the xpcnativewrapper for the current callers of components.lookupmethod : [Attachment 135169] Actually it's document.location that's safe, window is totally uns
Boris Zbarsky (real world intrudes) <bz-vacation@mit.edu> has granted neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview: Bug 220215: use the xpcnativewrapper for the current callers of components.lookupmethod http://bugzilla.mozilla.org/show_bug.cgi?id=220215 Attachment 135169: Actually it's document.location that's safe, window is totally unsafe http://bugzilla.mozilla.org/attachment.cgi?id=135169&action=edit ------- Additional Comments from Boris Zbarsky (real world intrudes) <bz-vacation@mit.edu> sr=bzbarsky...

superreview granted: [Bug 287943] Rebrand bootstrap's Windows bits including nsNativeAppSupportWin.cpp : [Attachment 180579] patch v4: address biesi's review nits
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Robert Kaiser <kairo@kairo.at>'s request for superreview: Bug 287943: Rebrand bootstrap's Windows bits including nsNativeAppSupportWin.cpp https://bugzilla.mozilla.org/show_bug.cgi?id=287943 Attachment 180579: patch v4: address biesi's review nits https://bugzilla.mozilla.org/attachment.cgi?id=180579&action=edit ...

superreview granted: [Bug 408792] Eliminate more QI' s from performance hotspots. : [Attachment 293639] Eliminate QI's that aren 't needed.
Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> has granted Johnny Stenback (:jst) <jst@mozilla.org>'s request for superreview: Bug 408792: Eliminate more QI's from performance hotspots. https://bugzilla.mozilla.org/show_bug.cgi?id=408792 Attachment 293639: Eliminate QI's that aren't needed. https://bugzilla.mozilla.org/attachment.cgi?id=293639&action=edit ------- Additional Comments from Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> sr=bzbarsky, with the comments expanded out. And please file a followup...

superreview granted: [Bug 303521] !!! Object's nsIClassInfo lies about it's interfaces!!! s.b. "its" : [Attachment 191706] fix spelling
Johnny Stenback <jst@mozilla.org> has granted timeless@myrealbox.com (working) <timeless@bemail.org>'s request for superreview: Bug 303521: !!! Object's nsIClassInfo lies about it's interfaces!!! s.b. "its" https://bugzilla.mozilla.org/show_bug.cgi?id=303521 Attachment 191706: fix spelling https://bugzilla.mozilla.org/attachment.cgi?id=191706&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> r+sr=jst either way... ...

superreview requested: [Bug 280713] ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly : [Attachment 173127] patch v1
Blake Kaplan <mrbkap@gmail.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 280713: ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly https://bugzilla.mozilla.org/show_bug.cgi?id=280713 Attachment 173127: patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=173127&action=edit ...

superreview granted: [Bug 378544] General's Default Feed Viewer's " =?UTF-8?Q?Select=E2=80=A6?=" doesn't use real elipsis
Mike Pinkerton <mikepinkerton@mac.com> has granted Stuart Morgan <stuart.morgan@alumni.case.edu>'s request for superreview: Bug 378544: General's Default Feed Viewer's "Select=E2=80=A6" doesn't use r= eal elipsis https://bugzilla.mozilla.org/show_bug.cgi?id=3D378544 Attachment 264750: changed https://bugzilla.mozilla.org/attachment.cgi?id=3D264750&action=3Dedit ------- Additional Comments from Mike Pinkerton <mikepinkerton@mac.com> rs=3Dpink= ...