superreview granted: [Bug 363706] Support CSS3 'ch' unit for border and outline : [Attachment 323795] Re-revised patch to expose width of '0'

David Baron [:dbaron] <dbaron@mozilla.com> has granted Zack Weinberg
<zweinberg@mozilla.com>'s request for superreview:
Bug 363706: Support CSS3 'ch' unit for border and outline
https://bugzilla.mozilla.org/show_bug.cgi?id=3D363706

Attachment 323795: Re-revised patch to expose width of '0'
https://bugzilla.mozilla.org/attachment.cgi?id=3D323795&action=3Dedit

------- Additional Comments from David Baron [:dbaron] <dbaron@mozilla.com>
>+	nsCOMPtr<nsIThebesFontMetrics> tfm(do_QueryInterface(fm));=0D
=0D
this looks fine=0D
=0D
>+	gfxFloat zeroWidth =3D
tfm->GetThebesFontGroup()->GetFontAt(0)->GetMetrics().zeroOrAveCharWidth;=
=0D
=0D
but I'd wrap this at less than 80 characters.=0D
=0D
sr=3Ddbaron with roc's comments addressed.=0D
=0D
Hopefully I'll be able to land this for you later today...=
0
bugzilla
6/16/2008 7:09:45 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
455 Views

Similar Articles

[PageSpeed] 30

Reply: