superreview granted: [Bug 363573] Table cells don't expand to contain <pre cols> ('ch' unit is broken) : [Attachment 248557] Patch rev. 2

David Baron <dbaron@mozilla.com> has granted  superreview:
Bug 363573: Table cells don't expand to contain <pre cols> ('ch' unit is
broken)
https://bugzilla.mozilla.org/show_bug.cgi?id=363573

Attachment 248557: Patch rev. 2
https://bugzilla.mozilla.org/attachment.cgi?id=248557&action=edit

------- Additional Comments from David Baron <dbaron@mozilla.com>
r+sr=dbaron.

Let's do the renaming in a separate patch after this one lands.  (You can if
you want, or I can...)
0
bugzilla
12/14/2006 7:26:47 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
422 Views

Similar Articles

[PageSpeed] 55

Reply:

Similar Artilces:

superreview requested: [Bug 363573] Table cells don't expand to contain <pre cols> ('ch' unit is broken) : [Attachment 248557] Patch rev. 2
Mats Palmgren <mats.palmgren@bredband.net> has asked David Baron <dbaron@mozilla.com> for superreview: Bug 363573: Table cells don't expand to contain <pre cols> ('ch' unit is broken) https://bugzilla.mozilla.org/show_bug.cgi?id=363573 Attachment 248557: Patch rev. 2 https://bugzilla.mozilla.org/attachment.cgi?id=248557&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> Ok, I made both ComputeHorizontalValue and ComputeVerticalValue use GetAbsoluteCoord, the latter made 'ch' work for 'height&#...

superreview requested: [Bug 363573] Table cells don't expand to contain <pre cols> ('ch' unit is broken) : [Attachment 248510] Patch rev. 1
Mats Palmgren <mats.palmgren@bredband.net> has asked David Baron <dbaron@mozilla.com> for superreview: Bug 363573: Table cells don't expand to contain <pre cols> ('ch' unit is broken) https://bugzilla.mozilla.org/show_bug.cgi?id=363573 Attachment 248510: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=248510&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> The 'cols' attribute is mapped to a 'ch' unit width. This patch implements the 'ch' unit generally for 'wid...

superreview cancelled: [Bug 363573] Table cells don't expand to contain <pre cols> ('ch' unit is broken) : [Attachment 248510] Patch rev. 1
Mats Palmgren <mats.palmgren@bredband.net> has cancelled superreview: Bug 363573: Table cells don't expand to contain <pre cols> ('ch' unit is broken) https://bugzilla.mozilla.org/show_bug.cgi?id=363573 Attachment 248510: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=248510&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> Ok, I made both ComputeHorizontalValue and ComputeVerticalValue use GetAbsoluteCoord, the latter made 'ch' work for 'height', 'min-height' and 'max...

superreview granted: [Bug 271955] "empty" table cells don't include borders in size even when 'empty-cells: show' : [Attachment 167169] patch
Robert O'Callahan <roc@ocallahan.org> has granted David Baron <dbaron@mozilla.org>'s request for superreview: Bug 271955: "empty" table cells don't include borders in size even when 'empty-cells: show' https://bugzilla.mozilla.org/show_bug.cgi?id=271955 Attachment 167169: patch https://bugzilla.mozilla.org/attachment.cgi?id=167169&action=edit ...

superreview granted: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only)
Brendan Eich <brendan@mozilla.org> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> rs=me, I'm trusting you guys, patch looks ok from the context di...

superreview requested: [Bug 271955] "empty" table cells don't include borders in size even when 'empty-cells: show' : [Attachment 167169] patch
David Baron <dbaron@mozilla.org> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 271955: "empty" table cells don't include borders in size even when 'empty-cells: show' https://bugzilla.mozilla.org/show_bug.cgi?id=271955 Attachment 167169: patch https://bugzilla.mozilla.org/attachment.cgi?id=167169&action=edit ...

superreview granted: [Bug 289667] drag 'n drop of < map > links found in an < img > is broken : [Attachment 187458] Patch rev. 2
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 289667: drag 'n drop of < map > links found in an < img > is broken https://bugzilla.mozilla.org/show_bug.cgi?id=289667 Attachment 187458: Patch rev. 2 https://bugzilla.mozilla.org/attachment.cgi?id=187458&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> looks good. The GetFrameFromNode cleanup sounds good too. ...

superreview granted: [Bug 300474] [FIX] <SELECT> with the MULTIPLE attribute and <OPTGROUP> item don't display properly : [Attachment 189490] Patch rev. 1
Boris Zbarsky <bzbarsky@mit.edu> has granted Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 300474: [FIX] <SELECT> with the MULTIPLE attribute and <OPTGROUP> item don't display properly https://bugzilla.mozilla.org/show_bug.cgi?id=300474 Attachment 189490: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=189490&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> >Index: layout/forms/nsListControlFrame.cpp >+ nsIPresShell* shell = aPresContext->GetPresShell(); I thi...

superreview granted: [Bug 296102] Venkman fails to start in Deer Park Alpha 1 after 5/27/2005 : [Attachment 187861] If we can't load a <xul:script>, don't barf, rev. 1
Johnny Stenback <jst@mozilla.org> has granted Benjamin Smedberg [:bs] (formerly bsmedberg@covad.net) <benjamin@smedbergs.us>'s request for superreview: Bug 296102: Venkman fails to start in Deer Park Alpha 1 after 5/27/2005 https://bugzilla.mozilla.org/show_bug.cgi?id=296102 Attachment 187861: If we can't load a <xul:script>, don't barf, rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=187861&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> r+sr=jst ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only) #2
Serge GAUTHERIE <gautheri@noos.fr> has asked Seth Spitzer <sspitzer@mozilla.org> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ...

superreview granted: [Bug 228448] Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' : [Attachment 137796] (Av2) <nsInternetSearchService.cpp>
Alec Flett <alecf@flett.org> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 228448: Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' http://bugzilla.mozilla.org/show_bug.cgi?id=228448 Attachment 137796: (Av2) <nsInternetSearchService.cpp> http://bugzilla.mozilla.org/attachment.cgi?id=137796&action=edit ------- Additional Comments from Alec Flett <alecf@flett.org> sr=alecf then. ...

superreview granted: [Bug 430650] '^' and '=?UTF-8?Q?=C2=A8?=' chars don't work in password fields : [Attachment 317954] Patch v1.0
Robert O'Callahan (:roc) <roc@ocallahan.org> has granted Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview: Bug 430650: '^' and '=C2=A8' chars don't work in password fields https://bugzilla.mozilla.org/show_bug.cgi?id=3D430650 Attachment 317954: Patch v1.0 https://bugzilla.mozilla.org/attachment.cgi?id=3D317954&action=3Dedit ------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.or= g> + if (aState =3D=3D mIMEData->mEnabled) {=0D mIMEData->mEnabled =3D aState;=0D =0D...

superreview granted: [Bug 430650] '^' and '=?UTF-8?Q?=C2=A8?=' chars don't work in password fields : [Attachment 318391] Patch v1.1
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has granted=20 superreview: Bug 430650: '^' and '=C2=A8' chars don't work in password fields https://bugzilla.mozilla.org/show_bug.cgi?id=3D430650 Attachment 318391: Patch v1.1 https://bugzilla.mozilla.org/attachment.cgi?id=3D318391&action=3Dedit ------- Additional Comments from Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> Thank you, Roc and Katakai-san.= ...

superreview requested: [Bug 426776] If a folder contains a 'broken' symbolic link, you can't navigate to it in Firefox using the file:/// URL. : [Attachment 313548] Patch rev. 1
Mats Palmgren <mats.palmgren@bredband.net> has asked Christian :Biesinger <cbiesinger@gmail.com> for superreview: Bug 426776: If a folder contains a 'broken' symbolic link, you can't navigate to it in Firefox using the file:/// URL. https://bugzilla.mozilla.org/show_bug.cgi?id=426776 Attachment 313548: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=313548&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> netwerk/base/src/nsDirectoryIndexStream.cpp: On MacOSX, IsFile() and IsDirectory() returns N...

Web resources about - superreview granted: [Bug 363573] Table cells don't expand to contain <pre cols> ('ch' unit is broken) : [Attachment 248557] Patch rev. 2 - mozilla.dev.super-review

Resources last updated: 1/18/2016 2:30:58 PM