superreview granted: [Bug 363235] [FIX]Regression with display of image placeholders when an invalid protocol is used : [Attachment 249072] Fix

Jonas Sicking <bugmail@sicking.cc> has granted Boris Zbarsky (gone Dec 8 -- Jan
2) <bzbarsky@mit.edu>'s request for superreview:
Bug 363235: [FIX]Regression with display of image placeholders when an invalid
protocol is used
https://bugzilla.mozilla.org/show_bug.cgi?id=363235

Attachment 249072: Fix
https://bugzilla.mozilla.org/attachment.cgi?id=249072&action=edit

------- Additional Comments from Jonas Sicking <bugmail@sicking.cc>
Thanks man
0
bugzilla
12/19/2006 9:39:14 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
396 Views

Similar Articles

[PageSpeed] 26

Reply:

Similar Artilces:

superreview requested: [Bug 363235] Regression with display of image placeholders when an invalid protocol is used : [Attachment 249072] Fix
Boris Zbarsky (gone Dec 8 -- Jan 2) <bzbarsky@mit.edu> has asked Jonas Sicking <bugmail@sicking.cc> for superreview: Bug 363235: Regression with display of image placeholders when an invalid protocol is used https://bugzilla.mozilla.org/show_bug.cgi?id=363235 Attachment 249072: Fix https://bugzilla.mozilla.org/attachment.cgi?id=249072&action=edit ...

superreview granted: [Bug 334341] [FIX]Using image tags with a non image file, and selected view image, file will still load up, allowing access to system resources : [Attachment 219194] Possible fix
Daniel Veditz <dveditz@cruzio.com> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 334341: [FIX]Using image tags with a non image file, and selected view image, file will still load up, allowing access to system resources https://bugzilla.mozilla.org/show_bug.cgi?id=334341 Attachment 219194: Possible fix https://bugzilla.mozilla.org/attachment.cgi?id=219194&action=edit ------- Additional Comments from Daniel Veditz <dveditz@cruzio.com> This is pretty ugly having to test all the different fixups. sr=dveditz, OK for the 1.8 bra...

superreview granted: [Bug 335333] [FIX]Relative, remote images which have a Content-Base fail to display. : [Attachment 219713] Fix
Johnny Stenback <jst@mozilla.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 335333: [FIX]Relative, remote images which have a Content-Base fail to display. https://bugzilla.mozilla.org/show_bug.cgi?id=335333 Attachment 219713: Fix https://bugzilla.mozilla.org/attachment.cgi?id=219713&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> Yeah, duh. r+sr=jst ...

superreview granted: [Bug 285981] [FIX]No alt text displayed with broken (security-blocked) image : [Attachment 178630] Proposed fix
Johnny Stenback <jst@mozilla.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 285981: [FIX]No alt text displayed with broken (security-blocked) image https://bugzilla.mozilla.org/show_bug.cgi?id=285981 Attachment 178630: Proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=178630&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> sr=jst ...

superreview granted: [Bug 303812] [FIX]ASSERTION: Not a URL value! when using invalid url for cursor value : [Attachment 203624] Fix
David Baron <dbaron@mozilla.com> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 303812: [FIX]ASSERTION: Not a URL value! when using invalid url for cursor value https://bugzilla.mozilla.org/show_bug.cgi?id=303812 Attachment 203624: Fix https://bugzilla.mozilla.org/attachment.cgi?id=203624&action=edit ------- Additional Comments from David Baron <dbaron@mozilla.com> OK, r+sr=dbaron if you add the comment "don't try to restart loads we've already started". ...

superreview granted: [Bug 281666] Fixes unchecked use of strcpy/strcat + memory holes in nsDirPrefs.cpp : [Attachment 207112] regression fix
David Bienvenu <bienvenu@nventure.com> has granted Mark Banner <bugzilla@standard8.demon.co.uk>'s request for superreview: Bug 281666: Fixes unchecked use of strcpy/strcat + memory holes in nsDirPrefs.cpp https://bugzilla.mozilla.org/show_bug.cgi?id=281666 Attachment 207112: regression fix https://bugzilla.mozilla.org/attachment.cgi?id=207112&action=edit ...

superreview granted: [Bug 424698] [FIX]textbox.setAttribute("value", ...) fails if the textbox has been hidden in the past using display:none : [Attachment 329740] Fix
Jonas Sicking (:sicking) <jonas@sicking.cc> has granted Boris Zbarsky (have a 300+-long to-do list to work through) <bzbarsky@mit.edu>'s request for superreview: Bug 424698: [FIX]textbox.setAttribute("value", ...) fails if the textbox has been hidden in the past using display:none https://bugzilla.mozilla.org/show_bug.cgi?id=424698 Attachment 329740: Fix https://bugzilla.mozilla.org/attachment.cgi?id=329740&action=edit ...

superreview granted: [Bug 408782] [FIX]Inconsistent display of <input type= "image"> when "alt" attribute is removed : [Attachment 293629] Simple fix
David Baron [:dbaron] <dbaron@mozilla.com> has granted Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu>'s request for superreview: Bug 408782: [FIX]Inconsistent display of <input type="image"> when "alt" attribute is removed https://bugzilla.mozilla.org/show_bug.cgi?id=408782 Attachment 293629: Simple fix https://bugzilla.mozilla.org/attachment.cgi?id=293629&action=edit ------- Additional Comments from David Baron [:dbaron] <dbaron@mozilla.com> r+sr=dbaron ...

superreview granted: [Bug 213591] iframes, input images/buttons are not displayed/rendered/visible/are missing 20030723 regression : [Attachment 128804] better fix
Robert O'Callahan <roc+moz@cs.cmu.edu> has granted David Baron <dbaron@dbaron.org>'s request for superreview: Bug 213591: iframes, input images/buttons are not displayed/rendered/visible/are missing 20030723 regression http://bugzilla.mozilla.org/show_bug.cgi?id=213591 Attachment 128804: better fix http://bugzilla.mozilla.org/attachment.cgi?id=128804&action=edit ------- Additional Comments from Robert O'Callahan <roc+moz@cs.cmu.edu> Just add a comment explaining that the root span never has a frame, so no view, if you please. Looks great!! ...

superreview granted: [Bug 286137] Crash [@ nsIFrame::Invalidate] with this evil testcase, using display:table-caption and then reloading page : [Attachment 180979] patch that fixes the crash (for me
Boris Zbarsky <bzbarsky@mit.edu> has granted Bernd <bernd_mozilla@gmx.de>'s request for superreview: Bug 286137: Crash [@ nsIFrame::Invalidate] with this evil testcase, using display:table-caption and then reloading page https://bugzilla.mozilla.org/show_bug.cgi?id=286137 Attachment 180979: patch that fixes the crash (for me at least) https://bugzilla.mozilla.org/attachment.cgi?id=180979&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Right. Makes sense to me. ...

superreview granted: [Bug 292431] 15% performance regression on DHTML due to fix for bug 240276 : [Attachment 182747] fix
Boris Zbarsky <bzbarsky@mit.edu> has granted Robert O'Callahan (Novell) <roc@ocallahan.org>'s request for superreview: Bug 292431: 15% performance regression on DHTML due to fix for bug 240276 https://bugzilla.mozilla.org/show_bug.cgi?id=292431 Attachment 182747: fix https://bugzilla.mozilla.org/attachment.cgi?id=182747&action=edit ...

superreview granted: [Bug 284166] [FIX]Shadow image not updated during image resizing, causing paint artefacts : [Attachment 175897] Fix
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 284166: [FIX]Shadow image not updated during image resizing, causing paint artefacts https://bugzilla.mozilla.org/show_bug.cgi?id=284166 Attachment 175897: Fix https://bugzilla.mozilla.org/attachment.cgi?id=175897&action=edit ...

superreview granted: [Bug 280947] Fix for bug 279945 breaks dragging of dynamic images : [Attachment 173629] Fix bz's issues.
Daniel Veditz <dveditz@cruzio.com> has granted Johnny Stenback <jst@mozilla.org>'s request for superreview: Bug 280947: Fix for bug 279945 breaks dragging of dynamic images https://bugzilla.mozilla.org/show_bug.cgi?id=280947 Attachment 173629: Fix bz's issues. https://bugzilla.mozilla.org/attachment.cgi?id=173629&action=edit ------- Additional Comments from Daniel Veditz <dveditz@cruzio.com> sr=dveditz ...

superreview granted: [Bug 263406] [FIX]abs/fixed pos handling (placeholder, etc) needs consolidation : [Attachment 163244] Patch without changes from bug 263846
Robert O'Callahan <roc@ocallahan.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 263406: [FIX]abs/fixed pos handling (placeholder, etc) needs consolidation https://bugzilla.mozilla.org/show_bug.cgi?id=263406 Attachment 163244: Patch without changes from bug 263846 https://bugzilla.mozilla.org/attachment.cgi?id=163244&action=edit ...

Web resources about - superreview granted: [Bug 363235] [FIX]Regression with display of image placeholders when an invalid protocol is used : [Attachment 249072] Fix - mozilla.dev.super-review

Mozilla rushes to fix regression bugs in Firefox
Sometimes you patch, and sometimes you have to patch the patch. Mozilla developers are living in the latter reality this week, rushing a 2.0.0.9 ...

Resources last updated: 12/11/2015 8:26:57 PM