superreview granted: [Bug 355352] [Cocoa] while the app is running, if no browser windows are open, clicking on the app in the dock doesn't open a browser window : [Attachment 248569] New and improved

Benjamin Smedberg  [:bs] (bsmedberg@) <benjamin@smedbergs.us> has granted Josh
Aas <joshmoz@gmail.com>'s request for superreview:
Bug 355352: [Cocoa] while the app is running, if no browser windows are open,
clicking on the app in the dock doesn't open a browser window
https://bugzilla.mozilla.org/show_bug.cgi?id=355352

Attachment 248569: New and improved patch
https://bugzilla.mozilla.org/attachment.cgi?id=248569&action=edit

------- Additional Comments from Benjamin Smedberg  [:bs] (bsmedberg@)
<benjamin@smedbergs.us>
moa=bsmedberg (I didn't review, I'm trusting josh to have looked this over
thoroughly)
0
bugzilla
12/14/2006 9:10:46 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
824 Views

Similar Articles

[PageSpeed] 38

Reply:

Similar Artilces:

superreview requested: [Bug 355352] [Cocoa] while the app is running, if no browser windows are open, clicking on the app in the dock doesn't open a browser window : [Attachment 248569] New and improv
Josh Aas <joshmoz@gmail.com> has asked Benjamin Smedberg [:bs] (bsmedberg@) <benjamin@smedbergs.us> for superreview: Bug 355352: [Cocoa] while the app is running, if no browser windows are open, clicking on the app in the dock doesn't open a browser window https://bugzilla.mozilla.org/show_bug.cgi?id=355352 Attachment 248569: New and improved patch https://bugzilla.mozilla.org/attachment.cgi?id=248569&action=edit ------- Additional Comments from Josh Aas <joshmoz@gmail.com> The minor changes remaining (comments mostly) can be made on checkin. ...

superreview granted: [Bug 429926] Make Cmd+T open a new window when no browser windows are open : [Attachment 316692] BrowserOpenTab() even when no windows are open
neil@parkwaycc.co.uk <neil@httl.net> has granted Stefan <stefanh@inbox.com>'s request for superreview: Bug 429926: Make Cmd+T open a new window when no browser windows are open https://bugzilla.mozilla.org/show_bug.cgi?id=429926 Attachment 316692: BrowserOpenTab() even when no windows are open https://bugzilla.mozilla.org/attachment.cgi?id=316692&action=edit ...

superreview granted: [Bug 429926] Make Cmd+T open a new window when no browser windows are open : [Attachment 317598] New version
neil@parkwaycc.co.uk <neil@httl.net> has granted jag (Peter Annema) <jag@tty.nl>'s request for superreview: Bug 429926: Make Cmd+T open a new window when no browser windows are open https://bugzilla.mozilla.org/show_bug.cgi?id=429926 Attachment 317598: New version https://bugzilla.mozilla.org/attachment.cgi?id=317598&action=edit ...

superreview requested: [Bug 429926] Make Cmd+T open a new window when no browser windows are open : [Attachment 316692] BrowserOpenTab() even when no windows are open
Stefan <stefanh@bluebottle.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 429926: Make Cmd+T open a new window when no browser windows are open https://bugzilla.mozilla.org/show_bug.cgi?id=429926 Attachment 316692: BrowserOpenTab() even when no windows are open https://bugzilla.mozilla.org/attachment.cgi?id=316692&action=edit ...

superreview granted: [Bug 217012] browser window won't come to foreground with help window open : [Attachment 130237] when raising a window to the top, first raise all windows in higher layers to th
jag (Peter Annema) <jag@tty.nl> has granted Dan M <danm-moz@comcast.net>'s request for superreview: Bug 217012: browser window won't come to foreground with help window open http://bugzilla.mozilla.org/show_bug.cgi?id=217012 Attachment 130237: when raising a window to the top, first raise all windows in higher layers to the top http://bugzilla.mozilla.org/attachment.cgi?id=130237&action=edit ------- Additional Comments from jag (Peter Annema) <jag@tty.nl> sr=jag ...

superreview requested: [Bug 429926] Make Cmd+T open a new window when no browser windows are open : [Attachment 317598] New version
jag (Peter Annema) <jag@tty.nl> has asked neil@parkwaycc.co.uk <neil@httl.n= et> for superreview: Bug 429926: Make Cmd+T open a new window when no browser windows are open https://bugzilla.mozilla.org/show_bug.cgi?id=3D429926 Attachment 317598: New version https://bugzilla.mozilla.org/attachment.cgi?id=3D317598&action=3Dedit ------- Additional Comments from jag (Peter Annema) <jag@tty.nl> I was thinking we could just check gBrowser at the beginning of this functi= on and call OpenBrowserWindow(), but that would use the "new window" pref sett= ing ...

superreview granted: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 227564] fixes in response to Darin's re
Darin Fisher (Google) <darin@meer.net> has granted Marria Nazif <marria@gmail.com>'s request for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 227564: fixes in response to Darin's review https://bugzilla.mozilla.org/attachment.cgi?id=227564&action=edit ------- Additional Comments from Darin Fisher (Google) <darin@meer.net> >Index: docshell/base/nsDocShell.cpp > if (!r...

superreview granted: [Bug 172962] Options for where to open URLs from other applications (reuse tab, new tab, new window) : [Attachment 161419] don't divert window.open to a new tab if the named wind
Johnny Stenback <jst@mozilla.jstenback.com> has granted Dan M <danm.moz@gmail.com>'s request for superreview: Bug 172962: Options for where to open URLs from other applications (reuse tab, new tab, new window) https://bugzilla.mozilla.org/show_bug.cgi?id=172962 Attachment 161419: don't divert window.open to a new tab if the named window exists https://bugzilla.mozilla.org/attachment.cgi?id=161419&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> sr=jst ...

superreview cancelled: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 227973] tweaks in response to reviews
Marria Nazif <marria@gmail.com> has cancelled Marria Nazif <marria@gmail.com>'s request for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 227973: tweaks in response to reviews https://bugzilla.mozilla.org/attachment.cgi?id=227973&action=edit ------- Additional Comments from Marria Nazif <marria@gmail.com> Actually, I'm going to go ahead and check this in on the trunk, since thes...

superreview requested: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 227973] tweaks in response to reviews
Marria Nazif <marria@gmail.com> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 227973: tweaks in response to reviews https://bugzilla.mozilla.org/attachment.cgi?id=227973&action=edit ------- Additional Comments from Marria Nazif <marria@gmail.com> (In reply to comment #60) > (From update of attachment 227564 [edit]) > So this w...

superreview granted: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 226606] store state in channel, works f
Darin Fisher (Google) <darin@meer.net> has granted Marria Nazif <marria@gmail.com>'s request for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 226606: store state in channel, works for target= as well as window.open https://bugzilla.mozilla.org/attachment.cgi?id=226606&action=edit ------- Additional Comments from Darin Fisher (Google) <darin@meer.net> >Index: docshell/base/nsDoc...

superreview cancelled: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 225294] close blank window
Marria Nazif <marria@gmail.com> has cancelled Marria Nazif <marria@gmail.com>'s request for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 225294: close blank window https://bugzilla.mozilla.org/attachment.cgi?id=225294&action=edit ...

superreview requested: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 225294] close blank window
Marria Nazif <marria@gmail.com> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 225294: close blank window https://bugzilla.mozilla.org/attachment.cgi?id=225294&action=edit ------- Additional Comments from Marria Nazif <marria@gmail.com> This is a first try at closing the window after the external app handler has done its work. This seemed to work for my test cases. One thing I'm not sure about is the refresh handler case - I could use some help coming up with a test case that triggers that code path since simply setting a Refresh header didn't (mOriginalChannel seems to always be null in ProcessAnyRefreshTags). ...

superreview granted: [Bug 255123] Opening URL from another app focuses an existing window before opening a new window : [Attachment 161778] Updated patch repsecting loadDivertedInBackground preferenc
Brian Ryner (IBM) <bryner@brianryner.com> has granted Dan M <danm.moz@gmail.com>'s request for superreview: Bug 255123: Opening URL from another app focuses an existing window before opening a new window https://bugzilla.mozilla.org/show_bug.cgi?id=255123 Attachment 161778: Updated patch repsecting loadDivertedInBackground preference https://bugzilla.mozilla.org/attachment.cgi?id=161778&action=edit ...

superreview requested: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 227564] fixes in response to Darin's
Marria Nazif <marria@gmail.com> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 227564: fixes in response to Darin's review https://bugzilla.mozilla.org/attachment.cgi?id=227564&action=edit ------- Additional Comments from Marria Nazif <marria@gmail.com> > >+ /** > >+ * This is set based on whether the channel indica...

superreview requested: [Bug 172962] Options for where to open URLs from other applications (reuse tab, new tab, new window) : [Attachment 161419] don't divert window.open to a new tab if the named wi
Dan M <danm.moz@gmail.com> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 172962: Options for where to open URLs from other applications (reuse tab, new tab, new window) https://bugzilla.mozilla.org/show_bug.cgi?id=172962 Attachment 161419: don't divert window.open to a new tab if the named window exists https://bugzilla.mozilla.org/attachment.cgi?id=161419&action=edit ...

superreview requested: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 225651] check that session history is
Marria Nazif <marria@gmail.com> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 225651: check that session history is empty https://bugzilla.mozilla.org/attachment.cgi?id=225651&action=edit ...

superreview requested: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 226289] pass state in the channel
Marria Nazif <marria@gmail.com> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 226289: pass state in the channel https://bugzilla.mozilla.org/attachment.cgi?id=226289&action=edit ------- Additional Comments from Marria Nazif <marria@gmail.com> This is another idea I had - we can pass state on the channel which indicates whether a new ...

superreview cancelled: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 226289] pass state in the channel
Marria Nazif <marria@gmail.com> has cancelled Marria Nazif <marria@gmail.com>'s request for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 226289: pass state in the channel https://bugzilla.mozilla.org/attachment.cgi?id=226289&action=edit ...

superreview cancelled: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 225903] docshell tracks whether it lo
Marria Nazif <marria@gmail.com> has cancelled Marria Nazif <marria@gmail.com>'s request for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 225903: docshell tracks whether it loaded any content before https://bugzilla.mozilla.org/attachment.cgi?id=225903&action=edit ...

superreview denied: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 225651] check that session history is em
Darin Fisher (Google) <darin@meer.net> has denied Marria Nazif <marria@gmail.com>'s request for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 225651: check that session history is empty https://bugzilla.mozilla.org/attachment.cgi?id=225651&action=edit ------- Additional Comments from Darin Fisher (Google) <darin@meer.net> Marria and I discussed this today. She's got a much better solution on the way... ...

superreview requested: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 225903] docshell tracks whether it lo
Marria Nazif <marria@gmail.com> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 225903: docshell tracks whether it loaded any content before https://bugzilla.mozilla.org/attachment.cgi?id=225903&action=edit ------- Additional Comments from Marria Nazif <marria@gmail.com> I added something to the DocShell which tracks if it ever loaded a...

superreview requested: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 226606] store state in channel, works
Marria Nazif <marria@gmail.com> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 226606: store state in channel, works for target= as well as window.open https://bugzilla.mozilla.org/attachment.cgi?id=226606&action=edit ------- Additional Comments from Marria Nazif <marria@gmail.com> This is a second iteration on the patch that stores s...

superreview granted: [Bug 300485] Launching SeaMonkey when it's already running, with "open in new tab" preference, should opens a new tab rather than window. : [Attachment 190315] Updated for commen
jag (Peter Annema) <jag@tty.nl> has granted jag (Peter Annema) <jag@tty.nl>'s request for superreview: Bug 300485: Launching SeaMonkey when it's already running, with "open in new tab" preference, should opens a new tab rather than window. https://bugzilla.mozilla.org/show_bug.cgi?id=300485 Attachment 190315: Updated for comments https://bugzilla.mozilla.org/attachment.cgi?id=190315&action=edit ...

Web resources about - superreview granted: [Bug 355352] [Cocoa] while the app is running, if no browser windows are open, clicking on the app in the dock doesn't open a browser window : [Attachment 248569] New and improved - mozilla.dev.super-review

Resources last updated: 3/27/2016 8:05:38 PM