superreview granted: [Bug 355222] Some downloads can fail when using 'Always ask me where to save files' NS_ERROR_FAILURE @ nsIFilePicker.init Line 148 : [Attachment 241057] patch

Darin Fisher (Google) <darin@meer.net> has granted Gavin Sharp
<gavin.sharp@gmail.com>'s request for superreview:
Bug 355222: Some downloads can fail when using 'Always ask me where to save
files' NS_ERROR_FAILURE @ nsIFilePicker.init Line 148
https://bugzilla.mozilla.org/show_bug.cgi?id=355222

Attachment 241057: patch
https://bugzilla.mozilla.org/attachment.cgi?id=241057&action=edit
0
bugzilla
10/3/2006 8:04:57 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
371 Views

Similar Articles

[PageSpeed] 33

Reply:

Similar Artilces:

superreview requested: [Bug 355222] Some downloads can fail when using 'Always ask me where to save files' NS_ERROR_FAILURE @ nsIFilePicker.init Line 148 : [Attachment 241057] patch
Gavin Sharp <gavin.sharp@gmail.com> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 355222: Some downloads can fail when using 'Always ask me where to save files' NS_ERROR_FAILURE @ nsIFilePicker.init Line 148 https://bugzilla.mozilla.org/show_bug.cgi?id=355222 Attachment 241057: patch https://bugzilla.mozilla.org/attachment.cgi?id=241057&action=edit ...

superreview granted: [Bug 290788] crash when try to 'save all' Attachments from MailNews 'File' 'Attachments' Menu [@ nsMessenger::SaveAllAttachments] : [Attachment 181152] Patch
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Frank Wein <bugzilla@mcsmurf.de>'s request for superreview: Bug 290788: crash when try to 'save all' Attachments from MailNews 'File' 'Attachments' Menu [@ nsMessenger::SaveAllAttachments] https://bugzilla.mozilla.org/show_bug.cgi?id=290788 Attachment 181152: Patch https://bugzilla.mozilla.org/attachment.cgi?id=181152&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> D'oh! ;-) ...

superreview granted: [Bug 299839] If I use the option 'reset camino' it removes downloaded files out of my download location. : [Attachment 189206] Alternative patch, don't cancel finnished downloads
Mike Pinkerton <pinkerton@aol.net> has granted Mike Pinkerton <pinkerton@aol.net>'s request for superreview: Bug 299839: If I use the option 'reset camino' it removes downloaded files out of my download location. https://bugzilla.mozilla.org/show_bug.cgi?id=299839 Attachment 189206: Alternative patch, don't cancel finnished downloads https://bugzilla.mozilla.org/attachment.cgi?id=189206&action=edit ------- Additional Comments from Mike Pinkerton <pinkerton@aol.net> sr=pink. i prefer this as well. ...

superreview granted: [Bug 299192] can we rework the quotes in: Error: Unexpected end of file while searching for '';' or '}' to end declaration'. : [Attachment 187728] patch
Boris Zbarsky (No email until July) <bzbarsky@mit.edu> has granted David Baron <dbaron@mozillafoundation.org>'s request for superreview: Bug 299192: can we rework the quotes in: Error: Unexpected end of file while searching for '';' or '}' to end declaration'. https://bugzilla.mozilla.org/show_bug.cgi?id=299192 Attachment 187728: patch https://bugzilla.mozilla.org/attachment.cgi?id=187728&action=edit ...

superreview requested: [Bug 290788] crash when try to 'save all' Attachments from MailNews 'File' 'Attachments' Menu [@ nsMessenger::SaveAllAttachments] : [Attachment 181152] Patch
Frank Wein <bugzilla@mcsmurf.de> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 290788: crash when try to 'save all' Attachments from MailNews 'File' 'Attachments' Menu [@ nsMessenger::SaveAllAttachments] https://bugzilla.mozilla.org/show_bug.cgi?id=290788 Attachment 181152: Patch https://bugzilla.mozilla.org/attachment.cgi?id=181152&action=edit ------- Additional Comments from Frank Wein <bugzilla@mcsmurf.de> Neil: Easy fix, you forgot an arg ;-). ...

superreview granted: [Bug 268941] Error ``tabs has no properties'' [xs] in file ``chrome://communicator/content/sidebar/sidebarOverlay.js'', line 1355, character 0. : [Attachment 165464] Patch
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Christopher A. Aillon <caillon@gmail.com>'s request for superreview: Bug 268941: Error ``tabs has no properties'' [xs] in file ``chrome://communicator/content/sidebar/sidebarOverlay.js'', line 1355, character 0. https://bugzilla.mozilla.org/show_bug.cgi?id=268941 Attachment 165464: Patch https://bugzilla.mozilla.org/attachment.cgi?id=165464&action=edit ...

superreview granted: [Bug 342321] nsIncrementalDownload doesn't create 0-sized file when downloading a 0-sized file : [Attachment 226514] Always create/truncate the dest. file during the channel's onS
Darin Fisher (Google) <darin@meer.net> has granted Jeff Walden (remove +bmo to email) <jwalden+bmo@mit.edu>'s request for superreview: Bug 342321: nsIncrementalDownload doesn't create 0-sized file when downloading a 0-sized file https://bugzilla.mozilla.org/show_bug.cgi?id=342321 Attachment 226514: Always create/truncate the dest. file during the channel's onStartRequest https://bugzilla.mozilla.org/attachment.cgi?id=226514&action=edit ...

superreview requested: [Bug 426776] If a folder contains a 'broken' symbolic link, you can't navigate to it in Firefox using the file:/// URL. : [Attachment 313548] Patch rev. 1
Mats Palmgren <mats.palmgren@bredband.net> has asked Christian :Biesinger <cbiesinger@gmail.com> for superreview: Bug 426776: If a folder contains a 'broken' symbolic link, you can't navigate to it in Firefox using the file:/// URL. https://bugzilla.mozilla.org/show_bug.cgi?id=426776 Attachment 313548: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=313548&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> netwerk/base/src/nsDirectoryIndexStream.cpp: On MacOSX, IsFile() and IsDirectory() returns N...

superreview canceled: [Bug 426776] If a folder contains a 'broken' symbolic link, you can't navigate to it in Firefox using the file:/// URL. : [Attachment 313548] Patch rev. 1
Christian :Biesinger <cbiesinger@gmail.com> has canceled Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 426776: If a folder contains a 'broken' symbolic link, you can't naviga= te to it in Firefox using the file:/// URL. https://bugzilla.mozilla.org/show_bug.cgi?id=3D426776 Attachment 313548: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=3D313548&action=3Dedit ------- Additional Comments from Christian :Biesinger <cbiesinger@gmail.com> + int err =3D lstat((char*)path, &stats);=0D =0D that cast se...

superreview requested: [Bug 299192] can we rework the quotes in: Error: Unexpected end of file while searching for '';' or '}' to end declaration'. : [Attachment 187728] patch
David Baron <dbaron@mozillafoundation.org> has asked Boris Zbarsky (No email until July) <bzbarsky@mit.edu> for superreview: Bug 299192: can we rework the quotes in: Error: Unexpected end of file while searching for '';' or '}' to end declaration'. https://bugzilla.mozilla.org/show_bug.cgi?id=299192 Attachment 187728: patch https://bugzilla.mozilla.org/attachment.cgi?id=187728&action=edit ------- Additional Comments from David Baron <dbaron@mozillafoundation.org> Yeah, I don't think this was intended. ...

superreview granted: [Bug 139568] [FIX]ASSERT: nsFrameManager::GenerateStateKey didn't find content by type!: 'index > -1', file nsFrameManager.cpp, line 2261 : [Attachment 172218] Patch
Johnny Stenback <jst@mozilla.jstenback.com> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 139568: [FIX]ASSERT: nsFrameManager::GenerateStateKey didn't find content by type!: 'index > -1', file nsFrameManager.cpp, line 2261 https://bugzilla.mozilla.org/show_bug.cgi?id=139568 Attachment 172218: Patch https://bugzilla.mozilla.org/attachment.cgi?id=172218&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> nsCOMPtr<nsIHTMLDocument> htmlDocument(do_QueryInterface(aConten...

superreview granted: [Bug 392698] ASSERTION: can' t mark frame dirty during reflow: '!mIsReflowing', file layout/base/ nsPresShell.cpp, line 3099 resizing given URL : [Attachment 293817] like this?
Robert O'Callahan (:roc) <roc@ocallahan.org> has granted superreview: Bug 392698: ASSERTION: can't mark frame dirty during reflow: '!mIsReflowing', file layout/base/nsPresShell.cpp, line 3099 resizing given URL https://bugzilla.mozilla.org/show_bug.cgi?id=392698 Attachment 293817: like this? https://bugzilla.mozilla.org/attachment.cgi?id=293817&action=edit ------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.org> + mIsRoot && mOuter->GetParent()->GetFirstChild(nsGkAtoms::fixedList)) { This aditional check...

superreview granted: [Bug 241147] DecodeStructParticle fails on 'sequences' and 'choices' : [Attachment 146641] v1 patch
Johnny Stenback <jst@mozilla.jstenback.com> has granted Darin Fisher (IBM) <darin@meer.net>'s request for superreview: Bug 241147: DecodeStructParticle fails on 'sequences' and 'choices' http://bugzilla.mozilla.org/show_bug.cgi?id=241147 Attachment 146641: v1 patch http://bugzilla.mozilla.org/attachment.cgi?id=146641&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> - rc = DecodeStructParticle(aEncoding, aElement, child, aAttachments, aDestination, getter_AddRefs(after)); + rc = DecodeStruct...

superreview granted: [Bug 284276] "Save Link (Target) As" doesn't display file size, clicking the link itself displays file size on download (FTP) : [Attachment 177385] patch
Boris Zbarsky <bzbarsky@mit.edu> has granted Christian Biesinger (:bi) <cbiesinger@gmx.at>'s request for superreview: Bug 284276: "Save Link (Target) As" doesn't display file size, clicking the link itself displays file size on download (FTP) https://bugzilla.mozilla.org/show_bug.cgi?id=284276 Attachment 177385: patch https://bugzilla.mozilla.org/attachment.cgi?id=177385&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Seems reasonable ...

Web resources about - superreview granted: [Bug 355222] Some downloads can fail when using 'Always ask me where to save files' NS_ERROR_FAILURE @ nsIFilePicker.init Line 148 : [Attachment 241057] patch - mozilla.dev.super-review

Resources last updated: 1/23/2016 12:37:14 AM