superreview requested: [Bug 354600] Blocks whose parents are not blocks should have SPACE_MGR and MARGIN_ROOT flags set : [Attachment 245729] Fix
Boris Zbarsky <bzbarsky@mit.edu> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 354600: Blocks whose parents are not blocks should have SPACE_MGR and MARGIN_ROOT flags set https://bugzilla.mozilla.org/show_bug.cgi?id=354600 Attachment 245729: Fix https://bugzilla.mozilla.org/attachment.cgi?id=245729&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> I only removed existing flags in places where it was _very_ obvious that the new code would kick in. ...

superreview granted: [Bug 354600] [FIX] Blocks whose parents are not blocks should have SPACE_MGR and MARGIN_ROOT flags set
Robert O'Callahan <roc@ocallahan.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 354600: [FIX]Blocks whose parents are not blocks should have SPACE_MGR and MARGIN_ROOT flags set https://bugzilla.mozilla.org/show_bug.cgi?id=354600 Attachment 254125: Better fix https://bugzilla.mozilla.org/attachment.cgi?id=254125&action=edit ...

superreview requested: [Bug 354600] Blocks whose parents are not blocks should have SPACE_MGR and MARGIN_ROOT flags set
Boris Zbarsky <bzbarsky@mit.edu> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 354600: Blocks whose parents are not blocks should have SPACE_MGR and MARGIN_ROOT flags set https://bugzilla.mozilla.org/show_bug.cgi?id=354600 Attachment 254125: Better fix https://bugzilla.mozilla.org/attachment.cgi?id=254125&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> That took a few days more than planned. ;) ...

superreview granted: [Bug 253195] Fix a couple of subtle block reflow bugs : [Attachment 154425] fix
David Baron <dbaron@dbaron.org> has granted Robert O'Callahan <roc@ocallahan.org>'s request for superreview: Bug 253195: Fix a couple of subtle block reflow bugs http://bugzilla.mozilla.org/show_bug.cgi?id=253195 Attachment 154425: fix http://bugzilla.mozilla.org/attachment.cgi?id=154425&action=edit ...

superreview granted: [Bug 408749] "ASSERTION: A block's child' s next in flow's parent must be a block" with -moz-column, table stuff : [ Attachment 293607] fix assert
Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> has granted Robert O'Callahan (:roc) <roc@ocallahan.org>'s request for superreview: Bug 408749: "ASSERTION: A block's child's next in flow's parent must be a block" with -moz-column, table stuff https://bugzilla.mozilla.org/show_bug.cgi?id=408749 Attachment 293607: fix assert https://bugzilla.mozilla.org/attachment.cgi?id=293607&action=edit ------- Additional Comments from Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> Looks good. That said, s...

superreview granted: [Bug 257216] More columns-related block fixes : [Attachment 157238] fix
David Baron <dbaron@dbaron.org> has granted Robert O'Callahan <roc@ocallahan.org>'s request for superreview: Bug 257216: More columns-related block fixes http://bugzilla.mozilla.org/show_bug.cgi?id=257216 Attachment 157238: fix http://bugzilla.mozilla.org/attachment.cgi?id=157238&action=edit ------- Additional Comments from David Baron <dbaron@dbaron.org> (Really, mLowestTop needs fixing too, although it may not be an issue.) And I've read the whole patch now -- it wasn't that big, so that is really the only thing I have a problem with. ...

superreview granted: [Bug 296083] [FIX]{ib} Counter weirdness in block-in-inline situations : [Attachment 188233] Proposed fix
David Baron <dbaron@mozillafoundation.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 296083: [FIX]{ib} Counter weirdness in block-in-inline situations https://bugzilla.mozilla.org/show_bug.cgi?id=296083 Attachment 188233: Proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=188233&action=edit ------- Additional Comments from David Baron <dbaron@mozillafoundation.org> r+sr=dbaron, but in the long run I'd like to actually make this use next/prev-in-flow linkage, and have a bit that indicates that the flow is fixe...

superreview granted: [Bug 285981] [FIX]No alt text displayed with broken (security-blocked) image : [Attachment 178630] Proposed fix
Johnny Stenback <jst@mozilla.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 285981: [FIX]No alt text displayed with broken (security-blocked) image https://bugzilla.mozilla.org/show_bug.cgi?id=285981 Attachment 178630: Proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=178630&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> sr=jst ...

superreview granted: [Bug 364862] [FIX]Painting block text decorations uses wrong percentage base for text-indent : [Attachment 249554] Fix
David Baron <dbaron@mozilla.com> has granted Boris Zbarsky (probably no internet Dec 20 -- Jan 2) <bzbarsky@mit.edu>'s request for superreview: Bug 364862: [FIX]Painting block text decorations uses wrong percentage base for text-indent https://bugzilla.mozilla.org/show_bug.cgi?id=364862 Attachment 249554: Fix https://bugzilla.mozilla.org/attachment.cgi?id=249554&action=edit ...

superreview granted: [Bug 325222] [FIX]Crash with evil xul/mathml testcase, involving mi display: block and eq [@ nsLineLayout::ReflowFrame] : [Attachment 239946] Do what blocks do
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 325222: [FIX]Crash with evil xul/mathml testcase, involving mi display: block and eq [@ nsLineLayout::ReflowFrame] https://bugzilla.mozilla.org/show_bug.cgi?id=325222 Attachment 239946: Do what blocks do https://bugzilla.mozilla.org/attachment.cgi?id=239946&action=edit ...

superreview granted: [Bug 224327] if domain.com is blocked, sub.domain.com is blocked, but cannot be unblocked using remove : [Attachment 139237] fix cookieviewer to not allow duplicating permissio
Alec Flett <alecf@flett.org> has granted Mike Connor <mconnor@myrealbox.com>'s request for superreview: Bug 224327: if domain.com is blocked, sub.domain.com is blocked, but cannot be unblocked using remove http://bugzilla.mozilla.org/show_bug.cgi?id=224327 Attachment 139237: fix cookieviewer to not allow duplicating permissions http://bugzilla.mozilla.org/attachment.cgi?id=139237&action=edit ------- Additional Comments from Alec Flett <alecf@flett.org> sr=alecf ...

superreview granted: [Bug 282754] Width:100% broken if parent block element has overflow:hidden : [Attachment 176684] stopgap fix
David Baron <dbaron@mozilla.org> has granted Robert O'Callahan (Novell) <roc@ocallahan.org>'s request for superreview: Bug 282754: Width:100% broken if parent block element has overflow:hidden https://bugzilla.mozilla.org/show_bug.cgi?id=282754 Attachment 176684: stopgap fix https://bugzilla.mozilla.org/attachment.cgi?id=176684&action=edit ------- Additional Comments from David Baron <dbaron@mozilla.org> Make the code in nsBlockFrame a little more careful about what happens if one of the parentReflowState pointers is null (consider reflow roots or box/...

superreview requested: [Bug 253195] Fix a couple of subtle block reflow bugs : [Attachment 154425] fix
Robert O'Callahan <roc@ocallahan.org> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 253195: Fix a couple of subtle block reflow bugs http://bugzilla.mozilla.org/show_bug.cgi?id=253195 Attachment 154425: fix http://bugzilla.mozilla.org/attachment.cgi?id=154425&action=edit ...

superreview requested: [Bug 408749] "ASSERTION: A block's child' s next in flow's parent must be a block" with -moz-column, table stuff : [ Attachment 293607] fix assert
Robert O'Callahan (:roc) <roc@ocallahan.org> has asked Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> for superreview: Bug 408749: "ASSERTION: A block's child's next in flow's parent must be a block" with -moz-column, table stuff https://bugzilla.mozilla.org/show_bug.cgi?id=408749 Attachment 293607: fix assert https://bugzilla.mozilla.org/attachment.cgi?id=293607&action=edit ------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.org> This patch creates nsBlockFrame* nsLayoutUtils::GetAsBlock wh...