superreview granted: [Bug 351606] nested for..in and throw causes "Assertion failure: OBJ_GET_CLASS(cx, obj)->flags & JSCLASS_HAS_PRIVATE" [@ JS_SetPrivate] : [Attachment 237063] Updated

Brendan Eich <brendan@mozilla.org> has granted Blake Kaplan
<mrbkap@gmail.com>'s request for superreview:
Bug 351606: nested for..in and throw causes "Assertion failure:
OBJ_GET_CLASS(cx, obj)->flags & JSCLASS_HAS_PRIVATE" [@ JS_SetPrivate]
https://bugzilla.mozilla.org/show_bug.cgi?id=351606

Attachment 237063: Updated
https://bugzilla.mozilla.org/attachment.cgi?id=237063&action=edit

------- Additional Comments from Brendan Eich <brendan@mozilla.org>
Need to get this into the trunk pretty quickly.

/be
0
bugzilla
9/7/2006 4:31:43 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
336 Views

Similar Articles

[PageSpeed] 47

Reply:

Similar Artilces:

superreview requested: [Bug 351606] nested for..in and throw causes "Assertion failure: OBJ_GET_CLASS(cx, obj)->flags & JSCLASS_HAS_PRIVATE" [@ JS_SetPrivate] : [Attachment 237063] Updated
Blake Kaplan <mrbkap@gmail.com> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 351606: nested for..in and throw causes "Assertion failure: OBJ_GET_CLASS(cx, obj)->flags & JSCLASS_HAS_PRIVATE" [@ JS_SetPrivate] https://bugzilla.mozilla.org/show_bug.cgi?id=351606 Attachment 237063: Updated https://bugzilla.mozilla.org/attachment.cgi?id=237063&action=edit ...

superreview granted: [Bug 351606] nested for..in and throw causes "Assertion failure: OBJ_GET_CLASS(cx, obj)->flags & JSCLASS_HAS_PRIVATE" [@ JS_SetPrivate] : [Attachment 237072] Maybe better
Brendan Eich <brendan@mozilla.org> has granted Blake Kaplan <mrbkap@gmail.com>'s request for superreview: Bug 351606: nested for..in and throw causes "Assertion failure: OBJ_GET_CLASS(cx, obj)->flags & JSCLASS_HAS_PRIVATE" [@ JS_SetPrivate] https://bugzilla.mozilla.org/show_bug.cgi?id=351606 Attachment 237072: Maybe better https://bugzilla.mozilla.org/attachment.cgi?id=237072&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> Looks good to me again, but I'm not counting for much here. Igor's r+ counts....

superreview requested: [Bug 351606] nested for..in and throw causes "Assertion failure: OBJ_GET_CLASS(cx, obj)->flags & JSCLASS_HAS_PRIVATE" [@ JS_SetPrivate] : [Attachment 237072] Maybe better
Blake Kaplan <mrbkap@gmail.com> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 351606: nested for..in and throw causes "Assertion failure: OBJ_GET_CLASS(cx, obj)->flags & JSCLASS_HAS_PRIVATE" [@ JS_SetPrivate] https://bugzilla.mozilla.org/show_bug.cgi?id=351606 Attachment 237072: Maybe better https://bugzilla.mozilla.org/attachment.cgi?id=237072&action=edit ------- Additional Comments from Blake Kaplan <mrbkap@gmail.com> The last patch did the wrong thing if the only object on fp->blockChain had a NULL parent. ...

superreview granted: [Bug 422009] [FIX]"Assertion failure: !cx->throwing" with XBL constructor that throws and syntax error in event handler : [Attachment 310421] Fix
Johnny Stenback (:jst) <jst@mozilla.org> has granted Boris Zbarsky (reviews very slow until May) <bzbarsky@mit.edu>'s request for superreview: Bug 422009: [FIX]"Assertion failure: !cx->throwing" with XBL constructor that throws and syntax error in event handler https://bugzilla.mozilla.org/show_bug.cgi?id=422009 Attachment 310421: Fix https://bugzilla.mozilla.org/attachment.cgi?id=310421&action=edit ...

superreview requested: [Bug 422009] [FIX]"Assertion failure: !cx->throwing" with XBL constructor that throws and syntax error in event handler : [Attachment 310421] Fix
Boris Zbarsky (reviews very slow until May) <bzbarsky@mit.edu> has asked Johnny Stenback (:jst) <jst@mozilla.org> for superreview: Bug 422009: [FIX]"Assertion failure: !cx->throwing" with XBL constructor that throws and syntax error in event handler https://bugzilla.mozilla.org/show_bug.cgi?id=422009 Attachment 310421: Fix https://bugzilla.mozilla.org/attachment.cgi?id=310421&action=edit ...

superreview granted: [Bug 194147] Selecting "Mark As" causes Quick Search not to work on "m" and "r" : [Attachment 203114] Updated version, carrying over flags
Stefan <stefan_h@hem.utfors.se> has granted Stefan <stefan_h@hem.utfors.se>'s request for superreview: Bug 194147: Selecting "Mark As" causes Quick Search not to work on "m" and "r" https://bugzilla.mozilla.org/show_bug.cgi?id=194147 Attachment 203114: Updated version, carrying over flags https://bugzilla.mozilla.org/attachment.cgi?id=203114&action=edit ------- Additional Comments from Stefan <stefan_h@hem.utfors.se> Updated version: Fixed indentation in win file (also added one empty line under the delete key section) and VK_...

superreview granted: [Bug 418133] [FIX]"Assertion failure: !JS_IsExceptionPending(cx)" with <xul:preferences> : [Attachment 306201] Possible patch
Brendan Eich <brendan@mozilla.org> has granted Boris Zbarsky (reviews very slow until May) <bzbarsky@mit.edu>'s request for superreview: Bug 418133: [FIX]"Assertion failure: !JS_IsExceptionPending(cx)" with <xul:preferences> https://bugzilla.mozilla.org/show_bug.cgi?id=418133 Attachment 306201: Possible patch https://bugzilla.mozilla.org/attachment.cgi?id=306201&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> >+ // If EvaluateStringWithValue() threw an exception, just report it now. >+ // Failure to ...

superreview granted: [Bug 436195] "ASSERTION: invalid min or max param: 'min <= max && min > 0'" when accessing a newsgroup : [Attachment 322870] Patch to fix the issue
David Bienvenu <bienvenu@nventure.com> has granted Joshua Cranmer [:jcranmer] <Pidgeot18@gmail.com>'s request for superreview: Bug 436195: "ASSERTION: invalid min or max param: 'min <= max && min > 0'" when accessing a newsgroup https://bugzilla.mozilla.org/show_bug.cgi?id=436195 Attachment 322870: Patch to fix the issue https://bugzilla.mozilla.org/attachment.cgi?id=322870&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> thx, Joshua ...

superreview granted: [Bug 226958] Bug 197315, "other" files: Convert <window class="dialog"> to <dialog> : [Attachment 137732] (Cv2c) <Wallet*.*>
Alec Flett <alecf@flett.org> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 226958: Bug 197315, "other" files: Convert <window class="dialog"> to <dialog> http://bugzilla.mozilla.org/show_bug.cgi?id=226958 Attachment 137732: (Cv2c) <Wallet*.*> http://bugzilla.mozilla.org/attachment.cgi?id=137732&action=edit ------- Additional Comments from Alec Flett <alecf@flett.org> damn, nice cleanup sr=alecf assuming it all works well. ...

superreview granted: [Bug 226958] Bug 197315, "other" files: Convert <window class="dialog"> to <dialog> : [Attachment 136628] <xpistatus.*> patch v3
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 226958: Bug 197315, "other" files: Convert <window class="dialog"> to <dialog> http://bugzilla.mozilla.org/show_bug.cgi?id=226958 Attachment 136628: <xpistatus.*> patch v3 http://bugzilla.mozilla.org/attachment.cgi?id=136628&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> I checked in the patch with ben's changes. ...

superreview granted: [Bug 345620] "text-shadow: menutext; " causes "ASSERTION: Must be a color value" : [Attachment 230521] patch
Boris Zbarsky <bzbarsky@mit.edu> has granted David Baron <dbaron@mozilla.com>'s request for superreview: Bug 345620: "text-shadow: menutext;" causes "ASSERTION: Must be a color value" https://bugzilla.mozilla.org/show_bug.cgi?id=345620 Attachment 230521: patch https://bugzilla.mozilla.org/attachment.cgi?id=230521&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> r+sr=bzbarsky ...

superreview granted: [Bug 407019] "Assertion failure: !JS_IsExceptionPending(cx)" with |new Option|, take 2 : [Attachment 293779 ] Fix
Jonas Sicking (:sicking) Vacation Dec 19th to Jan 2nd <jonas@sicking.cc> has granted Blake Kaplan <mrbkap@gmail.com>'s request for superreview: Bug 407019: "Assertion failure: !JS_IsExceptionPending(cx)" with |new Option|, take 2 https://bugzilla.mozilla.org/show_bug.cgi?id=407019 Attachment 293779: Fix https://bugzilla.mozilla.org/attachment.cgi?id=293779&action=edit ...

superreview granted: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 218487] updated patch ready for review
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 218487: updated patch ready for review https://bugzilla.mozilla.org/attachment.cgi?id=218487&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> my one concern is about migration from the per-server prefs to the global prefs. What happens in that scenar...

superreview granted: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 220151] updated fix with review comments
Scott MacGregor <mscott@mozilla.org> has granted superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 220151: updated fix with review comments https://bugzilla.mozilla.org/attachment.cgi?id=220151&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> carrying forward david's sr and neil's r. ...

Web resources about - superreview granted: [Bug 351606] nested for..in and throw causes "Assertion failure: OBJ_GET_CLASS(cx, obj)->flags & JSCLASS_HAS_PRIVATE" [@ JS_SetPrivate] : [Attachment 237063] Updated - mozilla.dev.super-review

Resources last updated: 1/19/2016 6:06:31 AM