superreview granted: [Bug 351601] Accessing the new navigator.buildID in a build w/o NS_BUILD_ID set shouldn't throw exception. : [Attachment 237006] Don't throw if NS_BUILD_ID is not set.

Jonas Sicking <bugmail@sicking.cc> has granted Johnny Stenback
<jst@mozilla.org>'s request for superreview:
Bug 351601: Accessing the new navigator.buildID in a build w/o NS_BUILD_ID set
shouldn't throw exception.
https://bugzilla.mozilla.org/show_bug.cgi?id=351601

Attachment 237006: Don't throw if NS_BUILD_ID is not set.
https://bugzilla.mozilla.org/attachment.cgi?id=237006&action=edit
0
bugzilla
9/6/2006 10:20:51 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
599 Views

Similar Articles

[PageSpeed] 7

Reply:

Similar Artilces:

superreview requested: [Bug 351601] Accessing the new navigator.buildID in a build w/o NS_BUILD_ID set shouldn't throw exception. : [Attachment 237006] Don't throw if NS_BUILD_ID is not set.
Johnny Stenback <jst@mozilla.org> has asked Jonas Sicking <bugmail@sicking.cc> for superreview: Bug 351601: Accessing the new navigator.buildID in a build w/o NS_BUILD_ID set shouldn't throw exception. https://bugzilla.mozilla.org/show_bug.cgi?id=351601 Attachment 237006: Don't throw if NS_BUILD_ID is not set. https://bugzilla.mozilla.org/attachment.cgi?id=237006&action=edit ...

superreview granted: [Bug 212231] Errors from document.open() cause silent failures in JS : [Attachment 127391] Don't return JS_FALSE in common cases to the JS engine w/o throwing an exception
Boris Zbarsky <bzbarsky@mit.edu> has granted Johnny Stenback <jst@netscape.com>'s request for superreview: Bug 212231: Errors from document.open() cause silent failures in JS http://bugzilla.mozilla.org/show_bug.cgi?id=212231 Attachment 127391: Don't return JS_FALSE in common cases to the JS engine w/o throwing an exception http://bugzilla.mozilla.org/attachment.cgi?id=127391&action=edit ...

superreview granted: [Bug 212231] Errors from document.open() cause silent failures in JS : [Attachment 127391] Don't return JS_FALSE in common cases to the JS engine w/o throwing an exception #3
Boris Zbarsky <bzbarsky@mit.edu> has granted Christopher A. Aillon <caillon@aillon.org>'s request for superreview: Bug 212231: Errors from document.open() cause silent failures in JS http://bugzilla.mozilla.org/show_bug.cgi?id=212231 Attachment 127391: Don't return JS_FALSE in common cases to the JS engine w/o throwing an exception http://bugzilla.mozilla.org/attachment.cgi?id=127391&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Dammit. I sr'ed this, then bugzilla clobbered it when caillon commented! ...

superreview granted: [Bug 212231] Errors from document.open() cause silent failures in JS : [Attachment 127391] Don't return JS_FALSE in common cases to the JS engine w/o throwing an exception #2
Christopher A. Aillon <caillon@aillon.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 212231: Errors from document.open() cause silent failures in JS http://bugzilla.mozilla.org/show_bug.cgi?id=212231 Attachment 127391: Don't return JS_FALSE in common cases to the JS engine w/o throwing an exception http://bugzilla.mozilla.org/attachment.cgi?id=127391&action=edit ------- Additional Comments from Christopher A. Aillon <caillon@aillon.org> r=caillon if you fix nsHTMLElementSH::ScrollIntoView() to do the right thing as w...

superreview granted: [Bug 245619] Don't bother converting result of scripts into a string when the caller doesn't care about the value. : [Attachment 150056] Don't convert the result to a string if t
Brendan Eich <brendan@mozilla.org> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 245619: Don't bother converting result of scripts into a string when the caller doesn't care about the value. http://bugzilla.mozilla.org/show_bug.cgi?id=245619 Attachment 150056: Don't convert the result to a string if the caller doesn't care about the return value. http://bugzilla.mozilla.org/attachment.cgi?id=150056&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> Duh, thanks. r+sr=me....

superreview granted: [Bug 337970] nsHTMLDocument doesn't notify the charset resolver of the resolved character set : [Attachment 222017] don't pass null
Boris Zbarsky (gone May 17 -- May 29) <bzbarsky@mit.edu> has granted Gavin Sharp <gavin.sharp@gmail.com>'s request for superreview: Bug 337970: nsHTMLDocument doesn't notify the charset resolver of the resolved character set https://bugzilla.mozilla.org/show_bug.cgi?id=337970 Attachment 222017: don't pass null https://bugzilla.mozilla.org/attachment.cgi?id=222017&action=edit ...

superreview granted: [Bug 340083] Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title in defs : [Attachment 224205] don't create frames for content we don't handle, don't invalidate nond
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted superreview: Bug 340083: Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title in defs https://bugzilla.mozilla.org/show_bug.cgi?id=340083 Attachment 224205: don't create frames for content we don't handle, don't invalidate nondisplay content https://bugzilla.mozilla.org/attachment.cgi?id=224205&action=edit ...

superreview granted: [Bug 338281] SVG drawing doesn't work anymore as expected : [Attachment 222632] invalid path: don't throw error, invalidate
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted superreview: Bug 338281: SVG drawing doesn't work anymore as expected https://bugzilla.mozilla.org/show_bug.cgi?id=338281 Attachment 222632: invalid path: don't throw error, invalidate https://bugzilla.mozilla.org/attachment.cgi?id=222632&action=edit ...

superreview granted: [Bug 390178] Can't focus elements within panel popup with the mouse if noautohide attribute is set to true : [Attachment 313421] This seems to work. Don't activate anything when c
Robert O'Callahan (:roc) (reduced activity March 18 to April 9) <roc@ocallahan.org> has granted Neil Deakin <enndeakin@gmail.com>'s request for superreview: Bug 390178: Can't focus elements within panel popup with the mouse if noautohide attribute is set to true https://bugzilla.mozilla.org/show_bug.cgi?id=390178 Attachment 313421: This seems to work. Don't activate anything when clicking with the mouse https://bugzilla.mozilla.org/attachment.cgi?id=313421&action=edit ...

superreview granted: [Bug 232443] Modifying Windows Folder Picker to use the new folder dialog : [Attachment 140622] don't set the callback unless we have an initial folder path to set
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 232443: Modifying Windows Folder Picker to use the new folder dialog http://bugzilla.mozilla.org/show_bug.cgi?id=232443 Attachment 140622: don't set the callback unless we have an initial folder path to set http://bugzilla.mozilla.org/attachment.cgi?id=140622&action=edit ...

superreview granted: [Bug 264442] plugin finder can't find anything for windows media. : [Attachment 162212] Don't assume we don't have a plugin before getting a responce from the network.
Boris Zbarsky <bzbarsky@mit.edu> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 264442: plugin finder can't find anything for windows media. https://bugzilla.mozilla.org/show_bug.cgi?id=264442 Attachment 162212: Don't assume we don't have a plugin before getting a responce from the network. https://bugzilla.mozilla.org/attachment.cgi?id=162212&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> r+sr=bzbarsky, I guess.. Is ther a reason mIsBrokenPlugin is write-only? ...

superreview requested: [Bug 212231] Errors from document.open() cause silent failures in JS : [Attachment 127391] Don't return JS_FALSE in common cases to the JS engine w/o throwing an exception
Johnny Stenback <jst@netscape.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 212231: Errors from document.open() cause silent failures in JS http://bugzilla.mozilla.org/show_bug.cgi?id=212231 Attachment 127391: Don't return JS_FALSE in common cases to the JS engine w/o throwing an exception http://bugzilla.mozilla.org/attachment.cgi?id=127391&action=edit ...

superreview granted: [Bug 288574] [FIX]Don't call ValueAppended for DOM changes that don't create the value : [Attachment 180304] Same as diff -w
David Baron <dbaron@mozillafoundation.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 288574: [FIX]Don't call ValueAppended for DOM changes that don't create the value https://bugzilla.mozilla.org/show_bug.cgi?id=288574 Attachment 180304: Same as diff -w https://bugzilla.mozilla.org/attachment.cgi?id=180304&action=edit ...

superreview granted: [Bug 217896] ASSERTION: nsMemoryImpl::Alloc of 0: 'size' in GlobalWindowImpl::Unescape : [Attachment 130691] don't do silly things that don't make sense
Johnny Stenback <jst@netscape.com> has granted timeless@myrealbox.com <timeless@bemail.org>'s request for superreview: Bug 217896: ASSERTION: nsMemoryImpl::Alloc of 0: 'size' in GlobalWindowImpl::Unescape http://bugzilla.mozilla.org/show_bug.cgi?id=217896 Attachment 130691: don't do silly things that don't make sense http://bugzilla.mozilla.org/attachment.cgi?id=130691&action=edit ------- Additional Comments from Johnny Stenback <jst@netscape.com> sr=jst ...

Web resources about - superreview granted: [Bug 351601] Accessing the new navigator.buildID in a build w/o NS_BUILD_ID set shouldn't throw exception. : [Attachment 237006] Don't throw if NS_BUILD_ID is not set. - mozilla.dev.super-review

resources last updated: 11/20/2015 10:04:05 AM