superreview granted: [Bug 350693] "Character Encoding" in "View Source" window doesn't work : [Attachment 236818] Patch

Scott MacGregor <mscott@mozilla.org> has granted Simon Montagu
<smontagu@smontagu.org>'s request for superreview:
Bug 350693: "Character Encoding" in "View Source" window doesn't work
https://bugzilla.mozilla.org/show_bug.cgi?id=350693

Attachment 236818: Patch
https://bugzilla.mozilla.org/attachment.cgi?id=236818&action=edit

------- Additional Comments from Scott MacGregor <mscott@mozilla.org>
this needs a  toolkit module owner review so I'll ask Benjamin for that.

David's on vacation, i'll do the sr.
0
bugzilla
9/5/2006 9:22:29 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
563 Views

Similar Articles

[PageSpeed] 11

Reply:

Similar Artilces:

superreview requested: [Bug 350693] "Character Encoding" in "View Source" window doesn't work : [Attachment 236818] Patch
Simon Montagu <smontagu@smontagu.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 350693: "Character Encoding" in "View Source" window doesn't work https://bugzilla.mozilla.org/show_bug.cgi?id=350693 Attachment 236818: Patch https://bugzilla.mozilla.org/attachment.cgi?id=236818&action=edit ------- Additional Comments from Simon Montagu <smontagu@smontagu.org> This is a port of Neil's patch to xpfe in bug 252317. It had r=doron, sr=bzbarsky over there, so I guess rs should be enough to apply it to toolkit. ...

superreview requested: [Bug 393002] "Server not found" message for view-source window doesn't display server name : [ Attachment 292031] patch v2: address issue raised by super-review
Anant Narayanan <anant@kix.in> has asked Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> for superreview: Bug 393002: "Server not found" message for view-source window doesn't display server name https://bugzilla.mozilla.org/show_bug.cgi?id=393002 Attachment 292031: patch v2: address issue raised by super-review https://bugzilla.mozilla.org/attachment.cgi?id=292031&action=edit ...

superreview denied: [Bug 393002] "Server not found" message for view-source window doesn't display server name : [ Attachment 292031] patch v2: address issue raised by super-review
Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> has denied Anant Narayanan <anant@kix.in>'s request for superreview: Bug 393002: "Server not found" message for view-source window doesn't displ= ay server name https://bugzilla.mozilla.org/show_bug.cgi?id=3D393002 Attachment 292031: patch v2: address issue raised by super-review https://bugzilla.mozilla.org/attachment.cgi?id=3D292031&action=3Dedit ------- Additional Comments from Boris Zbarsky (reviews very slow until spr= ing) <bzbarsky@mit.edu> You don't need the QI. ...

superreview granted: [Bug 237712] Gecko (? Firefox & Camino) doesn't interpret "macintosh" encoding as "x-mac-roman" : [Attachment 171486] patch (alias)
Boris Zbarsky <bzbarsky@mit.edu> has granted Jungshik Shin <jshin1987@gmail.com>'s request for superreview: Bug 237712: Gecko (? Firefox & Camino) doesn't interpret "macintosh" encoding as "x-mac-roman" https://bugzilla.mozilla.org/show_bug.cgi?id=237712 Attachment 171486: patch (alias) https://bugzilla.mozilla.org/attachment.cgi?id=171486&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Sure. sr=bzbarsky ...

superreview granted: [Bug 49487] If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard won't advance past "Next" : [Attachment 144546] patch
Brian Ryner (IBM) <bryner@brianryner.com> has granted Andrew Schultz <ajschult@mindspring.com>'s request for superreview: Bug 49487: If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard won't advance past "Next" http://bugzilla.mozilla.org/show_bug.cgi?id=49487 Attachment 144546: patch http://bugzilla.mozilla.org/attachment.cgi?id=144546&action=edit ...

superreview granted: [Bug 393002] "Server not found" message for view-source window doesn't display server name : [ Attachment 292088] patch v3: remove unnecessary QueryInterface
Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> has granted Anant Narayanan <anant@kix.in>'s request for superreview: Bug 393002: "Server not found" message for view-source window doesn't display server name https://bugzilla.mozilla.org/show_bug.cgi?id=393002 Attachment 292088: patch v3: remove unnecessary QueryInterface https://bugzilla.mozilla.org/attachment.cgi?id=292088&action=edit ------- Additional Comments from Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> Excellent! ...

superreview granted: [Bug 217147] [pwd-mngr] "View Saved Passwords..." window doesn't remember its size and position : [Attachment 131839] patch to fix bug 205176 as well
Brian Ryner <bryner@brianryner.com> has granted Steffen Wilberg <steffen.wilberg@web.de>'s request for superreview: Bug 217147: [pwd-mngr] "View Saved Passwords..." window doesn't remember its size and position http://bugzilla.mozilla.org/show_bug.cgi?id=217147 Attachment 131839: patch to fix bug 205176 as well http://bugzilla.mozilla.org/attachment.cgi?id=131839&action=edit ------- Additional Comments from Brian Ryner <bryner@brianryner.com> r+sr=bryner ...

superreview granted: [Bug 418961] "Save Page As" "Text Files" saves file but Downloads window doesn't show completion : [Attachment 305432] v1
Christian :Biesinger <cbiesinger@gmail.com> has granted Edward Lee (Mardak) <edilee@gmail.com>'s request for superreview: Bug 418961: "Save Page As" "Text Files" saves file but Downloads window doesn't show completion https://bugzilla.mozilla.org/show_bug.cgi?id=418961 Attachment 305432: v1 https://bugzilla.mozilla.org/attachment.cgi?id=305432&action=edit ...

superreview granted: [Bug 241209] "Show File Location" and "Launch File" buttons (on download progress dialog) don't work : [Attachment 147465] patch
Darin Fisher (IBM) <darin@meer.net> has granted Christian Biesinger <cbiesinger@gmx.at>'s request for superreview: Bug 241209: "Show File Location" and "Launch File" buttons (on download progress dialog) don't work http://bugzilla.mozilla.org/show_bug.cgi?id=241209 Attachment 147465: patch http://bugzilla.mozilla.org/attachment.cgi?id=147465&action=edit ------- Additional Comments from Darin Fisher (IBM) <darin@meer.net> sr=darin ...

superreview requested: [Bug 237712] Gecko (? Firefox & Camino) doesn't interpret "macintosh" encoding as "x-mac-roman" : [Attachment 171486] patch (alias)
Jungshik Shin <jshin1987@gmail.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 237712: Gecko (? Firefox & Camino) doesn't interpret "macintosh" encoding as "x-mac-roman" https://bugzilla.mozilla.org/show_bug.cgi?id=237712 Attachment 171486: patch (alias) https://bugzilla.mozilla.org/attachment.cgi?id=171486&action=edit ------- Additional Comments from Jungshik Shin <jshin1987@gmail.com> Let me steal it from smontagu. This is a trivial fix and should go in for branches as well. Later, we may consider making &#...

superreview granted: [Bug 198936] [patch] "Do you wish to compact..." dialog has no "don't ask me again" checkbox : [Attachment 227622] Add a "Do this automatically from now on" checkbox, v3
Scott MacGregor <mscott@mozilla.org> has granted Jens Bannmann <jens.b@web.de>'s request for superreview: Bug 198936: [patch] "Do you wish to compact..." dialog has no "don't ask me again" checkbox https://bugzilla.mozilla.org/show_bug.cgi?id=198936 Attachment 227622: Add a "Do this automatically from now on" checkbox, v3 https://bugzilla.mozilla.org/attachment.cgi?id=227622&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> +pref("mail.askBeforePurge", true); I'd probably...

superreview granted: [Bug 198936] [patch] "Do you wish to compact..." dialog has no "don't ask me again" checkbox : [Attachment 227798] Add a "Do this automatically from now on" checkbox, v4
Jens Bannmann <jens.b@web.de> has granted superreview: Bug 198936: [patch] "Do you wish to compact..." dialog has no "don't ask me again" checkbox https://bugzilla.mozilla.org/show_bug.cgi?id=198936 Attachment 227798: Add a "Do this automatically from now on" checkbox, v4 https://bugzilla.mozilla.org/attachment.cgi?id=227798&action=edit ------- Additional Comments from Jens Bannmann <jens.b@web.de> Carrying over r=bienvenu, sr=mscott. Renamed the pref to mail.purge.ask and fixed Scott's nits. ...

superreview granted: [Bug 239984] [OSX] "Minimize Window" and "Zoom Window" in the "Window" menu, cannot be chosen. : [Attachment 162779] Minimize & zoom frontend patch
Scott MacGregor <mscott@mozilla.org> has granted Asaf Romano <bugs.mano@mail-central.com>'s request for superreview: Bug 239984: [OSX] "Minimize Window" and "Zoom Window" in the "Window" menu, cannot be chosen. https://bugzilla.mozilla.org/show_bug.cgi?id=239984 Attachment 162779: Minimize & zoom frontend patch https://bugzilla.mozilla.org/attachment.cgi?id=162779&action=edit ...

superreview granted: [Bug 242346] "Customize Character Encoding" dialog doesn't remember its size and position and is opened to small when using larger fonts : [Attachment 147494] Patch
Alec Flett <alecf@flett.org> has granted Stefan Borggraefe <Stefan.Borggraefe@gmx.de>'s request for superreview: Bug 242346: "Customize Character Encoding" dialog doesn't remember its size and position and is opened to small when using larger fonts http://bugzilla.mozilla.org/show_bug.cgi?id=242346 Attachment 147494: Patch http://bugzilla.mozilla.org/attachment.cgi?id=147494&action=edit ------- Additional Comments from Alec Flett <alecf@flett.org> sr=alecf ...

Web resources about - superreview granted: [Bug 350693] "Character Encoding" in "View Source" window doesn't work : [Attachment 236818] Patch - mozilla.dev.super-review

Resources last updated: 1/19/2016 10:01:17 AM