superreview granted: [Bug 349419] "Unexpected load type value" assertion after entering a URL needing fixup : [Attachment 234708] fixes the assertion by introducing a new nsIDocShellLoadInfo type

Boris Zbarsky <bzbarsky@mit.edu> has granted Christian Biesinger (:bi) (CA)
(Google) <cbiesinger@gmx.at>'s request for superreview:
Bug 349419: "Unexpected load type value" assertion after entering a URL needing
fixup
https://bugzilla.mozilla.org/show_bug.cgi?id=349419

Attachment 234708: fixes the assertion by introducing a new nsIDocShellLoadInfo
type
https://bugzilla.mozilla.org/attachment.cgi?id=234708&action=edit

------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu>
Man.  We so need to fix this mess.  Can we find someone to do it for 1.9?

sr=bzbarsky
0
bugzilla
8/30/2006 4:40:22 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
398 Views

Similar Articles

[PageSpeed] 3

Reply:

Similar Artilces:

superreview requested: [Bug 349419] "Unexpected load type value" assertion after entering a URL needing fixup : [Attachment 234708] fixes the assertion by introducing a new nsIDocShellLoadInfo type
Christian Biesinger (:bi) (CA) (Google) <cbiesinger@gmx.at> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 349419: "Unexpected load type value" assertion after entering a URL needing fixup https://bugzilla.mozilla.org/show_bug.cgi?id=349419 Attachment 234708: fixes the assertion by introducing a new nsIDocShellLoadInfo type https://bugzilla.mozilla.org/attachment.cgi?id=234708&action=edit ------- Additional Comments from Christian Biesinger (:bi) (CA) (Google) <cbiesinger@gmx.at> looks ok to me ...

superreview granted: [Bug 409565] "ASSERTION: unexpected frame type" with -moz-column, float, svg : [Attachment 304895] patch
Robert O'Callahan (:roc) <roc@ocallahan.org> has granted Jonathan Watt <jwatt@jwatt.org>'s request for superreview: Bug 409565: "ASSERTION: unexpected frame type" with -moz-column, float, svg https://bugzilla.mozilla.org/show_bug.cgi?id=409565 Attachment 304895: patch https://bugzilla.mozilla.org/attachment.cgi?id=304895&action=edit ...

superreview requested: [Bug 344888] Bogus assertion: "ASSERTION: invalid length type" : [Attachment 229425] patch removing the assertion from several files
Jesse Ruderman <jruderman@gmail.com> has asked T Rowley (IBM) <tor@acm.org> for superreview: Bug 344888: Bogus assertion: "ASSERTION: invalid length type" https://bugzilla.mozilla.org/show_bug.cgi?id=344888 Attachment 229425: patch removing the assertion from several files https://bugzilla.mozilla.org/attachment.cgi?id=229425&action=edit ...

superreview granted: [Bug 307616] <input type="image"> with missing image gives "ASSERTION: Form control has a frame, but it's not a form frame" : [Attachment 207080] patch
Boris Zbarsky (out of town Dec 12 -- Jan 2) <bzbarsky@mit.edu> has granted Boris Zbarsky (out of town Dec 12 -- Jan 2) <bzbarsky@mit.edu>'s request for superreview: Bug 307616: <input type="image"> with missing image gives "ASSERTION: Form control has a frame, but it's not a form frame" https://bugzilla.mozilla.org/show_bug.cgi?id=307616 Attachment 207080: patch https://bugzilla.mozilla.org/attachment.cgi?id=207080&action=edit ------- Additional Comments from Boris Zbarsky (out of town Dec 12 -- Jan 2) <bzbarsky@mit.edu> Yep...

superreview granted: [Bug 288331] [FIX]Removing type attribute on an <input type="checkbox"> does not work : [Attachment 179095] Fix
Johnny Stenback <jst@mozilla.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 288331: [FIX]Removing type attribute on an <input type="checkbox"> does not work https://bugzilla.mozilla.org/show_bug.cgi?id=288331 Attachment 179095: Fix https://bugzilla.mozilla.org/attachment.cgi?id=179095&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> r+sr=jst ...

superreview granted: [Bug 344888] Bogus assertion: "ASSERTION: invalid length type"
T Rowley (IBM) <tor@acm.org> has granted Jesse Ruderman <jruderman@gmail.com>'s request for superreview: Bug 344888: Bogus assertion: "ASSERTION: invalid length type" https://bugzilla.mozilla.org/show_bug.cgi?id=344888 Attachment 229425: patch removing the assertion from several files https://bugzilla.mozilla.org/attachment.cgi?id=229425&action=edit ...

superreview granted: [Bug 224215] Edit Attribute says "Enter the attribute name" instead of "Enter the attribute value" : [Attachment 134494] fix
Heikki Toivonen <hjtoi-bugzilla@comcast.net> has granted timeless@myrealbox.com <timeless@bemail.org>'s request for superreview: Bug 224215: Edit Attribute says "Enter the attribute name" instead of "Enter the attribute value" http://bugzilla.mozilla.org/show_bug.cgi?id=224215 Attachment 134494: fix http://bugzilla.mozilla.org/attachment.cgi?id=134494&action=edit ...

superreview granted: [Bug 342923] [FIX]"ASSERTION: Unexpected CSS rule" putting certain SVG in HTML (not XHTML) document : [Attachment 245317] Fix
David Baron <dbaron@mozilla.com> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 342923: [FIX]"ASSERTION: Unexpected CSS rule" putting certain SVG in HTML (not XHTML) document https://bugzilla.mozilla.org/show_bug.cgi?id=342923 Attachment 245317: Fix https://bugzilla.mozilla.org/attachment.cgi?id=245317&action=edit ...

superreview granted: [Bug 408782] [FIX]Inconsistent display of <input type= "image"> when "alt" attribute is removed : [Attachment 293629] Simple fix
David Baron [:dbaron] <dbaron@mozilla.com> has granted Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu>'s request for superreview: Bug 408782: [FIX]Inconsistent display of <input type="image"> when "alt" attribute is removed https://bugzilla.mozilla.org/show_bug.cgi?id=408782 Attachment 293629: Simple fix https://bugzilla.mozilla.org/attachment.cgi?id=293629&action=edit ------- Additional Comments from David Baron [:dbaron] <dbaron@mozilla.com> r+sr=dbaron ...

superreview granted: [Bug 370933] "ASSERTION: aBlock must be a block" with <input type="file">
Boris Zbarsky <bzbarsky@mit.edu> has granted superreview: Bug 370933: "ASSERTION: aBlock must be a block" with <input type="file"> https://bugzilla.mozilla.org/show_bug.cgi?id=370933 Attachment 255726: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=255726&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Makes sense, and good catch! ...

superreview granted: [Bug 409291] "ASSERTION: Uh, an nsIXPConnectWrappedNative with the wrong JSClass or getObjectOps hooks" : [Attachment 294129] Fix the assertion
Johnny Stenback (:jst) <jst@mozilla.org> has granted Blake Kaplan <mrbkap@gmail.com>'s request for superreview: Bug 409291: "ASSERTION: Uh, an nsIXPConnectWrappedNative with the wrong JSClass or getObjectOps hooks" https://bugzilla.mozilla.org/show_bug.cgi?id=409291 Attachment 294129: Fix the assertion https://bugzilla.mozilla.org/attachment.cgi?id=294129&action=edit ------- Additional Comments from Johnny Stenback (:jst) <jst@mozilla.org> Thanks mrbkap, r+sr=jst ...

superreview granted: [Bug 370933] "ASSERTION: aBlock must be a block" with <input type="file"> #2
Boris Zbarsky <bzbarsky@mit.edu> has granted superreview: Bug 370933: "ASSERTION: aBlock must be a block" with <input type="file"> https://bugzilla.mozilla.org/show_bug.cgi?id=370933 Attachment 255726: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=255726&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Let's take this to fix the asserts and then we can work on eliminating uses of this CID for determining block-frame-ness. ...

superreview granted: [Bug 452415] Switch from <textbox type="timed"> to type="search" : [Attachment 335715] Patch for mailnews/base/
David Bienvenu <bienvenu@nventure.com> has granted neil@parkwaycc.co.uk <neil@httl.net>'s request for superreview: Bug 452415: Switch from <textbox type="timed"> to type="search" https://bugzilla.mozilla.org/show_bug.cgi?id=452415 Attachment 335715: Patch for mailnews/base/ https://bugzilla.mozilla.org/attachment.cgi?id=335715&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> yes, afaik it's shared. TB doesn't have its own. Will the timeout for quick search change now? ...

superreview granted: [Bug 345620] "text-shadow: menutext; " causes "ASSERTION: Must be a color value" : [Attachment 230521] patch
Boris Zbarsky <bzbarsky@mit.edu> has granted David Baron <dbaron@mozilla.com>'s request for superreview: Bug 345620: "text-shadow: menutext;" causes "ASSERTION: Must be a color value" https://bugzilla.mozilla.org/show_bug.cgi?id=345620 Attachment 230521: patch https://bugzilla.mozilla.org/attachment.cgi?id=230521&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> r+sr=bzbarsky ...

Web resources about - superreview granted: [Bug 349419] "Unexpected load type value" assertion after entering a URL needing fixup : [Attachment 234708] fixes the assertion by introducing a new nsIDocShellLoadInfo type - mozilla.dev.super-review

Resources last updated: 12/15/2015 6:45:24 AM