superreview granted: [Bug 345521] "return 0" in handler cancels events : [Attachment 232080] Patch to fix and test event cancel behaviour

Boris Zbarsky <bzbarsky@mit.edu> has granted Mark Hammond
<mhammond@skippinet.com.au>'s request for superreview:
Bug 345521: "return 0" in handler cancels events
https://bugzilla.mozilla.org/show_bug.cgi?id=345521

Attachment 232080: Patch to fix and test event cancel behaviour
https://bugzilla.mozilla.org/attachment.cgi?id=232080&action=edit

------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu>
r+sr=bzbarsky.	Does anyone ever run that test?  ;)
0
bugzilla
8/4/2006 3:05:15 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
584 Views

Similar Articles

[PageSpeed] 31

Reply:

Similar Artilces:

superreview requested: [Bug 345521] "return 0" in handler cancels events : [Attachment 232080] Patch to fix and test event cancel behaviour
Mark Hammond <mhammond@skippinet.com.au> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 345521: "return 0" in handler cancels events https://bugzilla.mozilla.org/show_bug.cgi?id=345521 Attachment 232080: Patch to fix and test event cancel behaviour https://bugzilla.mozilla.org/attachment.cgi?id=232080&action=edit ------- Additional Comments from Mark Hammond <mhammond@skippinet.com.au> Here is a patch that fixes this behaviour, and a simple test for the existing dom/tests/html/jshandlers.html file. I can also confirm that IE behav...

superreview cancelled: [Bug 299221] [CLEANUP] assign "isChar" inside gecko event conversion : [Attachment 187762] fix v1.0
Josh Aas <joshmoz@gmail.com> has cancelled Josh Aas <joshmoz@gmail.com>'s request for superreview: Bug 299221: [CLEANUP] assign "isChar" inside gecko event conversion https://bugzilla.mozilla.org/show_bug.cgi?id=299221 Attachment 187762: fix v1.0 https://bugzilla.mozilla.org/attachment.cgi?id=187762&action=edit ...

superreview granted: [Bug 291198] "overflow" and "underflow" events are missing detail attribute : [Attachment 181327] Fix for bug
David Baron <dbaron@mozillafoundation.org> has granted Nate Nielsen <nielsen@memberwebs.com>'s request for superreview: Bug 291198: "overflow" and "underflow" events are missing detail attribute https://bugzilla.mozilla.org/show_bug.cgi?id=291198 Attachment 181327: Fix for bug https://bugzilla.mozilla.org/attachment.cgi?id=181327&action=edit ...

superreview granted: [Bug 257801] Pressing "Cancel" in the "Defer Account?" warning closes the "Advanced Account Settings" dialog : [Attachment 157725] Fix
David Bienvenu <bienvenu@nventure.com> has granted Stefan Borggraefe <Stefan.Borggraefe@gmx.de>'s request for superreview: Bug 257801: Pressing "Cancel" in the "Defer Account?" warning closes the "Advanced Account Settings" dialog http://bugzilla.mozilla.org/show_bug.cgi?id=257801 Attachment 157725: Fix http://bugzilla.mozilla.org/attachment.cgi?id=157725&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> thx. I'm in the middle of making changes to this code, but I don't think this wil...

superreview granted: [Bug 422009] [FIX]"Assertion failure: !cx->throwing" with XBL constructor that throws and syntax error in event handler : [Attachment 310421] Fix
Johnny Stenback (:jst) <jst@mozilla.org> has granted Boris Zbarsky (reviews very slow until May) <bzbarsky@mit.edu>'s request for superreview: Bug 422009: [FIX]"Assertion failure: !cx->throwing" with XBL constructor that throws and syntax error in event handler https://bugzilla.mozilla.org/show_bug.cgi?id=422009 Attachment 310421: Fix https://bugzilla.mozilla.org/attachment.cgi?id=310421&action=edit ...

superreview granted: [Bug 341463] Firefox emits focus event before "window:activate" event : [Attachment 225530] patch
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted superreview: Bug 341463: Firefox emits focus event before "window:activate" event https://bugzilla.mozilla.org/show_bug.cgi?id=341463 Attachment 225530: patch https://bugzilla.mozilla.org/attachment.cgi?id=225530&action=edit ...

superreview granted: [Bug 216237] Stopping event propagation should not cancel system event group handlers : [Attachment 129837] patch
Johnny Stenback <jst@netscape.com> has granted Brian Ryner <bryner@brianryner.com>'s request for superreview: Bug 216237: Stopping event propagation should not cancel system event group handlers http://bugzilla.mozilla.org/show_bug.cgi?id=216237 Attachment 129837: patch http://bugzilla.mozilla.org/attachment.cgi?id=129837&action=edit ------- Additional Comments from Johnny Stenback <jst@netscape.com> sr=jst ...

superreview cancelled: [Bug 234847] "overflow:hidden" doesn't hide events : [Attachment 141791] patch
Bernd <bernd_mozilla@gmx.de> has cancelled Bernd <bernd_mozilla@gmx.de>'s request for superreview: Bug 234847: "overflow:hidden" doesn't hide events http://bugzilla.mozilla.org/show_bug.cgi?id=234847 Attachment 141791: patch http://bugzilla.mozilla.org/attachment.cgi?id=141791&action=edit ...

superreview granted: [Bug 410820] <svg> elements respond to mouse events when they should not : [Attachment 304607] patch for pointer-events="none" case
Robert O'Callahan (:roc) (Mozilla Corporation) <roc@ocallahan.org> has granted Jonathan Watt <jwatt@jwatt.org>'s request for superreview: Bug 410820: <svg> elements respond to mouse events when they should not https://bugzilla.mozilla.org/show_bug.cgi?id=410820 Attachment 304607: patch for pointer-events="none" case https://bugzilla.mozilla.org/attachment.cgi?id=304607&action=edit ...

superreview granted: [Bug 299221] [CLEANUP] assign "isChar" inside gecko event conversion : [Attachment 187762] fix v1.0
Simon Fraser <sfraser_bugs@smfr.org> has granted Simon Fraser <sfraser_bugs@smfr.org>'s request for superreview: Bug 299221: [CLEANUP] assign "isChar" inside gecko event conversion https://bugzilla.mozilla.org/show_bug.cgi?id=299221 Attachment 187762: fix v1.0 https://bugzilla.mozilla.org/attachment.cgi?id=187762&action=edit ...

superreview canceled: [Bug 406909] check for widget destruction after sending events in scrollwheel and flagsChanged event handlers : [Attachment 291598] fix v1.0
Robert O'Callahan (:roc) <roc@ocallahan.org> has canceled Josh Aas <joshmoz@gmail.com>'s request for superreview: Bug 406909: check for widget destruction after sending events in scrollwheel and flagsChanged event handlers https://bugzilla.mozilla.org/show_bug.cgi?id=406909 Attachment 291598: fix v1.0 https://bugzilla.mozilla.org/attachment.cgi?id=291598&action=edit ...

superreview cancelled: [Bug 342715] Need an API to allow extensions to hook "document load started" events : [Attachment 227032] patch
Robert O'Callahan (Novell) <roc@ocallahan.org> has cancelled Robert O'Callahan (Novell) <roc@ocallahan.org>'s request for superreview: Bug 342715: Need an API to allow extensions to hook "document load started" events https://bugzilla.mozilla.org/show_bug.cgi?id=342715 Attachment 227032: patch https://bugzilla.mozilla.org/attachment.cgi?id=227032&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> Updated comment. Also, I changed the flags combination to STATE_TRANSFERRING|STATE_IS_REQUEST|S...

superreview cancelled: [Bug 299221] [CLEANUP] assign "isChar" inside gecko event conversion : [Attachment 187852] fix v1.1
Mike Pinkerton <pinkerton@aol.net> has cancelled Josh Aas <joshmoz@gmail.com>'s request for superreview: Bug 299221: [CLEANUP] assign "isChar" inside gecko event conversion https://bugzilla.mozilla.org/show_bug.cgi?id=299221 Attachment 187852: fix v1.1 https://bugzilla.mozilla.org/attachment.cgi?id=187852&action=edit ------- Additional Comments from Mike Pinkerton <pinkerton@aol.net> well then... ...

superreview cancelled: [Bug 199262] Swap "Mark" and "Junk" Buttons (so that "Next" and "Mark" buttons are next to each other) : [Attachment 118601] patch that swaps the "Mark" and "Junk" buttons
Adam Becevello <bugs@abecevello.imapmail.org> has cancelled Adam Becevello <bugs@abecevello.imapmail.org>'s request for superreview: Bug 199262: Swap "Mark" and "Junk" Buttons (so that "Next" and "Mark" buttons are next to each other) https://bugzilla.mozilla.org/show_bug.cgi?id=199262 Attachment 118601: patch that swaps the "Mark" and "Junk" buttons https://bugzilla.mozilla.org/attachment.cgi?id=118601&action=edit ------- Additional Comments from Adam Becevello <bugs@abecevello.imapmail.org> Remo...

Web resources about - superreview granted: [Bug 345521] "return 0" in handler cancels events : [Attachment 232080] Patch to fix and test event cancel behaviour - mozilla.dev.super-review

Resources last updated: 1/1/2016 9:32:52 AM