superreview granted: [Bug 344215] <xul:observes/> with no attributes triggers "ASSERTION: getElementById(""), fix caller?" : [Attachment 229189] Patch rev. 1

Jonas Sicking <bugmail@sicking.cc> has granted	superreview:
Bug 344215: <xul:observes/> with no attributes triggers "ASSERTION:
getElementById(""), fix caller?"
https://bugzilla.mozilla.org/show_bug.cgi?id=344215

Attachment 229189: Patch rev. 1
https://bugzilla.mozilla.org/attachment.cgi?id=229189&action=edit
0
bugzilla
7/19/2006 1:23:51 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
455 Views

Similar Articles

[PageSpeed] 56

Reply:

Similar Artilces:

superreview requested: [Bug 344215] <xul:observes/> with no attributes triggers "ASSERTION: getElementById(""), fix caller?" : [Attachment 229189] Patch rev. 1
Mats Palmgren <mats.palmgren@bredband.net> has asked Jonas Sicking <bugmail@sicking.cc> for superreview: Bug 344215: <xul:observes/> with no attributes triggers "ASSERTION: getElementById(""), fix caller?" https://bugzilla.mozilla.org/show_bug.cgi?id=344215 Attachment 229189: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=229189&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> Return NS_FINDBROADCASTER_NOT_FOUND when there is no/empty "element" attribute. (as we do in th...

superreview granted: [Bug 226958] Bug 197315, "other" files: Convert <window class="dialog"> to <dialog> : [Attachment 136628] <xpistatus.*> patch v3
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 226958: Bug 197315, "other" files: Convert <window class="dialog"> to <dialog> http://bugzilla.mozilla.org/show_bug.cgi?id=226958 Attachment 136628: <xpistatus.*> patch v3 http://bugzilla.mozilla.org/attachment.cgi?id=136628&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> I checked in the patch with ben's changes. ...

superreview granted: [Bug 429157] <object type="image/png"> (with no data attribute) trigger PFS : [Attachment 315872] Patch rev. 1
Johnny Stenback (:jst) <jst@mozilla.org> has granted Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 429157: <object type="image/png"> (with no data attribute) trigger PFS https://bugzilla.mozilla.org/show_bug.cgi?id=429157 Attachment 315872: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=315872&action=edit ...

superreview granted: [Bug 391979] -moz-column-width in "ch" units triggers "ASSERTION: column-count and column-width can't both be auto" : [ Attachment 293370] Patch rev. 1
Robert O'Callahan (:roc) <roc@ocallahan.org> has granted Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 391979: -moz-column-width in "ch" units triggers "ASSERTION: column-count and column-width can't both be auto" https://bugzilla.mozilla.org/show_bug.cgi?id=391979 Attachment 293370: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=293370&action=edit ...

superreview requested: [Bug 427928] "ASSERTION: Non-border-colors case with borderColorStyleCount < 1 or > 3" and "ASSERTION: Unhandled border style" with <table style="outline: auto; "></table> : [At
Mats Palmgren <mats.palmgren@bredband.net> has asked David Baron [:dbaron] <dbaron@mozilla.com> for superreview: Bug 427928: "ASSERTION: Non-border-colors case with borderColorStyleCount < 1 or > 3" and "ASSERTION: Unhandled border style" with <table style="outline: auto;"></table> https://bugzilla.mozilla.org/show_bug.cgi?id=427928 Attachment 314802: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=314802&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> Not sure...

superreview denied: [Bug 427928] "ASSERTION: Non-border-colors case with borderColorStyleCount < 1 or > 3" and "ASSERTION: Unhandled border style" with <table style="outline: auto; "></table> : [Attac
David Baron [:dbaron] <dbaron@mozilla.com> has denied Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 427928: "ASSERTION: Non-border-colors case with borderColorStyleCount < 1 or > 3" and "ASSERTION: Unhandled border style" with <table style="outline: auto;"></table> https://bugzilla.mozilla.org/show_bug.cgi?id=427928 Attachment 314802: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=314802&action=edit ...

superreview granted: [Bug 408782] [FIX]Inconsistent display of <input type= "image"> when "alt" attribute is removed : [Attachment 293629] Simple fix
David Baron [:dbaron] <dbaron@mozilla.com> has granted Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu>'s request for superreview: Bug 408782: [FIX]Inconsistent display of <input type="image"> when "alt" attribute is removed https://bugzilla.mozilla.org/show_bug.cgi?id=408782 Attachment 293629: Simple fix https://bugzilla.mozilla.org/attachment.cgi?id=293629&action=edit ------- Additional Comments from David Baron [:dbaron] <dbaron@mozilla.com> r+sr=dbaron ...

superreview granted: [Bug 403249] [FIX]"ASSERTION: How did that happen??" with <col>, changing "span" attribute
Robert O'Callahan (:roc) <roc@ocallahan.org> has granted Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu>'s request for superreview: Bug 403249: [FIX]"ASSERTION: How did that happen??" with <col>, changing "span" attribute https://bugzilla.mozilla.org/show_bug.cgi?id=403249 Attachment 288234: Proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=288234&action=edit ...

superreview granted: [Bug 389196] "ASSERTION: Unhandled border style" and more with "border-left-style: hidden; " : [Attachment 293360] Patch rev . 1
Vladimir Vukicevic (:vlad) <vladimir@pobox.com> has granted Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 389196: "ASSERTION: Unhandled border style" and more with "border-left-style: hidden;" https://bugzilla.mozilla.org/show_bug.cgi?id=389196 Attachment 293360: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=293360&action=edit ...

superreview granted: [Bug 226958] Bug 197315, "other" files: Convert <window class="dialog"> to <dialog> : [Attachment 137732] (Cv2c) <Wallet*.*>
Alec Flett <alecf@flett.org> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 226958: Bug 197315, "other" files: Convert <window class="dialog"> to <dialog> http://bugzilla.mozilla.org/show_bug.cgi?id=226958 Attachment 137732: (Cv2c) <Wallet*.*> http://bugzilla.mozilla.org/attachment.cgi?id=137732&action=edit ------- Additional Comments from Alec Flett <alecf@flett.org> damn, nice cleanup sr=alecf assuming it all works well. ...

superreview requested: [Bug 226958] Bug 197315, "other" files: Convert <window class="dialog"> to <dialog> : [Attachment 136628] <xpistatus.*> patch v3
Serge GAUTHERIE <gautheri@noos.fr> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 226958: Bug 197315, "other" files: Convert <window class="dialog"> to <dialog> http://bugzilla.mozilla.org/show_bug.cgi?id=226958 Attachment 136628: <xpistatus.*> patch v3 http://bugzilla.mozilla.org/attachment.cgi?id=136628&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> 'approval1.6b=?': Trivial U.I. code cleanup. ...

superreview granted: [Bug 418133] [FIX]"Assertion failure: !JS_IsExceptionPending(cx)" with <xul:preferences> : [Attachment 306201] Possible patch
Brendan Eich <brendan@mozilla.org> has granted Boris Zbarsky (reviews very slow until May) <bzbarsky@mit.edu>'s request for superreview: Bug 418133: [FIX]"Assertion failure: !JS_IsExceptionPending(cx)" with <xul:preferences> https://bugzilla.mozilla.org/show_bug.cgi?id=418133 Attachment 306201: Possible patch https://bugzilla.mozilla.org/attachment.cgi?id=306201&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> >+ // If EvaluateStringWithValue() threw an exception, just report it now. >+ // Failure to ...

superreview granted: [Bug 322773] <iframe src="bogus:"> triggers "ASSERTION: nsPrompt used too early on window object!" : [Attachment 208821] Yeah, it should
Boris Zbarsky <bzbarsky@mit.edu> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 322773: <iframe src="bogus:"> triggers "ASSERTION: nsPrompt used too early on window object!" https://bugzilla.mozilla.org/show_bug.cgi?id=322773 Attachment 208821: Yeah, it should https://bugzilla.mozilla.org/attachment.cgi?id=208821&action=edit ...

superreview granted: [Bug 49813] "threadsafe" nsDirectoryIndexStream uses nsDirEnumeratorUnix triggering "not thread-safe" assertion : [Attachment 134810] fix caller, skip the useless member
Darin Fisher <darin@meer.net> has granted Darin Fisher <darin@meer.net>'s request for superreview: Bug 49813: "threadsafe" nsDirectoryIndexStream uses nsDirEnumeratorUnix triggering "not thread-safe" assertion http://bugzilla.mozilla.org/show_bug.cgi?id=49813 Attachment 134810: fix caller, skip the useless member http://bugzilla.mozilla.org/attachment.cgi?id=134810&action=edit ------- Additional Comments from Darin Fisher <darin@meer.net> r+sr=darin w/ dir cloning dropped. ...

Web resources about - superreview granted: [Bug 344215] <xul:observes/> with no attributes triggers "ASSERTION: getElementById(""), fix caller?" : [Attachment 229189] Patch rev. 1 - mozilla.dev.super-review

Resources last updated: 11/29/2015 8:38:59 PM