superreview granted: [Bug 341436] ###!!! ASSERTION: URI is empty: '!aURI.IsEmpty()', file c:/mozilla.org/baseline/mozilla/rdf/base/src/nsRDFService.cpp, line 978 : [Attachment 225493] Don't pass null

neil@parkwaycc.co.uk <neil@httl.net> has granted Alex Vincent
<ajvincent@gmail.com>'s request for superreview:
Bug 341436: ###!!! ASSERTION: URI is empty: '!aURI.IsEmpty()', file
c:/mozilla.org/baseline/mozilla/rdf/base/src/nsRDFService.cpp, line 978
https://bugzilla.mozilla.org/show_bug.cgi?id=341436

Attachment 225493: Don't pass null in.
https://bugzilla.mozilla.org/attachment.cgi?id=225493&action=edit

------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net>
Nit: adding a blank line after the return would make the code look nicer.
0
bugzilla
6/14/2006 9:15:53 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
695 Views

Similar Articles

[PageSpeed] 32

Reply:

Similar Artilces:

superreview granted: [Bug 392698] ASSERTION: can' t mark frame dirty during reflow: '!mIsReflowing', file layout/base/ nsPresShell.cpp, line 3099 resizing given URL : [Attachment 293817] like this?
Robert O'Callahan (:roc) <roc@ocallahan.org> has granted superreview: Bug 392698: ASSERTION: can't mark frame dirty during reflow: '!mIsReflowing', file layout/base/nsPresShell.cpp, line 3099 resizing given URL https://bugzilla.mozilla.org/show_bug.cgi?id=392698 Attachment 293817: like this? https://bugzilla.mozilla.org/attachment.cgi?id=293817&action=edit ------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.org> + mIsRoot && mOuter->GetParent()->GetFirstChild(nsGkAtoms::fixedList)) { This aditional check...

superreview granted: [Bug 139568] [FIX]ASSERT: nsFrameManager::GenerateStateKey didn't find content by type!: 'index > -1', file nsFrameManager.cpp, line 2261 : [Attachment 172218] Patch
Johnny Stenback <jst@mozilla.jstenback.com> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 139568: [FIX]ASSERT: nsFrameManager::GenerateStateKey didn't find content by type!: 'index > -1', file nsFrameManager.cpp, line 2261 https://bugzilla.mozilla.org/show_bug.cgi?id=139568 Attachment 172218: Patch https://bugzilla.mozilla.org/attachment.cgi?id=172218&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> nsCOMPtr<nsIHTMLDocument> htmlDocument(do_QueryInterface(aConten...

superreview granted: [Bug 217896] ASSERTION: nsMemoryImpl::Alloc of 0: 'size' in GlobalWindowImpl::Unescape : [Attachment 130691] don't do silly things that don't make sense
Johnny Stenback <jst@netscape.com> has granted timeless@myrealbox.com <timeless@bemail.org>'s request for superreview: Bug 217896: ASSERTION: nsMemoryImpl::Alloc of 0: 'size' in GlobalWindowImpl::Unescape http://bugzilla.mozilla.org/show_bug.cgi?id=217896 Attachment 130691: don't do silly things that don't make sense http://bugzilla.mozilla.org/attachment.cgi?id=130691&action=edit ------- Additional Comments from Johnny Stenback <jst@netscape.com> sr=jst ...

superreview granted: [Bug 319642] ASSERTION: unexpected null pointer: 'aParticipant', file nsDOMClassInfo.cpp, line 4960 : [Attachment 206365] patch
Boris Zbarsky (out of town Dec 12 -- Jan 2) <bzbarsky@mit.edu> has granted David Baron <dbaron@mozilla.com>'s request for superreview: Bug 319642: ASSERTION: unexpected null pointer: 'aParticipant', file nsDOMClassInfo.cpp, line 4960 https://bugzilla.mozilla.org/show_bug.cgi?id=319642 Attachment 206365: patch https://bugzilla.mozilla.org/attachment.cgi?id=206365&action=edit ...

superreview granted: [Bug 452438] ASSERTION: null data pointer: 'Not Reached', file nsTSubstring.cpp, line 667 : [Attachment 335837] trivial patch v1
Robert O'Callahan (:roc) (Mozilla Corporation) <roc@ocallahan.org> has granted Daniel Holbert [:dholbert] <dholbert@mozilla.com>'s request for superreview: Bug 452438: ASSERTION: null data pointer: 'Not Reached', file nsTSubstring.cpp, line 667 https://bugzilla.mozilla.org/show_bug.cgi?id=452438 Attachment 335837: trivial patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=335837&action=edit ...

superreview granted: [Bug 306909] nsHTMLDocument::GenerateParserKey ###!!! ASSERTION: You can't dereference a NULL nsCOMPtr with operator->().: 'mRawPtr != 0', file : [Attachment 196861] one that ac
Johnny Stenback <jst@mozilla.org> has granted Johnny Stenback <jst@mozilla.org>'s request for superreview: Bug 306909: nsHTMLDocument::GenerateParserKey ###!!! ASSERTION: You can't dereference a NULL nsCOMPtr with operator->().: 'mRawPtr != 0', file https://bugzilla.mozilla.org/show_bug.cgi?id=306909 Attachment 196861: one that actually compiles https://bugzilla.mozilla.org/attachment.cgi?id=196861&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> nsHTMLDocument::GenerateParserKey(void) { // The script lo...

superreview requested: [Bug 139568] ASSERT: nsFrameManager::GenerateStateKey didn't find content by type!: 'index > -1', file nsFrameManager.cpp, line 2261 : [Attachment 172218] Patch
Boris Zbarsky <bzbarsky@mit.edu> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 139568: ASSERT: nsFrameManager::GenerateStateKey didn't find content by type!: 'index > -1', file nsFrameManager.cpp, line 2261 https://bugzilla.mozilla.org/show_bug.cgi?id=139568 Attachment 172218: Patch https://bugzilla.mozilla.org/attachment.cgi?id=172218&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> This is the right thing to do. If this causes pageload issues, I'll remove the flush, but the assert ...

superreview granted: [Bug 363654] .url files opened via File:Open don't open/don't open properly on the 1.8.0 branch : [Attachment 248458] disables .url in file:open
Stuart Morgan <stuart.morgan@alumni.case.edu> has granted Smokey Ardisson (unreliable; no bugmail) <alqahira@ardisson.org>'s request for superreview: Bug 363654: .url files opened via File:Open don't open/don't open properly on the 1.8.0 branch https://bugzilla.mozilla.org/show_bug.cgi?id=363654 Attachment 248458: disables .url in file:open https://bugzilla.mozilla.org/attachment.cgi?id=248458&action=edit ------- Additional Comments from Stuart Morgan <stuart.morgan@alumni.case.edu> Well, that kinda sucks. ...

superreview requested: [Bug 217896] ASSERTION: nsMemoryImpl::Alloc of 0: 'size' in GlobalWindowImpl::Unescape : [Attachment 130691] don't do silly things that don't make sense
timeless@myrealbox.com <timeless@bemail.org> has asked Johnny Stenback <jst@netscape.com> for superreview: Bug 217896: ASSERTION: nsMemoryImpl::Alloc of 0: 'size' in GlobalWindowImpl::Unescape http://bugzilla.mozilla.org/show_bug.cgi?id=217896 Attachment 130691: don't do silly things that don't make sense http://bugzilla.mozilla.org/attachment.cgi?id=130691&action=edit ...

superreview granted: [Bug 337970] nsHTMLDocument doesn't notify the charset resolver of the resolved character set : [Attachment 222017] don't pass null
Boris Zbarsky (gone May 17 -- May 29) <bzbarsky@mit.edu> has granted Gavin Sharp <gavin.sharp@gmail.com>'s request for superreview: Bug 337970: nsHTMLDocument doesn't notify the charset resolver of the resolved character set https://bugzilla.mozilla.org/show_bug.cgi?id=337970 Attachment 222017: don't pass null https://bugzilla.mozilla.org/attachment.cgi?id=222017&action=edit ...

superreview granted: [Bug 340083] Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title in defs : [Attachment 224205] don't create frames for content we don't handle, don't invalidate nond
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted superreview: Bug 340083: Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title in defs https://bugzilla.mozilla.org/show_bug.cgi?id=340083 Attachment 224205: don't create frames for content we don't handle, don't invalidate nondisplay content https://bugzilla.mozilla.org/attachment.cgi?id=224205&action=edit ...

superreview granted: [Bug 271955] "empty" table cells don't include borders in size even when 'empty-cells: show' : [Attachment 167169] patch
Robert O'Callahan <roc@ocallahan.org> has granted David Baron <dbaron@mozilla.org>'s request for superreview: Bug 271955: "empty" table cells don't include borders in size even when 'empty-cells: show' https://bugzilla.mozilla.org/show_bug.cgi?id=271955 Attachment 167169: patch https://bugzilla.mozilla.org/attachment.cgi?id=167169&action=edit ...

superreview granted: [Bug 245619] Don't bother converting result of scripts into a string when the caller doesn't care about the value. : [Attachment 150056] Don't convert the result to a string if t
Brendan Eich <brendan@mozilla.org> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 245619: Don't bother converting result of scripts into a string when the caller doesn't care about the value. http://bugzilla.mozilla.org/show_bug.cgi?id=245619 Attachment 150056: Don't convert the result to a string if the caller doesn't care about the return value. http://bugzilla.mozilla.org/attachment.cgi?id=150056&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> Duh, thanks. r+sr=me....

superreview granted: [Bug 228397] Warning ``assignment to undeclared variable uri'' [xs] in file ``chrome://cookie/content/cookieContextOverlay.xul'', line 53, character 0. : [Attachment 137371] dec
Boris Zbarsky (not in town, no tree) <bz-vacation@mit.edu> has granted timeless@myrealbox.com - traveling <timeless@bemail.org>'s request for superreview: Bug 228397: Warning ``assignment to undeclared variable uri'' [xs] in file ``chrome://cookie/content/cookieContextOverlay.xul'', line 53, character 0. http://bugzilla.mozilla.org/show_bug.cgi?id=228397 Attachment 137371: declare uri http://bugzilla.mozilla.org/attachment.cgi?id=137371&action=edit ------- Additional Comments from Boris Zbarsky (not in town, no tree) <bz-vacation@mit.edu>...

superreview granted: [Bug 228501] Warning ``redeclaration of var i'' in file ``chrome://messenger/content/mailWidgets.xml'', line 1002, character 21. : [Attachment 137448] Make the JS match the C++
Scott MacGregor <mscott@mozilla.org> has granted neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview: Bug 228501: Warning ``redeclaration of var i'' in file ``chrome://messenger/content/mailWidgets.xml'', line 1002, character 21. http://bugzilla.mozilla.org/show_bug.cgi?id=228501 Attachment 137448: Make the JS match the C++ http://bugzilla.mozilla.org/attachment.cgi?id=137448&action=edit ...

Web resources about - superreview granted: [Bug 341436] ###!!! ASSERTION: URI is empty: '!aURI.IsEmpty()', file c:/mozilla.org/baseline/mozilla/rdf/base/src/nsRDFService.cpp, line 978 : [Attachment 225493] Don't pass null - mozilla.dev.super-review

Resources last updated: 1/10/2016 5:18:36 AM