superreview granted: [Bug 341382] [FIX] Crash [@ DoDeletingFrameSubtree] with position:fixed and display: table-caption : [Attachment 227367] Patch rev. 2 (diff -w)

Boris Zbarsky (gone June 26 -- Jul 13) <bzbarsky@mit.edu> has granted 
superreview:
Bug 341382: [FIX] Crash [@ DoDeletingFrameSubtree] with position:fixed and
display: table-caption
https://bugzilla.mozilla.org/show_bug.cgi?id=341382

Attachment 227367: Patch rev. 2 (diff -w)
https://bugzilla.mozilla.org/attachment.cgi?id=227367&action=edit

------- Additional Comments from Boris Zbarsky (gone June 26 -- Jul 13)
<bzbarsky@mit.edu>
> when I read the code I got the impression this is by design.

I suspect it's more likely negligence... Worth filing a followup bug on this
(and citing the bug in a comment in the table code).

r+sr=bzbarsky.	Thanks for doing this!
0
bugzilla
6/28/2006 6:18:08 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
537 Views

Similar Articles

[PageSpeed] 40

Reply:

Similar Artilces:

superreview granted: [Bug 286137] Crash [@ nsIFrame::Invalidate] with this evil testcase, using display:table-caption and then reloading page : [Attachment 180979] patch that fixes the crash (for me
Boris Zbarsky <bzbarsky@mit.edu> has granted Bernd <bernd_mozilla@gmx.de>'s request for superreview: Bug 286137: Crash [@ nsIFrame::Invalidate] with this evil testcase, using display:table-caption and then reloading page https://bugzilla.mozilla.org/show_bug.cgi?id=286137 Attachment 180979: patch that fixes the crash (for me at least) https://bugzilla.mozilla.org/attachment.cgi?id=180979&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Right. Makes sense to me. ...

superreview granted: [Bug 355993] [FIX]Crash [@ nsIFrame::GetPositionIgnoringScrolling] with MathML table, position: fixed : [Attachment 241733] So this also fixes the problem, as expected
rbs@maths.uq.edu.au has granted superreview: Bug 355993: [FIX]Crash [@ nsIFrame::GetPositionIgnoringScrolling] with MathML table, position: fixed https://bugzilla.mozilla.org/show_bug.cgi?id=355993 Attachment 241733: So this also fixes the problem, as expected https://bugzilla.mozilla.org/attachment.cgi?id=241733&action=edit ------- Additional Comments from rbs@maths.uq.edu.au Let's go for this, as there is no latent apprehension that the positioning might awake and bite us. (Since it is not conceivable to have math without matrices, commutative diagrams and the likes,...

superreview granted: [Bug 275746] [FIX]Crash [@ nsTableRowFrame::IR_TargetIsChild] when clicking in drop down list, when changing from display:table-cell to display:inline : [Attachment 172377] Fix f
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 275746: [FIX]Crash [@ nsTableRowFrame::IR_TargetIsChild] when clicking in drop down list, when changing from display:table-cell to display:inline https://bugzilla.mozilla.org/show_bug.cgi?id=275746 Attachment 172377: Fix for the new crash https://bugzilla.mozilla.org/attachment.cgi?id=172377&action=edit ...

superreview cancelled: [Bug 355993] [FIX]Crash [@ nsIFrame::GetPositionIgnoringScrolling] with MathML table, position: fixed : [Attachment 241723] Fixes the crash for me
Boris Zbarsky <bzbarsky@mit.edu> has cancelled Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 355993: [FIX]Crash [@ nsIFrame::GetPositionIgnoringScrolling] with MathML table, position: fixed https://bugzilla.mozilla.org/show_bug.cgi?id=355993 Attachment 241723: Fixes the crash for me https://bugzilla.mozilla.org/attachment.cgi?id=241723&action=edit ...

superreview granted: [Bug 363248] [reflow branch] Table caption regression : [Attachment 305672] patch 4 of 4: fix horizontal positions of top/bottom captions
Robert O'Callahan (:roc) <roc@ocallahan.org> has granted David Baron [:dbaron] <dbaron@mozilla.com>'s request for superreview: Bug 363248: [reflow branch] Table caption regression https://bugzilla.mozilla.org/show_bug.cgi?id=363248 Attachment 305672: patch 4 of 4: fix horizontal positions of top/bottom captions https://bugzilla.mozilla.org/attachment.cgi?id=305672&action=edit ------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.org> looks good except I still don't understand how we get the right horizontal caption margins f...

superreview granted: [Bug 291520] Crash [@ nsFrameList::DestroyFrames] with evil testcase using float:right and display:table-caption : [Attachment 181732] alternative crash fix
Boris Zbarsky <bzbarsky@mit.edu> has granted Bernd <bernd_mozilla@gmx.de>'s request for superreview: Bug 291520: Crash [@ nsFrameList::DestroyFrames] with evil testcase using float:right and display:table-caption https://bugzilla.mozilla.org/show_bug.cgi?id=291520 Attachment 181732: alternative crash fix https://bugzilla.mozilla.org/attachment.cgi?id=181732&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> >Index: nsCSSFrameConstructor.cpp >+ HaveSpecialBlockStyle(aContent, aStyleContext, >+ &haveFirstLet...

superreview requested: [Bug 286137] Crash [@ nsIFrame::Invalidate] with this evil testcase, using display:table-caption and then reloading page : [Attachment 180979] patch that fixes the crash (for m
Bernd <bernd_mozilla@gmx.de> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 286137: Crash [@ nsIFrame::Invalidate] with this evil testcase, using display:table-caption and then reloading page https://bugzilla.mozilla.org/show_bug.cgi?id=286137 Attachment 180979: patch that fixes the crash (for me at least) https://bugzilla.mozilla.org/attachment.cgi?id=180979&action=edit ...

superreview granted: [Bug 363248] [reflow branch] Table caption regression : [Attachment 305670] patch 2 of 4: fix top/bottom caption sizing, and split old behavior into top-outside/bottom-outside
Robert O'Callahan (:roc) <roc@ocallahan.org> has granted David Baron [:dbar= on] <dbaron@mozilla.com>'s request for superreview: Bug 363248: [reflow branch] Table caption regression https://bugzilla.mozilla.org/show_bug.cgi?id=3D363248 Attachment 305670: patch 2 of 4: fix top/bottom caption sizing, and split o= ld behavior into top-outside/bottom-outside https://bugzilla.mozilla.org/attachment.cgi?id=3D305670&action=3Dedit ------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.or= g> + case NS_STYLE_CAPTION_SIDE_BOTTOM:=0D + ...

superreview granted: [Bug 355993] [FIX]Crash [@ nsIFrame::GetPositionIgnoringScrolling] with MathML table, position: fixed : [Attachment 241787] Lightly tweaked
rbs@maths.uq.edu.au has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 355993: [FIX]Crash [@ nsIFrame::GetPositionIgnoringScrolling] with MathML table, position: fixed https://bugzilla.mozilla.org/show_bug.cgi?id=355993 Attachment 241787: Lightly tweaked https://bugzilla.mozilla.org/attachment.cgi?id=241787&action=edit ------- Additional Comments from rbs@maths.uq.edu.au sr=rbs ...

superreview granted: [Bug 206021] [FIX] Crash on quit [@ nsImageMap::FreeAreas] : [Attachment 178653] patch rev. 2
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted David Baron <dbaron@mozilla.org>'s request for superreview: Bug 206021: [FIX] Crash on quit [@ nsImageMap::FreeAreas] https://bugzilla.mozilla.org/show_bug.cgi?id=206021 Attachment 178653: patch rev. 2 https://bugzilla.mozilla.org/attachment.cgi?id=178653&action=edit ...

superreview granted: [Bug 295292] [FIX]crash when using fixed positioning, with no data rendered inside element[@nsFrame::BoxReflow ] : [Attachment 184708] Proposed patch
Robert O'Callahan (Novell) (offline May 23-June 6) <rocallahan@gmail.com> has granted Boris Zbarsky (gone June 3 -- June 30) <bzbarsky@mit.edu>'s request for superreview: Bug 295292: [FIX]crash when using fixed positioning, with no data rendered inside element[@nsFrame::BoxReflow ] https://bugzilla.mozilla.org/show_bug.cgi?id=295292 Attachment 184708: Proposed patch https://bugzilla.mozilla.org/attachment.cgi?id=184708&action=edit ...

superreview granted: [Bug 226637] Wrong table width when the table has "table-layout:fixed;" and fixed width and larger width cells than the table width. : [Attachment 162390] patch
Boris Zbarsky <bzbarsky@mit.edu> has granted Bernd <bernd_mozilla@gmx.de>'s request for superreview: Bug 226637: Wrong table width when the table has "table-layout:fixed;" and fixed width and larger width cells than the table width. https://bugzilla.mozilla.org/show_bug.cgi?id=226637 Attachment 162390: patch https://bugzilla.mozilla.org/attachment.cgi?id=162390&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> r+sr=bzbarsky ...

superreview granted: [Bug 278983] [FIX] Print Preview crashes: table+thead+page-break-before:always : [Attachment 172225] Patch rev. 1
Boris Zbarsky <bzbarsky@mit.edu> has granted Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 278983: [FIX] Print Preview crashes: table+thead+page-break-before:always https://bugzilla.mozilla.org/show_bug.cgi?id=278983 Attachment 172225: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=172225&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> > nsTableFrame::PageBreakAfter(nsIFrame& aSourceFrame, > nsIFrame* aNextFrame) >+ // don't allow a page break after a repeate...

superreview granted: [Bug 354510] [FIX]Crash [@ nsBlockBandData::Init] when moving mathml:geq inside html:span with display:table with removed mathml.css rule : [Attachment 240390] Fix more wonderful
rbs@maths.uq.edu.au has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 354510: [FIX]Crash [@ nsBlockBandData::Init] when moving mathml:geq inside html:span with display:table with removed mathml.css rule https://bugzilla.mozilla.org/show_bug.cgi?id=354510 Attachment 240390: Fix more wonderful inconsistencies between tables and MathML tables https://bugzilla.mozilla.org/attachment.cgi?id=240390&action=edit ------- Additional Comments from rbs@maths.uq.edu.au r+sr=rbs ...

superreview granted: [Bug 236450] [FIX] noscript element with display type set is rendered even if javascript is enabled : [Attachment 170133] Patch rev. 2
Boris Zbarsky <bzbarsky@mit.edu> has granted Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 236450: [FIX] noscript element with display type set is rendered even if javascript is enabled https://bugzilla.mozilla.org/show_bug.cgi?id=236450 Attachment 170133: Patch rev. 2 https://bugzilla.mozilla.org/attachment.cgi?id=170133&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> r+sr=bzbarsky ...

Web resources about - superreview granted: [Bug 341382] [FIX] Crash [@ DoDeletingFrameSubtree] with position:fixed and display: table-caption : [Attachment 227367] Patch rev. 2 (diff -w) - mozilla.dev.super-review

Resources last updated: 11/21/2015 12:13:18 AM