superreview granted: [Bug 341382] [FIX] Crash [@ DoDeletingFrameSubtree] with position:fixed and display: table-caption : [Attachment 225787] Patch rev. 1 (diff -w)

Boris Zbarsky (gone June 26 -- Jul 13) <bzbarsky@mit.edu> has granted 
superreview:
Bug 341382: [FIX] Crash [@ DoDeletingFrameSubtree] with position:fixed and
display: table-caption
https://bugzilla.mozilla.org/show_bug.cgi?id=341382

Attachment 225787: Patch rev. 1 (diff -w)
https://bugzilla.mozilla.org/attachment.cgi?id=225787&action=edit

------- Additional Comments from Boris Zbarsky (gone June 26 -- Jul 13)
<bzbarsky@mit.edu>
>Index: layout/generic/nsFrameList.cpp
>+	NS_ASSERTION(!aParent || aParent == aPrevSibling->GetParent(),
>+		     "prev sibling have different parent");
>	nsIFrame* nextFrame = aPrevSibling->GetNextSibling();
>+	NS_ASSERTION(!nextFrame || !aParent || aParent ==
nextFrame->GetParent(),
>+		     "next sibling have different parent");

s/have/has/ in both strings.  Why the !aParent check for the next sibling?

>Index: layout/tables/nsTableFrame.cpp
> nsTableFrame::RemoveFrame(nsIAtom*	    aListName,
>   if (NS_STYLE_DISPLAY_TABLE_COLUMN_GROUP == display->mDisplay) {
>+    NS_ASSERTION(!aListName || aListName == nsLayoutAtoms::colGroupList,
>+		   "unexpected child list");

Can we just assert aListName == nsLayoutAtoms::colGroupList here?  We're
certainly assuming that mColGroups is the thing to mess with...

r+sr=bzbarsky with the nits resolved (either changed, or explained).
0
bugzilla
6/27/2006 9:06:13 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
559 Views

Similar Articles

[PageSpeed] 8

Reply:

Similar Artilces:

superreview granted: [Bug 286137] Crash [@ nsIFrame::Invalidate] with this evil testcase, using display:table-caption and then reloading page : [Attachment 180979] patch that fixes the crash (for me
Boris Zbarsky <bzbarsky@mit.edu> has granted Bernd <bernd_mozilla@gmx.de>'s request for superreview: Bug 286137: Crash [@ nsIFrame::Invalidate] with this evil testcase, using display:table-caption and then reloading page https://bugzilla.mozilla.org/show_bug.cgi?id=286137 Attachment 180979: patch that fixes the crash (for me at least) https://bugzilla.mozilla.org/attachment.cgi?id=180979&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Right. Makes sense to me. ...

superreview granted: [Bug 278983] [FIX] Print Preview crashes: table+thead+page-break-before:always : [Attachment 172225] Patch rev. 1
Boris Zbarsky <bzbarsky@mit.edu> has granted Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 278983: [FIX] Print Preview crashes: table+thead+page-break-before:always https://bugzilla.mozilla.org/show_bug.cgi?id=278983 Attachment 172225: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=172225&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> > nsTableFrame::PageBreakAfter(nsIFrame& aSourceFrame, > nsIFrame* aNextFrame) >+ // don't allow a page break after a repeate...

superreview granted: [Bug 299188] [FIX] CSS position:relative on input tag within fieldset tag crashes browser : [Attachment 187834] Patch rev. 1
David Baron <dbaron@mozillafoundation.org> has granted Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 299188: [FIX] CSS position:relative on input tag within fieldset tag crashes browser https://bugzilla.mozilla.org/show_bug.cgi?id=299188 Attachment 187834: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=187834&action=edit ...

superreview granted: [Bug 355993] [FIX]Crash [@ nsIFrame::GetPositionIgnoringScrolling] with MathML table, position: fixed : [Attachment 241733] So this also fixes the problem, as expected
rbs@maths.uq.edu.au has granted superreview: Bug 355993: [FIX]Crash [@ nsIFrame::GetPositionIgnoringScrolling] with MathML table, position: fixed https://bugzilla.mozilla.org/show_bug.cgi?id=355993 Attachment 241733: So this also fixes the problem, as expected https://bugzilla.mozilla.org/attachment.cgi?id=241733&action=edit ------- Additional Comments from rbs@maths.uq.edu.au Let's go for this, as there is no latent apprehension that the positioning might awake and bite us. (Since it is not conceivable to have math without matrices, commutative diagrams and the likes,...

superreview granted: [Bug 275746] [FIX]Crash [@ nsTableRowFrame::IR_TargetIsChild] when clicking in drop down list, when changing from display:table-cell to display:inline : [Attachment 172377] Fix f
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 275746: [FIX]Crash [@ nsTableRowFrame::IR_TargetIsChild] when clicking in drop down list, when changing from display:table-cell to display:inline https://bugzilla.mozilla.org/show_bug.cgi?id=275746 Attachment 172377: Fix for the new crash https://bugzilla.mozilla.org/attachment.cgi?id=172377&action=edit ...

superreview cancelled: [Bug 355993] [FIX]Crash [@ nsIFrame::GetPositionIgnoringScrolling] with MathML table, position: fixed : [Attachment 241723] Fixes the crash for me
Boris Zbarsky <bzbarsky@mit.edu> has cancelled Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 355993: [FIX]Crash [@ nsIFrame::GetPositionIgnoringScrolling] with MathML table, position: fixed https://bugzilla.mozilla.org/show_bug.cgi?id=355993 Attachment 241723: Fixes the crash for me https://bugzilla.mozilla.org/attachment.cgi?id=241723&action=edit ...

superreview granted: [Bug 275232] [FIX]The theme "Plastikfox Crystal SVG 1.5.1" make this build of firefox crash on startup [@JS_CloneFunctionObject] : [Attachment 171957] Patch that should fix this
Brian Ryner (IBM) <bryner@brianryner.com> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 275232: [FIX]The theme "Plastikfox Crystal SVG 1.5.1" make this build of firefox crash on startup [@JS_CloneFunctionObject] https://bugzilla.mozilla.org/show_bug.cgi?id=275232 Attachment 171957: Patch that should fix this https://bugzilla.mozilla.org/attachment.cgi?id=171957&action=edit ...

superreview granted: [Bug 291520] Crash [@ nsFrameList::DestroyFrames] with evil testcase using float:right and display:table-caption : [Attachment 181732] alternative crash fix
Boris Zbarsky <bzbarsky@mit.edu> has granted Bernd <bernd_mozilla@gmx.de>'s request for superreview: Bug 291520: Crash [@ nsFrameList::DestroyFrames] with evil testcase using float:right and display:table-caption https://bugzilla.mozilla.org/show_bug.cgi?id=291520 Attachment 181732: alternative crash fix https://bugzilla.mozilla.org/attachment.cgi?id=181732&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> >Index: nsCSSFrameConstructor.cpp >+ HaveSpecialBlockStyle(aContent, aStyleContext, >+ &haveFirstLet...

superreview granted: [Bug 363248] [reflow branch] Table caption regression : [Attachment 305672] patch 4 of 4: fix horizontal positions of top/bottom captions
Robert O'Callahan (:roc) <roc@ocallahan.org> has granted David Baron [:dbaron] <dbaron@mozilla.com>'s request for superreview: Bug 363248: [reflow branch] Table caption regression https://bugzilla.mozilla.org/show_bug.cgi?id=363248 Attachment 305672: patch 4 of 4: fix horizontal positions of top/bottom captions https://bugzilla.mozilla.org/attachment.cgi?id=305672&action=edit ------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.org> looks good except I still don't understand how we get the right horizontal caption margins f...

superreview requested: [Bug 286137] Crash [@ nsIFrame::Invalidate] with this evil testcase, using display:table-caption and then reloading page : [Attachment 180979] patch that fixes the crash (for m
Bernd <bernd_mozilla@gmx.de> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 286137: Crash [@ nsIFrame::Invalidate] with this evil testcase, using display:table-caption and then reloading page https://bugzilla.mozilla.org/show_bug.cgi?id=286137 Attachment 180979: patch that fixes the crash (for me at least) https://bugzilla.mozilla.org/attachment.cgi?id=180979&action=edit ...

superreview granted: [Bug 147446] [FIX] A map definition inside a table and outside the tr element will add an extra space to the table : [Attachment 126246] Patch rev. 1
David Baron <dbaron@mozilla.org> has granted Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 147446: [FIX] A map definition inside a table and outside the tr element will add an extra space to the table https://bugzilla.mozilla.org/show_bug.cgi?id=147446 Attachment 126246: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=126246&action=edit ...

superreview granted: [Bug 201897] [FIX] shrink-wrap absolutely positioned boxes, right of container, have 0 width : [Attachment 168077] Patch B rev. 1 (correction for rev. 10)
David Baron <dbaron@mozilla.org> has granted Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 201897: [FIX] shrink-wrap absolutely positioned boxes, right of container, have 0 width https://bugzilla.mozilla.org/show_bug.cgi?id=201897 Attachment 168077: Patch B rev. 1 (correction for rev. 10) https://bugzilla.mozilla.org/attachment.cgi?id=168077&action=edit ...

superreview granted: [Bug 355993] [FIX]Crash [@ nsIFrame::GetPositionIgnoringScrolling] with MathML table, position: fixed : [Attachment 241787] Lightly tweaked
rbs@maths.uq.edu.au has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 355993: [FIX]Crash [@ nsIFrame::GetPositionIgnoringScrolling] with MathML table, position: fixed https://bugzilla.mozilla.org/show_bug.cgi?id=355993 Attachment 241787: Lightly tweaked https://bugzilla.mozilla.org/attachment.cgi?id=241787&action=edit ------- Additional Comments from rbs@maths.uq.edu.au sr=rbs ...

superreview granted: [Bug 332611] [FIX] Crash when viewing this xbm image : [Attachment 234778] Patch rev. 1
Stuart Parmenter <pavlov@pavlov.net> has granted superreview: Bug 332611: [FIX] Crash when viewing this xbm image https://bugzilla.mozilla.org/show_bug.cgi?id=332611 Attachment 234778: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=234778&action=edit ...

superreview granted: [Bug 224091] [FIX] crash on loading of page [@ DoCleanupFrameReferences ] : [Attachment 134595] Patch rev. 1
David Baron <dbaron@dbaron.org> has granted Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 224091: [FIX] crash on loading of page [@ DoCleanupFrameReferences ] http://bugzilla.mozilla.org/show_bug.cgi?id=224091 Attachment 134595: Patch rev. 1 http://bugzilla.mozilla.org/attachment.cgi?id=134595&action=edit ...

Web resources about - superreview granted: [Bug 341382] [FIX] Crash [@ DoDeletingFrameSubtree] with position:fixed and display: table-caption : [Attachment 225787] Patch rev. 1 (diff -w) - mozilla.dev.super-review

Resources last updated: 12/1/2015 6:13:57 AM