superreview granted: [Bug 340119] [FIX]Changing print preview settings makes <noscript> tags appear : [Attachment 224204] Maybe this will make life better?

Jonas Sicking <bugmail@sicking.cc> has granted Boris Zbarsky
<bzbarsky@mit.edu>'s request for superreview:
Bug 340119: [FIX]Changing print preview settings makes <noscript> tags appear
https://bugzilla.mozilla.org/show_bug.cgi?id=340119

Attachment 224204: Maybe this will make life better?
https://bugzilla.mozilla.org/attachment.cgi?id=224204&action=edit
0
bugzilla
6/2/2006 7:58:14 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
515 Views

Similar Articles

[PageSpeed] 42

Reply:

Similar Artilces:

superreview requested: [Bug 340119] Changing print preview settings makes <noscript> tags appear : [Attachment 224204] Maybe this will make life better?
Boris Zbarsky <bzbarsky@mit.edu> has asked Jonas Sicking <bugmail@sicking.cc> for superreview: Bug 340119: Changing print preview settings makes <noscript> tags appear https://bugzilla.mozilla.org/show_bug.cgi?id=340119 Attachment 224204: Maybe this will make life better? https://bugzilla.mozilla.org/attachment.cgi?id=224204&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> sicking, could you review? ...

superreview granted: [Bug 344258] Make <svg:use> live to id changes in document : [Attachment 325903] part 4: Use nsReferencedElement to track ID-map changes for <use>
Mats Palmgren <mats.palmgren@bredband.net> has granted Robert O'Callahan (:= roc) <roc@ocallahan.org>'s request for superreview: Bug 344258: Make <svg:use> live to id changes in document https://bugzilla.mozilla.org/show_bug.cgi?id=3D344258 Attachment 325903: part 4: Use nsReferencedElement to track ID-map changes = for <use> https://bugzilla.mozilla.org/attachment.cgi?id=3D325903&action=3Dedit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> Looks good to me. sr=3Dmats=0D =0D > content/svg/content/src/nsSV...

superreview granted: [Bug 277434] Setting .type property on <object> element doesn't create an HTML attribute type : [Attachment 187457] Make setting .type change the type attr
Peter Van der Beken <peterv@propagandism.org> has granted Johnny Stenback <jst@mozilla.org>'s request for superreview: Bug 277434: Setting .type property on <object> element doesn't create an HTML attribute type https://bugzilla.mozilla.org/show_bug.cgi?id=277434 Attachment 187457: Make setting .type change the type attr https://bugzilla.mozilla.org/attachment.cgi?id=187457&action=edit ------- Additional Comments from Peter Van der Beken <peterv@propagandism.org> Yeah, switch to nsACString, also maybe rename mType to mActualType. ...

superreview granted: [Bug 238989] whitespace after a </b> tag is ignored when enclosed inside <fieldset></fieldset> tags : [Attachment 145302] This should fix it
Peter Van der Beken <peterv@propagandism.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 238989: whitespace after a </b> tag is ignored when enclosed inside <fieldset></fieldset> tags http://bugzilla.mozilla.org/show_bug.cgi?id=238989 Attachment 145302: This should fix it http://bugzilla.mozilla.org/attachment.cgi?id=145302&action=edit ------- Additional Comments from Peter Van der Beken <peterv@propagandism.org> Fine by me, although I don't really understand why we'd want kOmitWS at all. ...

superreview granted: [Bug 230816] [FIX]Make <constructor>/<destructor> methods, not handlers : [Attachment 154323] Taadaa.
Brendan Eich <brendan@mozilla.org> has granted Boris Zbarsky (no tree till Sept 10) <bzbarsky@mit.edu>'s request for superreview: Bug 230816: [FIX]Make <constructor>/<destructor> methods, not handlers http://bugzilla.mozilla.org/show_bug.cgi?id=230816 Attachment 154323: Taadaa. http://bugzilla.mozilla.org/attachment.cgi?id=154323&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> >@@ -134,28 +134,28 @@ nsXBLContentSink::FlushText(PRBool aCrea > else if (mState == eXBL_InImplementation) { > if (mSecon...

superreview granted: [Bug 48376] [FIX]all inline element end tags (e.g. </code>, </tt>) in <dl> eats up whitespace after it : [Attachment 145376] Fix
Peter Van der Beken <peterv@propagandism.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 48376: [FIX]all inline element end tags (e.g. </code>, </tt>) in <dl> eats up whitespace after it http://bugzilla.mozilla.org/show_bug.cgi?id=48376 Attachment 145376: Fix http://bugzilla.mozilla.org/attachment.cgi?id=145376&action=edit ------- Additional Comments from Peter Van der Beken <peterv@propagandism.org> What choess said :-). ...

superreview granted: [Bug 334944] [FIX]Firefox printing content of <noscript> tag : [Attachment 219314] Evil hack
Johnny Stenback <jst@mozilla.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 334944: [FIX]Firefox printing content of <noscript> tag https://bugzilla.mozilla.org/show_bug.cgi?id=334944 Attachment 219314: Evil hack https://bugzilla.mozilla.org/attachment.cgi?id=219314&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> r+sr=jst ...

superreview granted: [Bug 340564] Print/Print Preview does not print text in <input text> or <textarea> : [Attachment 243735] Patch
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted superreview: Bug 340564: Print/Print Preview does not print text in <input text> or <textarea> https://bugzilla.mozilla.org/show_bug.cgi?id=340564 Attachment 243735: Patch https://bugzilla.mozilla.org/attachment.cgi?id=243735&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> thanks! the new textframe kills all this horrible code. ...

superreview granted: [Bug 271996] [FIX]Setting page title in javascript does not work if <title></title> tags are omitted or empty. : [Attachment 170367] Patch
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 271996: [FIX]Setting page title in javascript does not work if <title></title> tags are omitted or empty. https://bugzilla.mozilla.org/show_bug.cgi?id=271996 Attachment 170367: Patch https://bugzilla.mozilla.org/attachment.cgi?id=170367&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> >- text->SetText(mTitle, PR_TRUE); >+ text->SetText(title, P...

superreview granted: [Bug 282735] [FIX]XBL treats <children> tags in all namespaces as <xbl:children> : [Attachment 174709] Diff -w for ease of review
Johnny Stenback <jst@mozilla.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 282735: [FIX]XBL treats <children> tags in all namespaces as <xbl:children> https://bugzilla.mozilla.org/show_bug.cgi?id=282735 Attachment 174709: Diff -w for ease of review https://bugzilla.mozilla.org/attachment.cgi?id=174709&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> +nsXBLPrototypeBinding::GetNestedChildren(): + if (child->IsContentOfType(nsIContent::eELEMENT) && + child->GetNod...

superreview granted: [Bug 344258] Make <svg:use> live to id changes in document : [Attachment 325897] part 2: make XUL use the base ID-table
Johnny Stenback (:jst) <jst@mozilla.org> has granted Robert O'Callahan (:roc) <roc@ocallahan.org>'s request for superreview: Bug 344258: Make <svg:use> live to id changes in document https://bugzilla.mozilla.org/show_bug.cgi?id=344258 Attachment 325897: part 2: make XUL use the base ID-table https://bugzilla.mozilla.org/attachment.cgi?id=325897&action=edit ...

superreview granted: [Bug 288991] An <iframe> before a <frameset> makes the <frameset> fail to render : [Attachment 179742] patch v1
Boris Zbarsky <bzbarsky@mit.edu> has granted Blake Kaplan <mrbkap@gmail.com>'s request for superreview: Bug 288991: An <iframe> before a <frameset> makes the <frameset> fail to render https://bugzilla.mozilla.org/show_bug.cgi?id=288991 Attachment 179742: patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=179742&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> r+sr=bzbarsky ...

superreview granted: [Bug 362140] SVG <use> doesn't render when pointing to a <symbol> : [Attachment 246858] make inner <svg> responsible for coordinate systems
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted T Rowley (IBM) <tor@acm.org>'s request for superreview: Bug 362140: SVG <use> doesn't render when pointing to a <symbol> https://bugzilla.mozilla.org/show_bug.cgi?id=362140 Attachment 246858: make inner <svg> responsible for coordinate systems https://bugzilla.mozilla.org/attachment.cgi?id=246858&action=edit ...

superreview requested: [Bug 344258] Make <svg:use> live to id changes in document : [Attachment 325903] part 4: Use nsReferencedElement to track ID-map changes for <use>
Robert O'Callahan (:roc) <roc@ocallahan.org> has asked Mats Palmgren <mats.palmgren@bredband.net> for superreview: Bug 344258: Make <svg:use> live to id changes in document https://bugzilla.mozilla.org/show_bug.cgi?id=344258 Attachment 325903: part 4: Use nsReferencedElement to track ID-map changes for <use> https://bugzilla.mozilla.org/attachment.cgi?id=325903&action=edit ------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.org> Ok, since jst approved the nsReferencedElement API let's go for review on the real patc...

superreview granted: [Bug 172525] [ps] print legal size page fails to set '<< /PageSize [612 1008] >> setpagedevice' : [Attachment 135001] Set PageSize and ImagingBBox
<tor@acm.org> has granted timeless@myrealbox.com <timeless@bemail.org>'s request for superreview: Bug 172525: [ps] print legal size page fails to set '<< /PageSize [612 1008] >> setpagedevice' http://bugzilla.mozilla.org/show_bug.cgi?id=172525 Attachment 135001: Set PageSize and ImagingBBox http://bugzilla.mozilla.org/attachment.cgi?id=135001&action=edit ...

superreview granted: [Bug 344258] Make <svg:use> live to id changes in document : [Attachment 325900] part 3: Infrastructure for tracking ID-map changes
Johnny Stenback (:jst) <jst@mozilla.org> has granted Robert O'Callahan (:roc) <roc@ocallahan.org>'s request for superreview: Bug 344258: Make <svg:use> live to id changes in document https://bugzilla.mozilla.org/show_bug.cgi?id=344258 Attachment 325900: part 3: Infrastructure for tracking ID-map changes https://bugzilla.mozilla.org/attachment.cgi?id=325900&action=edit ...

superreview requested: [Bug 277434] Setting .type property on <object> element doesn't create an HTML attribute type : [Attachment 187457] Make setting .type change the type attr
Johnny Stenback <jst@mozilla.org> has asked Peter Van der Beken <peterv@propagandism.org> for superreview: Bug 277434: Setting .type property on <object> element doesn't create an HTML attribute type https://bugzilla.mozilla.org/show_bug.cgi?id=277434 Attachment 187457: Make setting .type change the type attr https://bugzilla.mozilla.org/attachment.cgi?id=187457&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> This implements what I talked about in my previous comment. ...

superreview requested: [Bug 238989] whitespace after a </b> tag is ignored when enclosed inside <fieldset></fieldset> tags : [Attachment 145302] This should fix it
Boris Zbarsky <bzbarsky@mit.edu> has asked Peter Van der Beken <peterv@propagandism.org> for superreview: Bug 238989: whitespace after a </b> tag is ignored when enclosed inside <fieldset></fieldset> tags http://bugzilla.mozilla.org/show_bug.cgi?id=238989 Attachment 145302: This should fix it http://bugzilla.mozilla.org/attachment.cgi?id=145302&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> So the problem here was that <fieldset> was marked as a tag which is allowed to discard all direct child whitespace...

superreview requested: [Bug 48376] [FIX]all inline element end tags (e.g. </code>, </tt>) in <dl> eats up whitespace after it : [Attachment 145376] Fix
Boris Zbarsky <bzbarsky@mit.edu> has asked Peter Van der Beken <peterv@propagandism.org> for superreview: Bug 48376: [FIX]all inline element end tags (e.g. </code>, </tt>) in <dl> eats up whitespace after it http://bugzilla.mozilla.org/show_bug.cgi?id=48376 Attachment 145376: Fix http://bugzilla.mozilla.org/attachment.cgi?id=145376&action=edit ...

superreview granted: [Bug 255236] <space> in list item inserts <br> tags instead : [Attachment 155923] Fix
Boris Zbarsky <bzbarsky@mit.edu> has granted Peter Van der Beken <peterv@propagandism.org>'s request for superreview: Bug 255236: <space> in list item inserts <br> tags instead http://bugzilla.mozilla.org/show_bug.cgi?id=255236 Attachment 155923: Fix http://bugzilla.mozilla.org/attachment.cgi?id=155923&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Doh. Copy/paste fun. ;) r+sr=bzbarsky ...

superreview granted: [Bug 293070] [FIX]Ordered lists (<ol> tags) inside <font> display all 0s : [Attachment 183742] Patch
David Baron <dbaron@mozillafoundation.org> has granted Boris Zbarsky (gone June 3 -- June 30) <bzbarsky@mit.edu>'s request for superreview: Bug 293070: [FIX]Ordered lists (<ol> tags) inside <font> display all 0s https://bugzilla.mozilla.org/show_bug.cgi?id=293070 Attachment 183742: Patch https://bugzilla.mozilla.org/attachment.cgi?id=183742&action=edit ...

superreview granted: [Bug 302729] netError.dtd entities can't be formatted prettily : [Attachment 193230] Convert [tag][/tag] in error strings to <tag></tag>
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Jeff Walden (remove +bmo to email) <jwalden+bmo@mit.edu>'s request for superreview: Bug 302729: netError.dtd entities can't be formatted prettily https://bugzilla.mozilla.org/show_bug.cgi?id=302729 Attachment 193230: Convert [tag][/tag] in error strings to <tag></tag> https://bugzilla.mozilla.org/attachment.cgi?id=193230&action=edit ...

superreview granted: [Bug 192557] Each instance of editing an HTML draft/template copies the <head> to the <body> : [Attachment 150948] Make RebuildDocumentFromSource smarter
Scott MacGregor <mscott@mozilla.org> has granted neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview: Bug 192557: Each instance of editing an HTML draft/template copies the <head> to the <body> http://bugzilla.mozilla.org/show_bug.cgi?id=192557 Attachment 150948: Make RebuildDocumentFromSource smarter http://bugzilla.mozilla.org/attachment.cgi?id=150948&action=edit ...

superreview granted: [Bug 410132] position MathML Frames before calling FinishReflowChild() : [ Attachment 295181] FinishReflowChild() with the final position for <msqrt> and <mpadded> and make nsBoun
Robert O'Callahan (:roc) <roc@ocallahan.org> has granted superreview: Bug 410132: position MathML Frames before calling FinishReflowChild() https://bugzilla.mozilla.org/show_bug.cgi?id=410132 Attachment 295181: FinishReflowChild() with the final position for <msqrt> and <mpadded> and make nsBoundingMetrics::operator+= handle empty bounds https://bugzilla.mozilla.org/attachment.cgi?id=295181&action=edit ...

Web resources about - superreview granted: [Bug 340119] [FIX]Changing print preview settings makes <noscript> tags appear : [Attachment 224204] Maybe this will make life better? - mozilla.dev.super-review

Resources last updated: 3/9/2016 3:30:01 PM