superreview granted: [Bug 340083] Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title in defs : [Attachment 224205] don't create frames for content we don't handle, don't invalidate nond

Robert O'Callahan (Novell) <roc@ocallahan.org> has granted  superreview:
Bug 340083: Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title
in defs
https://bugzilla.mozilla.org/show_bug.cgi?id=340083

Attachment 224205: don't create frames for content we don't handle, don't
invalidate nondisplay content
https://bugzilla.mozilla.org/attachment.cgi?id=224205&action=edit
0
bugzilla
6/8/2006 10:23:21 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
979 Views

Similar Articles

[PageSpeed] 25

Reply:

Similar Artilces:

superreview granted: [Bug 245619] Don't bother converting result of scripts into a string when the caller doesn't care about the value. : [Attachment 150056] Don't convert the result to a string if t
Brendan Eich <brendan@mozilla.org> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 245619: Don't bother converting result of scripts into a string when the caller doesn't care about the value. http://bugzilla.mozilla.org/show_bug.cgi?id=245619 Attachment 150056: Don't convert the result to a string if the caller doesn't care about the return value. http://bugzilla.mozilla.org/attachment.cgi?id=150056&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> Duh, thanks. r+sr=me....

superreview granted: [Bug 288532] OOM crash [@ XPCConvert::JSErrorToXPCException] : [Attachment 179228] don't leak and don't crash
rbs@maths.uq.edu.au has granted timeless@myrealbox.com (working) <timeless@bemail.org>'s request for superreview: Bug 288532: OOM crash [@ XPCConvert::JSErrorToXPCException] https://bugzilla.mozilla.org/show_bug.cgi?id=288532 Attachment 179228: don't leak and don't crash https://bugzilla.mozilla.org/attachment.cgi?id=179228&action=edit ------- Additional Comments from rbs@maths.uq.edu.au sr=rbs ...

superreview granted: [Bug 264442] plugin finder can't find anything for windows media. : [Attachment 162212] Don't assume we don't have a plugin before getting a responce from the network.
Boris Zbarsky <bzbarsky@mit.edu> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 264442: plugin finder can't find anything for windows media. https://bugzilla.mozilla.org/show_bug.cgi?id=264442 Attachment 162212: Don't assume we don't have a plugin before getting a responce from the network. https://bugzilla.mozilla.org/attachment.cgi?id=162212&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> r+sr=bzbarsky, I guess.. Is ther a reason mIsBrokenPlugin is write-only? ...

superreview granted: [Bug 333579] Firefox crash with Window-Eyes and DHTML/AJAX : [Attachment 228812] Two fixes for image map a11y: 1) Don't walk into maps so that areas don't show twice in a11y tree,
neil@parkwaycc.co.uk <neil@httl.net> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 333579: Firefox crash with Window-Eyes and DHTML/AJAX https://bugzilla.mozilla.org/show_bug.cgi?id=333579 Attachment 228812: Two fixes for image map a11y: 1) Don't walk into maps so that areas don't show twice in a11y tree, 2) Don't refer to |this| in area constructor, Init() from outside as other accessibles do https://bugzilla.mozilla.org/attachment.cgi?id=228812&action=edit ------- Additional Comments from neil@parkwaycc.co....

superreview granted: [Bug 312788] Crash exposing invisible plugins : [Attachment 199889] Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to cre
Brian Ryner <bryner@brianryner.com> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 312788: Crash exposing invisible plugins https://bugzilla.mozilla.org/show_bug.cgi?id=312788 Attachment 199889: Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to create children for native accessibles (make native accessibles inherit from the leaf class) https://bugzilla.mozilla.org/attachment.cgi?id=199889&action=edit ...

superreview granted: [Bug 217896] ASSERTION: nsMemoryImpl::Alloc of 0: 'size' in GlobalWindowImpl::Unescape : [Attachment 130691] don't do silly things that don't make sense
Johnny Stenback <jst@netscape.com> has granted timeless@myrealbox.com <timeless@bemail.org>'s request for superreview: Bug 217896: ASSERTION: nsMemoryImpl::Alloc of 0: 'size' in GlobalWindowImpl::Unescape http://bugzilla.mozilla.org/show_bug.cgi?id=217896 Attachment 130691: don't do silly things that don't make sense http://bugzilla.mozilla.org/attachment.cgi?id=130691&action=edit ------- Additional Comments from Johnny Stenback <jst@netscape.com> sr=jst ...

superreview granted: [Bug 288574] [FIX]Don't call ValueAppended for DOM changes that don't create the value : [Attachment 180304] Same as diff -w
David Baron <dbaron@mozillafoundation.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 288574: [FIX]Don't call ValueAppended for DOM changes that don't create the value https://bugzilla.mozilla.org/show_bug.cgi?id=288574 Attachment 180304: Same as diff -w https://bugzilla.mozilla.org/attachment.cgi?id=180304&action=edit ...

superreview requested: [Bug 288532] OOM crash [@ XPCConvert::JSErrorToXPCException] : [Attachment 179228] don't leak and don't crash
timeless@myrealbox.com (working) <timeless@bemail.org> has asked rbs@maths.uq.edu.au for superreview: Bug 288532: OOM crash [@ XPCConvert::JSErrorToXPCException] https://bugzilla.mozilla.org/show_bug.cgi?id=288532 Attachment 179228: don't leak and don't crash https://bugzilla.mozilla.org/attachment.cgi?id=179228&action=edit ...

superreview requested: [Bug 264442] plugin finder can't find anything for windows media. : [Attachment 162212] Don't assume we don't have a plugin before getting a responce from the network.
Johnny Stenback <jst@mozilla.jstenback.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 264442: plugin finder can't find anything for windows media. https://bugzilla.mozilla.org/show_bug.cgi?id=264442 Attachment 162212: Don't assume we don't have a plugin before getting a responce from the network. https://bugzilla.mozilla.org/attachment.cgi?id=162212&action=edit ...

superreview requested: [Bug 245619] Don't bother converting result of scripts into a string when the caller doesn't care about the value. : [Attachment 150056] Don't convert the result to a string if
Johnny Stenback <jst@mozilla.jstenback.com> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 245619: Don't bother converting result of scripts into a string when the caller doesn't care about the value. http://bugzilla.mozilla.org/show_bug.cgi?id=245619 Attachment 150056: Don't convert the result to a string if the caller doesn't care about the return value. http://bugzilla.mozilla.org/attachment.cgi?id=150056&action=edit ...

superreview requested: [Bug 333579] Firefox crash with Window-Eyes and DHTML/AJAX : [Attachment 228812] Two fixes for image map a11y: 1) Don't walk into maps so that areas don't show twice in a11y tre
Aaron Leventhal <aaronleventhal@moonset.net> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 333579: Firefox crash with Window-Eyes and DHTML/AJAX https://bugzilla.mozilla.org/show_bug.cgi?id=333579 Attachment 228812: Two fixes for image map a11y: 1) Don't walk into maps so that areas don't show twice in a11y tree, 2) Don't refer to |this| in area constructor, Init() from outside as other accessibles do https://bugzilla.mozilla.org/attachment.cgi?id=228812&action=edit ...

superreview requested: [Bug 312788] Crash exposing invisible plugins : [Attachment 199889] Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to c #2
Aaron Leventhal (vacation: mostly gone until Oct 17) <aaronleventhal@moonset.net> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 312788: Crash exposing invisible plugins https://bugzilla.mozilla.org/show_bug.cgi?id=312788 Attachment 199889: Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to create children for native accessibles (make native accessibles inherit from the leaf class) https://bugzilla.mozilla.org/attachment.cgi?id=199889&action=edit ...

superreview requested: [Bug 312788] Crash exposing invisible plugins : [Attachment 199889] Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to c #3
Aaron Leventhal <aaronleventhal@moonset.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 312788: Crash exposing invisible plugins https://bugzilla.mozilla.org/show_bug.cgi?id=312788 Attachment 199889: Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to create children for native accessibles (make native accessibles inherit from the leaf class) https://bugzilla.mozilla.org/attachment.cgi?id=199889&action=edit ...

superreview requested: [Bug 217896] ASSERTION: nsMemoryImpl::Alloc of 0: 'size' in GlobalWindowImpl::Unescape : [Attachment 130691] don't do silly things that don't make sense
timeless@myrealbox.com <timeless@bemail.org> has asked Johnny Stenback <jst@netscape.com> for superreview: Bug 217896: ASSERTION: nsMemoryImpl::Alloc of 0: 'size' in GlobalWindowImpl::Unescape http://bugzilla.mozilla.org/show_bug.cgi?id=217896 Attachment 130691: don't do silly things that don't make sense http://bugzilla.mozilla.org/attachment.cgi?id=130691&action=edit ...

superreview denied: [Bug 288574] [FIX]Don't call ValueAppended for DOM changes that don't create the value : [Attachment 179246] Like so
David Baron <dbaron@mozilla.org> has denied Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 288574: [FIX]Don't call ValueAppended for DOM changes that don't create the value https://bugzilla.mozilla.org/show_bug.cgi?id=288574 Attachment 179246: Like so https://bugzilla.mozilla.org/attachment.cgi?id=179246&action=edit ------- Additional Comments from David Baron <dbaron@mozilla.org> >@@ -752,17 +758,18 @@ CSSParserImpl::ParseAndAppendDeclaration >+ if (!ParseDeclaration(errorCode, aDeclaration, PR_FALSE, >+ PR_FAL...

superreview requested: [Bug 288574] [FIX]Don't call ValueAppended for DOM changes that don't create the value : [Attachment 179246] Like so
Boris Zbarsky <bzbarsky@mit.edu> has asked David Baron <dbaron@mozilla.org> for superreview: Bug 288574: [FIX]Don't call ValueAppended for DOM changes that don't create the value https://bugzilla.mozilla.org/show_bug.cgi?id=288574 Attachment 179246: Like so https://bugzilla.mozilla.org/attachment.cgi?id=179246&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> This would be simpler if we could depend on the bit on mData, but since we can't... ...

superreview granted: [Bug 302724] nsHostRecord and nsHostResolver are refcounted but don't log : [Attachment 203288] don't put negative numbers into the leak stats
Boris Zbarsky <bzbarsky@mit.edu> has granted David Baron <dbaron@mozilla.com>'s request for superreview: Bug 302724: nsHostRecord and nsHostResolver are refcounted but don't log https://bugzilla.mozilla.org/show_bug.cgi?id=302724 Attachment 203288: don't put negative numbers into the leak stats https://bugzilla.mozilla.org/attachment.cgi?id=203288&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Doh. Thanks for catching this! ...

superreview requested: [Bug 288574] [FIX]Don't call ValueAppended for DOM changes that don't create the value : [Attachment 180304] Same as diff -w
Boris Zbarsky <bzbarsky@mit.edu> has asked David Baron <dbaron@mozillafoundation.org> for superreview: Bug 288574: [FIX]Don't call ValueAppended for DOM changes that don't create the value https://bugzilla.mozilla.org/show_bug.cgi?id=288574 Attachment 180304: Same as diff -w https://bugzilla.mozilla.org/attachment.cgi?id=180304&action=edit ...

superreview granted: [Bug 451234] don't stop plugins from loading just because they don't have a resource file : [Attachment 334535] fix v1.0
Robert O'Callahan (:roc) (Mozilla Corporation) <roc@ocallahan.org> has granted Josh Aas <joshmoz@gmail.com>'s request for superreview: Bug 451234: don't stop plugins from loading just because they don't have a resource file https://bugzilla.mozilla.org/show_bug.cgi?id=451234 Attachment 334535: fix v1.0 https://bugzilla.mozilla.org/attachment.cgi?id=334535&action=edit ...

superreview granted: [Bug 214959] Xdefs.h not found while building with xft support on solaris : [Attachment 129134] Don't use Xdefs.h, and don't #undef Bool
<rbs@maths.uq.edu.au> has granted Matt Selsky <selsky@columbia.edu>'s request for superreview: Bug 214959: Xdefs.h not found while building with xft support on solaris http://bugzilla.mozilla.org/show_bug.cgi?id=214959 Attachment 129134: Don't use Xdefs.h, and don't #undef Bool http://bugzilla.mozilla.org/attachment.cgi?id=129134&action=edit ...

superreview granted: [Bug 338281] SVG drawing doesn't work anymore as expected : [Attachment 222632] invalid path: don't throw error, invalidate
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted superreview: Bug 338281: SVG drawing doesn't work anymore as expected https://bugzilla.mozilla.org/show_bug.cgi?id=338281 Attachment 222632: invalid path: don't throw error, invalidate https://bugzilla.mozilla.org/attachment.cgi?id=222632&action=edit ...

superreview cancelled: [Bug 335755] Extension XUL overlay errors should not create a gray bar : [Attachment 220937] Don't output error message for overlays that don't parse properly
Neil Deakin <enndeakin@sympatico.ca> has cancelled Neil Deakin <enndeakin@sympatico.ca>'s request for superreview: Bug 335755: Extension XUL overlay errors should not create a gray bar https://bugzilla.mozilla.org/show_bug.cgi?id=335755 Attachment 220937: Don't output error message for overlays that don't parse properly https://bugzilla.mozilla.org/attachment.cgi?id=220937&action=edit ...

superreview granted: [Bug 252984] Cannot type in any of the fields
Boris Zbarsky <bzbarsky@mit.edu> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 252984: Cannot type in any of the fields - forms don't get focus on left-click http://bugzilla.mozilla.org/show_bug.cgi?id=252984 Attachment 154483: We actually don't need either nsIFrame::FocusableAncestor() or nsGenericHTMLElement::HandleDOMEvent() anymore http://bugzilla.mozilla.org/attachment.cgi?id=154483&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> If things still work right and someone who...

superreview requested: [Bug 335755] Extension XUL overlay errors should not create a gray bar : [Attachment 220937] Don't output error message for overlays that don't parse properly
Neil Deakin <enndeakin@sympatico.ca> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 335755: Extension XUL overlay errors should not create a gray bar https://bugzilla.mozilla.org/show_bug.cgi?id=335755 Attachment 220937: Don't output error message for overlays that don't parse properly https://bugzilla.mozilla.org/attachment.cgi?id=220937&action=edit ------- Additional Comments from Neil Deakin <enndeakin@sympatico.ca> This patch disables printing out the error message for non-well-formed overlays. The "xul-overlay-parsererror&q...

Web resources about - superreview granted: [Bug 340083] Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title in defs : [Attachment 224205] don't create frames for content we don't handle, don't invalidate nond - mozilla.dev.super-review

Resources last updated: 2/18/2016 12:25:12 PM