superreview granted: [Bug 334193] nsContinueDespiteCertError's default case should set rv : [Attachment 218650] set rv

Boris Zbarsky <bzbarsky@mit.edu> has granted  superreview:
Bug 334193: nsContinueDespiteCertError's default case should set rv
https://bugzilla.mozilla.org/show_bug.cgi?id=334193

Attachment 218650: set rv
https://bugzilla.mozilla.org/attachment.cgi?id=218650&action=edit
0
bugzilla
4/17/2006 6:47:56 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
375 Views

Similar Articles

[PageSpeed] 31

Reply:

Similar Artilces:

superreview requested: [Bug 334193] nsContinueDespiteCertError's default case should set rv : [Attachment 218650] set rv
timeless <timeless@bemail.org> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 334193: nsContinueDespiteCertError's default case should set rv https://bugzilla.mozilla.org/show_bug.cgi?id=334193 Attachment 218650: set rv https://bugzilla.mozilla.org/attachment.cgi?id=218650&action=edit ...

superreview granted: [Bug 280713] ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly : [Attachment 173997] updated to review comments
Boris Zbarsky <bzbarsky@mit.edu> has granted Blake Kaplan <mrbkap@gmail.com>'s request for superreview: Bug 280713: ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly https://bugzilla.mozilla.org/show_bug.cgi?id=280713 Attachment 173997: updated to review comments https://bugzilla.mozilla.org/attachment.cgi?id=173997&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> sr=bzbarsky. Land this either _really_ early in 1.8b2 or in 1.9a.... ...

superreview granted: [Bug 370306] Move Address Book's autocomplete (and addressing widget) implementation to be based on toolkit's : [Attachment 326676] Fix default index setting.
neil@parkwaycc.co.uk <neil@httl.net> has granted Mark Banner <bugzilla@standard8.plus.com>'s request for superreview: Bug 370306: Move Address Book's autocomplete (and addressing widget) implementation to be based on toolkit's https://bugzilla.mozilla.org/show_bug.cgi?id=3D370306 Attachment 326676: Fix default index setting. https://bugzilla.mozilla.org/attachment.cgi?id=3D326676&action=3Dedit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> >+ else=0D >+ result.searchResult =3D ACR.RESULT_NOMATCH;=0D I don't sup...

superreview requested: [Bug 407538] newURI("http://foo.com:80").port is 80, should be -1 (can set a URI's port to it's default value by setting .spec) : [Attachment 292260] patch
Gavin Sharp <gavin.sharp@gmail.com> has asked Christian :Biesinger <cbiesinger@gmx.at> for superreview: Bug 407538: newURI("http://foo.com:80").port is 80, should be -1 (can set a URI's port to it's default value by setting .spec) https://bugzilla.mozilla.org/show_bug.cgi?id=407538 Attachment 292260: patch https://bugzilla.mozilla.org/attachment.cgi?id=292260&action=edit ------- Additional Comments from Gavin Sharp <gavin.sharp@gmail.com> I'm not sure about the XXX comment in the test - seems like we should probably fix that, too, but I&...

superreview granted: [Bug 407538] newURI("http://foo.com:80").port is 80, should be -1 (can set a URI's port to its default value by setting .spec) : [Attachment 292260] patch
Christian :Biesinger <cbiesinger@gmx.at> has granted Gavin Sharp <gavin.sharp@gmail.com>'s request for superreview: Bug 407538: newURI("http://foo.com:80").port is 80, should be -1 (can set a URI's port to its default value by setting .spec) https://bugzilla.mozilla.org/show_bug.cgi?id=407538 Attachment 292260: patch https://bugzilla.mozilla.org/attachment.cgi?id=292260&action=edit ------- Additional Comments from Christian :Biesinger <cbiesinger@gmx.at> would be good to also test that .spec doesn't include the :80 either + //XXX URL ...

superreview granted: [Bug 283342] Many windows don't set window classes : [Attachment 197950] Patch to add a window class to the Default Plugin's window
Johnny Stenback (:jst) <jst@mozilla.org> has granted superreview: Bug 283342: Many windows don't set window classes https://bugzilla.mozilla.org/show_bug.cgi?id=283342 Attachment 197950: Patch to add a window class to the Default Plugin's window https://bugzilla.mozilla.org/attachment.cgi?id=197950&action=edit ...

superreview granted: [Bug 280713] ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly : [Attachment 173127] patch v1
Boris Zbarsky <bzbarsky@mit.edu> has granted Blake Kaplan <mrbkap@gmail.com>'s request for superreview: Bug 280713: ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly https://bugzilla.mozilla.org/show_bug.cgi?id=280713 Attachment 173127: patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=173127&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> sr=bzbarsky, but it sounds like some cleanup of incremental vs final chunk is in order.... ...

superreview requested: [Bug 280713] ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly : [Attachment 173997] updated to review comments
Blake Kaplan <mrbkap@gmail.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 280713: ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly https://bugzilla.mozilla.org/show_bug.cgi?id=280713 Attachment 173997: updated to review comments https://bugzilla.mozilla.org/attachment.cgi?id=173997&action=edit ...

superreview granted: [Bug 216751] general.config.filename set in user's prefs.js overrides setting in all.js : [Attachment 189091] Patch
Brendan Eich <brendan@mozilla.org> has granted Frank Wein <bugzilla@mcsmurf.de>'s request for superreview: Bug 216751: general.config.filename set in user's prefs.js overrides setting in all.js https://bugzilla.mozilla.org/show_bug.cgi?id=216751 Attachment 189091: Patch https://bugzilla.mozilla.org/attachment.cgi?id=189091&action=edit ...

superreview requested: [Bug 370306] Move Address Book's autocomplete (and addressing widget) implementation to be based on toolkit's : [Attachment 326676] Fix default index setting.
Mark Banner <bugzilla@standard8.plus.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 370306: Move Address Book's autocomplete (and addressing widget) implementation to be based on toolkit's https://bugzilla.mozilla.org/show_bug.cgi?id=370306 Attachment 326676: Fix default index setting. https://bugzilla.mozilla.org/attachment.cgi?id=326676&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.plus.com> I was trying out some toolkit things earlier and noticed the defaultIndex implementation in the new sea...

superreview granted: [Bug 346119] Code added in bug 338122 doesn't actually enforce document equality : [Attachment 231004] update prescontext's mDocument when new shell is set.
Boris Zbarsky <bzbarsky@mit.edu> has granted Smaug <Olli.Pettay@gmail.com>'s request for superreview: Bug 346119: Code added in bug 338122 doesn't actually enforce document equality https://bugzilla.mozilla.org/show_bug.cgi?id=346119 Attachment 231004: update prescontext's mDocument when new shell is set. https://bugzilla.mozilla.org/attachment.cgi?id=231004&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Looks good. ...

superreview granted: [Bug 382331] [l10n] Default browser dialogue's "set" button does not resize well : [Attachment 303045] fix
Mike Pinkerton (not reading bugmail) <mikepinkerton@mac.com> has granted Stuart Morgan <stuart.morgan@alumni.case.edu>'s request for superreview: Bug 382331: [l10n] Default browser dialogue's "set" button does not resize well https://bugzilla.mozilla.org/show_bug.cgi?id=382331 Attachment 303045: fix https://bugzilla.mozilla.org/attachment.cgi?id=303045&action=edit ...

superreview granted: [Bug 224088] warning: unused variable `nsresult rv' in member function `nsDocShellEditorData::~nsDocShellEditorData()' : [Attachment 134409] don't store the rv
Peter Van der Beken <peterv@propagandism.org> has granted timeless@myrealbox.com <timeless@bemail.org>'s request for superreview: Bug 224088: warning: unused variable `nsresult rv' in member function `nsDocShellEditorData::~nsDocShellEditorData()' http://bugzilla.mozilla.org/show_bug.cgi?id=224088 Attachment 134409: don't store the rv http://bugzilla.mozilla.org/attachment.cgi?id=134409&action=edit ...

superreview granted: [Bug 279533] Update Camino's font preferences code per bug 95227 (serif/sans-serif set is now per language) / serif / sans-serif pref ui doesn't work : [Attachment 174475] patch
Simon Fraser <sfraser_bugs@smfr.org> has granted Asaf Romano <bugs.mano@mail-central.com>'s request for superreview: Bug 279533: Update Camino's font preferences code per bug 95227 (serif/sans-serif set is now per language) / serif / sans-serif pref ui doesn't work https://bugzilla.mozilla.org/show_bug.cgi?id=279533 Attachment 174475: patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=174475&action=edit ...

Web resources about - superreview granted: [Bug 334193] nsContinueDespiteCertError's default case should set rv : [Attachment 218650] set rv - mozilla.dev.super-review

Resources last updated: 1/23/2016 5:19:03 AM