superreview granted: [Bug 330946] Can drag bookmarks into address book collection of Show All Bookmarks : [Attachment 224328] invalidates drop if it's going to occur on a smart folder's outline view

Mike Pinkerton <mikepinkerton@mac.com> has granted Chris Lawson
<bugzilla@chrislawson.net>'s request for superreview:
Bug 330946: Can drag bookmarks into address book collection of Show All
Bookmarks
https://bugzilla.mozilla.org/show_bug.cgi?id=330946

Attachment 224328: invalidates drop if it's going to occur on a smart folder's
outline view
https://bugzilla.mozilla.org/attachment.cgi?id=224328&action=edit

------- Additional Comments from Mike Pinkerton <mikepinkerton@mac.com>
sr=pink
0
bugzilla
6/6/2006 2:11:01 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
682 Views

Similar Articles

[PageSpeed] 59

Reply:

Similar Artilces:

superreview requested: [Bug 330946] Can drag bookmarks into address book collection of Show All Bookmarks : [Attachment 224328] invalidates drop if it's going to occur on a smart folder's outline view
Chris Lawson <bugzilla@chrislawson.net> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 330946: Can drag bookmarks into address book collection of Show All Bookmarks https://bugzilla.mozilla.org/show_bug.cgi?id=330946 Attachment 224328: invalidates drop if it's going to occur on a smart folder's outline view https://bugzilla.mozilla.org/attachment.cgi?id=224328&action=edit ...

superreview granted: [Bug 338772] Show can't-drop indicator when dragging PTF bookmarks such that they won't move when dropped : [Attachment 233429] patch
jag (Peter Annema) <jag@tty.nl> has granted Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com>'s request for superreview: Bug 338772: Show can't-drop indicator when dragging PTF bookmarks such that they won't move when dropped https://bugzilla.mozilla.org/show_bug.cgi?id=338772 Attachment 233429: patch https://bugzilla.mozilla.org/attachment.cgi?id=233429&action=edit ------- Additional Comments from jag (Peter Annema) <jag@tty.nl> Instead of that comment you could move the second part to a |acceptsBookmarks(aTarget)| function which o...

superreview granted: [Bug 333765] Opening a bookmark in a new tab no longer works when pushing Command after opening a bookmark folder, only before : [Attachment 234645] Addresses hwaara's comments
Mike Pinkerton <mikepinkerton@mac.com> has granted froodian <stridey@gmail.com>'s request for superreview: Bug 333765: Opening a bookmark in a new tab no longer works when pushing Command after opening a bookmark folder, only before https://bugzilla.mozilla.org/show_bug.cgi?id=333765 Attachment 234645: Addresses hwaara's comments https://bugzilla.mozilla.org/attachment.cgi?id=234645&action=edit ------- Additional Comments from Mike Pinkerton <mikepinkerton@mac.com> sr=pink sucks we have to update so much code in so many places to do something like ...

superreview granted: [Bug 370306] Move Address Book's autocomplete (and addressing widget) implementation to be based on toolkit's : [Attachment 323118] autocompletesearchparam
David Bienvenu <bienvenu@nventure.com> has granted neil@parkwaycc.co.uk <neil@httl.net>'s request for superreview: Bug 370306: Move Address Book's autocomplete (and addressing widget) implementation to be based on toolkit's https://bugzilla.mozilla.org/show_bug.cgi?id=370306 Attachment 323118: autocompletesearchparam https://bugzilla.mozilla.org/attachment.cgi?id=323118&action=edit ...

superreview granted: [Bug 370306] Move Address Book's autocomplete (and addressing widget) implementation to be based on toolkit's : [Attachment 325783] MyDomain special @ handling
David Bienvenu <bienvenu@nventure.com> has granted neil@parkwaycc.co.uk <neil@httl.net>'s request for superreview: Bug 370306: Move Address Book's autocomplete (and addressing widget) implementation to be based on toolkit's https://bugzilla.mozilla.org/show_bug.cgi?id=370306 Attachment 325783: MyDomain special @ handling https://bugzilla.mozilla.org/attachment.cgi?id=325783&action=edit ...

superreview granted: [Bug 370306] Move Address Book's autocomplete (and addressing widget) implementation to be based on toolkit's : [Attachment 324755] mydomain using autocompletesearchparam
David Bienvenu <bienvenu@nventure.com> has granted neil@parkwaycc.co.uk <neil@httl.net>'s request for superreview: Bug 370306: Move Address Book's autocomplete (and addressing widget) implementation to be based on toolkit's https://bugzilla.mozilla.org/show_bug.cgi?id=370306 Attachment 324755: mydomain using autocompletesearchparam https://bugzilla.mozilla.org/attachment.cgi?id=324755&action=edit ...

superreview granted: [Bug 370306] Move Address Book's autocomplete (and addressing widget) implementation to be based on toolkit's : [Attachment 326676] Fix default index setting.
neil@parkwaycc.co.uk <neil@httl.net> has granted Mark Banner <bugzilla@standard8.plus.com>'s request for superreview: Bug 370306: Move Address Book's autocomplete (and addressing widget) implementation to be based on toolkit's https://bugzilla.mozilla.org/show_bug.cgi?id=3D370306 Attachment 326676: Fix default index setting. https://bugzilla.mozilla.org/attachment.cgi?id=3D326676&action=3Dedit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> >+ else=0D >+ result.searchResult =3D ACR.RESULT_NOMATCH;=0D I don't sup...

superreview granted: [Bug 370306] Move Address Book's autocomplete (and addressing widget) implementation to be based on toolkit's : [Attachment 322571] Split off autocomplete to my domain into a sepa
David Bienvenu <bienvenu@nventure.com> has granted neil@parkwaycc.co.uk <neil@httl.net>'s request for superreview: Bug 370306: Move Address Book's autocomplete (and addressing widget) implementation to be based on toolkit's https://bugzilla.mozilla.org/show_bug.cgi?id=370306 Attachment 322571: Split off autocomplete to my domain into a separate search https://bugzilla.mozilla.org/attachment.cgi?id=322571&action=edit ...

superreview granted: [Bug 370306] Move Address Book's autocomplete (and addressing widget) implementation to be based on toolkit's : [Attachment 325961] Implement Toolkit interfaces for addrbook searc
David Bienvenu <bienvenu@nventure.com> has granted Mark Banner <bugzilla@standard8.plus.com>'s request for superreview: Bug 370306: Move Address Book's autocomplete (and addressing widget) implementation to be based on toolkit's https://bugzilla.mozilla.org/show_bug.cgi?id=370306 Attachment 325961: Implement Toolkit interfaces for addrbook search v1.2 https://bugzilla.mozilla.org/attachment.cgi?id=325961&action=edit ...

superreview requested: [Bug 338772] Show can't-drop indicator when dragging PTF bookmarks such that they won't move when dropped : [Attachment 233429] patch
Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has asked jag (Peter Annema) <jag@tty.nl> for superreview: Bug 338772: Show can't-drop indicator when dragging PTF bookmarks such that they won't move when dropped https://bugzilla.mozilla.org/show_bug.cgi?id=338772 Attachment 233429: patch https://bugzilla.mozilla.org/attachment.cgi?id=233429&action=edit ------- Additional Comments from Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> Inlining this into the existing return would make it ridiculously long. ...

superreview granted: [Bug 370306] Move Address Book's autocomplete (and addressing widget) implementation to be based on toolkit's : [Attachment 325246] Provide test case for MyDomain and sort out EXT
neil@parkwaycc.co.uk <neil@httl.net> has granted Mark Banner <bugzilla@standard8.plus.com>'s request for superreview: Bug 370306: Move Address Book's autocomplete (and addressing widget) implementation to be based on toolkit's https://bugzilla.mozilla.org/show_bug.cgi?id=370306 Attachment 325246: Provide test case for MyDomain and sort out EXTRA_COMPONENTS in Makefile.in files v2 https://bugzilla.mozilla.org/attachment.cgi?id=325246&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> addrbook autocomplete also special...

superreview granted: [Bug 242760] code cleaning: rechecking checked rc's, dropping a temporary comptr, a comment change : [Attachment 147787] store rc's so ifs can check, drop temporary comptr, chang
Johnny Stenback <jst@mozilla.jstenback.com> has granted timeless@myrealbox.com (working) <timeless@bemail.org>'s request for superreview: Bug 242760: code cleaning: rechecking checked rc's, dropping a temporary comptr, a comment change http://bugzilla.mozilla.org/show_bug.cgi?id=242760 Attachment 147787: store rc's so ifs can check, drop temporary comptr, change comment, check alloc http://bugzilla.mozilla.org/attachment.cgi?id=147787&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> - element->Append...

superreview canceled: [Bug 256065] Bookmarks menu should show tool tip for each folder/bookmark' s description : [Attachment 292229] patch v2a
Bill Gianopoulos <wgianopoulos@yahoo.com> has canceled Bill Gianopoulos <wgianopoulos@yahoo.com>'s request for superreview: Bug 256065: Bookmarks menu should show tool tip for each folder/bookmark's description https://bugzilla.mozilla.org/show_bug.cgi?id=256065 Attachment 292229: patch v2a https://bugzilla.mozilla.org/attachment.cgi?id=292229&action=edit ------- Additional Comments from Bill Gianopoulos <wgianopoulos@yahoo.com> One more try. Make variable name conform to standard. ...

superreview requested: [Bug 256065] Bookmarks menu should show tool tip for each folder/bookmark' s description : [Attachment 292229] patch v2a
Bill Gianopoulos <wgianopoulos@yahoo.com> has asked Mike Connor <mconnor@mozilla.com> for superreview: Bug 256065: Bookmarks menu should show tool tip for each folder/bookmark's description https://bugzilla.mozilla.org/show_bug.cgi?id=256065 Attachment 292229: patch v2a https://bugzilla.mozilla.org/attachment.cgi?id=292229&action=edit ------- Additional Comments from Bill Gianopoulos <wgianopoulos@yahoo.com> Fix comment typo. ...

Web resources about - superreview granted: [Bug 330946] Can drag bookmarks into address book collection of Show All Bookmarks : [Attachment 224328] invalidates drop if it's going to occur on a smart folder's outline view - mozilla.dev.super-review

Resources last updated: 1/8/2016 6:12:25 AM