superreview granted: [Bug 328128] nsIPrefBranch:: prefHasUserValue should document the fact that a pref no longer has a user set value if it is set to its default value

Darin Fisher (Google) <darin.moz@gmail.com> has granted Nickolay_Ponomarev
<asqueella@gmail.com>'s request for superreview:
Bug 328128: nsIPrefBranch::prefHasUserValue should document the fact that a
pref no longer has a user set value if it is set to its default value
https://bugzilla.mozilla.org/show_bug.cgi?id=328128

Attachment 249861: patch
https://bugzilla.mozilla.org/attachment.cgi?id=249861&action=edit

------- Additional Comments from Darin Fisher (Google) <darin.moz@gmail.com>
>Index: modules/libpref/public/nsIPrefBranch.idl

>+   * considered reset to it's default value.

you meant "its"


r+sr=darin
0
bugzilla
12/29/2006 4:48:20 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
519 Views

Similar Articles

[PageSpeed] 28

Reply:

Similar Artilces:

superreview requested: [Bug 328128] nsIPrefBranch:: prefHasUserValue should document the fact that a pref no longer has a user set value if it is set to its default value
Nickolay_Ponomarev <asqueella@gmail.com> has asked Darin Fisher (Google) <darin.moz@gmail.com> for superreview: Bug 328128: nsIPrefBranch::prefHasUserValue should document the fact that a pref no longer has a user set value if it is set to its default value https://bugzilla.mozilla.org/show_bug.cgi?id=328128 Attachment 249861: patch https://bugzilla.mozilla.org/attachment.cgi?id=249861&action=edit ...

superreview granted: [Bug 407538] newURI("http://foo.com:80").port is 80, should be -1 (can set a URI's port to its default value by setting .spec) : [Attachment 292260] patch
Christian :Biesinger <cbiesinger@gmx.at> has granted Gavin Sharp <gavin.sharp@gmail.com>'s request for superreview: Bug 407538: newURI("http://foo.com:80").port is 80, should be -1 (can set a URI's port to its default value by setting .spec) https://bugzilla.mozilla.org/show_bug.cgi?id=407538 Attachment 292260: patch https://bugzilla.mozilla.org/attachment.cgi?id=292260&action=edit ------- Additional Comments from Christian :Biesinger <cbiesinger@gmx.at> would be good to also test that .spec doesn't include the :80 either + //XXX URL ...

superreview granted: [Bug 197466] Back button (session history) has 50 entries regardless of setting in prefs.js : [Attachment 305047] Simple patch to follow user prefs (> default) again, init variabl
Boris Zbarsky (reviews very slow until May) <bzbarsky@mit.edu> has granted zug_treno@yahoo.com's request for superreview: Bug 197466: Back button (session history) has 50 entries regardless of setting in prefs.js https://bugzilla.mozilla.org/show_bug.cgi?id=197466 Attachment 305047: Simple patch to follow user prefs (> default) again, init variable to 50 https://bugzilla.mozilla.org/attachment.cgi?id=305047&action=edit ------- Additional Comments from Boris Zbarsky (reviews very slow until May) <bzbarsky@mit.edu> I can just r+sr this. ...

superreview granted: [Bug 378860] If setAttribute sets an invalid value, the attribute default should be used
Robert O'Callahan (:roc) <roc@ocallahan.org> has granted Robert Longson <longsonr@gmail.com>'s request for superreview: Bug 378860: If setAttribute sets an invalid value, the attribute default should be used https://bugzilla.mozilla.org/show_bug.cgi?id=378860 Attachment 285857: address superreview comments https://bugzilla.mozilla.org/attachment.cgi?id=285857&action=edit ...

superreview granted: [Bug 396278] should take edge values from print settings instead of prefs
Robert O'Callahan (:roc) <roc@ocallahan.org> has granted superreview: Bug 396278: should take edge values from print settings instead of prefs https://bugzilla.mozilla.org/show_bug.cgi?id=396278 Attachment 281005: proposed patch https://bugzilla.mozilla.org/attachment.cgi?id=281005&action=edit ...

superreview granted: [Bug 216751] general.config.filename set in user' s prefs.js overrides setting in all.js
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 216751: general.config.filename set in user's prefs.js overrides setting in all.js https://bugzilla.mozilla.org/show_bug.cgi?id=216751 Attachment 253396: fix MCD https://bugzilla.mozilla.org/attachment.cgi?id=253396&action=edit ...

superreview granted: [Bug 403480] setting nsIURI:: port to its default value shouldn't be possible
Christian :Biesinger <cbiesinger@gmx.at> has granted Gavin Sharp <gavin.sharp@gmail.com>'s request for superreview: Bug 403480: setting nsIURI::port to its default value shouldn't be possible https://bugzilla.mozilla.org/show_bug.cgi?id=403480 Attachment 288311: patch https://bugzilla.mozilla.org/attachment.cgi?id=288311&action=edit ...

superreview granted: [Bug 216751] general.config.filename set in user's prefs.js overrides setting in all.js : [Attachment 189091] Patch
Brendan Eich <brendan@mozilla.org> has granted Frank Wein <bugzilla@mcsmurf.de>'s request for superreview: Bug 216751: general.config.filename set in user's prefs.js overrides setting in all.js https://bugzilla.mozilla.org/show_bug.cgi?id=216751 Attachment 189091: Patch https://bugzilla.mozilla.org/attachment.cgi?id=189091&action=edit ...

superreview granted: [Bug 219848] Cannot programmatically (JavaScript) set value of HTMLInputElement : [Attachment 134580] Fix for nsDOMClassInfo v1 (diff -w for review only)
Johnny Stenback <jst@mozilla.jstenback.com> has granted Peter Van der Beken <peterv@propagandism.org>'s request for superreview: Bug 219848: Cannot programmatically (JavaScript) set value of HTMLInputElement http://bugzilla.mozilla.org/show_bug.cgi?id=219848 Attachment 134580: Fix for nsDOMClassInfo v1 (diff -w for review only) http://bugzilla.mozilla.org/attachment.cgi?id=134580&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> sr=jst ...

superreview granted: [Bug 262624] [FIX]normal (default value) content in generated text with :after and :before does not override more general rule with content set : [Attachment 161166] Patch
David Baron <dbaron@dbaron.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 262624: [FIX]normal (default value) content in generated text with :after and :before does not override more general rule with content set https://bugzilla.mozilla.org/show_bug.cgi?id=262624 Attachment 161166: Patch https://bugzilla.mozilla.org/attachment.cgi?id=161166&action=edit ------- Additional Comments from David Baron <dbaron@dbaron.org> Since it looks like we parse -moz-initial, do you want to check for that as well? Other than that, sr=dba...

superreview requested: [Bug 407538] newURI("http://foo.com:80").port is 80, should be -1 (can set a URI's port to it's default value by setting .spec) : [Attachment 292260] patch
Gavin Sharp <gavin.sharp@gmail.com> has asked Christian :Biesinger <cbiesinger@gmx.at> for superreview: Bug 407538: newURI("http://foo.com:80").port is 80, should be -1 (can set a URI's port to it's default value by setting .spec) https://bugzilla.mozilla.org/show_bug.cgi?id=407538 Attachment 292260: patch https://bugzilla.mozilla.org/attachment.cgi?id=292260&action=edit ------- Additional Comments from Gavin Sharp <gavin.sharp@gmail.com> I'm not sure about the XXX comment in the test - seems like we should probably fix that, too, but I&...

The value set to controls at client side donot persist for each page load, else it is again set to the default value...??
 I am trying to set date to the textbox field using javascript (Client side), the function is as follows. function From_calendarPicker(){                                var    sDPath = "../Calender.aspx";                 var    oWin = window.showModalDialog(sDPath, null, "dialogWidth:300px;dialogHeight:250px;help:0;status:0;scroll:0;center:1");  &nbs...

superreview granted: [Bug 451232] Setting ui.textHighlightBackground pref to empty string or removing pref doesn't reset directly default highlight : [Attachment 334679] Patch v1
Robert O'Callahan (:roc) (Mozilla Corporation) <roc@ocallahan.org> has granted Graeme McCutcheon <graememcc_firefox@graeme-online.co.uk>'s request for superreview: Bug 451232: Setting ui.textHighlightBackground pref to empty string or removing pref doesn't reset directly default highlight https://bugzilla.mozilla.org/show_bug.cgi?id=451232 Attachment 334679: Patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=334679&action=edit ------- Additional Comments from Robert O'Callahan (:roc) (Mozilla Corporation) <roc@ocallahan.org> Excellent, t...

superreview granted: [Bug 237228] pref "layout.word_select.eat_space_to_next_word" can't be set by user in the profile's prefs.js : [Attachment 158389] patch, add UnregisterPrefCallback
Robert O'Callahan <roc@ocallahan.org> has granted Ginn Chen <ginn.chen@sun.com>'s request for superreview: Bug 237228: pref "layout.word_select.eat_space_to_next_word" can't be set by user in the profile's prefs.js http://bugzilla.mozilla.org/show_bug.cgi?id=237228 Attachment 158389: patch, add UnregisterPrefCallback http://bugzilla.mozilla.org/attachment.cgi?id=158389&action=edit ...

Web resources about - superreview granted: [Bug 328128] nsIPrefBranch:: prefHasUserValue should document the fact that a pref no longer has a user set value if it is set to its default value - mozilla.dev.super-review

Resources last updated: 12/25/2015 1:05:51 AM