superreview granted: [Bug 298737] newsgroups periodically lose unread count for messages whose headers haven't been downloaded : [Attachment 249328] fix counts issue

Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu
<bienvenu@nventure.com>'s request for superreview:
Bug 298737: newsgroups periodically lose unread count for messages whose
headers haven't been downloaded
https://bugzilla.mozilla.org/show_bug.cgi?id=298737

Attachment 249328: fix counts issue
https://bugzilla.mozilla.org/attachment.cgi?id=249328&action=edit

------- Additional Comments from Scott MacGregor <mscott@mozilla.org>
I'm assuming we want both this patch and the other one	I just reviewed for
this bug...
0
bugzilla
12/22/2006 4:05:58 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
526 Views

Similar Articles

[PageSpeed] 12

Reply:

Similar Artilces:

superreview granted: [Bug 298737] newsgroups periodically lose unread count for messages whose headers haven't been downloaded : [Attachment 249378] adjust unread counts for message headers we don't h
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 298737: newsgroups periodically lose unread count for messages whose headers haven't been downloaded https://bugzilla.mozilla.org/show_bug.cgi?id=298737 Attachment 249378: adjust unread counts for message headers we don't have, but just once for any given header https://bugzilla.mozilla.org/attachment.cgi?id=249378&action=edit ...

superreview requested: [Bug 298737] newsgroups periodically lose unread count for messages whose headers haven't been downloaded : [Attachment 249328] fix counts issue
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 298737: newsgroups periodically lose unread count for messages whose headers haven't been downloaded https://bugzilla.mozilla.org/show_bug.cgi?id=298737 Attachment 249328: fix counts issue https://bugzilla.mozilla.org/attachment.cgi?id=249328&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> If there are missing headers on the server (e.g., a message is cancelled), we were always showing that message as unread. So in...

superreview requested: [Bug 298737] newsgroups periodically lose unread count for messages whose headers haven't been downloaded : [Attachment 249378] adjust unread counts for message headers we don't
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 298737: newsgroups periodically lose unread count for messages whose headers haven't been downloaded https://bugzilla.mozilla.org/show_bug.cgi?id=298737 Attachment 249378: adjust unread counts for message headers we don't have, but just once for any given header https://bugzilla.mozilla.org/attachment.cgi?id=249378&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> this keeps track of the range of headers we'v...

superreview granted: [Bug 298737] newsgroups periodically lose unread count for messages whose headers haven't been downloaded : [Attachment 248023] work in progress
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 298737: newsgroups periodically lose unread count for messages whose headers haven't been downloaded https://bugzilla.mozilla.org/show_bug.cgi?id=298737 Attachment 248023: work in progress https://bugzilla.mozilla.org/attachment.cgi?id=248023&action=edit ...

superreview requested: [Bug 298737] newsgroups periodically lose unread count for messages whose headers haven't been downloaded : [Attachment 248023] work in progress
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 298737: newsgroups periodically lose unread count for messages whose headers haven't been downloaded https://bugzilla.mozilla.org/show_bug.cgi?id=298737 Attachment 248023: work in progress https://bugzilla.mozilla.org/attachment.cgi?id=248023&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> the patch definitely seems like an improvement ...

superreview granted: [Bug 259649] header only downloaded pop3 messages don't download correctly if filters sent header to different folder : [Attachment 159016] proposed fix
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 259649: header only downloaded pop3 messages don't download correctly if filters sent header to different folder http://bugzilla.mozilla.org/show_bug.cgi?id=259649 Attachment 159016: proposed fix http://bugzilla.mozilla.org/attachment.cgi?id=159016&action=edit ...

superreview granted: [Bug 428427] Unread count in virtual folders not updated for changed headers : [Attachment 328334] Fixed Bienvenu's issues, added defensive check for premature notification
David Bienvenu <bienvenu@nventure.com> has granted Kent James (:rkent) <kent@caspia.com>'s request for superreview: Bug 428427: Unread count in virtual folders not updated for changed headers https://bugzilla.mozilla.org/show_bug.cgi?id=428427 Attachment 328334: Fixed Bienvenu's issues, added defensive check for premature notification https://bugzilla.mozilla.org/attachment.cgi?id=328334&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> thx for doing this, Kent. Some nits - all the other notifications are past tense...

superreview granted: [Bug 267672] Request: groups (when "group by sort") should have the number of read and unread emails : [Attachment 192746] don't show the unread count if there aren't any unread
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 267672: Request: groups (when "group by sort") should have the number of read and unread emails https://bugzilla.mozilla.org/show_bug.cgi?id=267672 Attachment 192746: don't show the unread count if there aren't any unread messages https://bugzilla.mozilla.org/attachment.cgi?id=192746&action=edit ...

superreview requested: [Bug 259649] header only downloaded pop3 messages don't download correctly if filters sent header to different folder : [Attachment 159016] proposed fix
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 259649: header only downloaded pop3 messages don't download correctly if filters sent header to different folder http://bugzilla.mozilla.org/show_bug.cgi?id=259649 Attachment 159016: proposed fix http://bugzilla.mozilla.org/attachment.cgi?id=159016&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> It's gonna take Howard a while to try this, so I think I should get it checked in... ...

superreview granted: [Bug 265330] Issues with Unread messages and Virtual Folders : [Attachment 163023] fix counts when opening a single folder virtual folder
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 265330: Issues with Unread messages and Virtual Folders https://bugzilla.mozilla.org/show_bug.cgi?id=265330 Attachment 163023: fix counts when opening a single folder virtual folder https://bugzilla.mozilla.org/attachment.cgi?id=163023&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> isn't this: if (gCurrentVirtualFolderUri && gCurrentVirtualFolderUri != "" the same thing as just...

superreview granted: [Bug 270069] message counts in statusbar aren't consistently updated for virtual folders : [Attachment 166595] proposed fix
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 270069: message counts in statusbar aren't consistently updated for virtual folders https://bugzilla.mozilla.org/show_bug.cgi?id=270069 Attachment 166595: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=166595&action=edit ...

superreview granted: [Bug 428427] Unread count in virtual folders not updated for changed headers : [Attachment 330094] Fixed Neil's nits, patch to checkin
Kent James (:rkent) <kent@caspia.com> has granted superreview: Bug 428427: Unread count in virtual folders not updated for changed headers https://bugzilla.mozilla.org/show_bug.cgi?id=428427 Attachment 330094: Fixed Neil's nits, patch to checkin https://bugzilla.mozilla.org/attachment.cgi?id=330094&action=edit ------- Additional Comments from Kent James (:rkent) <kent@caspia.com> Carrying over reviews. I implemented all of Neil's suggestions except the one to split OnHdrPropertyChanged into two routines. Carrying over review flags, ready for check-in. ...

superreview requested: [Bug 428427] Unread count in virtual folders not updated for changed headers : [Attachment 328334] Fixed Bienvenu's issues, added defensive check for premature notification
Kent James (:rkent) <kent@caspia.com> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 428427: Unread count in virtual folders not updated for changed headers https://bugzilla.mozilla.org/show_bug.cgi?id=428427 Attachment 328334: Fixed Bienvenu's issues, added defensive check for premature notification https://bugzilla.mozilla.org/attachment.cgi?id=328334&action=edit ------- Additional Comments from Kent James (:rkent) <kent@caspia.com> Carrying over r. Added checks in SetStringPropertyByHdr to defend against callers who are using thi...

superreview granted: [Bug 435259] playing back offline delete of unread IMAP message gets unread count in Trash wrong : [Attachment 322182] proposed fix
neil@parkwaycc.co.uk <neil@httl.net> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 435259: playing back offline delete of unread IMAP message gets unread count in Trash wrong https://bugzilla.mozilla.org/show_bug.cgi?id=435259 Attachment 322182: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=322182&action=edit ...

Web resources about - superreview granted: [Bug 298737] newsgroups periodically lose unread count for messages whose headers haven't been downloaded : [Attachment 249328] fix counts issue - mozilla.dev.super-review

Resources last updated: 11/25/2015 8:00:54 AM