superreview granted: [Bug 293834] Save Page As should save form inputs' state : [Attachment 278185] Goes back to SetAttribute instead of SetDefaultValue

Jonas Sicking (:sicking) <jonas@sicking.cc> has granted Ben Karel [eschew]
<eschew@gmail.com>'s request for superreview:
Bug 293834: Save Page As should save form inputs' state
https://bugzilla.mozilla.org/show_bug.cgi?id=293834

Attachment 278185: Goes back to SetAttribute instead of SetDefaultValue
https://bugzilla.mozilla.org/attachment.cgi?id=278185&action=edit

------- Additional Comments from Jonas Sicking (:sicking) <jonas@sicking.cc>
Looks great, sorry for the extremely slow review on this one :(
0
bugzilla
7/24/2008 8:32:18 AM
mozilla.dev.super-review 29307 articles. 2 followers. Post Follow

0 Replies
606 Views

Similar Articles

[PageSpeed] 27

Reply:

Similar Artilces:

superreview requested: [Bug 293834] Save Page As should save form inputs' state
Ben Karel <web+moz@eschew.org> has asked Jonas Sicking <jonas@sicking.cc> for superreview: Bug 293834: Save Page As should save form inputs' state https://bugzilla.mozilla.org/show_bug.cgi?id=293834 Attachment 278185: Goes back to SetAttribute instead of SetDefaultValue https://bugzilla.mozilla.org/attachment.cgi?id=278185&action=edit ------- Additional Comments from Ben Karel <web+moz@eschew.org> Carrying over r+, requesting sr. ...

superreview granted: [Bug 416063] "Save this password?" dialog has "Never Save" focused instead of "Don't Save" with FKA on (again!) : [Attachment 304041] fix
Mike Pinkerton (not reading bugmail) <mikepinkerton@mac.com> has granted Stuart Morgan <stuart.morgan@alumni.case.edu>'s request for superreview: Bug 416063: "Save this password?" dialog has "Never Save" focused instead of "Don't Save" with FKA on (again!) https://bugzilla.mozilla.org/show_bug.cgi?id=416063 Attachment 304041: fix https://bugzilla.mozilla.org/attachment.cgi?id=304041&action=edit ------- Additional Comments from Mike Pinkerton (not reading bugmail) <mikepinkerton@mac.com> sr=pink ...

superreview granted: [Bug 98576] IMAP: 'Save as Draft' doesn't save the message. (if URI contains a space) : [Attachment 141256] fix for imap save as draft
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 98576: IMAP: 'Save as Draft' doesn't save the message. (if URI contains a space) http://bugzilla.mozilla.org/show_bug.cgi?id=98576 Attachment 141256: fix for imap save as draft http://bugzilla.mozilla.org/attachment.cgi?id=141256&action=edit ...

superreview granted: [Bug 290788] crash when try to 'save all' Attachments from MailNews 'File' 'Attachments' Menu [@ nsMessenger::SaveAllAttachments] : [Attachment 181152] Patch
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Frank Wein <bugzilla@mcsmurf.de>'s request for superreview: Bug 290788: crash when try to 'save all' Attachments from MailNews 'File' 'Attachments' Menu [@ nsMessenger::SaveAllAttachments] https://bugzilla.mozilla.org/show_bug.cgi?id=290788 Attachment 181152: Patch https://bugzilla.mozilla.org/attachment.cgi?id=181152&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> D'oh! ;-) ...

superreview granted: [Bug 418961] "Save Page As" "Text Files" saves file but Downloads window doesn't show completion : [Attachment 305432] v1
Christian :Biesinger <cbiesinger@gmail.com> has granted Edward Lee (Mardak) <edilee@gmail.com>'s request for superreview: Bug 418961: "Save Page As" "Text Files" saves file but Downloads window doesn't show completion https://bugzilla.mozilla.org/show_bug.cgi?id=418961 Attachment 305432: v1 https://bugzilla.mozilla.org/attachment.cgi?id=305432&action=edit ...

superreview granted: [Bug 276453] Save Page As "Web Page, complete" does not save Java applets : [Attachment 175087] Slightly updated
Johnny Stenback <jst@mozilla.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 276453: Save Page As "Web Page, complete" does not save Java applets https://bugzilla.mozilla.org/show_bug.cgi?id=276453 Attachment 175087: Slightly updated https://bugzilla.mozilla.org/attachment.cgi?id=175087&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> sr=jst ...

superreview requested: [Bug 416063] "Save this password?" dialog has "Never Save" focused instead of "Don't Save" with FKA on (again!) : [Attachment 304041] fix
Stuart Morgan <stuart.morgan@alumni.case.edu> has asked Mike Pinkerton (not reading bugmail) <mikepinkerton@mac.com> for superreview: Bug 416063: "Save this password?" dialog has "Never Save" focused instead of "Don't Save" with FKA on (again!) https://bugzilla.mozilla.org/show_bug.cgi?id=416063 Attachment 304041: fix https://bugzilla.mozilla.org/attachment.cgi?id=304041&action=edit ...

superreview granted: [Bug 280415] "Save As Page..." menu item disappears if no window open : [Attachment 174142] mac save page as fix patch v0.1
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Ian Neal <bugzilla@arlen.demon.co.uk>'s request for superreview: Bug 280415: "Save As Page..." menu item disappears if no window open https://bugzilla.mozilla.org/show_bug.cgi?id=280415 Attachment 174142: mac save page as fix patch v0.1 https://bugzilla.mozilla.org/attachment.cgi?id=174142&action=edit ...

superreview requested: [Bug 98576] IMAP: 'Save as Draft' doesn't save the message. (if URI contains a space) : [Attachment 141256] fix for imap save as draft
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 98576: IMAP: 'Save as Draft' doesn't save the message. (if URI contains a space) http://bugzilla.mozilla.org/show_bug.cgi?id=98576 Attachment 141256: fix for imap save as draft http://bugzilla.mozilla.org/attachment.cgi?id=141256&action=edit ...

superreview granted: [Bug 263839] 'Save Link Target As' may automatically add .htm to the target save-as filename : [Attachment 165403] Include also https in this strategy (using regex)
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Phil <Time_lord@hotmail.com>'s request for superreview: Bug 263839: 'Save Link Target As' may automatically add .htm to the target save-as filename https://bugzilla.mozilla.org/show_bug.cgi?id=263839 Attachment 165403: Include also https in this strategy (using regex) https://bugzilla.mozilla.org/attachment.cgi?id=165403&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> You probably don't need quite so many brackets ;-) ...

superreview granted: [Bug 267406] Crash using Ctrl-S or File/Save Page As to save a web page [@ nsFilePicker::ShowW] : [Attachment 164967] Fix for crash when browser.download.dir setting is missing
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 267406: Crash using Ctrl-S or File/Save Page As to save a web page [@ nsFilePicker::ShowW] https://bugzilla.mozilla.org/show_bug.cgi?id=267406 Attachment 164967: Fix for crash when browser.download.dir setting is missing https://bugzilla.mozilla.org/attachment.cgi?id=164967&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> Nice simplification :-) ...

superreview granted: [Bug 299372] Content-Disposition headers no longer looked at for Save Link As filename, so it uses e.g. "attachment.cgi" in bugzilla instead of the name of the attachment; Save Pa #5
Dan Mosedale <dmose@mozilla.org> has granted superreview: Bug 299372: Content-Disposition headers no longer looked at for Save Link As filename, so it uses e.g. "attachment.cgi" in bugzilla instead of the name of the attachment; Save Page As works fine https://bugzilla.mozilla.org/show_bug.cgi?id=299372 Attachment 294545: "Save Link As..." patch, v2 https://bugzilla.mozilla.org/attachment.cgi?id=294545&action=edit ------- Additional Comments from Dan Mosedale <dmose@mozilla.org> Patch v2; all comments addressed _except_ that I'm still using ...

superreview granted: [Bug 299372] Content-Disposition headers no longer looked at for Save Link As filename, so it uses e.g. "attachment.cgi" in bugzilla instead of the name of the attachment; Save Pa #2
Christian :Biesinger <cbiesinger@gmx.at> has granted Dan Mosedale <dmose@mozilla.org>'s request for superreview: Bug 299372: Content-Disposition headers no longer looked at for Save Link As filename, so it uses e.g. "attachment.cgi" in bugzilla instead of the name = of the attachment; Save Page As works fine https://bugzilla.mozilla.org/show_bug.cgi?id=3D299372 Attachment 305240: "Save Link As..." patch, v4 https://bugzilla.mozilla.org/attachment.cgi?id=3D305240&action=3Dedit ------- Additional Comments from Christian :Biesinger <cbiesing...

superreview granted: [Bug 299372] Content-Disposition headers no longer looked at for Save Link As filename, so it uses e.g. "attachment.cgi" in bugzilla instead of the name of the attachment; Save Pa #3
Dan Mosedale <dmose@mozilla.org> has granted superreview: Bug 299372: Content-Disposition headers no longer looked at for Save Link As filename, so it uses e.g. "attachment.cgi" in bugzilla instead of the name of the attachment; Save Page As works fine https://bugzilla.mozilla.org/show_bug.cgi?id=299372 Attachment 305659: "Save Link As..." patch, v5 https://bugzilla.mozilla.org/attachment.cgi?id=305659&action=edit ------- Additional Comments from Dan Mosedale <dmose@mozilla.org> Addresses the issues biesi found; carrying forward sr. ...

Web resources about - superreview granted: [Bug 293834] Save Page As should save form inputs' state : [Attachment 278185] Goes back to SetAttribute instead of SetDefaultValue - mozilla.dev.super-review

Resources last updated: 12/5/2015 11:09:47 PM