superreview granted: [Bug 290678] Port thunderbird's revised vcard attachment display to suite. : [Attachment 309922] Patch for classic and modern v3

neil@parkwaycc.co.uk <neil@httl.net> has granted Bruno 'Aqualon' Escherl
<aqualon@aquachan.de>'s request for superreview:
Bug 290678: Port thunderbird's revised vcard attachment display to suite.
https://bugzilla.mozilla.org/show_bug.cgi?id=290678

Attachment 309922: Patch for classic and modern v3
https://bugzilla.mozilla.org/attachment.cgi?id=309922&action=edit

------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net>
OK, r+sr=me with the noline image in Modern and the tweaked outline styles in
both themes.
0
bugzilla
3/18/2008 9:45:50 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
374 Views

Similar Articles

[PageSpeed] 25

Reply:

Similar Artilces:

superreview requested: [Bug 290678] Port thunderbird's revised vcard attachment display to suite. : [Attachment 309922] Patch for classic and modern v3
Bruno 'Aqualon' Escherl <aqualon@aquachan.de> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 290678: Port thunderbird's revised vcard attachment display to suite. https://bugzilla.mozilla.org/show_bug.cgi?id=290678 Attachment 309922: Patch for classic and modern v3 https://bugzilla.mozilla.org/attachment.cgi?id=309922&action=edit ------- Additional Comments from Bruno 'Aqualon' Escherl <aqualon@aquachan.de> Now I believe the theme patch is fine enough to be reviewed (finally ;-)) I had to do some tricks to make modern...

superreview granted: [Bug 290678] Port thunderbird's revised vcard attachment display to suite. : [Attachment 310204] Patch for classic and modern v4
Bruno 'Aqualon' Escherl <aqualon@aquachan.de> has granted superreview: Bug 290678: Port thunderbird's revised vcard attachment display to suite. https://bugzilla.mozilla.org/show_bug.cgi?id=290678 Attachment 310204: Patch for classic and modern v4 https://bugzilla.mozilla.org/attachment.cgi?id=310204&action=edit ------- Additional Comments from Bruno 'Aqualon' Escherl <aqualon@aquachan.de> Includes the changes from comment #12, taking over r/sr. ...

superreview canceled: [Bug 290678] Port thunderbird's revised vcard attachment display to suite. : [Attachment 309826] Patch for classic and modern
Bruno 'Aqualon' Escherl <aqualon@aquachan.de> has canceled Bruno 'Aqualon' Escherl <aqualon@aquachan.de>'s request for superreview: Bug 290678: Port thunderbird's revised vcard attachment display to suite. https://bugzilla.mozilla.org/show_bug.cgi?id=290678 Attachment 309826: Patch for classic and modern https://bugzilla.mozilla.org/attachment.cgi?id=309826&action=edit ------- Additional Comments from Bruno 'Aqualon' Escherl <aqualon@aquachan.de> Now with the correct modern icon (not that it would look any better, but at least i...

superreview requested: [Bug 290678] Port thunderbird's revised vcard attachment display to suite. : [Attachment 309826] Patch for classic and modern
Bruno 'Aqualon' Escherl <aqualon@aquachan.de> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 290678: Port thunderbird's revised vcard attachment display to suite. https://bugzilla.mozilla.org/show_bug.cgi?id=290678 Attachment 309826: Patch for classic and modern https://bugzilla.mozilla.org/attachment.cgi?id=309826&action=edit ------- Additional Comments from Bruno 'Aqualon' Escherl <aqualon@aquachan.de> Updated patch for classic and modern theme. I'll file a separate bug for better icons (at least modern looks quit...

superreview canceled: [Bug 290678] Port thunderbird's revised vcard attachment display to suite. : [Attachment 309834] Patch for classic and modern v2
Bruno 'Aqualon' Escherl <aqualon@aquachan.de> has canceled Bruno 'Aqualon' Escherl <aqualon@aquachan.de>'s request for superreview: Bug 290678: Port thunderbird's revised vcard attachment display to suite. https://bugzilla.mozilla.org/show_bug.cgi?id=290678 Attachment 309834: Patch for classic and modern v2 https://bugzilla.mozilla.org/attachment.cgi?id=309834&action=edit ------- Additional Comments from Bruno 'Aqualon' Escherl <aqualon@aquachan.de> Oh man, I was too blind to see the correct icons for that case. At least I have ...

superreview requested: [Bug 290678] Port thunderbird's revised vcard attachment display to suite. : [Attachment 309834] Patch for classic and modern v2
Bruno 'Aqualon' Escherl <aqualon@aquachan.de> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 290678: Port thunderbird's revised vcard attachment display to suite. https://bugzilla.mozilla.org/show_bug.cgi?id=290678 Attachment 309834: Patch for classic and modern v2 https://bugzilla.mozilla.org/attachment.cgi?id=309834&action=edit ------- Additional Comments from Bruno 'Aqualon' Escherl <aqualon@aquachan.de> Now with the correct modern icon (not that it would look any better, but at least it's the vcard icon ;-)) ...

superreview granted: [Bug 290678] Port thunderbird's revised vcard attachment display to suite. : [Attachment 308639] Use the same vcard code for SeaMonkey and Thunderbird
David Bienvenu <bienvenu@nventure.com> has granted Bruno 'Aqualon' Escherl <aqualon@aquachan.de>'s request for superreview: Bug 290678: Port thunderbird's revised vcard attachment display to suite. https://bugzilla.mozilla.org/show_bug.cgi?id=290678 Attachment 308639: Use the same vcard code for SeaMonkey and Thunderbird https://bugzilla.mozilla.org/attachment.cgi?id=308639&action=edit ...

superreview requested: [Bug 290678] Port thunderbird's revised vcard attachment display to suite. : [Attachment 308639] Use the same vcard code for SeaMonkey and Thunderbird
Bruno 'Aqualon' Escherl <aqualon@aquachan.de> has asked for superreview: Bug 290678: Port thunderbird's revised vcard attachment display to suite. https://bugzilla.mozilla.org/show_bug.cgi?id=290678 Attachment 308639: Use the same vcard code for SeaMonkey and Thunderbird https://bugzilla.mozilla.org/attachment.cgi?id=308639&action=edit ------- Additional Comments from Bruno 'Aqualon' Escherl <aqualon@aquachan.de> This patch lets SeaMonkey use the same code as Thunderbird and removes the previous used code from mimevcrd.cpp I'll post a fron...

superreview requested: [Bug 290678] Port thunderbird's revised vcard attachment display to suite. : [Attachment 308639] Use the same vcard code for SeaMonkey and Thunderbird #2
Bruno 'Aqualon' Escherl <aqualon@aquachan.de> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 290678: Port thunderbird's revised vcard attachment display to suite. https://bugzilla.mozilla.org/show_bug.cgi?id=290678 Attachment 308639: Use the same vcard code for SeaMonkey and Thunderbird https://bugzilla.mozilla.org/attachment.cgi?id=308639&action=edit ...

superreview granted: [Bug 353906] Modernize mail's registry code to implement toolkit's nsIShellService : [Attachment 240565] a patch
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 353906: Modernize mail's registry code to implement toolkit's nsIShellService https://bugzilla.mozilla.org/show_bug.cgi?id=353906 Attachment 240565: a patch https://bugzilla.mozilla.org/attachment.cgi?id=240565&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> + DWORD len = sizeof buf; hmm, I'd not seen that usage before... Wow, that's a lot of work! ...

superreview granted: [Bug 290788] crash when try to 'save all' Attachments from MailNews 'File' 'Attachments' Menu [@ nsMessenger::SaveAllAttachments] : [Attachment 181152] Patch
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Frank Wein <bugzilla@mcsmurf.de>'s request for superreview: Bug 290788: crash when try to 'save all' Attachments from MailNews 'File' 'Attachments' Menu [@ nsMessenger::SaveAllAttachments] https://bugzilla.mozilla.org/show_bug.cgi?id=290788 Attachment 181152: Patch https://bugzilla.mozilla.org/attachment.cgi?id=181152&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> D'oh! ;-) ...

superreview granted: [Bug 287943] Rebrand bootstrap's Windows bits including nsNativeAppSupportWin.cpp : [Attachment 180579] patch v4: address biesi's review nits
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Robert Kaiser <kairo@kairo.at>'s request for superreview: Bug 287943: Rebrand bootstrap's Windows bits including nsNativeAppSupportWin.cpp https://bugzilla.mozilla.org/show_bug.cgi?id=287943 Attachment 180579: patch v4: address biesi's review nits https://bugzilla.mozilla.org/attachment.cgi?id=180579&action=edit ...

superreview granted: [Bug 221381] Add Attach Personal Card (vCard) option to Attach button in compose window toolbar : [Attachment 132880] Revised patch v0.2b that adds Person Card to Attach button
David Bienvenu <bienvenu@nventure.com> has granted Ian Neal <bugzilla@arlen.demon.co.uk>'s request for superreview: Bug 221381: Add Attach Personal Card (vCard) option to Attach button in compose window toolbar http://bugzilla.mozilla.org/show_bug.cgi?id=221381 Attachment 132880: Revised patch v0.2b that adds Person Card to Attach button http://bugzilla.mozilla.org/attachment.cgi?id=132880&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> sr=bienvenu - these two menu items stay in sync re checked/unchecked because they ...

superreview granted: [Bug 288366] Port Thunderbird's View Layout to MailNews : [Attachment 179717] Tweaked extended patch v0.1f
David Bienvenu <bienvenu@nventure.com> has granted Ian Neal <bugzilla@arlen.demon.co.uk>'s request for superreview: Bug 288366: Port Thunderbird's View Layout to MailNews https://bugzilla.mozilla.org/show_bug.cgi?id=288366 Attachment 179717: Tweaked extended patch v0.1f https://bugzilla.mozilla.org/attachment.cgi?id=179717&action=edit ...

Web resources about - superreview granted: [Bug 290678] Port thunderbird's revised vcard attachment display to suite. : [Attachment 309922] Patch for classic and modern v3 - mozilla.dev.super-review

Resources last updated: 1/15/2016 12:53:02 AM