superreview granted: [Bug 283342] Many windows don't set window classes : [Attachment 197950] Patch to add a window class to the Default Plugin's window

Johnny Stenback (:jst) <jst@mozilla.org> has granted  superreview:
Bug 283342: Many windows don't set window classes
https://bugzilla.mozilla.org/show_bug.cgi?id=283342

Attachment 197950: Patch to add a window class to the Default Plugin's window
https://bugzilla.mozilla.org/attachment.cgi?id=197950&action=edit
0
bugzilla
2/27/2008 12:05:00 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
811 Views

Similar Articles

[PageSpeed] 3

Reply:

Similar Artilces:

superreview granted: [Bug 264442] plugin finder can't find anything for windows media. : [Attachment 162212] Don't assume we don't have a plugin before getting a responce from the network.
Boris Zbarsky <bzbarsky@mit.edu> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 264442: plugin finder can't find anything for windows media. https://bugzilla.mozilla.org/show_bug.cgi?id=264442 Attachment 162212: Don't assume we don't have a plugin before getting a responce from the network. https://bugzilla.mozilla.org/attachment.cgi?id=162212&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> r+sr=bzbarsky, I guess.. Is ther a reason mIsBrokenPlugin is write-only? ...

superreview granted: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 227564] fixes in response to Darin's re
Darin Fisher (Google) <darin@meer.net> has granted Marria Nazif <marria@gmail.com>'s request for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 227564: fixes in response to Darin's review https://bugzilla.mozilla.org/attachment.cgi?id=227564&action=edit ------- Additional Comments from Darin Fisher (Google) <darin@meer.net> >Index: docshell/base/nsDocShell.cpp > if (!r...

superreview requested: [Bug 264442] plugin finder can't find anything for windows media. : [Attachment 162212] Don't assume we don't have a plugin before getting a responce from the network.
Johnny Stenback <jst@mozilla.jstenback.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 264442: plugin finder can't find anything for windows media. https://bugzilla.mozilla.org/show_bug.cgi?id=264442 Attachment 162212: Don't assume we don't have a plugin before getting a responce from the network. https://bugzilla.mozilla.org/attachment.cgi?id=162212&action=edit ...

superreview granted: [Bug 318106] ###!!! ASSERTION: Setting mutation listener bits on outer window?: 'window->IsInnerWindow()' : [Attachment 204464] Add nsIDocument::GetInnerWindow() and use it where
Boris Zbarsky <bzbarsky@mit.edu> has granted Johnny Stenback <jst@mozilla.org>'s request for superreview: Bug 318106: ###!!! ASSERTION: Setting mutation listener bits on outer window?: 'window->IsInnerWindow()' https://bugzilla.mozilla.org/show_bug.cgi?id=318106 Attachment 204464: Add nsIDocument::GetInnerWindow() and use it where needed. https://bugzilla.mozilla.org/attachment.cgi?id=204464&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> r+sr=bzbarsky ...

superreview granted: [Bug 245131] [FIX]Don't flush reflows on document in window when looking for scrollinfo for window : [Attachment 153134] Updated to review comments
Johnny Stenback <jst@mozilla.jstenback.com> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 245131: [FIX]Don't flush reflows on document in window when looking for scrollinfo for window http://bugzilla.mozilla.org/show_bug.cgi?id=245131 Attachment 153134: Updated to review comments http://bugzilla.mozilla.org/attachment.cgi?id=153134&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> sr=jst ...

superreview granted: [Bug 217012] browser window won't come to foreground with help window open : [Attachment 130237] when raising a window to the top, first raise all windows in higher layers to th
jag (Peter Annema) <jag@tty.nl> has granted Dan M <danm-moz@comcast.net>'s request for superreview: Bug 217012: browser window won't come to foreground with help window open http://bugzilla.mozilla.org/show_bug.cgi?id=217012 Attachment 130237: when raising a window to the top, first raise all windows in higher layers to the top http://bugzilla.mozilla.org/attachment.cgi?id=130237&action=edit ------- Additional Comments from jag (Peter Annema) <jag@tty.nl> sr=jag ...

superreview granted: [Bug 305528] Cannot setTimeout window.focus or window.alert : [Attachment 193751] Make xpconnect attempt to use obj's outer if it can't find a wrapper using the given obj
Brendan Eich <brendan@mozilla.org> has granted Johnny Stenback <jst@mozilla.org>'s request for superreview: Bug 305528: Cannot setTimeout window.focus or window.alert https://bugzilla.mozilla.org/show_bug.cgi?id=305528 Attachment 193751: Make xpconnect attempt to use obj's outer if it can't find a wrapper using the given obj https://bugzilla.mozilla.org/attachment.cgi?id=193751&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> Pre-emptive a=me as well as sr=me. This is it. /be ...

superreview requested: [Bug 304388] Add hostname to title bar of windows that don't have location bars : [Attachment 192787] update dveditz's patch to trunk
Jesse Ruderman <jruderman@gmail.com> has asked Boris Zbarsky (gone till Aug 14) <bzbarsky@mit.edu> for superreview: Bug 304388: Add hostname to title bar of windows that don't have location bars https://bugzilla.mozilla.org/show_bug.cgi?id=304388 Attachment 192787: update dveditz's patch to trunk https://bugzilla.mozilla.org/attachment.cgi?id=192787&action=edit ------- Additional Comments from Jesse Ruderman <jruderman@gmail.com> I hand-applied dveditz's patch (https://bugzilla.mozilla.org/show_bug.cgi?id=22183#c238) to the trunk and edited a few ...

superreview denied: [Bug 304388] Add hostname to title bar of windows that don't have location bars : [Attachment 192787] update dveditz's patch to trunk
Boris Zbarsky <bzbarsky@mit.edu> has denied Jesse Ruderman <jruderman@gmail.com>'s request for superreview: Bug 304388: Add hostname to title bar of windows that don't have location bars https://bugzilla.mozilla.org/show_bug.cgi?id=304388 Attachment 192787: update dveditz's patch to trunk https://bugzilla.mozilla.org/attachment.cgi?id=192787&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> This needs at least a similar patch for xpfe and a check on whether nsWebBrowser has similar issues, as well as testing of the nsCon...

superreview requested: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 227564] fixes in response to Darin's
Marria Nazif <marria@gmail.com> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 227564: fixes in response to Darin's review https://bugzilla.mozilla.org/attachment.cgi?id=227564&action=edit ------- Additional Comments from Marria Nazif <marria@gmail.com> > >+ /** > >+ * This is set based on whether the channel indica...

superreview granted: [Bug 231384] global objects don't go away when closing window : [Attachment 139426] patch to (again) use prototype's nsIScriptContext for event handler compilation
Brian Ryner <bryner@brianryner.com> has granted David Baron <dbaron@dbaron.org>'s request for superreview: Bug 231384: global objects don't go away when closing window http://bugzilla.mozilla.org/show_bug.cgi?id=231384 Attachment 139426: patch to (again) use prototype's nsIScriptContext for event handler compilation http://bugzilla.mozilla.org/attachment.cgi?id=139426&action=edit ...

superreview requested: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 225294] close blank window
Marria Nazif <marria@gmail.com> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 225294: close blank window https://bugzilla.mozilla.org/attachment.cgi?id=225294&action=edit ------- Additional Comments from Marria Nazif <marria@gmail.com> This is a first try at closing the window after the external app handler has done its work. This se...

superreview cancelled: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 225294] close blank window
Marria Nazif <marria@gmail.com> has cancelled Marria Nazif <marria@gmail.com>'s request for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 225294: close blank window https://bugzilla.mozilla.org/attachment.cgi?id=225294&action=edit ...

superreview granted: [Bug 307632] Can't extend Selection Class anymore with Firefox 1.5b1 : [Attachment 195818] Use the current inner scope when wrapping natives in an outer window's scope.
Brendan Eich <brendan@mozilla.org> has granted Johnny Stenback <jst@mozilla.org>'s request for superreview: Bug 307632: Can't extend Selection Class anymore with Firefox 1.5b1 https://bugzilla.mozilla.org/show_bug.cgi?id=307632 Attachment 195818: Use the current inner scope when wrapping natives in an outer window's scope. https://bugzilla.mozilla.org/attachment.cgi?id=195818&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> sr=me ahead of mrbkap, he better not embarrass me ;-). /be ...

Web resources about - superreview granted: [Bug 283342] Many windows don't set window classes : [Attachment 197950] Patch to add a window class to the Default Plugin's window - mozilla.dev.super-review

Resources last updated: 12/4/2015 7:03:24 AM