superreview granted: [Bug 273977] Thunderbird does not identify itself correctly to iListen voice rec application (Thunderbird.app vs thunderbird-bin ?) : [Attachment 220339] Patch that uses MOZ_APP_D

Mark Mentovai <mark@moxienet.com> has granted David Bienvenu
<bienvenu@nventure.com>'s request for superreview:
Bug 273977: Thunderbird does not identify itself correctly to iListen voice rec
application (Thunderbird.app vs thunderbird-bin ?)
https://bugzilla.mozilla.org/show_bug.cgi?id=273977

Attachment 220339: Patch that uses MOZ_APP_DISPLAYNAME for executable
https://bugzilla.mozilla.org/attachment.cgi?id=220339&action=edit

------- Additional Comments from Mark Mentovai <mark@moxienet.com>
This comment isn't necessary:

+# Executable should match package filename - bug 273977

That's what cvs blame is for.  The new behavior is clear enough from the
conditions in the Makefile, and this isn't some sort of weird unexpected change
that warrants putting a bug ref directly in the comment.

I'm OK with trying this
0
bugzilla
5/1/2006 5:50:54 PM
mozilla.dev.super-review 29307 articles. 2 followers. Post Follow

0 Replies
749 Views

Similar Articles

[PageSpeed] 6

Reply:

Similar Artilces:

superreview requested: [Bug 273977] Thunderbird does not identify itself correctly to iListen voice rec application (Thunderbird.app vs thunderbird-bin ?) : [Attachment 220339] Patch that uses MOZ_APP #2
Chris Andrichak <chris@grope.com> has asked for superreview: Bug 273977: Thunderbird does not identify itself correctly to iListen voice rec application (Thunderbird.app vs thunderbird-bin ?) https://bugzilla.mozilla.org/show_bug.cgi?id=273977 Attachment 220339: Patch that uses MOZ_APP_DISPLAYNAME for executable https://bugzilla.mozilla.org/attachment.cgi?id=220339&action=edit ------- Additional Comments from Chris Andrichak <chris@grope.com> Getting the executable name from the variable at mark's suggestion, the make file now swaps it into the plist file also....

superreview requested: [Bug 273977] Thunderbird does not identify itself correctly to iListen voice rec application (Thunderbird.app vs thunderbird-bin ?) : [Attachment 220339] Patch that uses MOZ_APP #3
David Bienvenu <bienvenu@nventure.com> has asked for superreview: Bug 273977: Thunderbird does not identify itself correctly to iListen voice rec application (Thunderbird.app vs thunderbird-bin ?) https://bugzilla.mozilla.org/show_bug.cgi?id=273977 Attachment 220339: Patch that uses MOZ_APP_DISPLAYNAME for executable https://bugzilla.mozilla.org/attachment.cgi?id=220339&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> you need to request reviews of people - bugzilla should really complain about that! ...

superreview denied: [Bug 273977] Thunderbird does not identify itself correctly to iListen voice rec application (Thunderbird.app vs thunderbird-bin ?) : [Attachment 217422] Patch against current bran
Mark Mentovai <mark@moxienet.com> has denied Josh Aas <joshmoz@gmail.com>'s request for superreview: Bug 273977: Thunderbird does not identify itself correctly to iListen voice rec application (Thunderbird.app vs thunderbird-bin ?) https://bugzilla.mozilla.org/show_bug.cgi?id=273977 Attachment 217422: Patch against current branch files https://bugzilla.mozilla.org/attachment.cgi?id=217422&action=edit ------- Additional Comments from Mark Mentovai <mark@moxienet.com> The app bundle's name is ThunderbirdDebug during a debug build. I'd be pleased to...

superreview requested: [Bug 273977] Thunderbird does not identify itself correctly to iListen voice rec application (Thunderbird.app vs thunderbird-bin ?) : [Attachment 217422] Patch against current b #2
Josh Aas <joshmoz@gmail.com> has asked for superreview: Bug 273977: Thunderbird does not identify itself correctly to iListen voice rec application (Thunderbird.app vs thunderbird-bin ?) https://bugzilla.mozilla.org/show_bug.cgi?id=273977 Attachment 217422: Patch against current branch files https://bugzilla.mozilla.org/attachment.cgi?id=217422&action=edit ------- Additional Comments from Josh Aas <joshmoz@gmail.com> I know mark isn't sr, but I want him to review this and I can't request another normal review via flags... I suspect this won't be as sa...

superreview requested: [Bug 273977] Thunderbird does not identify itself correctly to iListen voice rec application (Thunderbird.app vs thunderbird-bin ?) : [Attachment 217422] Patch against current b #3
Josh Aas <joshmoz@gmail.com> has asked for superreview: Bug 273977: Thunderbird does not identify itself correctly to iListen voice rec application (Thunderbird.app vs thunderbird-bin ?) https://bugzilla.mozilla.org/show_bug.cgi?id=273977 Attachment 217422: Patch against current branch files https://bugzilla.mozilla.org/attachment.cgi?id=217422&action=edit ...

superreview granted: [Bug 290678] Port thunderbird's revised vcard attachment display to suite. : [Attachment 308639] Use the same vcard code for SeaMonkey and Thunderbird
David Bienvenu <bienvenu@nventure.com> has granted Bruno 'Aqualon' Escherl <aqualon@aquachan.de>'s request for superreview: Bug 290678: Port thunderbird's revised vcard attachment display to suite. https://bugzilla.mozilla.org/show_bug.cgi?id=290678 Attachment 308639: Use the same vcard code for SeaMonkey and Thunderbird https://bugzilla.mozilla.org/attachment.cgi?id=308639&action=edit ...

superreview granted: [Bug 339135] Convert Thunderbird to use the NSIS Installer : [Attachment 229176] patch for review
Scott MacGregor <mscott@mozilla.org> has granted superreview: Bug 339135: Convert Thunderbird to use the NSIS Installer https://bugzilla.mozilla.org/show_bug.cgi?id=339135 Attachment 229176: patch for review https://bugzilla.mozilla.org/attachment.cgi?id=229176&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> Thanks Rob! ...

superreview granted: [Bug 295729] crash after Firefox or Thunderbird checks for Extension/Theme updates
Benjamin Smedberg [:bs] (formerly bsmedberg@covad.net) <benjamin@smedbergs.us> has granted Benjamin Smedberg [:bs] (formerly bsmedberg@covad.net) <benjamin@smedbergs.us>'s request for superreview: Bug 295729: crash after Firefox or Thunderbird checks for Extension/Theme updates - Trunk FF11a1 TB11a1 [@ firefox-bin][@ thunderbird-bin] https://bugzilla.mozilla.org/show_bug.cgi?id=295729 Attachment 187084: Null-check XPConnect() directly, rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=187084&action=edit ------- Additional Comments from Benjamin Smedberg [...

superreview granted: [Bug 216137] Make xpinstall/packager produce thunderbird packages : [Attachment 129787] patch to allow building thunderbird install package
Scott MacGregor <mscott@mozilla.org> has granted Simon 'sipaq' Paquet <bugzilla@babylonsounds.com>'s request for superreview: Bug 216137: Make xpinstall/packager produce thunderbird packages http://bugzilla.mozilla.org/show_bug.cgi?id=216137 Attachment 129787: patch to allow building thunderbird install package http://bugzilla.mozilla.org/attachment.cgi?id=129787&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> I misunderstood this bug the first time around. This looks ok to me. ...

superreview requested: [Bug 408685] After ARIA namespaces have been removed , correct XUL in Thunderbird : [Attachment 293521] Patch removing the aaa: namespace from Thunderbird XUL and JS files
Marco Zehe <marco.zehe@googlemail.com> has asked for superreview: Bug 408685: After ARIA namespaces have been removed, correct XUL in Thunderbird https://bugzilla.mozilla.org/show_bug.cgi?id=408685 Attachment 293521: Patch removing the aaa: namespace from Thunderbird XUL and JS files https://bugzilla.mozilla.org/attachment.cgi?id=293521&action=edit ...

superreview canceled: [Bug 408685] After ARIA namespaces have been removed, correct XUL in Thunderbird : [Attachment 293521] Patch removing the aaa: namespace from Thunderbird XUL and JS files
Aaron Leventhal <aaronleventhal@moonset.net> has canceled Marco Zehe <marco.zehe@googlemail.com>'s request for superreview: Bug 408685: After ARIA namespaces have been removed, correct XUL in Thunderbird https://bugzilla.mozilla.org/show_bug.cgi?id=408685 Attachment 293521: Patch removing the aaa: namespace from Thunderbird XUL and JS files https://bugzilla.mozilla.org/attachment.cgi?id=293521&action=edit ------- Additional Comments from Aaron Leventhal <aaronleventhal@moonset.net> Hi Marco, the attribute names will now be aria-propertyname, e.g. aria-lab...

superreview requested: [Bug 290678] Port thunderbird's revised vcard attachment display to suite. : [Attachment 308639] Use the same vcard code for SeaMonkey and Thunderbird
Bruno 'Aqualon' Escherl <aqualon@aquachan.de> has asked for superreview: Bug 290678: Port thunderbird's revised vcard attachment display to suite. https://bugzilla.mozilla.org/show_bug.cgi?id=290678 Attachment 308639: Use the same vcard code for SeaMonkey and Thunderbird https://bugzilla.mozilla.org/attachment.cgi?id=308639&action=edit ------- Additional Comments from Bruno 'Aqualon' Escherl <aqualon@aquachan.de> This patch lets SeaMonkey use the same code as Thunderbird and removes the previous used code from mimevcrd.cpp I'll post a fron...

superreview requested: [Bug 290678] Port thunderbird's revised vcard attachment display to suite. : [Attachment 308639] Use the same vcard code for SeaMonkey and Thunderbird #2
Bruno 'Aqualon' Escherl <aqualon@aquachan.de> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 290678: Port thunderbird's revised vcard attachment display to suite. https://bugzilla.mozilla.org/show_bug.cgi?id=290678 Attachment 308639: Use the same vcard code for SeaMonkey and Thunderbird https://bugzilla.mozilla.org/attachment.cgi?id=308639&action=edit ...

superreview requested: [Bug 295729] crash after Firefox or Thunderbird checks for Extension/Theme updates
Benjamin Smedberg [:bs] (formerly bsmedberg@covad.net) <benjamin@smedbergs.us> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 295729: crash after Firefox or Thunderbird checks for Extension/Theme updates - Trunk FF11a1 TB11a1 [@ firefox-bin][@ thunderbird-bin] https://bugzilla.mozilla.org/show_bug.cgi?id=295729 Attachment 186966: New-doc check, rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=186966&action=edit ...

Web resources about - superreview granted: [Bug 273977] Thunderbird does not identify itself correctly to iListen voice rec application (Thunderbird.app vs thunderbird-bin ?) : [Attachment 220339] Patch that uses MOZ_APP_D - mozilla.dev.super-review

Resources last updated: 1/23/2016 12:32:43 PM