superreview granted: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 218487] updated patch ready for review
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 218487: updated patch ready for review https://bugzilla.mozilla.org/attachment.cgi?id=218487&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> my one concern is about migration from the per-server prefs to the global prefs. What happens in that scenar...

superreview requested: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 218487] updated patch ready for review
Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 218487: updated patch ready for review https://bugzilla.mozilla.org/attachment.cgi?id=218487&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> Here's what I did: 1) nsMsgAccountManagerDS.cpp.h Add code to display a junk mail panel for all accounts but news who h...

superreview granted: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 220052] migrate the new global settings
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 220052: migrate the new global settings https://bugzilla.mozilla.org/attachment.cgi?id=220052&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> great, thx. ...

superreview granted: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 222679] additional change
David Bienvenu - not reading bug mail from May 10th-May 18th <bienvenu@nventure.com> has granted Scott MacGregor (out of town May 11th-14th) <mscott@mozilla.org>'s request for superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 222679: additional change https://bugzilla.mozilla.org/attachment.cgi?id=222679&action=edit ...

superreview requested: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 220052] migrate the new global settings
Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 220052: migrate the new global settings https://bugzilla.mozilla.org/attachment.cgi?id=220052&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> This extra patch migrates the values for: manualMark, manualMarkMode and spamLogging from the default account to the new...

superreview requested: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 222679] additional change
Scott MacGregor (out of town May 11th-14th) <mscott@mozilla.org> has asked David Bienvenu - not reading bug mail from May 10th-May 18th <bienvenu@nventure.com> for superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 222679: additional change https://bugzilla.mozilla.org/attachment.cgi?id=222679&action=edit ------- Additional Comments from Scott MacGregor (out of town May 11th-14th) <mscott@mozilla.org> When I added manual mark as read to ...

superreview granted: [Bug 257801] Pressing "Cancel" in the "Defer Account?" warning closes the "Advanced Account Settings" dialog : [Attachment 157725] Fix
David Bienvenu <bienvenu@nventure.com> has granted Stefan Borggraefe <Stefan.Borggraefe@gmx.de>'s request for superreview: Bug 257801: Pressing "Cancel" in the "Defer Account?" warning closes the "Advanced Account Settings" dialog http://bugzilla.mozilla.org/show_bug.cgi?id=257801 Attachment 157725: Fix http://bugzilla.mozilla.org/attachment.cgi?id=157725&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> thx. I'm in the middle of making changes to this code, but I don't think this wil...

superreview granted: [Bug 216533] Move the "Composition" settings *above* the "Addressing" settings in the Account Settings : [Attachment 130078] Patch v0.1a
David Bienvenu <bienvenu@nventure.com> has granted Ian Neal <bugzilla@arlen.demon.co.uk>'s request for superreview: Bug 216533: Move the "Composition" settings *above* the "Addressing" settings in the Account Settings http://bugzilla.mozilla.org/show_bug.cgi?id=216533 Attachment 130078: Patch v0.1a http://bugzilla.mozilla.org/attachment.cgi?id=130078&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> sr=bienvenu ...

superreview requested: [Bug 257801] Pressing "Cancel" in the "Defer Account?" warning closes the "Advanced Account Settings" dialog : [Attachment 157725] Fix
Stefan Borggraefe <Stefan.Borggraefe@gmx.de> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 257801: Pressing "Cancel" in the "Defer Account?" warning closes the "Advanced Account Settings" dialog http://bugzilla.mozilla.org/show_bug.cgi?id=257801 Attachment 157725: Fix http://bugzilla.mozilla.org/attachment.cgi?id=157725&action=edit ...

superreview granted: [Bug 216789] "Server Settings" tab in "Account Settings" is too big for preferences window : [Attachment 130981] Revised Patch v0.2a
David Bienvenu <bienvenu@nventure.com> has granted Ian Neal <bugzilla@arlen.demon.co.uk>'s request for superreview: Bug 216789: "Server Settings" tab in "Account Settings" is too big for preferences window http://bugzilla.mozilla.org/show_bug.cgi?id=216789 Attachment 130981: Revised Patch v0.2a http://bugzilla.mozilla.org/attachment.cgi?id=130981&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> sr=bienvenu ...

superreview requested: [Bug 216533] Move the "Composition" settings *above* the "Addressing" settings in the Account Settings : [Attachment 130078] Patch v0.1a
Ian Neal <bugzilla@arlen.demon.co.uk> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 216533: Move the "Composition" settings *above* the "Addressing" settings in the Account Settings http://bugzilla.mozilla.org/show_bug.cgi?id=216533 Attachment 130078: Patch v0.1a http://bugzilla.mozilla.org/attachment.cgi?id=130078&action=edit ------- Additional Comments from Ian Neal <bugzilla@arlen.demon.co.uk> r= Neil carried forward ...

superreview granted: [Bug 444994] In <folderWidgets.xml>, "Error: aFolder is null", loading "Junk Settings" panel : [Attachment 333894] Fix regression per Neil's suggestion
neil@parkwaycc.co.uk <neil@httl.net> has granted Kent James (:rkent) <kent@caspia.com>'s request for superreview: Bug 444994: In <folderWidgets.xml>, "Error: aFolder is null", loading "Junk Settings" panel https://bugzilla.mozilla.org/show_bug.cgi?id=444994 Attachment 333894: Fix regression per Neil's suggestion https://bugzilla.mozilla.org/attachment.cgi?id=333894&action=edit ...

superreview granted: [Bug 257616] nsDOMClassInfo::sOuterHeight_id set to "outerWidth" when it should be "outerHeight" : [Attachment 157581] Fix.
Brendan Eich <brendan@mozilla.org> has granted Brendan Eich <brendan@mozilla.org>'s request for superreview: Bug 257616: nsDOMClassInfo::sOuterHeight_id set to "outerWidth" when it should be "outerHeight" http://bugzilla.mozilla.org/show_bug.cgi?id=257616 Attachment 157581: Fix. http://bugzilla.mozilla.org/attachment.cgi?id=157581&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> r+sr+a=me! /be ...

superreview granted: [Bug 234865] when "Regional Options / General" locale is set to "Serbian (Latin)" or "Serbian (Cyrillic)" wrong display of date in Page Info (Ctrl + J) : [Attachment 162030] Patc
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Simon Montagu <smontagu@smontagu.org>'s request for superreview: Bug 234865: when "Regional Options / General" locale is set to "Serbian (Latin)" or "Serbian (Cyrillic)" wrong display of date in Page Info (Ctrl + J) https://bugzilla.mozilla.org/show_bug.cgi?id=234865 Attachment 162030: Patch https://bugzilla.mozilla.org/attachment.cgi?id=162030&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> I don't...