Darin Fisher (Google) <darin@meer.net> has granted Marria Nazif
<marria@gmail.com>'s request for superreview:
Bug 241972: new window opened by window.open('xxx.exe') or target="_blank"
isn't closed automatically when a download begins
https://bugzilla.mozilla.org/show_bug.cgi?id=241972
Attachment 227564: fixes in response to Darin's review
https://bugzilla.mozilla.org/attachment.cgi?id=227564&action=edit
------- Additional Comments from Darin Fisher (Google) <darin@meer.net>
>Index: docshell/base/nsDocShell.cpp
> if (!refreshHeader.IsEmpty()) {
> SetupReferrerFromChannel(aChannel);
> rv = SetupRefreshURIFromHeader(mCurrentURI, refreshHeader);
>+ if (NS_SUCCEEDED(rv)) {
>+ return NS_REFRESHURI_HEADER_FOUND;
>+ }
> }
> }
whoops... 4 space indentation
>+ if (aIsNewWindowTarget) {
>+ nsCOMPtr<nsIWritablePropertyBag2> props = do_QueryInterface(channel);
>+ if (props) {
>+
props->SetPropertyAsBool(NS_LITERAL_STRING("docshell.newWindowTarget"),
>+ PR_TRUE);
>+ }
>+ }
ditto
sr=darin