superreview granted: [Bug 216456] 'font' with system font keyword and ' font-family' with generic font family keyword behaving incorrectly

Boris Zbarsky <bzbarsky@mit.edu> has granted David Baron [:dbaron]
<dbaron@mozilla.com>'s request for superreview:
Bug 216456: 'font' with system font keyword and 'font-family' with generic =
font
family keyword behaving incorrectly
https://bugzilla.mozilla.org/show_bug.cgi?id=3D216456

Attachment 271263: patch
https://bugzilla.mozilla.org/attachment.cgi?id=3D271263&action=3Dedit

------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu>
>+    if (i !=3D 0)=0D
>+	fontData.mFamily.Reset(); // avoid unnecessary operations in SetFont()=
=0D
=0D
Document that this is because i =3D=3D 0 is our own context and we do care =
about
the font-family then?=0D
=0D
r+sr=3Dbzbarsky.	Sorry for the delay; I have an irrational aversion to revi=
ewing
code I don't think I fully understand, so this took awhile.  :(=
0
bugzilla
7/26/2007 5:03:45 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
583 Views

Similar Articles

[PageSpeed] 56

Reply:

Similar Artilces:

superreview requested: [Bug 216456] 'font' with system font keyword and ' font-family' with generic font family keyword behaving incorrectly
David Baron [:dbaron] <dbaron@mozilla.com> has asked Boris Zbarsky (not available till July 4) <bzbarsky@mit.edu> for superreview: Bug 216456: 'font' with system font keyword and 'font-family' with generic font family keyword behaving incorrectly https://bugzilla.mozilla.org/show_bug.cgi?id=216456 Attachment 271007: patch https://bugzilla.mozilla.org/attachment.cgi?id=271007&action=edit ------- Additional Comments from David Baron [:dbaron] <dbaron@mozilla.com> We can't stomp on aFont as temporary storage because it's sometimes the only...

superreview canceled: [Bug 216456] 'font' with system font keyword and ' font-family' with generic font family keyword behaving incorrectly
David Baron [:dbaron] <dbaron@mozilla.com> has canceled David Baron [:dbaron] <dbaron@mozilla.com>'s request for superreview: Bug 216456: 'font' with system font keyword and 'font-family' with generic font family keyword behaving incorrectly https://bugzilla.mozilla.org/show_bug.cgi?id=216456 Attachment 271007: patch https://bugzilla.mozilla.org/attachment.cgi?id=271007&action=edit ------- Additional Comments from David Baron [:dbaron] <dbaron@mozilla.com> This seems to break generic fonts entirely, though. ...

superreview requested: [Bug 216456] 'font' with system font keyword and ' font-family' with generic font family keyword behaving incorrectly #2
David Baron [:dbaron] <dbaron@mozilla.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 216456: 'font' with system font keyword and 'font-family' with generic font family keyword behaving incorrectly https://bugzilla.mozilla.org/show_bug.cgi?id=216456 Attachment 271263: patch https://bugzilla.mozilla.org/attachment.cgi?id=271263&action=edit ------- Additional Comments from David Baron [:dbaron] <dbaron@mozilla.com> ....but I can effectively skip the optimization by changing SetGenericFont, which fixes the major problems with...

superreview canceled: [Bug 93725] 'bolder' and 'lighter' keywords of 'font-weight' don't work : [Attachment 323226] possible patch for this and #77882
Zack Weinberg <zweinberg@mozilla.com> has canceled Zack Weinberg <zweinberg@mozilla.com>'s request for superreview: Bug 93725: 'bolder' and 'lighter' keywords of 'font-weight' don't work https://bugzilla.mozilla.org/show_bug.cgi?id=93725 Attachment 323226: possible patch for this and #77882 https://bugzilla.mozilla.org/attachment.cgi?id=323226&action=edit ------- Additional Comments from Zack Weinberg <zweinberg@mozilla.com> retracting review request. ...

superreview requested: [Bug 93725] 'bolder' and 'lighter' keywords of 'font-weight' don't work : [Attachment 323226] possible patch for this and #77882
Zack Weinberg <zweinberg@mozilla.com> has asked David Baron [:dbaron] <dbaron@mozilla.com> for superreview: Bug 93725: 'bolder' and 'lighter' keywords of 'font-weight' don't work https://bugzilla.mozilla.org/show_bug.cgi?id=3D93725 Attachment 323226: possible patch for this and #77882 https://bugzilla.mozilla.org/attachment.cgi?id=3D323226&action=3Dedit ------- Additional Comments from Zack Weinberg <zweinberg@mozilla.com> This proved to be pretty simple to fix, with some caveats. The attached pa= tch passes Hixie's test linke...

superreview granted: [Bug 420822] Hiragino fonts display as bold for 'font-weight:500' : [Attachment 307170] patch, missing 500 weight font should fallback to lighter weights
Stuart Parmenter <pavlov@pavlov.net> has granted John Daggett (:jtd) <jdaggett@mozilla.com>'s request for superreview: Bug 420822: Hiragino fonts display as bold for 'font-weight:500' https://bugzilla.mozilla.org/show_bug.cgi?id=420822 Attachment 307170: patch, missing 500 weight font should fallback to lighter weights https://bugzilla.mozilla.org/attachment.cgi?id=307170&action=edit ...

superreview granted: [Bug 96041] Left or right pixels of 'F' 'J' 'M' 'W' characters overflow and lack hover color (bounding box / font metrics problem)
David Baron [:dbaron] (less responsive until September 17) <dbaron@mozilla.com> has granted Robert O'Callahan (:roc) <roc@ocallahan.org>'s request for superreview: Bug 96041: Left or right pixels of 'F' 'J' 'M' 'W' characters overflow and lack hover color (bounding box / font metrics problem) https://bugzilla.mozilla.org/show_bug.cgi?id=96041 Attachment 281783: updated patch v6 https://bugzilla.mozilla.org/attachment.cgi?id=281783&action=edit ------- Additional Comments from David Baron [:dbaron] (less responsive until Septem...

superreview granted: [Bug 96041] Left or right pixels of 'F' 'J' 'M' 'W' characters overflow and lack hover color (bounding box / font metrics problem) #2
David Baron [:dbaron] (less responsive until September 17) <dbaron@mozilla.com> has granted superreview: Bug 96041: Left or right pixels of 'F' 'J' 'M' 'W' characters overflow and lack hover color (bounding box / font metrics problem) https://bugzilla.mozilla.org/show_bug.cgi?id=96041 Attachment 282043: updated patch v7 https://bugzilla.mozilla.org/attachment.cgi?id=282043&action=edit ------- Additional Comments from David Baron [:dbaron] (less responsive until September 17) <dbaron@mozilla.com> File a bug on the XXX comment in nsBu...

IMP for indian national language"Hindi fonts 'or' u can say Devanagri font 'or' known as mangal font in word pad"
Name: sourabh verma Email: sourabh.iitm_at_gmail.com Product: Firefox Summary: IMP for indian national language"Hindi fonts 'or' u can say Devanagri font 'or' known as mangal font in word pad" Comments: Sir, I would like to tell you that "Hindi fonts 'or' u can say Devanagri font 'or' known as mangal font in word pad" are not coming properly in mozilla. They r coming properly in internet explorer.. words like &#2354;&#2375;&#2325;&#2367;&#2344; , &#2348;&#2361;&#2369;&#2340; ,&#2311;...

superreview requested: [Bug 420822] Hiragino fonts display as bold for 'font-weight:500' : [Attachment 307170] patch, missing 500 weight font should fallback to lighter weights
John Daggett (:jtd) <jdaggett@mozilla.com> has asked Robert O'Callahan (:roc) <roc@ocallahan.org> for superreview: Bug 420822: Hiragino fonts display as bold for 'font-weight:500' https://bugzilla.mozilla.org/show_bug.cgi?id=420822 Attachment 307170: patch, missing 500 weight font should fallback to lighter weights https://bugzilla.mozilla.org/attachment.cgi?id=307170&action=edit ...

superreview requested: [Bug 420822] Hiragino fonts display as bold for 'font-weight:500' : [Attachment 307170] patch, missing 500 weight font should fallback to lighter weights #2
John Daggett (:jtd) <jdaggett@mozilla.com> has asked Stuart Parmenter <pavlov@pavlov.net> for superreview: Bug 420822: Hiragino fonts display as bold for 'font-weight:500' https://bugzilla.mozilla.org/show_bug.cgi?id=420822 Attachment 307170: patch, missing 500 weight font should fallback to lighter weights https://bugzilla.mozilla.org/attachment.cgi?id=307170&action=edit ------- Additional Comments from John Daggett (:jtd) <jdaggett@mozilla.com> (In reply to comment #5) > I've never looked at this code before in my life, maybe Stuart should re...

superreview canceled: [Bug 96041] Left or right pixels of 'F' 'J' 'M' 'W' characters overflow and lack hover color (bounding box / font metrics problem)
Robert O'Callahan (:roc) <roc@ocallahan.org> has canceled Robert O'Callahan (:roc) <roc@ocallahan.org>'s request for superreview: Bug 96041: Left or right pixels of 'F' 'J' 'M' 'W' characters overflow and lack hover color (bounding box / font metrics problem) https://bugzilla.mozilla.org/show_bug.cgi?id=96041 Attachment 278456: updated patch v2 https://bugzilla.mozilla.org/attachment.cgi?id=278456&action=edit ...

superreview requested: [Bug 96041] Left or right pixels of 'F' 'J' 'M' 'W' characters overflow and lack hover color (bounding box / font metrics problem)
Robert O'Callahan <roc@ocallahan.org> has asked David Baron [:dbaron] (less responsive until September 17) <dbaron@mozilla.com> for superreview: Bug 96041: Left or right pixels of 'F' 'J' 'M' 'W' characters overflow and lack hover color (bounding box / font metrics problem) https://bugzilla.mozilla.org/show_bug.cgi?id=96041 Attachment 278456: updated patch v2 https://bugzilla.mozilla.org/attachment.cgi?id=278456&action=edit ------- Additional Comments from Robert O'Callahan <roc@ocallahan.org> The layout changes need rev...

superreview granted: [Bug 282830] move down 'Other languages' and 'User defined' to the end in the font selection pref. panel : [Attachment 174787] patch
Brian Ryner (IBM) <bryner@brianryner.com> has granted Jungshik Shin <jshin1987@gmail.com>'s request for superreview: Bug 282830: move down 'Other languages' and 'User defined' to the end in the font selection pref. panel https://bugzilla.mozilla.org/show_bug.cgi?id=282830 Attachment 174787: patch https://bugzilla.mozilla.org/attachment.cgi?id=174787&action=edit ...

Web resources about - superreview granted: [Bug 216456] 'font' with system font keyword and ' font-family' with generic font family keyword behaving incorrectly - mozilla.dev.super-review

Resources last updated: 1/17/2016 4:51:43 PM