superreview granted: [Bug 193332] about:config doesn't remove deleted prefs with no default : [Attachment 219490] don't remove entries while enumerating

Darin Fisher (Google) <darin@meer.net> has granted Andrew Schultz
<ajschult@verizon.net>'s request for superreview:
Bug 193332: about:config doesn't remove deleted prefs with no default
https://bugzilla.mozilla.org/show_bug.cgi?id=193332

Attachment 219490: don't remove entries while enumerating
https://bugzilla.mozilla.org/attachment.cgi?id=219490&action=edit

------- Additional Comments from Darin Fisher (Google) <darin@meer.net>
r+sr=darin with BOGUS_DEFAULT_BOOL_PREF_VALUE
0
bugzilla
6/5/2006 7:31:58 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
751 Views

Similar Articles

[PageSpeed] 26

Reply:

Similar Artilces:

superreview requested: [Bug 193332] about:config doesn't remove deleted prefs with no default : [Attachment 219490] don't remove entries while enumerating
Andrew Schultz <ajschult@verizon.net> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 193332: about:config doesn't remove deleted prefs with no default https://bugzilla.mozilla.org/show_bug.cgi?id=193332 Attachment 219490: don't remove entries while enumerating https://bugzilla.mozilla.org/attachment.cgi?id=219490&action=edit ------- Additional Comments from Andrew Schultz <ajschult@verizon.net> Running with this, I noticed it asserts during profile switch (I don't remember that before) due to pldhash recursion. This handles t...

superreview requested: [Bug 193332] about:config doesn't remove deleted prefs with no default : [Attachment 225230] frontend patch
Andrew Schultz <ajschult@verizon.net> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 193332: about:config doesn't remove deleted prefs with no default https://bugzilla.mozilla.org/show_bug.cgi?id=193332 Attachment 225230: frontend patch https://bugzilla.mozilla.org/attachment.cgi?id=225230&action=edit ------- Additional Comments from Andrew Schultz <ajschult@verizon.net> updates about:config to remove prefs without a type ...

superreview cancelled: [Bug 193332] about:config doesn't remove deleted prefs with no default : [Attachment 218623] do what the comment says
Andrew Schultz <ajschult@verizon.net> has cancelled Andrew Schultz <ajschult@verizon.net>'s request for superreview: Bug 193332: about:config doesn't remove deleted prefs with no default https://bugzilla.mozilla.org/show_bug.cgi?id=193332 Attachment 218623: do what the comment says https://bugzilla.mozilla.org/attachment.cgi?id=218623&action=edit ------- Additional Comments from Andrew Schultz <ajschult@verizon.net> Running with this, I noticed it asserts during profile switch (I don't remember that before) due to pldhash recursion. This handles th...

superreview denied: [Bug 193332] about:config doesn't remove deleted prefs with no default : [Attachment 225230] frontend patch
neil@parkwaycc.co.uk <neil@httl.net> has denied Andrew Schultz <ajschult@verizon.net>'s request for superreview: Bug 193332: about:config doesn't remove deleted prefs with no default https://bugzilla.mozilla.org/show_bug.cgi?id=193332 Attachment 225230: frontend patch https://bugzilla.mozilla.org/attachment.cgi?id=225230&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> I don't think this would be complete without an extra "Delete" context menuitem to be shown instead of the existing "Reset" menui...

superreview requested: [Bug 193332] about:config doesn't remove deleted prefs with no default : [Attachment 218623] do what the comment says
Andrew Schultz <ajschult@verizon.net> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 193332: about:config doesn't remove deleted prefs with no default https://bugzilla.mozilla.org/show_bug.cgi?id=193332 Attachment 218623: do what the comment says https://bugzilla.mozilla.org/attachment.cgi?id=218623&action=edit ------- Additional Comments from Andrew Schultz <ajschult@verizon.net> This just does what the comment says would work without saying why it isn't done. It works. To get rid of the pref displayed in about:config, you hav...

superreview granted: [Bug 245619] Don't bother converting result of scripts into a string when the caller doesn't care about the value. : [Attachment 150056] Don't convert the result to a string if t
Brendan Eich <brendan@mozilla.org> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 245619: Don't bother converting result of scripts into a string when the caller doesn't care about the value. http://bugzilla.mozilla.org/show_bug.cgi?id=245619 Attachment 150056: Don't convert the result to a string if the caller doesn't care about the return value. http://bugzilla.mozilla.org/attachment.cgi?id=150056&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> Duh, thanks. r+sr=me....

superreview granted: [Bug 66410] Deleting addressbook should also delete corresponding mab file : [Attachment 171183] Don't always create a database file if one doesn't exist
Scott MacGregor <mscott@mozilla.org> has granted Mark Banner <mark@standard8.demon.co.uk>'s request for superreview: Bug 66410: Deleting addressbook should also delete corresponding mab file https://bugzilla.mozilla.org/show_bug.cgi?id=66410 Attachment 171183: Don't always create a database file if one doesn't exist https://bugzilla.mozilla.org/attachment.cgi?id=171183&action=edit ...

superreview granted: [Bug 451232] Setting ui.textHighlightBackground pref to empty string or removing pref doesn't reset directly default highlight : [Attachment 334679] Patch v1
Robert O'Callahan (:roc) (Mozilla Corporation) <roc@ocallahan.org> has granted Graeme McCutcheon <graememcc_firefox@graeme-online.co.uk>'s request for superreview: Bug 451232: Setting ui.textHighlightBackground pref to empty string or removing pref doesn't reset directly default highlight https://bugzilla.mozilla.org/show_bug.cgi?id=451232 Attachment 334679: Patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=334679&action=edit ------- Additional Comments from Robert O'Callahan (:roc) (Mozilla Corporation) <roc@ocallahan.org> Excellent, t...

superreview granted: [Bug 340083] Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title in defs : [Attachment 224205] don't create frames for content we don't handle, don't invalidate nond
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted superreview: Bug 340083: Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title in defs https://bugzilla.mozilla.org/show_bug.cgi?id=340083 Attachment 224205: don't create frames for content we don't handle, don't invalidate nondisplay content https://bugzilla.mozilla.org/attachment.cgi?id=224205&action=edit ...

superreview granted: [Bug 436214] Deleting an imap message offline can cause an assertion nsMsgHdr::SetThreadParent "can't be your own parent : [Attachment 323133] remove stuff that didn't belong in p
neil@parkwaycc.co.uk <neil@httl.net> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 436214: Deleting an imap message offline can cause an assertion nsMsgHdr::SetThreadParent "can't be your own parent https://bugzilla.mozilla.org/show_bug.cgi?id=3D436214 Attachment 323133: remove stuff that didn't belong in previous patch https://bugzilla.mozilla.org/attachment.cgi?id=3D323133&action=3Dedit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> >- attribute long ImapUidValidity;=0D >- a...

superreview granted: [Bug 252984] Cannot type in any of the fields
Aaron Leventhal <aaronleventhal@moonset.net> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 252984: Cannot type in any of the fields - forms don't get focus on left-click http://bugzilla.mozilla.org/show_bug.cgi?id=252984 Attachment 154652: Correct patch. In the last one The last patch didn't include the removal of the call to FocusableAncestor() in nsFrame::IsFocusable() http://bugzilla.mozilla.org/attachment.cgi?id=154652&action=edit ------- Additional Comments from Aaron Leventhal <aaronleventhal@moonset.net...

superreview granted: [Bug 264442] plugin finder can't find anything for windows media. : [Attachment 162212] Don't assume we don't have a plugin before getting a responce from the network.
Boris Zbarsky <bzbarsky@mit.edu> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 264442: plugin finder can't find anything for windows media. https://bugzilla.mozilla.org/show_bug.cgi?id=264442 Attachment 162212: Don't assume we don't have a plugin before getting a responce from the network. https://bugzilla.mozilla.org/attachment.cgi?id=162212&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> r+sr=bzbarsky, I guess.. Is ther a reason mIsBrokenPlugin is write-only? ...

superreview requested: [Bug 245619] Don't bother converting result of scripts into a string when the caller doesn't care about the value. : [Attachment 150056] Don't convert the result to a string if
Johnny Stenback <jst@mozilla.jstenback.com> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 245619: Don't bother converting result of scripts into a string when the caller doesn't care about the value. http://bugzilla.mozilla.org/show_bug.cgi?id=245619 Attachment 150056: Don't convert the result to a string if the caller doesn't care about the return value. http://bugzilla.mozilla.org/attachment.cgi?id=150056&action=edit ...

superreview granted: [Bug 87513] about:<randomness> doesn't display a default page, if the about: topic doesn't exist. : [Attachment 195365] Simple fix
Darin Fisher <darin@meer.net> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 87513: about:<randomness> doesn't display a default page, if the about: topic doesn't exist. https://bugzilla.mozilla.org/show_bug.cgi?id=87513 Attachment 195365: Simple fix https://bugzilla.mozilla.org/attachment.cgi?id=195365&action=edit ------- Additional Comments from Darin Fisher <darin@meer.net> sr=darin ...

Web resources about - superreview granted: [Bug 193332] about:config doesn't remove deleted prefs with no default : [Attachment 219490] don't remove entries while enumerating - mozilla.dev.super-review

Resources last updated: 11/25/2015 12:58:29 PM