superreview granted: [Bug 188108] Inline-Forward of message with unnamed RFC822 attachment unnecessarily adds name to the headers: (null).eml : [Attachment 223717] use ForwardedMessage.eml as attachme

Scott MacGregor <mscott@mozilla.org> has granted Magnus Melin
<mkmelin+mozilla@iki.fi>'s request for superreview:
Bug 188108: Inline-Forward of message with unnamed RFC822 attachment
unnecessarily adds name to the headers: (null).eml
https://bugzilla.mozilla.org/show_bug.cgi?id=188108

Attachment 223717: use ForwardedMessage.eml as attachment name if the we don't
know the name
https://bugzilla.mozilla.org/attachment.cgi?id=223717&action=edit

------- Additional Comments from Scott MacGregor <mscott@mozilla.org>
sr=mscott, but I'd be curious to note what happens if we just didn't fill in a
real_name at all here, since it didn't have a name to begin with. 

i.e. 

    else if (tmpSpec.get())
-	   NS_MsgSACopy ( &(tmp->real_name), tmpSpec.get() );
0
bugzilla
8/9/2006 6:02:24 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
626 Views

Similar Articles

[PageSpeed] 26

Reply:

Similar Artilces:

superreview requested: [Bug 188108] Inline-Forward of message with unnamed RFC822 attachment unnecessarily adds name to the headers: (null).eml : [Attachment 223717] use ForwardedMessage.eml as attach
Magnus Melin <mkmelin+mozilla@iki.fi> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 188108: Inline-Forward of message with unnamed RFC822 attachment unnecessarily adds name to the headers: (null).eml https://bugzilla.mozilla.org/show_bug.cgi?id=188108 Attachment 223717: use ForwardedMessage.eml as attachment name if the we don't know the name https://bugzilla.mozilla.org/attachment.cgi?id=223717&action=edit ...

superreview granted: [Bug 154332] Forwarding a ".EML" attachment adds additional ".EML" to file name. : [Attachment 212403] proposed fix
David Bienvenu <bienvenu@nventure.com> has granted Magnus Melin <mkmelin+bugzilla@cc.hut.fi>'s request for superreview: Bug 154332: Forwarding a ".EML" attachment adds additional ".EML" to file name. https://bugzilla.mozilla.org/show_bug.cgi?id=154332 Attachment 212403: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=212403&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> yeah, let's try it on the trunk - I'm a little worried about this as well. ...

superreview granted: [Bug 204350] (message/rfc822) Attached email message window glitches (forward, reply, view source disabled) : [Attachment 200351] support reply/forward (as attachment and inline)
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 204350: (message/rfc822) Attached email message window glitches (forward, reply, view source disabled) https://bugzilla.mozilla.org/show_bug.cgi?id=204350 Attachment 200351: support reply/forward (as attachment and inline) for message/rfc822 attachments https://bugzilla.mozilla.org/attachment.cgi?id=200351&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> + rv = NS_NewURI(getter_AddRefs(uri), messageURI...

superreview requested: [Bug 204350] (message/rfc822) Attached email message window glitches (forward, reply, view source disabled) : [Attachment 200351] support reply/forward (as attachment and inlin
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 204350: (message/rfc822) Attached email message window glitches (forward, reply, view source disabled) https://bugzilla.mozilla.org/show_bug.cgi?id=204350 Attachment 200351: support reply/forward (as attachment and inline) for message/rfc822 attachments https://bugzilla.mozilla.org/attachment.cgi?id=200351&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> with this patch, thunderbird supports reply + forward as attachme...

superreview granted: [Bug 241212] Message window for .EML file needs envelope panel : [Attachment 193489] enable opening of attachments from .eml files opened in stand-along window
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 241212: Message window for .EML file needs envelope panel https://bugzilla.mozilla.org/show_bug.cgi?id=241212 Attachment 193489: enable opening of attachments from .eml files opened in stand-along window https://bugzilla.mozilla.org/attachment.cgi?id=193489&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> I don't know what the answer is to Neil's comment about using LOAD_FLAGS_LINK. I know everywhe...

superreview granted: [Bug 250291] html messages: forward as inline not quoting headers or inserting "original message" header : [Attachment 152960] Proposed patch
David Bienvenu <bienvenu@nventure.com> has granted neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview: Bug 250291: html messages: forward as inline not quoting headers or inserting "original message" header http://bugzilla.mozilla.org/show_bug.cgi?id=250291 Attachment 152960: Proposed patch http://bugzilla.mozilla.org/attachment.cgi?id=152960&action=edit ...

superreview granted: [Bug 380354] TB2 adds ".eml" extension to attached messages, causes virus scanner to complain; TB1. 5 was OK : [Attachment 294485] Proposed fix (v4)
David Bienvenu <bienvenu@nventure.com> has granted rsx11m.pub@gmail.com's request for superreview: Bug 380354: TB2 adds ".eml" extension to attached messages, causes virus scanner to complain; TB1.5 was OK https://bugzilla.mozilla.org/show_bug.cgi?id=380354 Attachment 294485: Proposed fix (v4) https://bugzilla.mozilla.org/attachment.cgi?id=294485&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> thx for the patch. ...

superreview granted: [Bug 217149] Thunderbird can't open .eml files or handle message/rfc822 MIME-type : [Attachment 145713] Add msg extension
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 217149: Thunderbird can't open .eml files or handle message/rfc822 MIME-type http://bugzilla.mozilla.org/show_bug.cgi?id=217149 Attachment 145713: Add msg extension http://bugzilla.mozilla.org/attachment.cgi?id=145713&action=edit ...

superreview granted: [Bug 343102] Thunderbird cannot forward messages correctly in the inline format when the message contains attachments encoded in quoted-printable format : [Attachment 239997] prop
Scott MacGregor <mscott@mozilla.org> has granted Mike Cowperthwaite <mcow@well.com>'s request for superreview: Bug 343102: Thunderbird cannot forward messages correctly in the inline format when the message contains attachments encoded in quoted-printable format https://bugzilla.mozilla.org/show_bug.cgi?id=343102 Attachment 239997: proposed patch - file mailnews/mime/src/mimeenc.cpp https://bugzilla.mozilla.org/attachment.cgi?id=239997&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> cool. Thanks for the patch, and a libmim...

superreview granted: [Bug 343102] Thunderbird cannot forward messages correctly in the inline format when the message contains attachments encoded in quoted-printable format : [Attachment 242221] addi
neil@parkwaycc.co.uk <neil@httl.net> has granted Gavin Sharp <gavin.sharp@gmail.com>'s request for superreview: Bug 343102: Thunderbird cannot forward messages correctly in the inline format when the message contains attachments encoded in quoted-printable format https://bugzilla.mozilla.org/show_bug.cgi?id=343102 Attachment 242221: additional cleanup patch, v3 https://bugzilla.mozilla.org/attachment.cgi?id=242221&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> >+ /* Treat null bytes as spaces when format_out is >+ ...

superreview granted: [Bug 204350] (message/rfc822) Attached email message window glitches (forward, reply, view source disabled) : [Attachment 201005] front end part
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 204350: (message/rfc822) Attached email message window glitches (forward, reply, view source disabled) https://bugzilla.mozilla.org/show_bug.cgi?id=204350 Attachment 201005: front end part https://bugzilla.mozilla.org/attachment.cgi?id=201005&action=edit ...

superreview granted: [Bug 373954] Cannot send any attachment files which are attached in original message when I forward a mail as inline
David Bienvenu <bienvenu@nventure.com> has granted Masayuki Nakano (Mozilla Japan)(busy) <masayuki@d-toybox.com>'s request for superreview: Bug 373954: Cannot send any attachment files which are attached in original message when I forward a mail as inline https://bugzilla.mozilla.org/show_bug.cgi?id=3D373954 Attachment 258599: Patch rv1.1 https://bugzilla.mozilla.org/attachment.cgi?id=3D258599&action=3Dedit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> thx for the patch!=0D =0D two nits:=0D =0D you don't need this:=0D =0D...

superreview granted: [Bug 373954] Cannot send any attachment files which are attached in original message when I forward a mail as inline #2
Masayuki Nakano (Mozilla Japan)(busy) <masayuki@d-toybox.com> has granted superreview: Bug 373954: Cannot send any attachment files which are attached in original message when I forward a mail as inline https://bugzilla.mozilla.org/show_bug.cgi?id=373954 Attachment 258657: Patch rv1.2 https://bugzilla.mozilla.org/attachment.cgi?id=258657&action=edit ...

superreview granted: [Bug 288906] Return null for MSAA name when no name explicitly set for HTML form control : [Attachment 179538] If no name explictly set for form control, use SetIsVoid(null)
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 288906: Return null for MSAA name when no name explicitly set for HTML form control https://bugzilla.mozilla.org/show_bug.cgi?id=288906 Attachment 179538: If no name explictly set for form control, use SetIsVoid(null) https://bugzilla.mozilla.org/attachment.cgi?id=179538&action=edit ...

Web resources about - superreview granted: [Bug 188108] Inline-Forward of message with unnamed RFC822 attachment unnecessarily adds name to the headers: (null).eml : [Attachment 223717] use ForwardedMessage.eml as attachme - mozilla.dev.super-review

Resources last updated: 1/2/2016 4:57:38 AM