superreview requested: [Bug 185662] In SMTP prefs, make it clear what "use secure connection (SSL)" really means : [Attachment 245106] Jan Braun's patch, unbitrotted and including thunderbird (not jusMagnus Melin <mkmelin+mozilla@iki.fi> has asked David Bienvenu
<bienvenu@nventure.com> for superreview:
Bug 185662: In SMTP prefs, make it clear what "use secure connection (SSL)"
really means
https://bugzilla.mozilla.org/show_bug.cgi?id=185662
Attachment 245106: Jan Braun's patch, unbitrotted and including thunderbird
(not just seamonkey)
https://bugzilla.mozilla.org/attachment.cgi?id=245106&action=edit
------- Additional Comments from Magnus Melin <mkmelin+mozilla@iki.fi>
This does the same thing as the patch that already got r,sr. Only now it...
superreview granted: [Bug 185662] In SMTP prefs, make it clear what "use secure connection (SSL)" really means : [Attachment 162528] updated version of STARTTLS/SMTP-over-SSL patchDavid Bienvenu <bienvenu@nventure.com> has granted Nelson Bolyard
<nelson@bolyard.com>'s request for superreview:
Bug 185662: In SMTP prefs, make it clear what "use secure connection (SSL)"
really means
https://bugzilla.mozilla.org/show_bug.cgi?id=185662
Attachment 162528: updated version of STARTTLS/SMTP-over-SSL patch
https://bugzilla.mozilla.org/attachment.cgi?id=162528&action=edit
------- Additional Comments from David Bienvenu <bienvenu@nventure.com>
we need to make sure this doesn't overflow the dialog because of the longer
string (STA...
superreview requested: [Bug 185662] In SMTP prefs, make it clear what "use secure connection (SSL)" really means : [Attachment 162528] updated version of STARTTLS/SMTP-over-SSL patchNelson Bolyard <nelson@bolyard.com> has asked David Bienvenu
<bienvenu@nventure.com> for superreview:
Bug 185662: In SMTP prefs, make it clear what "use secure connection (SSL)"
really means
https://bugzilla.mozilla.org/show_bug.cgi?id=185662
Attachment 162528: updated version of STARTTLS/SMTP-over-SSL patch
https://bugzilla.mozilla.org/attachment.cgi?id=162528&action=edit
...
superreview granted: [Bug 185662] In SMTP prefs, make it clear what " use secure connection (SSL)" really meansDavid Bienvenu <bienvenu@nventure.com> has granted Magnus Melin
<mkmelin+mozilla@iki.fi>'s request for superreview:
Bug 185662: In SMTP prefs, make it clear what "use secure connection (SSL)"
really means
https://bugzilla.mozilla.org/show_bug.cgi?id=185662
Attachment 266951: proposed additional fix
https://bugzilla.mozilla.org/attachment.cgi?id=266951&action=edit
...
superreview requested: [Bug 185662] In SMTP prefs, make it clear what " use secure connection (SSL)" really meansMagnus Melin <mkmelin+mozilla@iki.fi> has asked David Bienvenu
<bienvenu@nventure.com> for superreview:
Bug 185662: In SMTP prefs, make it clear what "use secure connection (SSL)"
really means
https://bugzilla.mozilla.org/show_bug.cgi?id=185662
Attachment 266951: proposed additional fix
https://bugzilla.mozilla.org/attachment.cgi?id=266951&action=edit
------- Additional Comments from Magnus Melin <mkmelin+mozilla@iki.fi>
Fix the displayed smtp info also...
...
superreview granted: [Bug 225809] Don't fall back to insecure authentication if "use secure authentication" is checked : [Attachment 136279] patch addressing mscott's commentsLorenzo Colitti <lorenzo@colitti.com> has granted Lorenzo Colitti
<lorenzo@colitti.com>'s request for superreview:
Bug 225809: Don't fall back to insecure authentication if "use secure
authentication" is checked
http://bugzilla.mozilla.org/show_bug.cgi?id=225809
Attachment 136279: patch addressing mscott's comments
http://bugzilla.mozilla.org/attachment.cgi?id=136279&action=edit
------- Additional Comments from Lorenzo Colitti <lorenzo@colitti.com>
Carrying forward r= and sr=
...
superreview granted: [Bug 31685] changing "use secure connection" doesn't affect the icons in the folder pane until restart (toggling SSL connection type does not immediately show lock) : [AttachmentDavid Bienvenu <bienvenu@nventure.com> has granted neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview:
Bug 31685: changing "use secure connection" doesn't affect the icons in the
folder pane until restart (toggling SSL connection type does not immediately
show lock)
https://bugzilla.mozilla.org/show_bug.cgi?id=31685
Attachment 194837: Fixed patch
https://bugzilla.mozilla.org/attachment.cgi?id=194837&action=edit
...
superreview granted: [Bug 313217] document.open('replace') now opens text/plain document where it used to open text/html : [Attachment 200309] Patch to make a type of "replace" mean HTML but not replJohnny Stenback <jst@mozilla.org> has granted Boris Zbarsky
<bzbarsky@mit.edu>'s request for superreview:
Bug 313217: document.open('replace') now opens text/plain document where it
used to open text/html
https://bugzilla.mozilla.org/show_bug.cgi?id=313217
Attachment 200309: Patch to make a type of "replace" mean HTML but not replace
https://bugzilla.mozilla.org/attachment.cgi?id=200309&action=edit
------- Additional Comments from Johnny Stenback <jst@mozilla.org>
r+sr=jst
...
superreview granted: [Bug 427293] "Secure Connection Failed" makes it difficult to work in the web hosting industry : [Attachment 318920] same using new prefDaniel Veditz <dveditz@cruzio.com> has granted superreview:
Bug 427293: "Secure Connection Failed" makes it difficult to work in the web
hosting industry
https://bugzilla.mozilla.org/show_bug.cgi?id=3D427293
Attachment 318920: same using new pref
https://bugzilla.mozilla.org/attachment.cgi?id=3D318920&action=3Dedit
------- Additional Comments from Daniel Veditz <dveditz@cruzio.com>
Same as before except using a separate pref rather than assuming the state =
of
the "cert pre-fetch" pref.=
...
superreview granted: [Bug 237228] pref "layout.word_select.eat_space_to_next_word" can't be set by user in the profile's prefs.js : [Attachment 158389] patch, add UnregisterPrefCallbackRobert O'Callahan <roc@ocallahan.org> has granted Ginn Chen
<ginn.chen@sun.com>'s request for superreview:
Bug 237228: pref "layout.word_select.eat_space_to_next_word" can't be set by
user in the profile's prefs.js
http://bugzilla.mozilla.org/show_bug.cgi?id=237228
Attachment 158389: patch, add UnregisterPrefCallback
http://bugzilla.mozilla.org/attachment.cgi?id=158389&action=edit
...
superreview cancelled: [Bug 295774] "Clear" vs. "Empty" wording is inconsistent (cache/history in prefs vs menus) : [Attachment 202628] History prefPane's History.nib with "Clear History" and "Empty Mike Pinkerton <mikepinkerton@mac.com> has cancelled Smokey Ardisson
<alqahira@mindspring.com>'s request for superreview:
Bug 295774: "Clear" vs. "Empty" wording is inconsistent (cache/history in prefs
vs menus)
https://bugzilla.mozilla.org/show_bug.cgi?id=295774
Attachment 202628: History prefPane's History.nib with "Clear History�" and
"Empty Cache�"
https://bugzilla.mozilla.org/attachment.cgi?id=202628&action=edit
...
superreview requested: [Bug 295774] "Clear" vs. "Empty" wording is inconsistent (cache/history in prefs vs menus) : [Attachment 202628] History prefPane's History.nib with "Clear History" and "Empty Smokey Ardisson <alqahira@mindspring.com> has asked Mike Pinkerton
<mikepinkerton@mac.com> for superreview:
Bug 295774: "Clear" vs. "Empty" wording is inconsistent (cache/history in prefs
vs menus)
https://bugzilla.mozilla.org/show_bug.cgi?id=295774
Attachment 202628: History prefPane's History.nib with "Clear History�" and
"Empty Cache�"
https://bugzilla.mozilla.org/attachment.cgi?id=202628&action=edit
------- Additional Comments from Smokey Ardisson <alqahira@mindspring.com>
So the buttons are now "Clear Hist...
superreview granted: [Bug 102269] Cookie Manager: "Server Secure" should be "Secure Server" : [Attachment 143120] patch v2 including dialog updateAlec Flett <alecf@flett.org> has granted Mike Connor <mconnor@myrealbox.com>'s
request for superreview:
Bug 102269: Cookie Manager: "Server Secure" should be "Secure Server"
http://bugzilla.mozilla.org/show_bug.cgi?id=102269
Attachment 143120: patch v2 including dialog update
http://bugzilla.mozilla.org/attachment.cgi?id=143120&action=edit
------- Additional Comments from Alec Flett <alecf@flett.org>
sr=alecf
...
superreview granted: [Bug 122238] input type="image" doesn't send x/y (image doesn't exist; width and height not set) : [Attachment 139545] Same as jkeiser's patch, really...Johnny Stenback <jst@mozilla.jstenback.com> has granted Boris Zbarsky
<bz-vacation@mit.edu>'s request for superreview:
Bug 122238: input type="image" doesn't send x/y (image doesn't exist; width and
height not set)
http://bugzilla.mozilla.org/show_bug.cgi?id=122238
Attachment 139545: Same as jkeiser's patch, really...
http://bugzilla.mozilla.org/attachment.cgi?id=139545&action=edit
------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com>
+ if (!name.IsEmpty()) {
+ aFormSubmission->AddNameValuePair(thi...