superreview granted: [Bug 155537] Text in multipart message does not show if Content-Type is blank [ Mail with attachments sent by Outlook don't work] : [Attachment 294768] proposed fix

David Bienvenu <bienvenu@nventure.com> has granted Magnus Melin
<mkmelin+mozilla@iki.fi>'s request for superreview:
Bug 155537: Text in multipart message does not show if Content-Type is blank
[Mail with attachments sent by Outlook don't work]
https://bugzilla.mozilla.org/show_bug.cgi?id=155537

Attachment 294768: proposed fix
https://bugzilla.mozilla.org/attachment.cgi?id=294768&action=edit

------- Additional Comments from David Bienvenu <bienvenu@nventure.com>
sr=bienvenu, except, instead of 

+  if (!obj->content_type || strlen(obj->content_type) == 0)


you can just use if (!obj->content_type || !*(obj->content_type))

it's faster and less code than doing strlen...
0
bugzilla
12/28/2007 8:28:19 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
624 Views

Similar Articles

[PageSpeed] 19

Reply:

Similar Artilces:

superreview requested: [Bug 155537] Text in multipart message does not show if Content-Type is blank [ Mail with attachments sent by Outlook don't work] : [Attachment 294768] proposed fix
Magnus Melin <mkmelin+mozilla@iki.fi> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 155537: Text in multipart message does not show if Content-Type is blank [Mail with attachments sent by Outlook don't work] https://bugzilla.mozilla.org/show_bug.cgi?id=155537 Attachment 294768: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=294768&action=edit ------- Additional Comments from Magnus Melin <mkmelin+mozilla@iki.fi> The problem was that when the header value is an empty string we iterate over to the next line and the value...

superreview granted: [Bug 189174] MAPISendMail does not copy file attachment to message before returning (WinZip 'Zip and e-mail' doesn't work) : [Attachment 166809] proposed fix
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 189174: MAPISendMail does not copy file attachment to message before returning (WinZip 'Zip and e-mail' doesn't work) https://bugzilla.mozilla.org/show_bug.cgi?id=189174 Attachment 166809: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=166809&action=edit ...

superreview requested: [Bug 189174] MAPISendMail does not copy file attachment to message before returning (WinZip 'Zip and e-mail' doesn't work) : [Attachment 166809] proposed fix
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 189174: MAPISendMail does not copy file attachment to message before returning (WinZip 'Zip and e-mail' doesn't work) https://bugzilla.mozilla.org/show_bug.cgi?id=189174 Attachment 166809: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=166809&action=edit ...

superreview granted: [Bug 409962] Cannot view attached mail with Content-type "Message/Rfc822" correctly : [ Attachment 294839] proposed fix
David Bienvenu <bienvenu@nventure.com> has granted Magnus Melin <mkmelin+mozilla@iki.fi>'s request for superreview: Bug 409962: Cannot view attached mail with Content-type "Message/Rfc822" correctly https://bugzilla.mozilla.org/show_bug.cgi?id=409962 Attachment 294839: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=294839&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> thx Magnus. + // to avoid some hazzle later down the road. I think you mean hassle I'm not sure I understand the pa...

superreview granted: [Bug 235053] [FIX]Flash objects don't work if type attribute is specified : [Attachment 141975] Fix for the missing type issue
Robert O'Callahan <roc@ocallahan.org> has granted Boris Zbarsky (not able to do reviews) <bzbarsky@mit.edu>'s request for superreview: Bug 235053: [FIX]Flash objects don't work if type attribute is specified http://bugzilla.mozilla.org/show_bug.cgi?id=235053 Attachment 141975: Fix for the missing type issue http://bugzilla.mozilla.org/attachment.cgi?id=141975&action=edit ...

superreview granted: [Bug 193698] "attachment" content shows a checkbox for "don't ask" : [Attachment 126900] fix other implementers
Darin Fisher <darin@netscape.com> has granted Christian Biesinger <cbiesinger@web.de>'s request for superreview: Bug 193698: "attachment" content shows a checkbox for "don't ask" http://bugzilla.mozilla.org/show_bug.cgi?id=193698 Attachment 126900: fix other implementers http://bugzilla.mozilla.org/attachment.cgi?id=126900&action=edit ------- Additional Comments from Darin Fisher <darin@netscape.com> sr=darin ...

superreview granted: [Bug 337815] Messages don't show; summary-file increases every time Tb opens : [Attachment 229361] proposed fix
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 337815: Messages don't show; summary-file increases every time Tb opens https://bugzilla.mozilla.org/show_bug.cgi?id=337815 Attachment 229361: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=229361&action=edit ...

superreview granted: [Bug 259649] header only downloaded pop3 messages don't download correctly if filters sent header to different folder : [Attachment 159016] proposed fix
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 259649: header only downloaded pop3 messages don't download correctly if filters sent header to different folder http://bugzilla.mozilla.org/show_bug.cgi?id=259649 Attachment 159016: proposed fix http://bugzilla.mozilla.org/attachment.cgi?id=159016&action=edit ...

superreview denied: [Bug 228149] messages with attachments imported from Eudora don't show properly : [Attachment 147943] A proposed patch to solve this bug
Scott MacGregor <mscott@mozilla.org> has denied Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 228149: messages with attachments imported from Eudora don't show properly http://bugzilla.mozilla.org/show_bug.cgi?id=228149 Attachment 147943: A proposed patch to solve this bug http://bugzilla.mozilla.org/attachment.cgi?id=147943&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> I think the string management can be a little tighter here. Lose nsString defaultBodyType and just do: pMimeType = ToN...

superreview granted: [Bug 299231] [FIX]xbl bound elements generated from innerHTML don't work very well : [Attachment 188328] Proposed fix
Peter Van der Beken <peterv@propagandism.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 299231: [FIX]xbl bound elements generated from innerHTML don't work very well https://bugzilla.mozilla.org/show_bug.cgi?id=299231 Attachment 188328: Proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=188328&action=edit ...

superreview granted: [Bug 343596] setTimeout doesn't work after setting script node's text to a script that causes an error : [Attachment 228093] Proposed fix
Johnny Stenback <jst@mozilla.org> has granted superreview: Bug 343596: setTimeout doesn't work after setting script node's text to a script that causes an error https://bugzilla.mozilla.org/show_bug.cgi?id=343596 Attachment 228093: Proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=228093&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> r+sr=jst ...

superreview granted: [Bug 259603] junk mail plugin doesn't run on messages in folder if you move to another folder before mail retrieval completes : [Attachment 162397] proposed fix
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 259603: junk mail plugin doesn't run on messages in folder if you move to another folder before mail retrieval completes https://bugzilla.mozilla.org/show_bug.cgi?id=259603 Attachment 162397: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=162397&action=edit ...

superreview granted: [Bug 340083] Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title in defs : [Attachment 224205] don't create frames for content we don't handle, don't invalidate nond
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted superreview: Bug 340083: Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title in defs https://bugzilla.mozilla.org/show_bug.cgi?id=340083 Attachment 224205: don't create frames for content we don't handle, don't invalidate nondisplay content https://bugzilla.mozilla.org/attachment.cgi?id=224205&action=edit ...

superreview granted: [Bug 333579] Firefox crash with Window-Eyes and DHTML/AJAX : [Attachment 228812] Two fixes for image map a11y: 1) Don't walk into maps so that areas don't show twice in a11y tree,
neil@parkwaycc.co.uk <neil@httl.net> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 333579: Firefox crash with Window-Eyes and DHTML/AJAX https://bugzilla.mozilla.org/show_bug.cgi?id=333579 Attachment 228812: Two fixes for image map a11y: 1) Don't walk into maps so that areas don't show twice in a11y tree, 2) Don't refer to |this| in area constructor, Init() from outside as other accessibles do https://bugzilla.mozilla.org/attachment.cgi?id=228812&action=edit ------- Additional Comments from neil@parkwaycc.co....

Web resources about - superreview granted: [Bug 155537] Text in multipart message does not show if Content-Type is blank [ Mail with attachments sent by Outlook don't work] : [Attachment 294768] proposed fix - mozilla.dev.super-review

Health care reforms proposed during the Obama administration - Wikipedia, the free encyclopedia
There have been a number of different health care reforms proposed during the Obama administration. Key reforms address cost and coverage and ...

Proposed law would have social media companies report 'terrorist activity' to law enforcement
Lawmakers have introduced a bill that would require technology companies to report online terrorist activity they become aware of to law enforcement. ...

Resources last updated: 12/10/2015 7:05:43 AM