superreview denied: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 327181] v4

neil@parkwaycc.co.uk <neil@httl.net> has denied Vlado Valastiak (wladow,
Mozilla.sk) <wladow@gmail.com>'s request for superreview:
Bug 93390: [RFE]"Block images from this server" should identify "this server"
https://bugzilla.mozilla.org/show_bug.cgi?id=93390

Attachment 327181: v4
https://bugzilla.mozilla.org/attachment.cgi?id=327181&action=edit

------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net>
OK, so this patch is almost ready, but I checked with L10N and we do want
separate accesskeys for block and unblock. While you're fixing that, I'd
appreciate if you could tweak the menu showing code; I think it would be
simpler if we a) hid both menuitems first b) show the menuitem that we update
the label and accesskey for, if we're on an image with a host. Having done
that, you can then move all the menu code inside the try/catch, beginning
try {
  var serverLabel = uri.host;

Just one more nit: we like to sprinkle spaces around in the code to space
things out a bit, e.g. after commas (but not at the end of a line of course).
(I notice that the Firefox code has this problem too, so I guess it got copied
that way.)
0
bugzilla
6/30/2008 3:48:12 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
525 Views

Similar Articles

[PageSpeed] 58

Reply:

Similar Artilces:

superreview requested: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 327181] v4
Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 327181: v4 https://bugzilla.mozilla.org/attachment.cgi?id=327181&action=edit ------- Additional Comments from Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com> This is updated v3 patch with neil's comments addressed: 1) shows menu-item only for schemes with hosts (FX appro...

superreview denied: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 307048] SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2
neil@parkwaycc.co.uk <neil@httl.net> has denied zug_treno@yahoo.com's reque= st for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this serve= r" https://bugzilla.mozilla.org/show_bug.cgi?id=3D93390 Attachment 307048: SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2 https://bugzilla.mozilla.org/attachment.cgi?id=3D307048&action=3Dedit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> >+ if (scheme =3D=3D "file") {=0D >+ serverLabel =3D "localhost&qu...

superreview requested: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 327636] for checkin
Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 327636: for checkin https://bugzilla.mozilla.org/attachment.cgi?id=327636&action=edit ------- Additional Comments from Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com> This patch compared to previous: 1) removes isBlockingImages() completely 2) uses serverLabel only (gets rid ...

superreview granted: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 327455] v5
neil@parkwaycc.co.uk <neil@httl.net> has granted Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com>'s request for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this serve= r" https://bugzilla.mozilla.org/show_bug.cgi?id=3D93390 Attachment 327455: v5 https://bugzilla.mozilla.org/attachment.cgi?id=3D327455&action=3Dedit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> Wow, that code looks much better now :-)=0D =0D >- gContextMenu.showItem=0D >- ("context-blocki...

superreview granted: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 327636] for checkin
neil@parkwaycc.co.uk <neil@httl.net> has granted Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com>'s request for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 327636: for checkin https://bugzilla.mozilla.org/attachment.cgi?id=327636&action=edit ...

superreview requested: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 327455] v5
Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 327455: v5 https://bugzilla.mozilla.org/attachment.cgi?id=327455&action=edit ------- Additional Comments from Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com> This adds separate accesskeys and as requested changes the way how we hide/unhide both menu-items (hide both first, unh...

superreview requested: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 307048] SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2
zug_treno@yahoo.com has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 307048: SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2 https://bugzilla.mozilla.org/attachment.cgi?id=307048&action=edit ...

superreview requested: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 310268] SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2.5
zug_treno@yahoo.com has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this serve= r" https://bugzilla.mozilla.org/show_bug.cgi?id=3D93390 Attachment 310268: SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2.5 https://bugzilla.mozilla.org/attachment.cgi?id=3D310268&action=3Dedit ------- Additional Comments from zug_treno@yahoo.com (In reply to comment #40)=0D > I don't like this. I think we should hide the menuitems if we can't get a= =0D > host.=0...

superreview canceled: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 310268] SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2.5
zug_treno@yahoo.com has canceled zug_treno@yahoo.com's request for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 310268: SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2.5 https://bugzilla.mozilla.org/attachment.cgi?id=310268&action=edit ------- Additional Comments from zug_treno@yahoo.com (In reply to comment #40) > I don't like this. I think we should hide the menuitems if we can't get a > host. OK, the menuitems aren&...

superreview canceled: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 312640] SeaMonkey 2.0a1pre version of Mogens Isager's patch v.3 (ready for sr)
neil@parkwaycc.co.uk <neil@httl.net> has canceled zug_treno@yahoo.com's request for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 312640: SeaMonkey 2.0a1pre version of Mogens Isager's patch v.3 (ready for sr) https://bugzilla.mozilla.org/attachment.cgi?id=312640&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> So, if you could fix the code to only show the menuitem for schemes with hosts, and while y...

superreview requested: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 312640] SeaMonkey 2.0a1pre version of Mogens Isager's patch v.3 (ready for sr)
zug_treno@yahoo.com has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 312640: SeaMonkey 2.0a1pre version of Mogens Isager's patch v.3 (ready for sr) https://bugzilla.mozilla.org/attachment.cgi?id=312640&action=edit ------- Additional Comments from zug_treno@yahoo.com (In reply to comment #40) > I don't like this. I think we should hide the menuitems if we can't get a > host. OK...

superreview denied: [Bug 393002] "Server not found" message for view-source window doesn't display server name : [ Attachment 292031] patch v2: address issue raised by super-review
Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> has denied Anant Narayanan <anant@kix.in>'s request for superreview: Bug 393002: "Server not found" message for view-source window doesn't displ= ay server name https://bugzilla.mozilla.org/show_bug.cgi?id=3D393002 Attachment 292031: patch v2: address issue raised by super-review https://bugzilla.mozilla.org/attachment.cgi?id=3D292031&action=3Dedit ------- Additional Comments from Boris Zbarsky (reviews very slow until spr= ing) <bzbarsky@mit.edu> You don't need the QI. ...

superreview requested: [Bug 102269] Cookie Manager: "Server Secure" should be "Secure Server" : [Attachment 143120] patch v2 including dialog update
Mike Connor <mconnor@myrealbox.com> has asked Alec Flett <alecf@flett.org> for superreview: Bug 102269: Cookie Manager: "Server Secure" should be "Secure Server" http://bugzilla.mozilla.org/show_bug.cgi?id=102269 Attachment 143120: patch v2 including dialog update http://bugzilla.mozilla.org/attachment.cgi?id=143120&action=edit ------- Additional Comments from Mike Connor <mconnor@myrealbox.com> alec, this one is pretty trivial if you have time before freeze... ...

superreview granted: [Bug 102269] Cookie Manager: "Server Secure" should be "Secure Server" : [Attachment 143120] patch v2 including dialog update
Alec Flett <alecf@flett.org> has granted Mike Connor <mconnor@myrealbox.com>'s request for superreview: Bug 102269: Cookie Manager: "Server Secure" should be "Secure Server" http://bugzilla.mozilla.org/show_bug.cgi?id=102269 Attachment 143120: patch v2 including dialog update http://bugzilla.mozilla.org/attachment.cgi?id=143120&action=edit ------- Additional Comments from Alec Flett <alecf@flett.org> sr=alecf ...

superreview requested: [Bug 90263] New account wizard uses "server name" and "hostname" : [Attachment 106602] quick patch that changes hostname to server name
Henrik Lynggaard Hansen <admin@mozillatranslator.org> has asked Scott MacGregor (on holiday until 01/02/2004) <mscott@mozilla.org> for superreview: Bug 90263: New account wizard uses "server name" and "hostname" http://bugzilla.mozilla.org/show_bug.cgi?id=90263 Attachment 106602: quick patch that changes hostname to server name http://bugzilla.mozilla.org/attachment.cgi?id=106602&action=edit ------- Additional Comments from Henrik Lynggaard Hansen <admin@mozillatranslator.org> review please ...

superreview granted: [Bug 90263] New account wizard uses "server name" and "hostname" : [Attachment 106602] quick patch that changes hostname to server name
Scott MacGregor <mscott@mozilla.org> has granted Henrik Lynggaard Hansen <admin@mozillatranslator.org>'s request for superreview: Bug 90263: New account wizard uses "server name" and "hostname" http://bugzilla.mozilla.org/show_bug.cgi?id=90263 Attachment 106602: quick patch that changes hostname to server name http://bugzilla.mozilla.org/attachment.cgi?id=106602&action=edit ...

superreview requested: [Bug 393002] "Server not found" message for view-source window doesn't display server name : [ Attachment 292031] patch v2: address issue raised by super-review
Anant Narayanan <anant@kix.in> has asked Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> for superreview: Bug 393002: "Server not found" message for view-source window doesn't display server name https://bugzilla.mozilla.org/show_bug.cgi?id=393002 Attachment 292031: patch v2: address issue raised by super-review https://bugzilla.mozilla.org/attachment.cgi?id=292031&action=edit ...

superreview requested: [Bug 75927] RFE: "Compact" or "Purge" button : [Attachment 313184] proposed fix, v4
Magnus Melin <mkmelin+mozilla@iki.fi> has asked Dan Mosedale <dmose@mozilla.org> for superreview: Bug 75927: RFE: "Compact" or "Purge" button https://bugzilla.mozilla.org/show_bug.cgi?id=75927 Attachment 313184: proposed fix, v4 https://bugzilla.mozilla.org/attachment.cgi?id=313184&action=edit ------- Additional Comments from Magnus Melin <mkmelin+mozilla@iki.fi> One hunk didn't make it into the earlier patch... ...

superreview granted: [Bug 75927] RFE: "Compact" or "Purge" button : [Attachment 313184] proposed fix, v4
Dan Mosedale <dmose@mozilla.org> has granted Magnus Melin <mkmelin+mozilla@iki.fi>'s request for superreview: Bug 75927: RFE: "Compact" or "Purge" button https://bugzilla.mozilla.org/show_bug.cgi?id=3D75927 Attachment 313184: proposed fix, v4 https://bugzilla.mozilla.org/attachment.cgi?id=3D313184&action=3Dedit ------- Additional Comments from Dan Mosedale <dmose@mozilla.org> Sorry for the delay; sr=3Ddmose. Out of curiousity, why is it necessary to = have separate XUL commands for the button and the menu command?= ...

superreview requested: [Bug 47475] Need "Show(View) Image" / "Reload Image" on context menu : [Attachment 233530] unrotted, addressing bz's review comments from before
Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 47475: Need "Show(View) Image" / "Reload Image" on context menu https://bugzilla.mozilla.org/show_bug.cgi?id=47475 Attachment 233530: unrotted, addressing bz's review comments from before https://bugzilla.mozilla.org/attachment.cgi?id=233530&action=edit ...

superreview granted: [Bug 47475] Need "Show(View) Image" / "Reload Image" on context menu : [Attachment 233530] unrotted, addressing bz's review comments from before
neil@parkwaycc.co.uk <neil@httl.net> has granted Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com>'s request for superreview: Bug 47475: Need "Show(View) Image" / "Reload Image" on context menu https://bugzilla.mozilla.org/show_bug.cgi?id=47475 Attachment 233530: unrotted, addressing bz's review comments from before https://bugzilla.mozilla.org/attachment.cgi?id=233530&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> only xul/js change was typo fix right? ...

.ALLCOL("%COLUMN%", " ", ", ", ", ")
Do you know anyway for me to exclude a subset of columns returned by this function. We have two columns (rec_user and rec_datetime) which are in all of our tables, but when generating triggers I want automatically generate a script which does not include those two columns but does include all other columns in that table. Bruce I should add that I am using PD 9.0.0.580. Bruce "Bruce Lamb" <lamb.bruce@mayo.edu> wrote in message news:6HgI315nCHA.155@forums.sybase.com... > Do you know anyway for me to exclude a subset of columns returned by this > function. ...

Precedence of "where" ("of", "is", "will")?
Nobody on #perl6 today could answer this one. Is: Str | Int where { $_ } the same as: (Str | Int) where { $_ } or: Str | (Int where { $_ }) ? Followup questions, Mr. President: What kind of operators are "where", "of", "is", and "will"? Is there a reason that S03 doesn't list them? What are their precedence(s)? -- Chip Salzenberg - a.k.a. - <chip@pobox.com> Open Source is not an excuse to write fun code then leave the actual work to others. Chip Salzenberg writes: &...

superreview denied: [Bug 335637] "Backup" and "Backup all" should be "Back Up" in the Certificate action menu : [Attachment 247247] New CertificatesWindow.nib
Stuart Morgan <stuart.morgan@alumni.case.edu> has denied Smokey Ardisson (unreliable; no bugmail) <alqahira@ardisson.org>'s request for superreview: Bug 335637: "Backup" and "Backup all" should be "Back Up" in the Certificate action menu https://bugzilla.mozilla.org/show_bug.cgi?id=335637 Attachment 247247: New CertificatesWindow.nib https://bugzilla.mozilla.org/attachment.cgi?id=247247&action=edit ------- Additional Comments from Stuart Morgan <stuart.morgan@alumni.case.edu> (In reply to comment #12) > Specifically, the a...

Web resources about - superreview denied: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 327181] v4 - mozilla.dev.super-review

Resources last updated: 2/14/2016 7:44:34 PM