superreview denied: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 307048] SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2

neil@parkwaycc.co.uk <neil@httl.net> has denied zug_treno@yahoo.com's reque=
st
for superreview:
Bug 93390: [RFE]"Block images from this server" should identify "this serve=
r"
https://bugzilla.mozilla.org/show_bug.cgi?id=3D93390

Attachment 307048: SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2
https://bugzilla.mozilla.org/attachment.cgi?id=3D307048&action=3Dedit

------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net>
>+	    if (scheme =3D=3D "file") {=0D
>+	      serverLabel =3D "localhost";=0D
>+	    } else {=0D
>+	      // Get server name=0D
>+	      try {=0D
>+		serverLabel =3D IOService.newURI(gContextMenu.imageURL, null,
null).host;=0D
>+	      } catch (e) {=0D
>+		serverLabel =3D "";=0D
>+	      }=0D
I don't like this. I think we should hide the menuitems if we can't get a h=
ost.
Or start by hiding them, then try to get a host, then unhide the appropriate
item. Or possibly even borrow from the Firefox code which I believe uses a
single menuitem, and works out whether it needs to block or unblock.=0D
=0D
>+		serverLabel +=3D "\u2026";=0D
Ideally you would use the value of the intl.ellipsis localised pref.=0D
=0D
>+	    // Set label for appropiate action=0D
Typo: appropriate=0D
=0D
>+	    var saveImageMenuItem;=0D
Surely this should be blockImageMenuItem?=0D
=0D
>+	    if (cookieContextMenu.isBlockingImages()) {=0D
You could probably inline the code, since you already have a URI.=0D
=0D
>+blockImage=3DBlock Images from %S=0D
>+unblockImage=3DUnblock Images from %S=0D
You should also remove the old strings.=
0
bugzilla
3/15/2008 11:49:35 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
479 Views

Similar Articles

[PageSpeed] 50

Reply:

Similar Artilces:

superreview requested: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 307048] SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2
zug_treno@yahoo.com has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 307048: SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2 https://bugzilla.mozilla.org/attachment.cgi?id=307048&action=edit ...

superreview canceled: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 310268] SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2.5
zug_treno@yahoo.com has canceled zug_treno@yahoo.com's request for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 310268: SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2.5 https://bugzilla.mozilla.org/attachment.cgi?id=310268&action=edit ------- Additional Comments from zug_treno@yahoo.com (In reply to comment #40) > I don't like this. I think we should hide the menuitems if we can't get a > host. OK, the menuitems aren&...

superreview requested: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 310268] SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2.5
zug_treno@yahoo.com has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this serve= r" https://bugzilla.mozilla.org/show_bug.cgi?id=3D93390 Attachment 310268: SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2.5 https://bugzilla.mozilla.org/attachment.cgi?id=3D310268&action=3Dedit ------- Additional Comments from zug_treno@yahoo.com (In reply to comment #40)=0D > I don't like this. I think we should hide the menuitems if we can't get a= =0D > host.=0...

superreview requested: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 312640] SeaMonkey 2.0a1pre version of Mogens Isager's patch v.3 (ready for sr)
zug_treno@yahoo.com has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 312640: SeaMonkey 2.0a1pre version of Mogens Isager's patch v.3 (ready for sr) https://bugzilla.mozilla.org/attachment.cgi?id=312640&action=edit ------- Additional Comments from zug_treno@yahoo.com (In reply to comment #40) > I don't like this. I think we should hide the menuitems if we can't get a > host. OK...

superreview canceled: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 312640] SeaMonkey 2.0a1pre version of Mogens Isager's patch v.3 (ready for sr)
neil@parkwaycc.co.uk <neil@httl.net> has canceled zug_treno@yahoo.com's request for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 312640: SeaMonkey 2.0a1pre version of Mogens Isager's patch v.3 (ready for sr) https://bugzilla.mozilla.org/attachment.cgi?id=312640&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> So, if you could fix the code to only show the menuitem for schemes with hosts, and while y...

superreview denied: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 327181] v4
neil@parkwaycc.co.uk <neil@httl.net> has denied Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com>'s request for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 327181: v4 https://bugzilla.mozilla.org/attachment.cgi?id=327181&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> OK, so this patch is almost ready, but I checked with L10N and we do want separate accesskeys for block and unblock. While you're fixing that, I'd appreciate if you could tweak the menu showing code; I think it would be simpler if we a) hid both menuitems first b) show the menuitem that we update the label and accesskey for, if we're on an image with a host. Having done that, you can then move all the menu code inside the try/catch, beginning try { var serverLabel = uri.host; Just one more nit: we like to sprinkle spaces around in the code to space things out a bit, e.g. after commas (but not at the end of a line of course). (I notice that the Firefox code has this problem too, so I guess it got copied that way.) ...

superreview granted: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 327636] for checkin
neil@parkwaycc.co.uk <neil@httl.net> has granted Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com>'s request for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 327636: for checkin https://bugzilla.mozilla.org/attachment.cgi?id=327636&action=edit ...

superreview requested: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 327181] v4
Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 327181: v4 https://bugzilla.mozilla.org/attachment.cgi?id=327181&action=edit ------- Additional Comments from Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com> This is updated v3 patch with neil's comments addressed: 1) shows menu-item only for schemes with hosts (FX appro...

superreview granted: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 327455] v5
neil@parkwaycc.co.uk <neil@httl.net> has granted Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com>'s request for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this serve= r" https://bugzilla.mozilla.org/show_bug.cgi?id=3D93390 Attachment 327455: v5 https://bugzilla.mozilla.org/attachment.cgi?id=3D327455&action=3Dedit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> Wow, that code looks much better now :-)=0D =0D >- gContextMenu.showItem=0D >- ("context-blocki...

superreview requested: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 327455] v5
Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 327455: v5 https://bugzilla.mozilla.org/attachment.cgi?id=327455&action=edit ------- Additional Comments from Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com> This adds separate accesskeys and as requested changes the way how we hide/unhide both menu-items (hide both first, unh...

superreview requested: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 327636] for checkin
Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 327636: for checkin https://bugzilla.mozilla.org/attachment.cgi?id=327636&action=edit ------- Additional Comments from Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com> This patch compared to previous: 1) removes isBlockingImages() completely 2) uses serverLabel only (gets rid ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only) #2
Serge GAUTHERIE <gautheri@noos.fr> has asked Seth Spitzer <sspitzer@mozilla.org> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ...

superreview requested: [Bug 302695] Misleading message when starting Thunderbird in "Ask for Online state" mode
timeless@gmail.com <timeless@bemail.org> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com> for superreview: Bug 302695: Misleading message when starting Thunderbird in "Ask for Online state" mode - there is no "File -> Work Online" https://bugzilla.mozilla.org/show_bug.cgi?id=302695 Attachment 205036: Patch v.2 (SeaMonkey) https://bugzilla.mozilla.org/attachment.cgi?id=205036&action=edit ...

superreview denied: [Bug 393002] "Server not found" message for view-source window doesn't display server name : [ Attachment 292031] patch v2: address issue raised by super-review
Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> has denied Anant Narayanan <anant@kix.in>'s request for superreview: Bug 393002: "Server not found" message for view-source window doesn't displ= ay server name https://bugzilla.mozilla.org/show_bug.cgi?id=3D393002 Attachment 292031: patch v2: address issue raised by super-review https://bugzilla.mozilla.org/attachment.cgi?id=3D292031&action=3Dedit ------- Additional Comments from Boris Zbarsky (reviews very slow until spr= ing) <bzbarsky@mit.edu> You don't need the QI. ...

superreview granted: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only)
Brendan Eich <brendan@mozilla.org> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> rs=me, I'm trusting you guys, patch looks ok from the context di...

superreview cancelled: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only)
Serge GAUTHERIE <gautheri@noos.fr> has cancelled Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only)
Serge GAUTHERIE <gautheri@noos.fr> has asked Seth Spitzer <sspitzer@mozilla.org> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only) #3
Serge GAUTHERIE <gautheri@noos.fr> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only) #4
Serge GAUTHERIE <gautheri@noos.fr> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> No super-review from <bienvenu@nventure.com> since '2004-04-26' :-( ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 151481] (Cv1) <nsMsgBodyHandler.cpp> #2
Serge GAUTHERIE <gautheri@noos.fr> has asked Dan Mosedale <dmose@mozilla.org> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 151481: (Cv1) <nsMsgBodyHandler.cpp> http://bugzilla.mozilla.org/attachment.cgi?id=151481&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> No super-review from <bienvenu@nventure.com> since "2004-06-22" :-( ...

superreview cancelled: [Bug 90906] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") : [Attachment 174788] (Tv1) transformiix/xpath #2
Peter Van der Beken <peterv@propagandism.org> has cancelled Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 90906: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") https://bugzilla.mozilla.org/show_bug.cgi?id=90906 Attachment 174788: (Tv1) transformiix/xpath https://bugzilla.mozilla.org/attachment.cgi?id=174788&action=edit ------- Additional Comments from Peter Van der Beken <peterv@propagandism.org> Code was rewritten as part of the fix for bug 278981. ...

superreview granted: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 151802] (Dv1) <nsViewManager.cpp>
David Baron <dbaron@dbaron.org> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 151802: (Dv1) <nsViewManager.cpp> http://bugzilla.mozilla.org/attachment.cgi?id=151802&action=edit ...

superreview granted: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 156855] (Cv2) <nsMsgBodyHandler.cpp>
Dan Mosedale <dmose@mozilla.org> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 156855: (Cv2) <nsMsgBodyHandler.cpp> http://bugzilla.mozilla.org/attachment.cgi?id=156855&action=edit ------- Additional Comments from Dan Mosedale <dmose@mozilla.org> sr=dmose ...

superreview granted: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 141227] (Av1c) <nsMacMain.cpp>
Serge GAUTHERIE <gautheri@noos.fr> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 141227: (Av1c) <nsMacMain.cpp> http://bugzilla.mozilla.org/attachment.cgi?id=141227&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> Keeping { (Av1b) <nsMacMain.cpp> patch 2003-12-20 05:33 PST pinkerton: r...

Web resources about - superreview denied: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 307048] SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2 - mozilla.dev.super-review

Resources last updated: 3/24/2016 7:19:38 PM