superreview denied: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 312934] Disable and lock checking patch v1.0a

neil@parkwaycc.co.uk <neil@httl.net> has denied Ian Neal
<iann_bugzilla@blueyonder.co.uk>'s request for superreview:
Bug 79603: Disable color controls when 'Use system color' is checked
https://bugzilla.mozilla.org/show_bug.cgi?id=3D79603

Attachment 312934: Disable and lock checking patch v1.0a
https://bugzilla.mozilla.org/attachment.cgi?id=3D312934&action=3Dedit

------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net>
Unfortunately disabling colourpickers doesn't work correctly - the binding
simply makes a bold claim that it's a XUL control, when it should in fact
extend the base control binding which additionally provides the code that
handles the disabled and tabindex properties needed for correct disabling..=
..=0D
=0D
>+		      oncommand=3D"ToggleCustomColorPickers(this.checked);"/>=0D
This needs to run from an onchange event on the preference element.=0D
=0D
>+function Startup()=0D
>+{=0D
>+=20
ToggleCustomColorPickers(document.getElementById("browserUseSystemColors").=
chec
ked);=0D
>+}=0D
This needs to read the value from the preference element.=0D
=0D
>+  if (aDisable)=0D
>+    aElement.setAttribute("disabled", "true");=0D
>+  else=0D
>+    aElement.removeAttribute("disabled");=0D
.... and you'd therefore want to use the property instead of the attribute.=
0
bugzilla
4/2/2008 12:28:49 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
489 Views

Similar Articles

[PageSpeed] 56

Reply: