superreview denied: [Bug 393002] "Server not found" message for view-source window doesn't display server name : [ Attachment 292022] patch v1: fixes mentioned problem

Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> has denied
Anant Narayanan <anant@kix.in>'s request for superreview:
Bug 393002: "Server not found" message for view-source window doesn't display
server name
https://bugzilla.mozilla.org/show_bug.cgi?id=393002

Attachment 292022: patch v1: fixes mentioned problem
https://bugzilla.mozilla.org/attachment.cgi?id=292022&action=edit

------- Additional Comments from Boris Zbarsky (reviews very slow until spring)
<bzbarsky@mit.edu>
I think you want to use NS_GetInnermostURI here instead of largely duplicating
it.
0
bugzilla
12/7/2007 7:10:02 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
617 Views

Similar Articles

[PageSpeed] 1

Reply:

Similar Artilces:

superreview requested: [Bug 393002] "Server not found" message for view-source window doesn't display server name : [ Attachment 292022] patch v1: fixes mentioned problem
Anant Narayanan <anant@kix.in> has asked Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> for superreview: Bug 393002: "Server not found" message for view-source window doesn't display server name https://bugzilla.mozilla.org/show_bug.cgi?id=393002 Attachment 292022: patch v1: fixes mentioned problem https://bugzilla.mozilla.org/attachment.cgi?id=292022&action=edit ...

superreview denied: [Bug 393002] "Server not found" message for view-source window doesn't display server name : [ Attachment 292031] patch v2: address issue raised by super-review
Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> has denied Anant Narayanan <anant@kix.in>'s request for superreview: Bug 393002: "Server not found" message for view-source window doesn't displ= ay server name https://bugzilla.mozilla.org/show_bug.cgi?id=3D393002 Attachment 292031: patch v2: address issue raised by super-review https://bugzilla.mozilla.org/attachment.cgi?id=3D292031&action=3Dedit ------- Additional Comments from Boris Zbarsky (reviews very slow until spr= ing) <bzbarsky@mit.edu> You don't need the QI. ...

superreview requested: [Bug 393002] "Server not found" message for view-source window doesn't display server name : [ Attachment 292031] patch v2: address issue raised by super-review
Anant Narayanan <anant@kix.in> has asked Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> for superreview: Bug 393002: "Server not found" message for view-source window doesn't display server name https://bugzilla.mozilla.org/show_bug.cgi?id=393002 Attachment 292031: patch v2: address issue raised by super-review https://bugzilla.mozilla.org/attachment.cgi?id=292031&action=edit ...

superreview requested: [Bug 393002] "Server not found" message for view-source window doesn't display server name : [ Attachment 292088] patch v3: remove unnecessary QueryInterface
Anant Narayanan <anant@kix.in> has asked Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> for superreview: Bug 393002: "Server not found" message for view-source window doesn't display server name https://bugzilla.mozilla.org/show_bug.cgi?id=393002 Attachment 292088: patch v3: remove unnecessary QueryInterface https://bugzilla.mozilla.org/attachment.cgi?id=292088&action=edit ------- Additional Comments from Anant Narayanan <anant@kix.in> Sorry, should have taken a look at the implementation of NS_GetInnermostURI first. ...

superreview granted: [Bug 393002] "Server not found" message for view-source window doesn't display server name : [ Attachment 292088] patch v3: remove unnecessary QueryInterface
Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> has granted Anant Narayanan <anant@kix.in>'s request for superreview: Bug 393002: "Server not found" message for view-source window doesn't display server name https://bugzilla.mozilla.org/show_bug.cgi?id=393002 Attachment 292088: patch v3: remove unnecessary QueryInterface https://bugzilla.mozilla.org/attachment.cgi?id=292088&action=edit ------- Additional Comments from Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> Excellent! ...

superreview granted: [Bug 350693] "Character Encoding" in "View Source" window doesn't work : [Attachment 236818] Patch
Scott MacGregor <mscott@mozilla.org> has granted Simon Montagu <smontagu@smontagu.org>'s request for superreview: Bug 350693: "Character Encoding" in "View Source" window doesn't work https://bugzilla.mozilla.org/show_bug.cgi?id=350693 Attachment 236818: Patch https://bugzilla.mozilla.org/attachment.cgi?id=236818&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> this needs a toolkit module owner review so I'll ask Benjamin for that. David's on vacation, i'll do the sr. ...

superreview requested: [Bug 350693] "Character Encoding" in "View Source" window doesn't work : [Attachment 236818] Patch
Simon Montagu <smontagu@smontagu.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 350693: "Character Encoding" in "View Source" window doesn't work https://bugzilla.mozilla.org/show_bug.cgi?id=350693 Attachment 236818: Patch https://bugzilla.mozilla.org/attachment.cgi?id=236818&action=edit ------- Additional Comments from Simon Montagu <smontagu@smontagu.org> This is a port of Neil's patch to xpfe in bug 252317. It had r=doron, sr=bzbarsky over there, so I guess rs should be enough to apply it to toolkit. ...

superreview requested: [Bug 217147] "View Saved Passwords..." window doesn't remember its size and position : [Attachment 131839] patch to fix bug 205176 as well
Steffen Wilberg <steffen.wilberg@web.de> has asked Brian Ryner <bryner@brianryner.com> for superreview: Bug 217147: "View Saved Passwords..." window doesn't remember its size and position http://bugzilla.mozilla.org/show_bug.cgi?id=217147 Attachment 131839: patch to fix bug 205176 as well http://bugzilla.mozilla.org/attachment.cgi?id=131839&action=edit ------- Additional Comments from Steffen Wilberg <steffen.wilberg@web.de> Brian, I just realized that you've got the full cvs blame for both files. Can you review this please? ...

superreview granted: [Bug 217147] [pwd-mngr] "View Saved Passwords..." window doesn't remember its size and position : [Attachment 131839] patch to fix bug 205176 as well
Brian Ryner <bryner@brianryner.com> has granted Steffen Wilberg <steffen.wilberg@web.de>'s request for superreview: Bug 217147: [pwd-mngr] "View Saved Passwords..." window doesn't remember its size and position http://bugzilla.mozilla.org/show_bug.cgi?id=217147 Attachment 131839: patch to fix bug 205176 as well http://bugzilla.mozilla.org/attachment.cgi?id=131839&action=edit ------- Additional Comments from Brian Ryner <bryner@brianryner.com> r+sr=bryner ...

superreview denied: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 307048] SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2
neil@parkwaycc.co.uk <neil@httl.net> has denied zug_treno@yahoo.com's reque= st for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this serve= r" https://bugzilla.mozilla.org/show_bug.cgi?id=3D93390 Attachment 307048: SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2 https://bugzilla.mozilla.org/attachment.cgi?id=3D307048&action=3Dedit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> >+ if (scheme =3D=3D "file") {=0D >+ serverLabel =3D "localhost&qu...

superreview granted: [Bug 90263] New account wizard uses "server name" and "hostname" : [Attachment 106602] quick patch that changes hostname to server name
Scott MacGregor <mscott@mozilla.org> has granted Henrik Lynggaard Hansen <admin@mozillatranslator.org>'s request for superreview: Bug 90263: New account wizard uses "server name" and "hostname" http://bugzilla.mozilla.org/show_bug.cgi?id=90263 Attachment 106602: quick patch that changes hostname to server name http://bugzilla.mozilla.org/attachment.cgi?id=106602&action=edit ...

superreview requested: [Bug 90263] New account wizard uses "server name" and "hostname" : [Attachment 106602] quick patch that changes hostname to server name
Henrik Lynggaard Hansen <admin@mozillatranslator.org> has asked Scott MacGregor (on holiday until 01/02/2004) <mscott@mozilla.org> for superreview: Bug 90263: New account wizard uses "server name" and "hostname" http://bugzilla.mozilla.org/show_bug.cgi?id=90263 Attachment 106602: quick patch that changes hostname to server name http://bugzilla.mozilla.org/attachment.cgi?id=106602&action=edit ------- Additional Comments from Henrik Lynggaard Hansen <admin@mozillatranslator.org> review please ...

superreview denied: [Bug 219662] "OK" button doesn't activate in "Link Properties" dialog : [Attachment 236543] patch
neil@parkwaycc.co.uk <neil@httl.net> has denied Andrew Schultz <ajschult@verizon.net>'s request for superreview: Bug 219662: "OK" button doesn't activate in "Link Properties" dialog https://bugzilla.mozilla.org/show_bug.cgi?id=219662 Attachment 236543: patch https://bugzilla.mozilla.org/attachment.cgi?id=236543&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> > <textbox id="hrefInput" type="autocomplete" > searchSessions="history" timeout="50" m...

superreview cancelled: [Bug 236600] "Open in tabs" in bm manager doesn't switch to browser view. : [Attachment 148181] simple fix v1
Stuart Morgan <sbm5@case.edu> has cancelled Josh Aas <josha@mac.com>'s request for superreview: Bug 236600: "Open in tabs" in bm manager doesn't switch to browser view. http://bugzilla.mozilla.org/show_bug.cgi?id=236600 Attachment 148181: simple fix v1 http://bugzilla.mozilla.org/attachment.cgi?id=148181&action=edit ------- Additional Comments from Stuart Morgan <sbm5@case.edu> Removing review requests ...