superreview requested: [Bug 282180] sync xpfe button.xml with toolkit button.xml : [Attachment 217747] (Av2) <button.xml>Serge GAUTHERIE <gautheri@noos.fr> has asked neil@parkwaycc.co.uk
<neil@httl.net> for superreview:
Bug 282180: sync xpfe button.xml with toolkit button.xml
https://bugzilla.mozilla.org/show_bug.cgi?id=282180
Attachment 217747: (Av2) <button.xml>
https://bugzilla.mozilla.org/attachment.cgi?id=217747&action=edit
------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr>
(In reply to comment #4)
> If the diff still has not changed, I would suggest this also be applied + a
> migration to toolkit's directly.
Updated to current Trunk; un...
superreview cancelled: [Bug 282180] sync xpfe button.xml with toolkit button.xml : [Attachment 218477] (Av3-XPFE) <button.xml>neil@parkwaycc.co.uk <neil@httl.net> has cancelled Serge GAUTHERIE
<gautheri@noos.fr>'s request for superreview:
Bug 282180: sync xpfe button.xml with toolkit button.xml
https://bugzilla.mozilla.org/show_bug.cgi?id=282180
Attachment 218477: (Av3-XPFE) <button.xml>
https://bugzilla.mozilla.org/attachment.cgi?id=218477&action=edit
------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net>
> <children>
> <xul:image class="button-icon" xbl:inherits="src=image"/>
>- <xul:label class="b...
superreview requested: [Bug 282180] sync xpfe button.xml with toolkit button.xml : [Attachment 218477] (Av3-XPFE) <button.xml>Serge GAUTHERIE <gautheri@noos.fr> has asked for superreview:
Bug 282180: sync xpfe button.xml with toolkit button.xml
https://bugzilla.mozilla.org/show_bug.cgi?id=282180
Attachment 218477: (Av3-XPFE) <button.xml>
https://bugzilla.mozilla.org/attachment.cgi?id=218477&action=edit
------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr>
Av2, with comment 7 suggestion(s).
...
superreview requested: [Bug 282180] sync xpfe button.xml with toolkit button.xml : [Attachment 221700] (Av4-XPFE) <button.xml>Serge GAUTHERIE <gautheri@noos.fr> has asked for superreview:
Bug 282180: sync xpfe button.xml with toolkit button.xml
https://bugzilla.mozilla.org/show_bug.cgi?id=282180
Attachment 221700: (Av4-XPFE) <button.xml>
https://bugzilla.mozilla.org/attachment.cgi?id=221700&action=edit
------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr>
Av3-XPFE, with comment 17 suggestion(s).
Untested: Would you have a testcase to check this behaviour ?
...
superreview granted: [Bug 282180] sync xpfe button.xml with toolkit button.xml : [Attachment 221700] (Av4-XPFE) <button.xml>neil@parkwaycc.co.uk <neil@httl.net> has granted Serge GAUTHERIE
<gautheri@noos.fr>'s request for superreview:
Bug 282180: sync xpfe button.xml with toolkit button.xml
https://bugzilla.mozilla.org/show_bug.cgi?id=282180
Attachment 221700: (Av4-XPFE) <button.xml>
https://bugzilla.mozilla.org/attachment.cgi?id=221700&action=edit
...
superreview requested: [Bug 282180] sync xpfe button.xml with toolkit button.xml : [Attachment 218477] (Av3-XPFE) <button.xml> #2Serge GAUTHERIE <gautheri@noos.fr> has asked neil@parkwaycc.co.uk
<neil@httl.net> for superreview:
Bug 282180: sync xpfe button.xml with toolkit button.xml
https://bugzilla.mozilla.org/show_bug.cgi?id=282180
Attachment 218477: (Av3-XPFE) <button.xml>
https://bugzilla.mozilla.org/attachment.cgi?id=218477&action=edit
...
superreview requested: [Bug 282180] sync xpfe button.xml with toolkit button.xml : [Attachment 221700] (Av4-XPFE) <button.xml> #2Serge GAUTHERIE <gautheri@noos.fr> has asked neil@parkwaycc.co.uk
<neil@httl.net> for superreview:
Bug 282180: sync xpfe button.xml with toolkit button.xml
https://bugzilla.mozilla.org/show_bug.cgi?id=282180
Attachment 221700: (Av4-XPFE) <button.xml>
https://bugzilla.mozilla.org/attachment.cgi?id=221700&action=edit
...
superreview denied: [Bug 282182] sync xpfe general.xml with toolkit general.xml : [Attachment 217751] (Av2) <general.xml>neil@parkwaycc.co.uk <neil@httl.net> has denied Serge GAUTHERIE
<gautheri@noos.fr>'s request for superreview:
Bug 282182: sync xpfe general.xml with toolkit general.xml
https://bugzilla.mozilla.org/show_bug.cgi?id=282182
Attachment 217751: (Av2) <general.xml>
https://bugzilla.mozilla.org/attachment.cgi?id=217751&action=edit
------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net>
>+ <binding id="statusbarpanel-menu-iconic" display="xul:menu"
extends="chrome://global/content/bindings/general.xml#statusbarpa...
Bug 282180KaiRo,
I see you're interested in bug 282178 and 282179.
On a related matter,
I'm desperately seeking help/hints to get the following patch reviewed:
[
282180: sync xpfe button.xml with toolkit button.xml
https://bugzilla.mozilla.org/show_bug.cgi?id=282180
221775: (Bv1a-TK) <button.xml>
https://bugzilla.mozilla.org/attachment.cgi?id=221775&action=edit
]
Serge Gautherie schrieb:
> KaiRo,
If you want to contact me, mail me or poke me on IRC.
If you want to post to the newsgroup, don't pretend to mail me personally.
Thanks.
> I see you're in...
superreview requested: [Bug 282182] sync xpfe general.xml with toolkit general.xml : [Attachment 217751] (Av2) <general.xml>Serge GAUTHERIE <gautheri@noos.fr> has asked neil@parkwaycc.co.uk
<neil@httl.net> for superreview:
Bug 282182: sync xpfe general.xml with toolkit general.xml
https://bugzilla.mozilla.org/show_bug.cgi?id=282182
Attachment 217751: (Av2) <general.xml>
https://bugzilla.mozilla.org/attachment.cgi?id=217751&action=edit
------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr>
(In reply to comment #2)
> Hmm, if the diff is current (by date I would imagine so) then I do not
> personally see a problem syncing this and grabbing toolkits version fr...
superreview requested: [Bug 282186] sync xpfe text.xml with toolkit text.xml : [Attachment 221205] (Cv1-XPFE) <text.xml>Serge GAUTHERIE <gautheri@noos.fr> has asked neil@parkwaycc.co.uk
<neil@httl.net> for superreview:
Bug 282186: sync xpfe text.xml with toolkit text.xml
https://bugzilla.mozilla.org/show_bug.cgi?id=282186
Attachment 221205: (Cv1-XPFE) <text.xml>
https://bugzilla.mozilla.org/attachment.cgi?id=221205&action=edit
------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr>
This part comes from bug 280065 and followups.
Untested.
...
superreview granted: [Bug 282182] sync xpfe general.xml with toolkit general.xml : [Attachment 219626] (Av3-XPFE) <general.xml>++neil@parkwaycc.co.uk <neil@httl.net> has granted Serge GAUTHERIE
<gautheri@noos.fr>'s request for superreview:
Bug 282182: sync xpfe general.xml with toolkit general.xml
https://bugzilla.mozilla.org/show_bug.cgi?id=282182
Attachment 219626: (Av3-XPFE) <general.xml>++
https://bugzilla.mozilla.org/attachment.cgi?id=219626&action=edit
...
superreview requested: [Bug 282182] sync xpfe general.xml with toolkit general.xml : [Attachment 219626] (Av3-XPFE) <general.xml>++Serge GAUTHERIE <gautheri@noos.fr> has asked neil@parkwaycc.co.uk
<neil@httl.net> for superreview:
Bug 282182: sync xpfe general.xml with toolkit general.xml
https://bugzilla.mozilla.org/show_bug.cgi?id=282182
Attachment 219626: (Av3-XPFE) <general.xml>++
https://bugzilla.mozilla.org/attachment.cgi?id=219626&action=edit
------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr>
Av3-XPFE-Bw, with full diff.
Keeping
[[
(Av3-XPFE-Bw) <general.xml>++ patch 2006-04-23 16:17 PDT
2.38 KB neil: review+
]]
...
superreview requested: [Bug 282189] sync xpfe toolbarbutton.xml with toolkit toolbarbutton.xml : [Attachment 219242] (Bv2-XPFE) <toolbarbutton.xml> ++Serge GAUTHERIE <gautheri@noos.fr> has asked neil@parkwaycc.co.uk
<neil@httl.net> for superreview:
Bug 282189: sync xpfe toolbarbutton.xml with toolkit toolbarbutton.xml
https://bugzilla.mozilla.org/show_bug.cgi?id=282189
Attachment 219242: (Bv2-XPFE) <toolbarbutton.xml> ++
https://bugzilla.mozilla.org/attachment.cgi?id=219242&action=edit
------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr>
Bv1, updated to current Trunk:
in fact, it's now a port, of the (TB+TK) attachment 214196 in bug 252393,
which addresses comment 5 and comment 6.
...