superreview cancelled: [Bug 363573] Table cells don't expand to contain <pre cols> ('ch' unit is broken) : [Attachment 248510] Patch rev. 1

Mats Palmgren <mats.palmgren@bredband.net> has cancelled  superreview:
Bug 363573: Table cells don't expand to contain <pre cols> ('ch' unit is
broken)
https://bugzilla.mozilla.org/show_bug.cgi?id=363573

Attachment 248510: Patch rev. 1
https://bugzilla.mozilla.org/attachment.cgi?id=248510&action=edit

------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net>
Ok, I made both ComputeHorizontalValue and ComputeVerticalValue use
GetAbsoluteCoord, the latter made 'ch' work for 'height', 'min-height'
and 'max-height' (to my surprise it seems to be working for vertical
padding and margin already).
0
bugzilla
12/13/2006 9:15:31 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
526 Views

Similar Articles

[PageSpeed] 54

Reply:

Similar Artilces:

superreview requested: [Bug 363573] Table cells don't expand to contain <pre cols> ('ch' unit is broken) : [Attachment 248510] Patch rev. 1
Mats Palmgren <mats.palmgren@bredband.net> has asked David Baron <dbaron@mozilla.com> for superreview: Bug 363573: Table cells don't expand to contain <pre cols> ('ch' unit is broken) https://bugzilla.mozilla.org/show_bug.cgi?id=363573 Attachment 248510: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=248510&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> The 'cols' attribute is mapped to a 'ch' unit width. This patch implements the 'ch' unit generally for 'wid...

superreview requested: [Bug 363573] Table cells don't expand to contain <pre cols> ('ch' unit is broken) : [Attachment 248557] Patch rev. 2
Mats Palmgren <mats.palmgren@bredband.net> has asked David Baron <dbaron@mozilla.com> for superreview: Bug 363573: Table cells don't expand to contain <pre cols> ('ch' unit is broken) https://bugzilla.mozilla.org/show_bug.cgi?id=363573 Attachment 248557: Patch rev. 2 https://bugzilla.mozilla.org/attachment.cgi?id=248557&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> Ok, I made both ComputeHorizontalValue and ComputeVerticalValue use GetAbsoluteCoord, the latter made 'ch' work for 'height&#...

superreview granted: [Bug 363573] Table cells don't expand to contain <pre cols> ('ch' unit is broken) : [Attachment 248557] Patch rev. 2
David Baron <dbaron@mozilla.com> has granted superreview: Bug 363573: Table cells don't expand to contain <pre cols> ('ch' unit is broken) https://bugzilla.mozilla.org/show_bug.cgi?id=363573 Attachment 248557: Patch rev. 2 https://bugzilla.mozilla.org/attachment.cgi?id=248557&action=edit ------- Additional Comments from David Baron <dbaron@mozilla.com> r+sr=dbaron. Let's do the renaming in a separate patch after this one lands. (You can if you want, or I can...) ...

superreview canceled: [Bug 426776] If a folder contains a 'broken' symbolic link, you can't navigate to it in Firefox using the file:/// URL. : [Attachment 313548] Patch rev. 1
Christian :Biesinger <cbiesinger@gmail.com> has canceled Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 426776: If a folder contains a 'broken' symbolic link, you can't naviga= te to it in Firefox using the file:/// URL. https://bugzilla.mozilla.org/show_bug.cgi?id=3D426776 Attachment 313548: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=3D313548&action=3Dedit ------- Additional Comments from Christian :Biesinger <cbiesinger@gmail.com> + int err =3D lstat((char*)path, &stats);=0D =0D that cast se...

superreview requested: [Bug 426776] If a folder contains a 'broken' symbolic link, you can't navigate to it in Firefox using the file:/// URL. : [Attachment 313548] Patch rev. 1
Mats Palmgren <mats.palmgren@bredband.net> has asked Christian :Biesinger <cbiesinger@gmail.com> for superreview: Bug 426776: If a folder contains a 'broken' symbolic link, you can't navigate to it in Firefox using the file:/// URL. https://bugzilla.mozilla.org/show_bug.cgi?id=426776 Attachment 313548: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=313548&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> netwerk/base/src/nsDirectoryIndexStream.cpp: On MacOSX, IsFile() and IsDirectory() returns N...

superreview granted: [Bug 296102] Venkman fails to start in Deer Park Alpha 1 after 5/27/2005 : [Attachment 187861] If we can't load a <xul:script>, don't barf, rev. 1
Johnny Stenback <jst@mozilla.org> has granted Benjamin Smedberg [:bs] (formerly bsmedberg@covad.net) <benjamin@smedbergs.us>'s request for superreview: Bug 296102: Venkman fails to start in Deer Park Alpha 1 after 5/27/2005 https://bugzilla.mozilla.org/show_bug.cgi?id=296102 Attachment 187861: If we can't load a <xul:script>, don't barf, rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=187861&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> r+sr=jst ...

superreview requested: [Bug 296102] Venkman fails to start in Deer Park Alpha 1 after 5/27/2005 : [Attachment 187861] If we can't load a <xul:script>, don't barf, rev. 1
Benjamin Smedberg [:bs] (formerly bsmedberg@covad.net) <benjamin@smedbergs.us> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 296102: Venkman fails to start in Deer Park Alpha 1 after 5/27/2005 https://bugzilla.mozilla.org/show_bug.cgi?id=296102 Attachment 187861: If we can't load a <xul:script>, don't barf, rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=187861&action=edit ...

superreview canceled: [Bug 93725] 'bolder' and 'lighter' keywords of 'font-weight' don't work : [Attachment 323226] possible patch for this and #77882
Zack Weinberg <zweinberg@mozilla.com> has canceled Zack Weinberg <zweinberg@mozilla.com>'s request for superreview: Bug 93725: 'bolder' and 'lighter' keywords of 'font-weight' don't work https://bugzilla.mozilla.org/show_bug.cgi?id=93725 Attachment 323226: possible patch for this and #77882 https://bugzilla.mozilla.org/attachment.cgi?id=323226&action=edit ------- Additional Comments from Zack Weinberg <zweinberg@mozilla.com> retracting review request. ...

superreview requested: [Bug 271955] "empty" table cells don't include borders in size even when 'empty-cells: show' : [Attachment 167169] patch
David Baron <dbaron@mozilla.org> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 271955: "empty" table cells don't include borders in size even when 'empty-cells: show' https://bugzilla.mozilla.org/show_bug.cgi?id=271955 Attachment 167169: patch https://bugzilla.mozilla.org/attachment.cgi?id=167169&action=edit ...

superreview granted: [Bug 271955] "empty" table cells don't include borders in size even when 'empty-cells: show' : [Attachment 167169] patch
Robert O'Callahan <roc@ocallahan.org> has granted David Baron <dbaron@mozilla.org>'s request for superreview: Bug 271955: "empty" table cells don't include borders in size even when 'empty-cells: show' https://bugzilla.mozilla.org/show_bug.cgi?id=271955 Attachment 167169: patch https://bugzilla.mozilla.org/attachment.cgi?id=167169&action=edit ...

superreview granted: [Bug 300474] [FIX] <SELECT> with the MULTIPLE attribute and <OPTGROUP> item don't display properly : [Attachment 189490] Patch rev. 1
Boris Zbarsky <bzbarsky@mit.edu> has granted Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 300474: [FIX] <SELECT> with the MULTIPLE attribute and <OPTGROUP> item don't display properly https://bugzilla.mozilla.org/show_bug.cgi?id=300474 Attachment 189490: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=189490&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> >Index: layout/forms/nsListControlFrame.cpp >+ nsIPresShell* shell = aPresContext->GetPresShell(); I thi...

superreview requested: [Bug 300474] [FIX] <SELECT> with the MULTIPLE attribute and <OPTGROUP> item don't display properly : [Attachment 189490] Patch rev. 1
Mats Palmgren <mats.palmgren@bredband.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 300474: [FIX] <SELECT> with the MULTIPLE attribute and <OPTGROUP> item don't display properly https://bugzilla.mozilla.org/show_bug.cgi?id=300474 Attachment 189490: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=189490&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> These two changes are not needed to fix this bug: Removed an unused parameter from GetMaxOptionHeight(). Make sure GetNum...

superreview cancelled: [Bug 344505] role="anything" on <table> should remove roleless <td>'s, <th's> from hierarchy : [Attachment 229522] Any role on a table means the table structure descendants are
Aaron Leventhal <aaronleventhal@moonset.net> has cancelled Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 344505: role="anything" on <table> should remove roleless <td>'s, <th's> from hierarchy https://bugzilla.mozilla.org/show_bug.cgi?id=344505 Attachment 229522: Any role on a table means the table structure descendants are no longer structurally relevant, unless they have their own role. They're being used to layout the container. https://bugzilla.mozilla.org/attachment.cgi?id=229522&action=edi...

superreview cancelled: [Bug 228448] Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' : [Attachment 137404] (Av1) <nsInternetSearchService.cpp>
Alec Flett <alecf@flett.org> has cancelled Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 228448: Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' http://bugzilla.mozilla.org/show_bug.cgi?id=228448 Attachment 137404: (Av1) <nsInternetSearchService.cpp> http://bugzilla.mozilla.org/attachment.cgi?id=137404&action=edit ------- Additional Comments from Alec Flett <alecf@flett.org> reviewers do not compile and test. Don't ask for a review until you've done that much yourself. ...

Web resources about - superreview cancelled: [Bug 363573] Table cells don't expand to contain <pre cols> ('ch' unit is broken) : [Attachment 248510] Patch rev. 1 - mozilla.dev.super-review

Resources last updated: 1/2/2016 10:02:06 PM